summaryrefslogtreecommitdiff
path: root/crates/arti/src
Commit message (Collapse)AuthorAgeFilesLines
...
* In rust-nightly CI, forbid debugging prints.Nick Mathewson2021-11-041-0/+3
| | | | | | | | | | | | | | | | | | | | This patch makes the rust-nightly CI task fail if it detects any dbg!(), println!(), or eprintln!() calls in production code. Because of clippy limitations, it may also gripe about calls to these macros in our tests. The preferred workarounds are to either instead. Both are acceptable. We're doing this check in CI rather than unconditionally with clippy directives, since we often want to have these calls in our code temporarily while we're developing. Some day we might want this test to go into a pre-push hook. This patch also adds #![allow()] directives for println!() and eprintln!() in the arti crate. Since that one isn't a library, it's okay for it to speak to stdout/stderr. Closes #218.
* Remove all remaining dbg! instances.Nick Mathewson2021-11-041-3/+0
|
* Typo fix in an expect() message.Nick Mathewson2021-10-281-1/+1
|
* Improve and future-proof the `arti` CLIeta2021-10-272-69/+136
| | | | | | | | | | | | | | | | | | | | | | | | This switches out `arti`'s argument-parsing library with `clap`, which is a lot more featureful (and very widely used within the Rust ecosystem). We also now use a lot of `clap`'s features to improve the CLI experience: - The CLI now expects a subcommand (currently, either "help", or "proxy" for the existing SOCKS proxy behaviour). This should let us add additional non-SOCKS-proxy features to arti in future. - `clap` supports default values determined at runtime, so the way the default config file is loaded was changed: now, we determine the OS-specific path for said file before invoking `clap`, so the help command can show it properly. - The behaviour of `tor_config` was also changed; now, one simply specifies a list of configuration files to load, together with whether they're required. - That function also way overused generics; this has been fixed. - Instead of using the ARTI_LOG environment variable to configure logging, one now uses the `-l, --log-level` CLI option. (The intent is for this option to be more discoverable by users.) - The `proxy` subcommand allows the user to override the SOCKS port used on the CLI without editing the config file.
* Update our disclaimers and limitations sections.Nick Mathewson2021-10-271-5/+3
|
* Tests and refactoring for IsolationMap.Nick Mathewson2021-10-261-13/+50
|
* TorClient::resolve_ptr should take an IpAddr.Nick Mathewson2021-10-261-1/+13
|
* Rename tor_client/arti_tor_client to arti_client.Nick Mathewson2021-10-212-7/+7
| | | | | | Solves a name conflict with the existing tor_client create. Closes #130.
* Fix most warnings from nightly.Nick Mathewson2021-10-191-1/+3
| | | | (One represents code that I forgot to write.)
* Make elements of TorClientConfig private.Nick Mathewson2021-10-192-14/+11
|
* tor-client: refactor TorClient::bootstrap's args into a config objecteta2021-10-191-10/+16
| | | | | | | | | | | | | The three arguments TorClient::bootstrap requires by way of configuration have been factored into a new TorClientConfig object. This object gains two associated functions: one which uses `tor_config`'s `CfgPath` machinery to generate sane defaults for the state and cache directories, and one that accepts said directories in order to create a config object with those inserted. (this commit was inspired by trying to use arti as a library and being somewhat overwhelmed by the amount of config stuff there was to do :p)
* Change how we connect to target addresses.Nick Mathewson2021-10-181-1/+1
| | | | | | | Now we all both address:port, (address, port), and more. We also allow SocketAddr and IpAddr, but only via a trait labeled as "Dangerous".
* Merge branch 'reject_bad_hostnames'Nick Mathewson2021-10-182-2/+16
|\
| * Rename is_localhost to allow_local_addrs, and apply it to IPs too.Nick Mathewson2021-10-181-2/+2
| |
| * Formatting fixesNeel Chauhan2021-10-061-1/+3
| |
| * Introduce ClientConfig for is_localhost config parameterNeel Chauhan2021-10-062-2/+14
| |
* | Do not use downcast_ref, use tor-client error.Jani Monoses2021-10-181-8/+6
| |
* | Add a cast to correct a type error about WSAEMFILENick Mathewson2021-10-151-1/+7
| |
* | arti: On startup, increase the NOFILE resource limit.Nick Mathewson2021-10-142-0/+28
| | | | | | | | | | | | | | | | | | | | | | The default soft limit is typically enough for process usage on most Unixes, but OSX has a pretty low default (256), which you can run into easily under heavy usage. With this patch, we're going to aim for as much as 16384, if we're allowed. Fixes part of #188.
* | proxy: Mark ENFILES and EMFILES as survivable.Nick Mathewson2021-10-141-2/+27
| | | | | | | | | | | | | | | | I don't love this approach, but those errors aren't distinguished by ErrorKind, so we have to use libc or winapi, apparently. At least nothing here is unsafe. Addresses part of #188.
* | Report errors in logging configuration a bit more usefullyNick Mathewson2021-10-131-2/+22
| |
* | Document trace_filter example in main.rs too.Nick Mathewson2021-10-131-0/+2
| |
* | Re-export configuration types from tor-client.Nick Mathewson2021-10-091-8/+10
| |
* | enable checked_conversions lint.Nick Mathewson2021-10-091-0/+1
|/
* Do not use set_ prefix on derive_builder settersJani Monoses2021-09-161-3/+3
|
* Merge remote-tracking branch 'origin/mr/77'Nick Mathewson2021-09-102-11/+21
|\
| * Create a separate logging section in config.Jani Monoses2021-09-092-11/+21
| |
* | Use derive_builder for the rest of tor_dirmgr::configNick Mathewson2021-09-091-3/+3
| |
* | Use derive_builder for NetworkConfig.Nick Mathewson2021-09-082-51/+5
|/
* Make journald an optional feature.Jani Monoses2021-09-071-6/+7
|
* Do not log to journald by defaultJani Monoses2021-09-071-1/+1
|
* Allow logging to journald.Jani Monoses2021-09-072-7/+30
| | | | | Log to journald when available, add journald config option. Separate logging setup into its own function.
* Fix typosJani Monoses2021-09-071-1/+1
|
* Light refactoring and documentation improvements in proxy.rsNick Mathewson2021-08-271-40/+103
|
* Move all crates into a `crates` subdirectory.Nick Mathewson2021-08-275-0/+799
This will cause some pain for now, but now is really the best time to do this kind of thing.