| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
| |
Instead, link to documentation, and give the warning about their
security.
|
| |
|
|
| |
Closes #1124.
|
| | |
|
| |\
| |
| |
| |
| | |
Encapsulate usage of config-rs inside tor-config.
See merge request tpo/core/arti!2040
|
| | |
| |
| |
| | |
This will let us replace Config with something better.
|
| | | |
|
| | |
| |
| |
| |
| | |
This will let us test our configuration logic without having
to use the `config` crate directly.
|
| |/ |
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
That's not the default.
|
| |
|
|
|
|
|
|
|
| |
ab950a68 "arti: Add an hss subcommand." mistakenly moved the calls to
`subcommand_required` and `arg_required_else_help` into the
compile-time conditional. But they're related to the main command
parsing.
Fixes #1311
|
| |\
| |
| |
| |
| |
| |
| | |
deny clippy::unchecked_duration_subtraction
Closes #1304
See merge request tpo/core/arti!2008
|
| | | |
|
| | |
| |
| |
| | |
That seems often how we do things elsewhere.
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
I found this confusing in !2009, where the variable is unused on
Windows: I wondered if this meant our config-reloading only worked on
Unix, since "obviously it would need the TorClient".
But actually the TorClient was only used *in this argument* for its
runtime. The actual reconfiguration of the TorClient is doen by it
being in one of the ReconfigurableModule's.
Change the type of the argument for clarity.
|
| |\ \
| | |
| | |
| | |
| | | |
Fix rust-analyzer problems seen with default features on Windows
See merge request tpo/core/arti!2009
|
| | | |
| | |
| | |
| | |
| | | |
Do not complain on non-unix systems that variable client is not used.
It is only accessed within the function on unix systems.
|
| | | |
| | |
| | |
| | | |
The RpcConfig struct is only used if feature rpc is selected.
|
| | |/
| |
| |
| |
| | |
The local name binding for tor_config::define_list_builder_accessors is
only needed if feature onion-service-service is selected.
|
| |/
|
|
|
| |
Windows has a 100-nanosecond precision, so avoid test failure due to a
known system limitation.
|
| |
|
|
| |
Closes #1298
|
| |\
| |
| |
| |
| |
| |
| | |
arti, arti-client, tor-keymgr: Remove keystore dir configuration.
Closes #1202
See merge request tpo/core/arti!1995
|
| | |
| |
| |
| | |
Closes #1202
|
| |/
|
|
|
| |
This is not implemented. It is better to have it commented out than
providing a knob that isn't connected to anything.
|
| |\
| |
| |
| |
| |
| |
| | |
Require the Fast and Stable flags as appropriate.
Closes #1100
See merge request tpo/core/arti!1976
|
| | | |
|
| |/
|
|
|
|
|
|
|
|
|
|
| |
Instead of using complicated match statements, use downcasting
to find error types that define specific hints. This also lets us
define a reasonable hint-extractor for anyhow::Error, and use it
when reporting errors in main.
I've left an implementation of hint() in `impl Error`, to
avoid breaking backward compatibility.
Closes #1165.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Since Rust 1.66, std's default works properly for enums, provided that
the default variant is a unit.
Review all uses of `#[educe(default)]` on enums and replace them with
std where possible, which is most of them.
In 1.66 and later, std's `#[derive(Default)]` doesn't infer any
generic bounds on the derived impl, where it's an enum - since the
unit variant can always be constructed. So this change doesn't add
any generic bounds and is not API-visible.
|
| | |
|
| |
|
|
| |
Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1917#note_2988815
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, the `ProxySet` (and all the other `reconfigurable_modules`)
were kept alive by the `watch_for_config_changes` background thread,
which was preventing them from being dropped when `run()` exited. IOW,
onion services never received the shutdown signal.
Now `watch_for_config_changes` takes `Weak` references, and the only
strong references to the modules are kept in the
`reconfigurable_modules` local variable in `run()`, which is dropped
when `run()` exits (e.g. on SIGINT). This allows onion services to
execute their shutdown logic on CTRL-C.
Part of #1244
|
| | |
|
| | |
|
| |
|
|
|
| |
We are about to need the `svc_cfg` (for calling
`TorClient::create_onion_service`).
|
| |
|
|
|
|
|
|
| |
This will enable us to construct non-launched (but configured)
`OnionService`s. We need this, for example, for implementing
the `arti hss` CLI command.
Part of #1227
|
| |\
| |
| |
| |
| |
| |
| | |
Give an error when user configured onion services with no support.
Closes #1184
See merge request tpo/core/arti!1885
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We do this by adding a stub config and config builder type, whose
only purpose is to generate an error if anything is deserialized
into it.
(If this turns out not to be the best pattern, we can change it
later, since this is all internal to the `arti` crate.)
Closes #1184.
|
| |/
|
|
|
|
|
|
| |
I'm taking this out for now since we don't have support for actually
making these addresses work, and the current behavior will just
ignore connections silently.
Closes #1245
|
| |
|
|
|
|
| |
This resolves a `TODO HSS` in arti-client.
Part of #1187
|
| |
|
|
| |
These are not "must fix before releasing onion services".
|
| | |
|
| | |
|
| | |
|
| |\
| |
| |
| |
| | |
Resolve Arti crate todos, redux
See merge request tpo/core/arti!1833
|
| | | |
|