summaryrefslogtreecommitdiff
path: root/crates/arti/src/logging.rs
Commit message (Collapse)AuthorAgeFilesLines
* arti: Port logging config to dd(TorConfig)Nick Mathewson2026-02-241-130/+69
|
* arti: Resolve unreachable-pub warnings.Nick Mathewson2026-01-131-9/+25
|
* arti: Make logging parent check work with our MSRV.Nick Mathewson2025-11-251-1/+1
|
* arti: use anyhow::Context on a make_directory failure.Nick Mathewson2025-11-241-1/+6
| | | | | This will improve the error message for problems similar to arti#2240, if they recur.
* arti: Allow a logfile with no directory prefix.Nick Mathewson2025-11-241-1/+12
| | | | | | This should fix the main part of arti#2240. This is an instance of arti#2267 ("Path::parent has funny behavior")
* arti: Boyscout fixnield2025-11-131-1/+1
| | | | It seems this config is for tokio-console and not the RPC.
* arti: Warning when opentelemetry config is set but not build with featurenield2025-11-131-0/+16
|
* arti: better error when tokio-console in cfg but feature is absent.Nick Mathewson2025-11-061-3/+27
| | | | | | | This is the pattern we used elsewhere with the "rpc" option. IMO, this kind of thing is another argument in favor if arti#1704 (redoing config types using derive-deftly.)
* arti: Experimental support for tokio-consoleNick Mathewson2025-11-061-0/+36
| | | | | | This is controlled by a new option, `logging.tokio_console.enabled`. It requires building with `--cfg tokio_unstable`. See documentation and comments for more information.
* arti: Make panic into error on invalid OTEL endpoint.Wesley Aptekar-Cassels2025-09-241-3/+5
|
* arti: Add note about lack of filtering in OpenTelemetry layer.Wesley Aptekar-Cassels2025-09-241-0/+3
|
* opentelemetry: Use humantime_serde for parsing Durations.Wesley Aptekar-Cassels2025-09-241-0/+3
|
* opentelemetry: Panic if configured for non-localhost HTTP endpoint.Wesley Aptekar-Cassels2025-09-241-0/+8
| | | | | | | | | We may want to add a way to opt out of this check, if someone asks for it. Checking for "localhost" and "127.0.0.1" is not a very robust check for a loopback interface, and it's possible that there could be other situations we can't detect where HTTP is safe (private network, WireGuard tunnel, etc). But I don't expect those to be likely to come up in practice, so this should be fine for now.
* arti: Add experimental support for OpenTelemetry.Wesley Aptekar-Cassels2025-09-241-0/+168
|
* arti: log error fields lastSteven Engler2025-08-181-0/+5
|
* Switch Cargo.toml files to edition 2024.Nick Mathewson2025-08-071-4/+4
| | | | | | | | | | | | | | First, run ``` git grep -l "^edition =" | xargs perl -i -pe 's/^edition *=.*/edition = "2024"/;' ``` Second, manually verify that all Cargo.toml files have changed, and nothing else has changed. Third, run cargo fmt again.
* Update code for Edition 2024Nick Mathewson2025-08-071-3/+3
| | | | | | | | | | | | | | | | | | 1. Run cargo fix --edition 2. Selectively revert the "if let"->"match" changes. These changes are meant to protect us from the lifetime changes for "if let" bindings in Rust 2024. But we're not actually relying on the old lifetime rules anywhere, and the match syntax here is quite ugly. 3. Automatically revert `$pat:expr_2021` to `$pat:expr`. (We don't actually want to restrict the expression syntax that our macros accept). Done with `git grep -l expr_2021 | xargs perl -i -pe 's/expr_2021/expr/g;'` 4. Run cargo fmt.
* arti console logging: use stderr instead of stdoutJim Newsome2025-06-171-3/+3
| | | | Fixes #2024
* arti: Disable color when stdout is not a tty.Nick Mathewson2025-02-241-1/+7
| | | | | Closes #1763. Closes #1862.
* update `CfgPath::path` to use a `CfgPathResolver`Steven Engler2024-11-181-5/+14
| | | | | | | | | | | | | | | | This is a big change across multiple crates since there isn't a good way to break it up. This changes the signature of `CfgPath::path` to: ``` pub fn path(&self, path_resolver: &CfgPathResolver) -> Result<PathBuf, CfgPathError> { ``` Making this change means that our global `CfgPathResolver` needs to be stored in the 'arti-client' library instead of `tor-config-path`, and must be passed through to anything that calls `path` to expand the variables.
* tor-config: removed re-export of `CfgPath`Steven Engler2024-11-041-1/+2
| | | | | Also updated other packages to get `CfgPath` directly from `tor-config-path' instead of 'tor-config'.
* Match previous backtrace formattingRobin Leander Schröder2024-08-081-2/+2
| | | | | std::backtrace::Backtrace's Display looks the same as backtrace_rs::Backtrace's Debug
* Use std::backtrace instead of backtrace crateRobin Leander Schröder2024-08-011-3/+1
| | | | | Removes resolve_backtraces from rtmock since it is no longer needed as stdlib's backtraces automatically lazily resolve without needing a &mut.
* arti: Don't output ANSI escape codes when logging to file.Gabriela Moldovan2024-02-221-0/+1
| | | | Closes #1298
* educe: Use std's default for enums where default variant is unitIan Jackson2024-02-121-4/+2
| | | | | | | | | | | | | Since Rust 1.66, std's default works properly for enums, provided that the default variant is a unit. Review all uses of `#[educe(default)]` on enums and replace them with std where possible, which is most of them. In 1.66 and later, std's `#[derive(Default)]` doesn't infer any generic bounds on the derived impl, where it's an enum - since the unit variant can always be constructed. So this change doesn't add any generic bounds and is not API-visible.
* Throughout: Use *_report!() macros for reporting Errors.Nick Mathewson2023-07-071-3/+3
| | | | | | | | | | | | | | | I identified the cases to replace by searching for the string `.report()`. There are a few that I didn't change: * A couple of cases that used anyhow::Error, * One case that reported two Errors. * Two cases in `tor_hsclient::err` that just did `error!("Bug: {}")`. I have also not audited the cases in `tor-hsclient` where we're using `tor_error::Report` manually. Nonetheless, closes #949.
* Merge branch 'log_precision' into 'main'Nick Mathewson2023-07-061-4/+25
|\ | | | | | | | | | | | | arti: Add a `logging.time_granularity` option with 1s default. Closes #551 See merge request tpo/core/arti!1376
| * arti: Add a `logging.time_granularity` option with 1s default.Nick Mathewson2023-07-061-4/+25
| | | | | | | | | | | | | | This lets us provide less information in our logs: in particular, it lets us avoid logging with microsecond precision. Closes #551.
* | arti: Note possibility for future use of other tracing panic providerNick Mathewson2023-07-061-0/+5
| |
* | arti: On panic, avoid allocation even more.Nick Mathewson2023-07-061-7/+5
| | | | | | | | | | | | | | | | | | | | The original version of our panic handler would allocate a string for the panic `Location`. But if we're panicking we'd like to keep allocations to a minimum: so instead format the `Location` conditionally. This also drops a useless `std::borrow::Cow`. (The possibility of a "Don't have a `Cow`" commit message was considered and rejected.)
* | Add TODO comments about possibly migrating away from the backtrace crate.Nick Mathewson2023-07-051-1/+2
| |
* | arti: Install a panic hook that sends messages to `tracing`Nick Mathewson2023-07-051-0/+31
|/ | | | | | | (Also leaves installed the default handler that sends messages to stderr.) Closes #921.
* Use ErrorReport/Report for errors in warn! in artiIan Jackson2023-01-301-1/+2
|
* Enforce SafeLogging on the console.Nick Mathewson2022-09-261-30/+10
| | | | | | | | | | | | Previously we always assumed that the console was ephemeral, and so we disabled safe logging. But the console can be piped to journald. And even if we enforce isatty there's no guarantee that the user isn't using some kind of terminal that logs to disk or something. Best just to enable SafeLogging unconditionally. I've added a note about where and how we might re-enable this. Closes #553.
* Mark a few APIs as experimental in docs.Nick Mathewson2022-08-301-0/+1
| | | | | | | | For example, see https://tpo.pages.torproject.net/core/doc/rust/arti/fn.run.html : this isn't labeled as `experimental-api`, but it should be. These APIs were found by poking around in the `arti` crate.
* arti: Raise the default console log severity to "info"Nick Mathewson2022-08-251-1/+1
| | | | | Previously we logged at "debug", but that's not meant to user-facing.
* arti: Move most public APIs behind `experimental-api`.Nick Mathewson2022-08-111-2/+4
| | | | | | | | | | | | | | | | | The remaining unconditionally public APIs are those related to our configuration objects, and the main_main() API. The rationale for making main_main() public is to have an actual entry point. The rationale for making the config APIs public is: 1. We really do intend for others to be able to read our configuration files using this API. 2. The structure of our configuration files is already part of our interface. Closes #530.
* impl_standard_builder: Use for arti::logging::LogfileConfigIan Jackson2022-06-161-7/+2
|
* arti: logging config: Replace a manual Debug implIan Jackson2022-06-161-7/+4
|
* config: Do not strip_option for journald (and in future)Ian Jackson2022-06-101-1/+1
| | | | | As per point 1 in https://gitlab.torproject.org/tpo/core/arti/-/issues/488
* config: Provide tor_config::resolve_option and resolve journaldIan Jackson2022-05-301-1/+4
| | | | | | | | | | | | | | Canonicalise the `logging.journald` setting in the validated configuration. Now it will never be `Some("")`, even if that is what was written in the config file. This allows us to write `journald = ""` in the example configuration. (Without the canonicalisation the default builder produces `None` and the example would produce `Some("")`, which are semantically identical but fail the test.) See https://gitlab.torproject.org/tpo/core/arti/-/issues/488 for some background.
* Apply fs-mistrust to logfile directories.Nick Mathewson2022-05-241-5/+15
|
* impl_standard_builder: Have it generate FooConfig::builderIan Jackson2022-05-121-7/+0
| | | | | This deletes many handcoded impls. It also generates lots of impls that we previously didn't have.
* Rename impl_standard_builder from impl_default_via_builderIan Jackson2022-05-121-2/+2
| | | | | | | | | | | | I have Plans for this macro. In particular: * I have a wip branch which tests that the Builder can be deserialised from an empty config (ie, that config reading of a config with a blank section for this item works). * I think we should autogenerate $Config::builder(), and promote that, rather than $ConfigBuilder::default(). This macro could do that.
* config: Replace more handwritten impl DefaultIan Jackson2022-05-121-6/+2
|
* Disable safe-logging when logging to console.Nick Mathewson2022-05-061-1/+30
|
* arti: add support for safe-logging configurationNick Mathewson2022-05-061-2/+33
| | | | | | Here we add a config option to disable safe logging, and ensure that safe logging is disabled when we are formatting an error message on exit (since we assume it's safe to write sensitive info to stderr.)
* config derive attrs: Make builders serde, and validated structs notIan Jackson2022-05-051-10/+5
| | | | | | | | | | | | | | | * Builders additionally derive: Debug, Serialize, Deserialize. * Validated structs no longer derive: Serialize, Deserialize and all related attributes deleted. * As a consequence, all the `#[serde(deny_unknown_fields)]` are gone. That means that right now unknown fields are totally ignored. This is good for compatibility but poor for useability. Doing something better here is arti#417, in progress. * As a consequence, delete tor_dirmgr::retry::default_parallelism. (The default value was already duplicated into a builder attr.)
* Make LogRotation SerializeIan Jackson2022-05-051-1/+1
| | | | We want to be able to serialise as well as deserialise configurations.
* Change builder list APIIan Jackson2022-05-041-7/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | The new API is (roughly) as discussed in https://gitlab.torproject.org/tpo/core/arti/-/issues/451 This is quite a large commit and it is not convenient to split it up. It contains the following changes: * Redo the list builder and accessor macros implemnetation, including docs and tests. * Change uses of define_list_config_builder. In each case: - Move the docs about the default value to the containing field. - Remove the other docs (which were just recapitulations, and are now not needed since the ListBuilder is no longer public). - Rewmove or replace `pub` in the define_list_builder_helper call, so that the builder is no longer public. - Change the main macro call site to use define_list_builder_helper. - Add a call to define_list_builder_accessors. * Make the module `list_builder` pub so that we have somewhere to put the overview documentation. * Consequential changes: - Change `outer.inner().replace(X)` to `outer.set_inner(X)` - Consequential changes to imports (`use` statements).
generated by cgit v1.2.3 (git 2.46.0) at 2026-08-26 21:53:56 +0000