aboutsummaryrefslogtreecommitdiff
path: root/crates/arti/src/cfg.rs
Commit message (Collapse)AuthorAgeFilesLines
...
* cfg test: bridges: Test all three feature casesIan Jackson2022-10-121-4/+31
| | | | | | | | | | | | | This demonstrates that: * !bridge-client: uncommenting nondefault bridge config generates urecognized config key warnings (but the config is still accepted)( * bridge-client, !pt-client: uncommenting nondefault bridges generates error due to attempting to use a PT. If that's filtered out, everything is fine. * pt-client: Everything is good (as before).
* cfg tests: bridges: Prepare for more comprehensive testingIan Jackson2022-10-121-8/+20
| | | | | | | | | | | | | * Introduce filter_examples and resolve_examples helpers, which will become more complex in a moment. * Move the API test into a { } block to minimise subsequent diff. It's going to become conditional. * In subsequent comparisons, use the parsed version, since the API built one might not exist. No overall functional change.
* cfg tests: Make ExampleSectionLines::resolve fallibleIan Jackson2022-10-121-5/+5
|
* Fix comment typo.Nick Mathewson2022-10-121-1/+1
|
* bridges: Test configurationIan Jackson2022-10-121-0/+121
|
* pt and bridges: Parse configurationIan Jackson2022-10-121-3/+1
|
* config exhaust checking: Feature-limit some of the testsIan Jackson2022-10-121-11/+17
|
* bridges config example: Add bridges section to example configIan Jackson2022-10-121-0/+3
| | | | | | | This is precisely the text from the original version of !744. There is no implementation yet, so we must add a entry to the exception list in the tests.
* config exhaust checking: Allow for whole sectionsIan Jackson2022-10-121-2/+17
| | | | | | | | Section headings appear uncommented in the file, so if we have a whole section which is completely unrecognized (ie, an entry with no `.`, it will be spotted when we parse the not-uncommented file too. Right now there aren't any but there will be in a moment.
* config exhaust checking: Allow for options only unrecognized in newIan Jackson2022-10-121-4/+10
|
* config exhaust checking: Move unrecognized lists earlierIan Jackson2022-10-121-3/+3
| | | | It turns out that we will need these even for uncommented parsing.
* arti config exhaust checking: Improve message, add commentIan Jackson2022-10-121-2/+4
| | | | I had a failure that was confusing to me, and I wrote it...
* Allow "clippy::single_char_pattern" in tests.Ian Jackson2022-10-121-0/+1
| | | | | | | This lint exists for perf reasons, and this is rarely relevant in tests. Using double quoted str is generally cognitively less burdensome.
* Add test warning exceptions to arti::cfg::testNick Mathewson2022-08-311-0/+7
|
* Fix Tests on Windows in Configuration Subsystem.Alexander Færøy2022-08-301-6/+30
| | | | | | | | | | | | | | | | This patch changes our `default_config()` test in `arti/src/cfg.rs` such that we can define a number of known unrecognized options on different platforms. We mark the two keys "storage.permissions.trust_group" and "storage.permissions.trust_user" as unknown on the Windows platform as such features is not available using the ordinary Unix UID concept. This patch also publicly exposes the `tor_config::load::DisfavouredKey` and `tor_config::load::PathEntry` types and marks them as non-exhaustive. See: tpo/core/arti#450.
* arti cfg: Provide comprehensive tests for port listeningIan Jackson2022-08-251-1/+116
|
* arti: cfg: Rename `*_port` to `*_listen` and change the typeIan Jackson2022-08-251-9/+69
| | | | | | | This commit largely follows the example for resolve_alternative_specs. The difference is that there are two fields, so we use a macro to avoid recapitulating the field names.
* tor-config: Support tracking deprecated config keysIan Jackson2022-08-251-5/+11
|
* tor-config: Introduce ResolutionResultsIan Jackson2022-08-251-6/+7
| | | | This will allow us to handle new kinds of warnigns etc.
* fix nightly lintstrinity-1686a2022-08-241-0/+1
|
* fix test failing due to missing allow_running_as_roottrinity-1686a2022-08-241-1/+1
|
* Merge branch 'no_root' into 'main'Nick Mathewson2022-08-241-0/+6
|\ | | | | | | | | arti: Do not allow running as root. See merge request tpo/core/arti!688
| * arti: Do not allow running as root.Nick Mathewson2022-08-241-0/+6
| | | | | | | | | | | | This can be overridden with `application.allow_running_as_root`. Part of #523.
* | arti cfg: Write down future plansIan Jackson2022-08-231-0/+13
| | | | | | | | | | Mostly cribbed from https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/684#note_2829937
* | arti cfg: Test parsing of the oldest config file we still supportIan Jackson2022-08-221-8/+36
| |
* | arti cfg: Fix docs about ARTI_EXAMPLE_CONFIGIan Jackson2022-08-221-1/+4
|/ | | | The defaults are now
* arti: Add support for process hardeningNick Mathewson2022-08-151-0/+12
| | | | | | | | | | | | | This is a compile-time feature with an associated configuration flag, both enabled by default. When it's turned on, hardening prevents the arti process from dumping core or being attached to by low-privileged processes. (This is a defense-in-depth measure, not an absolute way to prevent attacks. For more information, see [`secmem_proc`](https://docs.rs/secmem-proc/0.1.1/secmem_proc/).) Closes #364.
* arti: cfg: Remove another needless borrowIan Jackson2022-06-161-1/+1
|
* arti cfg tests: Remove a redundant line that shadows an earlier bindingIan Jackson2022-06-161-1/+0
| | | | | Prompted by review https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/589#note_2813596
* arti cfg tests: Test that example config works as-isIan Jackson2022-06-161-0/+2
| | | | It contains only sections, but we want to detect when that is a problem!
* arti: cfg tests: Refactor to prepare for new testIan Jackson2022-06-161-16/+23
| | | | We're going to call this new closure another time.
* arti config: Check that example config is exhaustiveIan Jackson2022-05-301-0/+114
| | | | This is the final piece of #457.
* arti: config: Canonicalise ports, and provide example dns_portIan Jackson2022-05-301-8/+2
| | | | | | | | | | | | | Now the validated configuration will never be `Some(0)`, even if that is what was written in the config file. The arti CLI parser can still produce this, so we don't touch the code that actually uses this. (Without the canonicalisation the default builder produces `None` for the `dns_port`, but the example would produce `Some(0)`, which is semantically identical but fails the test.) See https://gitlab.torproject.org/tpo/core/arti/-/issues/488 for some background.
* arti: Make ProxyConfig no longer DeserializeIan Jackson2022-05-301-4/+1
| | | | That this remained was an oversight.
* arti: cfg: Actually uncomment *all* the things in the exampleIan Jackson2022-05-301-1/+1
|
* add unit tests for ArtiConfig public functionsmichael mccune2022-05-281-0/+24
| | | | | this change adds some simple tests for the ArtiConfig public getter functions to help expand coverage in this crate.
* arti: Better doc for ArtiCombinedConfigIan Jackson2022-05-251-1/+3
|
* tor-config: Rename resolve_return_unrecognized, ..._ignore_...Ian Jackson2022-05-251-1/+1
| | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/529#note_2807077
* tor-config: Rename "ignored" to "unrecognized" throughoutIan Jackson2022-05-251-3/+3
| | | | | As per review comments https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/529#note_2807076
* tor-config: Tests for ignored config key handlingIan Jackson2022-05-241-8/+4
|
* Split TorClientConfig out of ArtiConfig, and Resolvable traitIan Jackson2022-05-241-35/+14
| | | | | | | | | | | | This gets rid of `#[serde(flatten)]` which prevents serde_ignored (and other kinds of introspection) from working properly. The price is now that the toplevel has to deal with two configuration objects. The Resolvable trait is overkill right now, but is going to do More Things in a moment. In particular, we need the impl on tuples, so that the whole config can be processed in one go.
* arti tests: Introduce bld_tor variableIan Jackson2022-05-241-22/+19
| | | | | | We are going to reorganise ArtiConfig to not contain a TorClientConfig. This test case's calls to bld.tor() will all need to change. Do this in advance to make that future commit more readable.
* Apply fs-mistrust to logfile directories.Nick Mathewson2022-05-241-1/+1
|
* Merge branch 'builder-default-3' into 'main'Nick Mathewson2022-05-131-19/+0
|\ | | | | | | | | impl_standard_builder: Test the Deserialize impl and have it generate ::builder See merge request tpo/core/arti!507
| * impl_standard_builder: Have it generate FooConfig::builderIan Jackson2022-05-121-19/+0
| | | | | | | | | | This deletes many handcoded impls. It also generates lots of impls that we previously didn't have.
* | Merge branch 'template' into 'main'Nick Mathewson2022-05-121-6/+34
|\ \ | |/ |/| | | | | Make the example config file into a template and move it to arti See merge request tpo/core/arti!503
| * arti-example-config.toml: Re-un-comment the example settings in testIan Jackson2022-05-121-4/+23
| |
| * config defaults: Test that empty deser is the sameIan Jackson2022-05-121-0/+4
| |
| * ARTI_EXAMPLE_CONFIG: Rename from ARTI_DEFAULTSIan Jackson2022-05-121-3/+2
| | | | | | | | | | The defaults are built into the code. This is a doc-commented example file, not the primary specification of what the defaults are.
| * ARTI_DEFAULTS: Move to arti crateIan Jackson2022-05-121-0/+3
| |