summaryrefslogtreecommitdiff
path: root/crates/arti-rpcserver/src
Commit message (Collapse)AuthorAgeFilesLines
...
* Note/clean more TODOs in objmap.Nick Mathewson2023-05-041-1/+4
|
* RPC: Make the "client" return optional.Nick Mathewson2023-05-041-2/+2
|
* RPC: Make "Weak" and "Strong" entries separate.Nick Mathewson2023-05-041-43/+41
| | | | | | | | | Now there can be one of each, since we want references and handles to be conceptually separate. (The alternative would be to say that an operation either "returns a handle" or "returns a reference (which may become a handle) unless a handle already exists.")
* Temporarily replace generational-arena with a fake version.Nick Mathewson2023-05-041-1/+77
| | | | | This fake version is completely silly, but it will do the job until we figure out our MPL2 concerns.
* RPC: Rename session.rs to connection.rsNick Mathewson2023-05-044-4/+4
|
* RPC: rename Session to Connection.Nick Mathewson2023-05-043-45/+48
| | | | | | | To me, "Session" suggests that we're authenticated, when we are not necessarily authenticated. Also, we may eventually want to have some kind of persistent session object; if we do, then we'll want Connections to be separate.
* RPC: Make authentication return a TorClient.Nick Mathewson2023-05-042-58/+66
| | | | | | (This is the correct capabilities-based behavior. For now it will only work if the TorClient uses a PreferredRuntime, but with luck we will find a solution for #837 soon.)
* Add a generational arena for object mapping for RPC.Nick Mathewson2023-05-042-0/+664
| | | | | | See the comments on `TypedAddr` for some explanations about why this is so tricky. Thanks to @diziet for helping me figure this out.
* RPC: Add "register" methods to RequestContext.Nick Mathewson2023-05-041-0/+8
|
* RPC: Start on plumbing TorClient into our RPC codeNick Mathewson2023-05-041-3/+8
| | | | | Because of #837, we won't be able to work with _every_ TorClient<R>, so I'm only going to be using TorClient<PreferredRuntime> for now.
* RPC: Move the "listen" part of the RPC listener code to `arti`.Nick Mathewson2023-05-044-63/+27
| | | | | | | | | Now there's a module in `arti` that runs the loop for an RPC listener. The part of the old `listener` module that made the framed connections is now part of the `Session` object. There is now yet another a temporary location for the pipe; we should pick something better. At least now it's configurable.
* rpc: Make an RpcMgr type to own the DispatchTable.Nick Mathewson2023-05-044-12/+56
| | | | | | | | | In the future, this will probably hold more data as well, like a TorClient and some configuration info. The TorClient will present an issue; I've made comments about that. Closes #820
* RPC: Log all internal errors.Nick Mathewson2023-04-191-1/+6
|
* Arti: Add ability to remember the list of methods names.Nick Mathewson2023-04-193-12/+17
| | | | | | | | | | | | Right now, this lets us say whether the method was unrecognized or whether the parameter type was incorrect. We'll use this to enforce correct method names later on. (I have to add another `inventory` here, since the `typetag` maintainer does not want to expose this functionality: see https://github.com/dtolnay/typetag/issues/57#issuecomment-1506106290 )
* rpcserver: Use with_fn.Nick Mathewson2023-04-191-12/+7
|
* rpc: Use Method types to determine type of method outputs, updates.Nick Mathewson2023-04-191-17/+39
| | | | This lets us do much less in our rpc_invoke_fn functions.
* rpc: Split Method into DynMethod and MethodNick Mathewson2023-04-192-19/+26
| | | | | Now `Method` has an Output and Update associated type, and `decl_method` can do a little more.
* Merge branch 'rpc_refactoring_v2' into 'main'Ian Jackson2023-04-181-141/+92
|\ | | | | | | | | | | | | A few RPC refactorings Closes #817 and #824 See merge request tpo/core/arti!1144
| * rpc: simplify API by always providing a sink.Nick Mathewson2023-04-161-7/+6
| | | | | | | | | | Previously we have two places where we had to do "make a `Drain` sink if updates aren't wanted"; now there's only one.
| * rpc: Ensure well-ordering of responses.Nick Mathewson2023-04-161-60/+88
| | | | | | | | | | | | | | | | | | | | | | | | Previously the main loop received updates via a `mpsc::channel`, and final responses via a `futures::unordered`. This could lead to final responses being transmitted to the user before the updates were all flushed. Now all of the responses are sent to the main loop via the same channel, and they can't get out-of-sequence. Closes #817 and (IMO) simplifies the code a bit.
| * rpc: Move update sink out of context.Nick Mathewson2023-04-161-101/+25
| | | | | | | | | | Now the update sink is its own boxed object. It is not yet passed to the invoke functions that want it.
* | rpcserver: Fix a couple of broken rustdoc linksNick Mathewson2023-04-162-3/+5
|/
* rpc: Change `id=<SYNTAX>` to "no id".Nick Mathewson2023-04-133-14/+32
| | | | | | | Now instead of hoping that buggy clients will detect a magic `id`, we can simply tell them that they will get no `id` at all. If they can't handle that case, no major harm is done: the connection will get closed anyway.
* rpc: Require that errors are RpcError.Nick Mathewson2023-04-133-7/+22
| | | | | | Since we're serializing everything in this format, let's enforce it. With this change, we can no longer cram arbitrary junk into an RPC error, so we have to clean up our handling of cancelled requests.
* rpc: Improve error reporting for invalid requestsNick Mathewson2023-04-127-17/+291
| | | | | | | | | | | | | | | | This is a bit big, but it's not that _complicated_. The idea here is that we use serde's "untagged" enum facility when parsing our `Request`s, such that if parsing as a `Request` fails, we parse as an `InvalidRequest` and try to report what the problem was exactly. This lets us determine the ID of a request (if it had one), so we can report that ID in our error message. We can also recover from a much broader variety of errors. We now also conform with the spec reporting errors about completely wrong json, requests without IDs, and so on.
* arti-rpcserver: Be careful about saying "result".Nick Mathewson2023-04-123-7/+12
| | | | | | Even though json-rpc uses "result" to mean "a successful return value from a method", we can't: Rust's `Result` type is so pervasive that confusion would be inevitable.
* arti-rpcserver: Rename Authentication{Method => Scheme}.Nick Mathewson2023-04-121-7/+7
|
* arti-rpcserver: rename cmd to method.Nick Mathewson2023-04-121-2/+2
|
* arti-rpcserver: rename command to method.Nick Mathewson2023-04-122-19/+19
|
* tor-rpcbase: Rename and rephrase "command" to "method"Nick Mathewson2023-04-122-7/+7
|
* Rename tor-rpccmd to tor-rpcbase.Nick Mathewson2023-04-122-3/+3
|
* rpc: Make AuthenticationMethod an enum.Nick Mathewson2023-04-121-13/+20
|
* rpc: Reify and expose DispatchTable.Nick Mathewson2023-04-121-1/+9
|
* rpc: Use Pin<Box<Stream/Sink>> for run_loopNick Mathewson2023-04-122-16/+24
|
* rpc: Import Pin/Context/Poll.Nick Mathewson2023-04-121-29/+13
| | | | | (Except for one case where we are using crate::Context and task::Context at the same time.)
* rpc: Document our intended read-blocking behavior.Nick Mathewson2023-04-121-0/+4
|
* rpc: Switch JsonLinesEncoder to have Default, not new.Nick Mathewson2023-04-122-6/+5
|
* rpc: Rename BoxedResponseBody => ResponseBodyNick Mathewson2023-04-123-18/+18
|
* rpc: Remove anyhow dependencyNick Mathewson2023-04-121-5/+13
|
* rpc: Add standard warnings to arti-rpcserverNick Mathewson2023-04-125-7/+85
|
* rpc: Add an authentication step.Nick Mathewson2023-04-121-1/+70
| | | | | | | | Per our design, every connection starts out unauthenticated, and needs one authenticate command to become authenticated. Right now the only authentication type is "This is a unix named socket where everybody who can connect has permission."
* RPC: add a temporary "listen" function.Nick Mathewson2023-04-122-0/+52
| | | | | It requires tokio, it's unix-only, and makes some unfortunate shortcuts. Probably good enough for initial testing.
* rpc: Declare a trivial Echo command that works on a session.Nick Mathewson2023-04-121-1/+24
|
* rpc: Wire up arti-rpcserver to use tor-rpccmd.Nick Mathewson2023-04-122-24/+159
|
* rpc: do a better job of hiding impl_const_type_id!Nick Mathewson2023-04-121-1/+2
|
* RPC: Initial implementation of a multiple-argument dispatchNick Mathewson2023-04-121-0/+1
| | | | | | | | | | This code uses some kludges (discussed with Ian previously and hopefully well documented here) to get a type-identifier for each type in a const context. It then defines a macro to declare a type-erased versions of a concrete implementation functions, and register those implementations to be called later. We will probably want to tweak a bunch of this code as we move ahead.
* Start on a lower-level tor-rpccmd crate.Nick Mathewson2023-04-121-35/+10
| | | | | This crate will hold the backend pieces of RPC interaction that different parts of Arti get to implement.
* rpc: Add a Session object and an interaction loop.Nick Mathewson2023-04-122-0/+184
|
* rpc: Add asynchronous_codec wrapper for jsonlines.Nick Mathewson2023-04-122-0/+101
|
* rpc: Add a cancellable future type.Nick Mathewson2023-04-122-0/+134
| | | | | | Ordinarily you can cancel a future just by dropping it, but we'll want the ability to cancel futures that we no longer own (because we gave them to a `FuturesUnordered`).