aboutsummaryrefslogtreecommitdiff
path: root/crates/arti-rpcserver/src/session.rs
Commit message (Collapse)AuthorAgeFilesLines
...
* rpcserver: Use with_fn.Nick Mathewson2023-04-191-12/+7
|
* rpc: Use Method types to determine type of method outputs, updates.Nick Mathewson2023-04-191-17/+39
| | | | This lets us do much less in our rpc_invoke_fn functions.
* rpc: Split Method into DynMethod and MethodNick Mathewson2023-04-191-7/+11
| | | | | Now `Method` has an Output and Update associated type, and `decl_method` can do a little more.
* rpc: simplify API by always providing a sink.Nick Mathewson2023-04-161-7/+6
| | | | | Previously we have two places where we had to do "make a `Drain` sink if updates aren't wanted"; now there's only one.
* rpc: Ensure well-ordering of responses.Nick Mathewson2023-04-161-60/+88
| | | | | | | | | | | | Previously the main loop received updates via a `mpsc::channel`, and final responses via a `futures::unordered`. This could lead to final responses being transmitted to the user before the updates were all flushed. Now all of the responses are sent to the main loop via the same channel, and they can't get out-of-sequence. Closes #817 and (IMO) simplifies the code a bit.
* rpc: Move update sink out of context.Nick Mathewson2023-04-161-101/+25
| | | | | Now the update sink is its own boxed object. It is not yet passed to the invoke functions that want it.
* rpc: Change `id=<SYNTAX>` to "no id".Nick Mathewson2023-04-131-5/+8
| | | | | | | Now instead of hoping that buggy clients will detect a magic `id`, we can simply tell them that they will get no `id` at all. If they can't handle that case, no major harm is done: the connection will get closed anyway.
* rpc: Require that errors are RpcError.Nick Mathewson2023-04-131-2/+16
| | | | | | Since we're serializing everything in this format, let's enforce it. With this change, we can no longer cram arbitrary junk into an RPC error, so we have to clean up our handling of cancelled requests.
* rpc: Improve error reporting for invalid requestsNick Mathewson2023-04-121-12/+34
| | | | | | | | | | | | | | | | This is a bit big, but it's not that _complicated_. The idea here is that we use serde's "untagged" enum facility when parsing our `Request`s, such that if parsing as a `Request` fails, we parse as an `InvalidRequest` and try to report what the problem was exactly. This lets us determine the ID of a request (if it had one), so we can report that ID in our error message. We can also recover from a much broader variety of errors. We now also conform with the spec reporting errors about completely wrong json, requests without IDs, and so on.
* arti-rpcserver: Be careful about saying "result".Nick Mathewson2023-04-121-1/+1
| | | | | | Even though json-rpc uses "result" to mean "a successful return value from a method", we can't: Rust's `Result` type is so pervasive that confusion would be inevitable.
* arti-rpcserver: Rename Authentication{Method => Scheme}.Nick Mathewson2023-04-121-7/+7
|
* arti-rpcserver: rename cmd to method.Nick Mathewson2023-04-121-2/+2
|
* arti-rpcserver: rename command to method.Nick Mathewson2023-04-121-11/+11
|
* tor-rpcbase: Rename and rephrase "command" to "method"Nick Mathewson2023-04-121-4/+4
|
* Rename tor-rpccmd to tor-rpcbase.Nick Mathewson2023-04-121-1/+1
|
* rpc: Make AuthenticationMethod an enum.Nick Mathewson2023-04-121-13/+20
|
* rpc: Reify and expose DispatchTable.Nick Mathewson2023-04-121-1/+9
|
* rpc: Use Pin<Box<Stream/Sink>> for run_loopNick Mathewson2023-04-121-9/+15
|
* rpc: Import Pin/Context/Poll.Nick Mathewson2023-04-121-29/+13
| | | | | (Except for one case where we are using crate::Context and task::Context at the same time.)
* rpc: Document our intended read-blocking behavior.Nick Mathewson2023-04-121-0/+4
|
* rpc: Rename BoxedResponseBody => ResponseBodyNick Mathewson2023-04-121-5/+5
|
* rpc: Remove anyhow dependencyNick Mathewson2023-04-121-5/+13
|
* rpc: Add standard warnings to arti-rpcserverNick Mathewson2023-04-121-1/+15
|
* rpc: Add an authentication step.Nick Mathewson2023-04-121-1/+70
| | | | | | | | Per our design, every connection starts out unauthenticated, and needs one authenticate command to become authenticated. Right now the only authentication type is "This is a unix named socket where everybody who can connect has permission."
* rpc: Declare a trivial Echo command that works on a session.Nick Mathewson2023-04-121-1/+24
|
* rpc: Wire up arti-rpcserver to use tor-rpccmd.Nick Mathewson2023-04-121-24/+153
|
* rpc: Add a Session object and an interaction loop.Nick Mathewson2023-04-121-0/+183