aboutsummaryrefslogtreecommitdiff
path: root/crates/arti-client/src
Commit message (Collapse)AuthorAgeFilesLines
...
* errors: Handle exit circuit creation failure the new wayIan Jackson2022-02-042-2/+22
|
* errors: Handle circmgr setup errors differentlyIan Jackson2022-02-042-4/+5
| | | | | | | | | | | | | The motivation for doing this now is to remove the `#[from]` so we would spot where operationsl circuit setup failures were handled. (But it turns out that they are turned into internal errors!) Perhaps this will want to become a different error type from circmgr in due course, but for now we simply use a bespoke variant of TorError. It will want its own Kind. The TODO in the HasKind impl marks this (amongst much else here).
* errors: Introduce error_detail featureIan Jackson2022-02-042-3/+35
| | | | | Right now we must always expose the `Error` type since we haven't converted everything.
* errors: Refer to err::Error in some bits of arti_clientIan Jackson2022-02-044-9/+11
| | | | We are going to make the top-level Error type conditionally hidden.
* errors: Introduce TorErrorIan Jackson2022-02-043-7/+50
| | | | Still much to do here.
* errors: Initial impl HasKind in arti-client, ErrorKind::TODOIan Jackson2022-02-041-0/+7
| | | | | | | | | This involves making a temporary ErrorKind::TODO. That will continue to exist until all errors (at least, the ones that make it out to here) can be properly categorised. Introducing this will let us work from the top and bottom towards the middle.
* spawn errors: Fix arti-client, tor-chanmgr, tor-circmgrIan Jackson2022-02-041-3/+10
| | | | | | | Provide an enum variant to contain the SpawnError and a From impl. We use `#[from]` here because it doesn't really make sense to attach any context, as it's not likely to be very relevant.
* Fix typosDimitris Apostolou2022-02-021-1/+1
|
* Expose Reconfigure enum from arti-client.Nick Mathewson2022-02-011-1/+1
| | | | | This enum is required to use `TorClient::reconfigure` correctly, and as such ought to be re-exported.
* Make max_file_limit configurableNeel Chauhan2022-01-281-0/+56
|
* Fix documentation references for tor-rtcompat refactoring.Nick Mathewson2022-01-261-5/+7
|
* Make the native-tls crate optional.Nick Mathewson2022-01-261-8/+8
| | | | | | | | | | | This commit puts the native-tls crate behind a feature. The feature is off-by-default in the tor-rtcompat crate, but can be enabled either from arti or arti-client. There is an included script that I used to test that tor-rtcompat could build and run its tests with all subsets of its features. Closes #300
* Make current/create functions into runtime member functions.Nick Mathewson2022-01-262-4/+3
| | | | | This should help avoid some amount of temptation towards API proliferation.
* Rename FooRuntime to FooNativeTlsRuntime for consistency.Nick Mathewson2022-01-261-6/+8
|
* Unify TokioRuntime and TokioRuntimeHandleNick Mathewson2022-01-261-5/+3
| | | | | | | | | Having separate types here doesn't justify the (very limited) benefit of distinguishing between the case where we have created an executor that we own and the case where we have a handle to an already-running tokio executor. Part of #301.
* Rename TorClient::set_stream_prefsIan Jackson2022-01-211-2/+2
| | | | | | | In line with the rest of the renaming. As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/256#note_2771617
* StreamPrefs: rename from ConnectPrefsIan Jackson2022-01-212-13/+13
| | | | | | | | | | | | | The docs even say this is about stream. As @nickm writes in https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/252#note_2771289 we generally call end-to-end connections that are tunneled over Tor "Streams" to distinguish them from everything else in the Tor protocols that could possibly be called a "Connection". That seems to apply here too.
* Merge branch 'always-isolate' into 'main'Ian Jackson2022-01-201-4/+58
|\ | | | | | | | | | | | | Provide isolate-all-streams function Closes #279 See merge request tpo/core/arti!252
| * isolation: Rename isolate_every_stream from ..._connectionIan Jackson2022-01-201-1/+1
| | | | | | | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/252#note_2771291
| * isolation: Rename (internal) EveryStream enum variantIan Jackson2022-01-201-3/+3
| | | | | | | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/252#note_2771289
| * isolation: Much better wording for always isolate settingNick Mathewson2022-01-201-1/+6
| |
| * isolation: Provide isolate-every-connection optionIan Jackson2022-01-201-0/+16
| |
| * isolation: Provide new_isolation_group methodIan Jackson2022-01-201-0/+14
| | | | | | | | | | | | | | In the usual case, set_isolation_group is awkward. This is perhaps slightly duplicative with TorClient::isolated_client(). If so then perhaps the *latter* should be abolished.
| * isolation: Refactor to introduce a bespoke enumIan Jackson2022-01-201-4/+23
| | | | | | | | | | | | No functional change. This will grow a new variant shortly.
* | connection preferences: Make `set_default_prefs` private for nowIan Jackson2022-01-201-1/+4
| |
* | connection preferences: Make `clone_with_prefs` must_useIan Jackson2022-01-201-0/+1
|/ | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/250#note_2771239
* connection preferences: Provide `clone_with_prefs` methodIan Jackson2022-01-191-0/+10
|
* connection preferences: Provide `set_connect_prefs` methodIan Jackson2022-01-191-6/+22
|
* connection preferences: Take ConnectPrefs by referenceIan Jackson2022-01-191-9/+9
| | | | | This may save quite a bit of copying. The callees don't need to copy the whole struct; they copy the bits they need.
* connection preferences: Rename variable and docs to not say "flags"Ian Jackson2022-01-191-12/+12
| | | | These aren't flags. Eg, there's an isolation token in there.
* isolation: Document orthogonality of isolated_client and isolation_groupIan Jackson2022-01-191-0/+11
|
* Merge branch 'bootstrap_reporting'Nick Mathewson2022-01-192-40/+82
|\
| * Integrate status information at arti-clientNick Mathewson2022-01-182-40/+82
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit combines status update information from tor-dirmgr and tor-chanmgr in the arti-client crate, so that the user can get to it; it represents a high-level view of the client's ability to reach the network and route traffic. I have omitted the tor-circmgr support for now; it's mostly not needed. At present it's not so useful, since there's no way for a client to get a TorClient that _isn't_ completely bootstrapped, and therefore there's no way to actually watch these events until they're no longer interesting. That should change with arti#293. This is part of #96.
* | Put our cache files in the right place.Nick Mathewson2022-01-181-1/+1
|/ | | | | | | This resolves a copy-and-paste error where we were putting everything in our state directory. Closes #297.
* Implement the basics of a bootstrap-status API.Nick Mathewson2022-01-133-1/+220
| | | | | | | | | | | | The purpose of a this API is to tell the user how far along Arti is in getting bootstrapped, and if it's stuck, what it's stuck on. This API doesn't yet expose any useful information: by the time it's observable to a client, it's always "100% bootstrapped." But I'm putting it in a MR now so that we can review the basic idea, and to avoid conflicts with later work on tickets like #293 and #278. This is part of #96.
* Improve the layout of crate exports; add runtime convenience functionseta2022-01-113-6/+47
| | | | | | | | | | | | | | | | | | | | This commit addresses multiple problems highlighted by arti#182: - `arti-client` had some types in its public API that weren't accessible without importing another crate (`CfgPath`, `DataReader`, `DataWriter`). This has been fixed. - In addition, the doc comments for `DataReader` and `DataWriter` were cleaned up to be of better quality, now that they're public. - It was impossible to use `arti-client` without also importing `tor-rtcompat`. This is now fixed by the addition of two convenience methods: `TorClient::bootstrap_with_tokio` and `TorClient::bootstrap_with_async_std`. - Potentially controversially: `tor-rtcompat` now returns *concrete* types from methods like `current_runtime`, instead of `impl Runtime`. - This was needed in order to actually be able to name the `TorClient` type that results from using these methods. - This does mean we lose API flexibility, but on balance I think this is a good thing, because the API we *do* have is actually usable...
* Merge branch 'ticket_281' into 'main'eta2022-01-102-18/+26
|\ | | | | | | | | | | | | Expose and rename stream timeout config. Closes #281 See merge request tpo/core/arti!231
| * Expose and rename stream timeout config.Nick Mathewson2022-01-102-18/+26
| | | | | | | | | | | | | | | | | | | | | | Previously we kept this in an ambiguously named type, `ClientTimeoutConfig`. But everything we do right now is client related! So `StreamTimeoutConfig` is a better name. Also, we'd previously neglected to expose the builder for this type from `TorClientConfigBuilder`. Now we do. Closes #281.
* | Make the arti_client::Result type public.Nick Mathewson2022-01-101-2/+2
|/ | | | Closes #280.
* Use *_with_prefs() for Option<ConnectPrefs> callers in TorClient::connectNeel Chauhan2022-01-082-10/+31
|
* tor-circmgr: Remove Arc around ClientCircIan Jackson2022-01-071-1/+1
| | | | | | See the new commentary text on `ClientCirc` for the rationale. Signed-off-by: Ian Jackson <[email protected]>
* extend lints to include 'clippy::all'Daniel Eades2021-12-281-0/+1
|
* Merge branch 'refactor/must-use-self' into 'main'eta2021-12-201-0/+1
|\ | | | | | | | | address clippy's latest lint See merge request tpo/core/arti!205
| * address clippy's latest lintDaniel Eades2021-12-201-0/+1
| |
* | arti-client: Change an XXXX to a TODO.Nick Mathewson2021-12-201-1/+5
|/ | | | | | We _do_ reject bad hostnames: just not where I once thought we might. We need to decide if the current behavior is what we want (and I think it is, probably?).
* Merge branch 'reconfigure' into 'main'eta2021-12-133-14/+108
|\ | | | | | | | | Make most arti-client fields reconfigurable. See merge request tpo/core/arti!181
| * Oops: MutCfg shouldn't implement Clone.Nick Mathewson2021-12-071-4/+7
| | | | | | | | | | | | | | | | We don't want MutCfg to be automatially coneable, or we'll wind up with surprises like the one that this patch fixes in TorClient. (The "surprise" is that reconfigure() would only apply its client-specific options to one client instance.)
| * Sequence reconfiguration requests.Nick Mathewson2021-12-071-8/+25
| | | | | | | | | | | | If we allow overlapping reconfiguration requests, we introduce all kinds of "fun" bugs. For example, we could wind up with a configuration made up of parts of one reconfiguration attempt, and parts of another.
| * Improve documentation of which config can change.Nick Mathewson2021-12-071-0/+2
| | | | | | | | | | It no longer makes sense to say "most things can't change", now that most things can.
| * Make TorClient reconfigurable.Nick Mathewson2021-12-072-15/+29
| | | | | | | | This covers ClientAddrConfig and ClientTimeoutConfig.