summaryrefslogtreecommitdiff
path: root/crates/arti-client/src
Commit message (Collapse)AuthorAgeFilesLines
...
* Discourage providing HintableErrorImpl without using the macro.Nick Mathewson2024-02-161-3/+10
|
* Rename one of the hint methods to hint_specificNick Mathewson2024-02-161-3/+10
|
* Refactor and improve error hinting.Nick Mathewson2024-02-143-50/+109
| | | | | | | | | | | | Instead of using complicated match statements, use downcasting to find error types that define specific hints. This also lets us define a reasonable hint-extractor for anyhow::Error, and use it when reporting errors in main. I've left an implementation of hint() in `impl Error`, to avoid breaking backward compatibility. Closes #1165.
* educe: Use std's default for two structsIan Jackson2024-02-121-2/+1
| | | | | | Reviewing uses of `#[educe(default)]`, I came across these two places where it was applied to a non-generic struct without any special attributes on fields. std's derive will do just as well here.
* educe: Use std's default for enums where default variant is unitIan Jackson2024-02-121-10/+6
| | | | | | | | | | | | | Since Rust 1.66, std's default works properly for enums, provided that the default variant is a unit. Review all uses of `#[educe(default)]` on enums and replace them with std where possible, which is most of them. In 1.66 and later, std's `#[derive(Default)]` doesn't infer any generic bounds on the derived impl, where it's an enum - since the unit variant can always be constructed. So this change doesn't add any generic bounds and is not API-visible.
* tor-hsservice: Use tor_persist::state_dirIan Jackson2024-02-011-1/+3
|
* tor-hsservice: Use tor_persist::state_dir, etc. (fmt)Ian Jackson2024-02-011-4/+3
|
* tor-hsservice: Use tor_persist::state_dirIan Jackson2024-02-011-8/+8
| | | | | | | | | | | | | | | | | | | | | | | We no longer do replay log locking in IptManager::new. Instead, we rely on the acquire_instance call in OnionService::launch, which ends up with ipt_mgr getting an InstanceHandle (which contains a lock guard). OnionServiceStateMgr is abolished; it existed to deal with the generics in the tor_persist::StateMgr API. state_dir has no generics (other than the T being loaded/stored). Many places (structs and argument lists) now have state_dir types which embody a path (or a CheckeDir) along with a lock, rather than separate path+lock+mistrust. The creation/startup code uses the new calls from state_dir. Other more minor changes: - StartupError::StateDirectoryInaccessible contains tor_persist::Error - test::create_storage_handles_from_state_dir changed and renamed, from _from_state_mgr. - replay::PersistFile's (separate) file lock is now fslock_guard's
* tor-hsclient: Rename HsClientSpecifier to HsClientNickname (fmt).Gabriela Moldovan2024-01-311-2/+2
|
* tor-hsclient: Rename HsClientSpecifier to HsClientNickname.Gabriela Moldovan2024-01-311-2/+2
| | | | | Service nicknames are represented by `HsNickname`, so let's rename `HsClientSpecifier` to `HsClientNickname`.
* tor-hsservice: Store the StateMgr inside OnionServiceState.Gabriela Moldovan2024-01-181-3/+5
| | | | | | This introduces an internal `OnionServiceStateMgr` trait, which enables us to store the `StateMgr` inside the `OnionServiceState` (without having to parameterize `OnionServiceState` on `S: StateMgr`).
* arti-client: Move state_dir and mistrust handling to separate function.Gabriela Moldovan2024-01-181-11/+19
| | | | This reduces code duplication.
* arti-client: Move keymgr creation to TorClient::create_keymgr.Gabriela Moldovan2024-01-181-49/+34
| | | | | This code was duplicated by `create_inner()` and `create_onion_service()`.
* tor-hsservice: Do not store the StateMgr in OnionService.Gabriela Moldovan2024-01-181-13/+7
| | | | | | | The `StateMgr` is currently only needed in `launch()`, so we don't really need to store it. This allows us to unparameterize OnionService.
* arti-client: Add a function for creating OnionServices.Gabriela Moldovan2024-01-181-0/+58
| | | | | This will be used from `arti` to create an `OnionService`, to implement the `arti hss` command.
* tor-hsservice: Create a separate RunningOnionService type.Gabriela Moldovan2024-01-181-5/+8
| | | | | | | | This will enable us to construct non-launched (but configured) `OnionService`s. We need this, for example, for implementing the `arti hss` CLI command. Part of #1227
* arti-client Remove a TODO hs that is no longer relevant.Gabriela Moldovan2024-01-111-1/+0
|
* arti-client: Add ErrorDetail::KeystoreRequired.Gabriela Moldovan2024-01-112-4/+12
| | | | | This addresses a `TODO HSS` about not using `internal!` for an error caused by misconfiguration.
* arti-client: Turn a TODO hs into #858.Gabriela Moldovan2024-01-111-1/+1
|
* arti-client: Turn a TODO HSS into #1106.Gabriela Moldovan2024-01-111-1/+1
|
* Merge branch 'expand-keystore-dir' into 'main'gabi-2502024-01-112-6/+4
|\ | | | | | | | | tor-keymgr: Abolish ArtiNativeKeystoreConfig::expand_keystore_dir. See merge request tpo/core/arti!1867
| * tor-keymgr: Abolish ArtiNativeKeystoreConfig::expand_keystore_dir.Gabriela Moldovan2024-01-102-6/+4
| | | | | | | | | | | | This resolves a `TODO HSS` in arti-client. Part of #1187
* | tor-hsclient: Derive the KeySpecifier implementation (fmt).Gabriela Moldovan2024-01-101-4/+2
| |
* | tor-hsclient: Derive the KeySpecifier implementation.Gabriela Moldovan2024-01-101-3/+2
|/ | | | | | | | This addresses a `TODO HSS` about deriving the `KeySpecifier` implementation for client key specifiers. Note that we no longer have a key specifier type for intro auth keys (which are not supported anyway, see #1037).
* arti_client: Change ephemeral-service TODO HSS comments to #1186.Nick Mathewson2024-01-091-3/+3
|
* arti-client::client: remove TODO HSS that is no longer true.Nick Mathewson2024-01-091-2/+0
|
* arti-client::config: Turn a TODO HSS into #1185.Nick Mathewson2024-01-091-1/+1
|
* Merge branch 'public-dir-mgr-config' into 'main'Ian Jackson2024-01-091-1/+1
|\ | | | | | | | | | | | | dirmgr: Make the `dir_mgr_config` method public Closes #1175 See merge request tpo/core/arti!1847
| * dirmgr: Make the `dir_mgr_config` method publicEmil Engler2024-01-091-1/+1
| | | | | | | | | | | | | | | | | | | | | | This commit makes the `dir_mgr_config` method of the `TorClientConfig` struct public. It might be questionable whether we should make this function public or switch to a `TryInto` trait in general, which also seems like an even Rustier solution Rustier solution. Fixes #1175
* | Fix typosDimitris Apostolou2024-01-081-1/+1
|/
* arti-client: Add an accessor for the keystore config.Gabriela Moldovan2023-12-141-0/+5
|
* Merge branch 'keymgr_enabled_default' into 'main'Nick Mathewson2023-12-131-24/+12
|\ | | | | | | | | arti_client: Cleanup around keymgr feature and config See merge request tpo/core/arti!1832
| * arti_config: remove experimental-api as way to enable keymgr.Nick Mathewson2023-12-131-7/+4
| | | | | | | | | | keymgr is always on when it is needed, so experimental-api isn't needed here.
| * arti-client: use sub_builder for ArtiNativeKeystoreConfigNick Mathewson2023-12-131-10/+3
| | | | | | | | | | | | | | | | | | The sub_builder pattern changes `StorageConfigBuilder` so that instead of holding an `Option<ArtiNativeKeystoreConfig>`, it holds an `ArtiNativeKeystoreConfigBuilder`. This makes it a little more ergonomic to use from Rust, and lets us use defaults for the builder fields so that we can make them optional in our configuration.
| * arti_client: enable keymgr when keymgr feature is configuredNick Mathewson2023-12-131-11/+9
| | | | | | | | | | | | | | This change causes arti_client to have a configurable keymgr when the onion-service-service feature is present, so that you no longer need to configure "experimental" or "experimental-api" as well in order to get a working onion service.
* | arti-client: TorClient.storage_mistrust: Correct doc commentIan Jackson2023-12-131-1/+6
| |
* | tor-hsservice: Plumb state dir and its mistrust into ipt_mgrIan Jackson2023-12-131-1/+15
| | | | | | | | | | | | | | | | | | | | | | This is needed for the replay logs. It's a shame that CheckedDir is (i) a bit unergonomic (ii) has an extra bool in it, or we could pass one of those instead of these two arguments. Since HS's might be created after startup, TorClient must have these fields.
* | arti-client: Centralise state_dir variable (fmt)Ian Jackson2023-12-131-5/+2
| |
* | arti-client: Centralise state_dir variableIan Jackson2023-12-131-3/+4
|/ | | | | Call expand_state_dir only once. We'll reuse this value, another time, too.
* Add NOTEs about similar code for address types.Nick Mathewson2023-12-121-1/+6
|
* tor-keymgr: ArtiPathSyntaxError: rename from ArtiPathErrorIan Jackson2023-12-071-1/+1
| | | | | The previous name was ambiguous, and confusable with KeyPathError (of which it is, basically, a variant).
* arti config: Declare who is supposed to add path leaf componentsIan Jackson2023-12-041-0/+10
| | | | | | Currently some components do this one way, and some the other. This is confusing. We should do it one way. This way is slightly better because it makes navigation with `grep` easier.
* tor-dirmgr: Rename DirMgrConfig.cache_path to cache_dirIan Jackson2023-12-041-1/+1
| | | | | | This variable contains precisely the value of cache_dir from arti_client::config::StorageConfig and it should therefore have the same name.
* arti config: Declare cache_dir /var/cache like natureIan Jackson2023-12-041-0/+5
|
* arti config: Declare cache_dir is not necessarily just the Tor directoryIan Jackson2023-12-041-1/+1
|
* tor-keymgr: Abolish KeyMgr::new.Gabriela Moldovan2023-11-271-2/+7
| | | | We don't use this now that we have a `KeyMgrBuilder`.
* arti-client: Stop using HsClientIntroAuthKeypair for client auth.Gabriela Moldovan2023-11-201-15/+1
| | | | Closes #1037
* Merge branch 'main' into 'main'gabi-2502023-11-171-13/+15
|\ | | | | | | | | Added macro for StorageConfig expand dir See merge request tpo/core/arti!1728
| * Added macro for StorageConfig expand dirrdbo2023-11-171-13/+15
| |
* | arti-client test: add clippy exceptionJim Newsome2023-11-161-0/+1
|/ | | | This clippy rule appears to be enabled by default in Rust 1.74.0
generated by cgit v1.2.3 (git 2.46.0) at 2026-08-27 22:29:43 +0000