summaryrefslogtreecommitdiff
path: root/crates/arti-client/src
Commit message (Collapse)AuthorAgeFilesLines
...
* Merge branch 'eta/unbootstrapped-clients' into 'main'Nick Mathewson2022-02-113-65/+215
|\ | | | | | | | | | | | | Allow creating unbootstrapped `TorClient`s (and `DirMgr`s) Closes #293 See merge request tpo/core/arti!298
| * Allow creating unbootstrapped `TorClient`s (and `DirMgr`s)eta2022-02-113-65/+215
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit changes how the `TorClient` type works, enabling it to be constructed synchronously without initiating the bootstrapping process. Daemon tasks are still started on construction (although some of them won't do anything if the client isn't bootstrapped). The old bootstrap() methods are now reimplemented in terms of the new create_unbootstrapped() and bootstrap_existing() methods. This required refactoring how the `DirMgr` works to enable the same sort of thing there. closes #293
* | Write some examples for TorClient::connect()Nick Mathewson2022-02-111-5/+64
|/ | | | | | These should explain better what you can pass as an address, and what you should do if you _really need_ to provide a SocketAddr or something.
* Update launch of chan expiration task to new APINick Mathewson2022-02-081-4/+6
| | | | This fixes a compilation error.
* ErrorDetail Simplify visibility macros a bit.Nick Mathewson2022-02-082-19/+53
| | | | | | | | Instead of declaring a macro that takes vis as an argument, we now conditionally declare a macro that applies an appropriate visibility. There's a long comment explaining the rationale here, along with a couple of other solutions that don't work.
* Rename TorResult to Result.Nick Mathewson2022-02-083-27/+28
| | | | | | | This is closer to common usage. (Not that we all agree with common usage, but it's closer to what people expect.)
* arti_client: Rename Error to ErrorDetail.Nick Mathewson2022-02-084-48/+43
| | | | | | | This is closer to what we described in Errors.md. Also, remove the (sometimes private) Result alias: it was only used in one or two places, and never exposed in public.
* TorError: Make detail() an accessor function.Nick Mathewson2022-02-081-4/+25
| | | | | | This change lets us make TorError's members unconditionally hidden, and makes our API a little more consistent (since basically nothing else is a public field).
* Merge branch 'error-improvements' into 'main'eta2022-02-083-147/+225
|\ | | | | | | | | Hopefully uncontroversial improvements to new Error code See merge request tpo/core/arti!291
| * Docs and clarification for a bunch of Error stuffNick Mathewson2022-02-042-64/+102
| |
| * Make SpawnError wrappers contain a 'spawning' stringNick Mathewson2022-02-042-36/+56
| | | | | | | | | | (By our convention, these errors should say what we were trying to spawn when the error occurred.)
| * Make the Error detail type non-exported from arti-clientNick Mathewson2022-02-043-41/+44
| | | | | | | | | | | | | | | | | | | | | | At least by default, we should have Error be private, and not expose it as part of our APIs. To keep functionality in `arti`, I had to add an `ExitTimeout` error kind. For interface consistency, I also re-exported ErrorKind and HasError from `arti_client`.
| * Test that TorError implements the right traits.Nick Mathewson2022-02-041-3/+21
| | | | | | | | | | I had planned to use assert_impl, but that can't check for the 'static lifetime.
| * Make TorError implement Clone.Nick Mathewson2022-02-041-3/+2
| | | | | | | | | | This patch makes only minimal changes in lower-level error types: we have more refactoring to do.
* | Expire channels that have been unused for too longYuan Lyu2022-02-041-0/+23
|/
* errors: Add some TODOs as per discussion commentsIan Jackson2022-02-041-0/+3
|
* errors: Drop "Error" and "Failed" from various enum variantsIan Jackson2022-02-042-3/+3
|
* Box the Error in a TorErrorIan Jackson2022-02-041-2/+10
| | | | | | This will get quite large and boxing it here is very convenient. This also avoids us exposing a large error type to our callers.
* errors: Handle exit circuit creation failure the new wayIan Jackson2022-02-042-2/+22
|
* errors: Handle circmgr setup errors differentlyIan Jackson2022-02-042-4/+5
| | | | | | | | | | | | | The motivation for doing this now is to remove the `#[from]` so we would spot where operationsl circuit setup failures were handled. (But it turns out that they are turned into internal errors!) Perhaps this will want to become a different error type from circmgr in due course, but for now we simply use a bespoke variant of TorError. It will want its own Kind. The TODO in the HasKind impl marks this (amongst much else here).
* errors: Introduce error_detail featureIan Jackson2022-02-042-3/+35
| | | | | Right now we must always expose the `Error` type since we haven't converted everything.
* errors: Refer to err::Error in some bits of arti_clientIan Jackson2022-02-044-9/+11
| | | | We are going to make the top-level Error type conditionally hidden.
* errors: Introduce TorErrorIan Jackson2022-02-043-7/+50
| | | | Still much to do here.
* errors: Initial impl HasKind in arti-client, ErrorKind::TODOIan Jackson2022-02-041-0/+7
| | | | | | | | | This involves making a temporary ErrorKind::TODO. That will continue to exist until all errors (at least, the ones that make it out to here) can be properly categorised. Introducing this will let us work from the top and bottom towards the middle.
* spawn errors: Fix arti-client, tor-chanmgr, tor-circmgrIan Jackson2022-02-041-3/+10
| | | | | | | Provide an enum variant to contain the SpawnError and a From impl. We use `#[from]` here because it doesn't really make sense to attach any context, as it's not likely to be very relevant.
* Fix typosDimitris Apostolou2022-02-021-1/+1
|
* Expose Reconfigure enum from arti-client.Nick Mathewson2022-02-011-1/+1
| | | | | This enum is required to use `TorClient::reconfigure` correctly, and as such ought to be re-exported.
* Make max_file_limit configurableNeel Chauhan2022-01-281-0/+56
|
* Fix documentation references for tor-rtcompat refactoring.Nick Mathewson2022-01-261-5/+7
|
* Make the native-tls crate optional.Nick Mathewson2022-01-261-8/+8
| | | | | | | | | | | This commit puts the native-tls crate behind a feature. The feature is off-by-default in the tor-rtcompat crate, but can be enabled either from arti or arti-client. There is an included script that I used to test that tor-rtcompat could build and run its tests with all subsets of its features. Closes #300
* Make current/create functions into runtime member functions.Nick Mathewson2022-01-262-4/+3
| | | | | This should help avoid some amount of temptation towards API proliferation.
* Rename FooRuntime to FooNativeTlsRuntime for consistency.Nick Mathewson2022-01-261-6/+8
|
* Unify TokioRuntime and TokioRuntimeHandleNick Mathewson2022-01-261-5/+3
| | | | | | | | | Having separate types here doesn't justify the (very limited) benefit of distinguishing between the case where we have created an executor that we own and the case where we have a handle to an already-running tokio executor. Part of #301.
* Rename TorClient::set_stream_prefsIan Jackson2022-01-211-2/+2
| | | | | | | In line with the rest of the renaming. As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/256#note_2771617
* StreamPrefs: rename from ConnectPrefsIan Jackson2022-01-212-13/+13
| | | | | | | | | | | | | The docs even say this is about stream. As @nickm writes in https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/252#note_2771289 we generally call end-to-end connections that are tunneled over Tor "Streams" to distinguish them from everything else in the Tor protocols that could possibly be called a "Connection". That seems to apply here too.
* Merge branch 'always-isolate' into 'main'Ian Jackson2022-01-201-4/+58
|\ | | | | | | | | | | | | Provide isolate-all-streams function Closes #279 See merge request tpo/core/arti!252
| * isolation: Rename isolate_every_stream from ..._connectionIan Jackson2022-01-201-1/+1
| | | | | | | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/252#note_2771291
| * isolation: Rename (internal) EveryStream enum variantIan Jackson2022-01-201-3/+3
| | | | | | | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/252#note_2771289
| * isolation: Much better wording for always isolate settingNick Mathewson2022-01-201-1/+6
| |
| * isolation: Provide isolate-every-connection optionIan Jackson2022-01-201-0/+16
| |
| * isolation: Provide new_isolation_group methodIan Jackson2022-01-201-0/+14
| | | | | | | | | | | | | | In the usual case, set_isolation_group is awkward. This is perhaps slightly duplicative with TorClient::isolated_client(). If so then perhaps the *latter* should be abolished.
| * isolation: Refactor to introduce a bespoke enumIan Jackson2022-01-201-4/+23
| | | | | | | | | | | | No functional change. This will grow a new variant shortly.
* | connection preferences: Make `set_default_prefs` private for nowIan Jackson2022-01-201-1/+4
| |
* | connection preferences: Make `clone_with_prefs` must_useIan Jackson2022-01-201-0/+1
|/ | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/250#note_2771239
* connection preferences: Provide `clone_with_prefs` methodIan Jackson2022-01-191-0/+10
|
* connection preferences: Provide `set_connect_prefs` methodIan Jackson2022-01-191-6/+22
|
* connection preferences: Take ConnectPrefs by referenceIan Jackson2022-01-191-9/+9
| | | | | This may save quite a bit of copying. The callees don't need to copy the whole struct; they copy the bits they need.
* connection preferences: Rename variable and docs to not say "flags"Ian Jackson2022-01-191-12/+12
| | | | These aren't flags. Eg, there's an isolation token in there.
* isolation: Document orthogonality of isolated_client and isolation_groupIan Jackson2022-01-191-0/+11
|
* Merge branch 'bootstrap_reporting'Nick Mathewson2022-01-192-40/+82
|\
generated by cgit v1.2.3 (git 2.46.0) at 2026-08-27 19:53:59 +0000