| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
| |
Discussion on #1960 suggests that this option is not a good idea:
it encourages developers to work around deliberate signals that the
software they're shipping won't work on the network.
Closes #1960.
|
| |
|
|
| |
Run maint/add_warning
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
First, run
```
git grep -l "^edition =" |
xargs perl -i -pe 's/^edition *=.*/edition = "2024"/;'
```
Second, manually verify that all Cargo.toml files have changed,
and nothing else has changed.
Third, run cargo fmt again.
|
| |
|
|
| |
Signed-off-by: David Goulet <[email protected]>
|
| |
|
|
| |
Closes #2012.
|
| |
|
|
|
|
|
|
|
| |
This commit implements the HasKind trait for TorAddrError in address.rs,
mapping all variants to the InvalidStreamTarget error kind. It also updates
the ErrorDetail implementation in err.rs to delegate to TorAddrError's
HasKind implementation instead of hardcoding the error kind.
Resolves TODOs in address.rs and err.rs.
|
| |
|
|
|
| |
(This isn't a boolean, because we really don't want people ignoring
all possible required protocols.)
|
| |
|
|
| |
This is the major part of #1849.
|
| | |
|
| |
|
|
|
| |
We only ever return `BadOnionAddress` is we are asked to connect to a
.onion address that doesn't parse.
|
| |
|
|
|
|
|
|
|
|
| |
Also changes the `ErrorKind` of `BadOnionAddress` to
`ForbbiddenStreamTarget`.
See context in
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2246#note_3045683
Closes #1483
|
| |
|
|
|
|
| |
During startup we'll call a few not-just-at-startup memquota methods
which produce tor_memquota::Error, rather than StartupError. So we
need a variant for that.
|
| |
|
|
|
| |
It turns out that my fingers want to treat "memquota" as a word. We
have this in tor_memquota etc. too.
|
| | |
|
| | |
|
| |
|
|
| |
Nothing uses this yet.
|
| | |
|
| |
|
|
| |
This is an actual bug. Closes #1379.
|
| | |
|
| |
|
|
| |
Closes #1277
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Instead of using complicated match statements, use downcasting
to find error types that define specific hints. This also lets us
define a reasonable hint-extractor for anyhow::Error, and use it
when reporting errors in main.
I've left an implementation of hint() in `impl Error`, to
avoid breaking backward compatibility.
Closes #1165.
|
| |
|
|
|
| |
This addresses a `TODO HSS` about not using `internal!` for an error
caused by misconfiguration.
|
| |
|
|
|
| |
The previous name was ambiguous, and confusable with KeyPathError
(of which it is, basically, a variant).
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
I spotted these while I was working on something else.
|
| |
|
|
|
| |
Nightly rustdoc now warns if you have a link that isn't necessary,
and if you have a link that might refer to two different things.
|
| |
|
|
|
| |
Previously there was a missing "not", and it didn't say what to do
about the error.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
`KeyStore` was renamed to `Keystore` globally in !1355. This fixes a
compile error caused an unfortunate series of non-conflicting (from
git's POV) but incompatible merges:
* !1356 added a line threferencing an error variant that capitalizes the
"s" in "KeyStore" (`ErrorDetail::KeyStore`)
* !1356 landed just before !1355 (the global renaming). Since there was
no conflict between the 2, we're now in a state where the code added
in !1356 is referencing an `ErrorDetail` variant that no longer
exists.
|
| |\
| |
| |
| |
| | |
keymgr: Rename KeyStore to Keystore globally.
See merge request tpo/core/arti!1355
|
| | |
| |
| |
| |
| | |
We've been capitalizing the "s" in "KeyStore" inconsistently. This
`s/KeyStore/Keystore/g` across the codebase.
|
| |/
|
|
| |
This `From` impl was just calling itself recursively...
|
| |
|
|
|
|
|
|
|
|
| |
This variant can never be constructed when parsing a TorAddr, so it
doesn't make sense to have it in TorAddrError: the use can never see
it unless they enable `error_detail`.
Not a semver break because the client feature is not yet stable.
Closes #932.
|
| | |
|
| |
|
|
| |
Part of #897
|
| |
|
|
|
| |
ErrorDetail isn't PartialEq so we can't assert_eq! it.
But the discriminants will be.
|
| | |
|
| |
|
|
|
| |
Previously this error meant "we haven't written this code yet".
Now, we change it to "you haven't built Arti with this feature".
|
| | |
|
| |
|
|
|
|
|
|
|
| |
TorClient now only uses the tor_keymgr::KeyMgr implementation if the
keymgr experimental feature is enabled. If the feature is disabled, a
dummy key manager implementation is used.
The new `keymgr` feature depends on `onion-client`, because the key
manager is only used for HS client auth.
|
| | |
|
| |
|
|
|
| |
`TorClient` now uses a `KeyMgr` to retrieve the `HsClientSecretKeys`
client auth keys passed to `get_or_launch_connection`.
|
| |
|
|
|
| |
The old name was unwieldy and other crates can just as well name it by
the crate scope.
|
| |
|
|
|
|
| |
Now
cargo +stable clippy --locked --offline --workspace --all-targets
is clean.
|
| |
|
|
|
| |
As per
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1071/diffs?commit_id=580fe1118dbbbfa086d11b28e3e26d7c91afe21c#fbd7ab2d6d0a5b515697d4f9f99a42ebd508aa4b_153_165
|