summaryrefslogtreecommitdiff
path: root/crates/arti-client/src/client.rs
Commit message (Collapse)AuthorAgeFilesLines
* tor-hsclient: Remove client nickname from the client key specifiers (fmt).Gabriela Moldovan2024-02-221-6/+2
|
* tor-hsclient: Remove client nickname from the client key specifiers.Gabriela Moldovan2024-02-221-5/+2
| | | | Closes #1283
* arti, arti-client, tor-keymgr: Remove keystore dir configuration.Gabriela Moldovan2024-02-211-2/+3
| | | | Closes #1202
* educe: Use std's default for two structsIan Jackson2024-02-121-2/+1
| | | | | | Reviewing uses of `#[educe(default)]`, I came across these two places where it was applied to a non-generic struct without any special attributes on fields. std's derive will do just as well here.
* educe: Use std's default for enums where default variant is unitIan Jackson2024-02-121-10/+6
| | | | | | | | | | | | | Since Rust 1.66, std's default works properly for enums, provided that the default variant is a unit. Review all uses of `#[educe(default)]` on enums and replace them with std where possible, which is most of them. In 1.66 and later, std's `#[derive(Default)]` doesn't infer any generic bounds on the derived impl, where it's an enum - since the unit variant can always be constructed. So this change doesn't add any generic bounds and is not API-visible.
* tor-hsservice: Use tor_persist::state_dirIan Jackson2024-02-011-1/+3
|
* tor-hsservice: Use tor_persist::state_dir, etc. (fmt)Ian Jackson2024-02-011-4/+3
|
* tor-hsservice: Use tor_persist::state_dirIan Jackson2024-02-011-8/+8
| | | | | | | | | | | | | | | | | | | | | | | We no longer do replay log locking in IptManager::new. Instead, we rely on the acquire_instance call in OnionService::launch, which ends up with ipt_mgr getting an InstanceHandle (which contains a lock guard). OnionServiceStateMgr is abolished; it existed to deal with the generics in the tor_persist::StateMgr API. state_dir has no generics (other than the T being loaded/stored). Many places (structs and argument lists) now have state_dir types which embody a path (or a CheckeDir) along with a lock, rather than separate path+lock+mistrust. The creation/startup code uses the new calls from state_dir. Other more minor changes: - StartupError::StateDirectoryInaccessible contains tor_persist::Error - test::create_storage_handles_from_state_dir changed and renamed, from _from_state_mgr. - replay::PersistFile's (separate) file lock is now fslock_guard's
* tor-hsclient: Rename HsClientSpecifier to HsClientNickname (fmt).Gabriela Moldovan2024-01-311-2/+2
|
* tor-hsclient: Rename HsClientSpecifier to HsClientNickname.Gabriela Moldovan2024-01-311-2/+2
| | | | | Service nicknames are represented by `HsNickname`, so let's rename `HsClientSpecifier` to `HsClientNickname`.
* tor-hsservice: Store the StateMgr inside OnionServiceState.Gabriela Moldovan2024-01-181-3/+5
| | | | | | This introduces an internal `OnionServiceStateMgr` trait, which enables us to store the `StateMgr` inside the `OnionServiceState` (without having to parameterize `OnionServiceState` on `S: StateMgr`).
* arti-client: Move state_dir and mistrust handling to separate function.Gabriela Moldovan2024-01-181-11/+19
| | | | This reduces code duplication.
* arti-client: Move keymgr creation to TorClient::create_keymgr.Gabriela Moldovan2024-01-181-49/+34
| | | | | This code was duplicated by `create_inner()` and `create_onion_service()`.
* tor-hsservice: Do not store the StateMgr in OnionService.Gabriela Moldovan2024-01-181-13/+7
| | | | | | | The `StateMgr` is currently only needed in `launch()`, so we don't really need to store it. This allows us to unparameterize OnionService.
* arti-client: Add a function for creating OnionServices.Gabriela Moldovan2024-01-181-0/+58
| | | | | This will be used from `arti` to create an `OnionService`, to implement the `arti hss` command.
* tor-hsservice: Create a separate RunningOnionService type.Gabriela Moldovan2024-01-181-5/+8
| | | | | | | | This will enable us to construct non-launched (but configured) `OnionService`s. We need this, for example, for implementing the `arti hss` CLI command. Part of #1227
* arti-client Remove a TODO hs that is no longer relevant.Gabriela Moldovan2024-01-111-1/+0
|
* arti-client: Add ErrorDetail::KeystoreRequired.Gabriela Moldovan2024-01-111-4/+3
| | | | | This addresses a `TODO HSS` about not using `internal!` for an error caused by misconfiguration.
* arti-client: Turn a TODO hs into #858.Gabriela Moldovan2024-01-111-1/+1
|
* arti-client: Turn a TODO HSS into #1106.Gabriela Moldovan2024-01-111-1/+1
|
* Merge branch 'expand-keystore-dir' into 'main'gabi-2502024-01-111-4/+2
|\ | | | | | | | | tor-keymgr: Abolish ArtiNativeKeystoreConfig::expand_keystore_dir. See merge request tpo/core/arti!1867
| * tor-keymgr: Abolish ArtiNativeKeystoreConfig::expand_keystore_dir.Gabriela Moldovan2024-01-101-4/+2
| | | | | | | | | | | | This resolves a `TODO HSS` in arti-client. Part of #1187
* | tor-hsclient: Derive the KeySpecifier implementation (fmt).Gabriela Moldovan2024-01-101-4/+2
| |
* | tor-hsclient: Derive the KeySpecifier implementation.Gabriela Moldovan2024-01-101-3/+2
|/ | | | | | | | This addresses a `TODO HSS` about deriving the `KeySpecifier` implementation for client key specifiers. Note that we no longer have a key specifier type for intro auth keys (which are not supported anyway, see #1037).
* arti_client: Change ephemeral-service TODO HSS comments to #1186.Nick Mathewson2024-01-091-3/+3
|
* arti-client::client: remove TODO HSS that is no longer true.Nick Mathewson2024-01-091-2/+0
|
* arti-client: TorClient.storage_mistrust: Correct doc commentIan Jackson2023-12-131-1/+6
|
* tor-hsservice: Plumb state dir and its mistrust into ipt_mgrIan Jackson2023-12-131-1/+15
| | | | | | | | | | | This is needed for the replay logs. It's a shame that CheckedDir is (i) a bit unergonomic (ii) has an extra bool in it, or we could pass one of those instead of these two arguments. Since HS's might be created after startup, TorClient must have these fields.
* arti-client: Centralise state_dir variable (fmt)Ian Jackson2023-12-131-5/+2
|
* arti-client: Centralise state_dir variableIan Jackson2023-12-131-3/+4
| | | | | Call expand_state_dir only once. We'll reuse this value, another time, too.
* tor-keymgr: Abolish KeyMgr::new.Gabriela Moldovan2023-11-271-2/+7
| | | | We don't use this now that we have a `KeyMgrBuilder`.
* arti-client: Stop using HsClientIntroAuthKeypair for client auth.Gabriela Moldovan2023-11-201-15/+1
| | | | Closes #1037
* Send less information in onion service BEGIN messagesNick Mathewson2023-11-151-1/+9
| | | | | | | | | While looking for differences, we found that C tor always omits the flags and the hostname from a BEGIN message sent on an onion service circuit. In torspec!179, we specified that behavior. This patch brings arti into conformance. Closes #1077.
* hsclient: Rename get_or_launch{connection => circuit}Nick Mathewson2023-10-241-1/+1
| | | | Closes #1078.
* tor-keymgr: Use ArtiPathError for invalid ArtiPaths.Gabriela Moldovan2023-10-191-2/+2
|
* arti-client: fix up launch_onion_service a bit.Nick Mathewson2023-10-031-10/+19
| | | | Return a stream of requests, and document what to do with them.
* hss: actually provide a stream of RendRequest from launch().Nick Mathewson2023-09-271-1/+1
|
* tor-hsservice: Run cargo fmt.Gabriela Moldovan2023-09-271-3/+1
|
* tor-hsservice: Make Launchable a non-async trait.Gabriela Moldovan2023-09-271-1/+0
| | | | | This doesn't need to be an async_trait now that `Publisher::launch` is no longer async.
* arti-client: add a minimal onion-service-launching API.Nick Mathewson2023-09-271-6/+54
|
* tor-hsclient, arti-client, tor-keymgr, tor-netdoc: Use a keypair instead of ↵Gabriela Moldovan2023-09-251-2/+2
| | | | | | | | | | | | | StaticSecret. Previously, when retrieving `KS_hsc_desc_enc` keys (or any other x25519 keys) from the keystore, the keymgr would discard the public part of the key (SSH private keys contain the public part of the key too). Instead of discarding the public key and returning just the `StaticSecret`, the keymgr now returns a `StaticKeypair`. This makes the x25519 `EncodableKey`/`ToEncodableKey` implementation consistent with the ed25519 one (which retrieves key pairs rather than "unescorted" secrets).
* arti-client: add exit selection with GeoIP country codeseta2023-09-181-1/+40
| | | | | | | | | | | | | | | | | | | | This threads the country codes work through the rest of the codebase: - `tor-dirmgr` will now enable GeoIP with the embedded database when the `geoip` future is enabled - This can be extended later using the `DirMgrConfig` to allow specifying a custom database; this is not done here, though - `tor-circmgr`'s `SupportedCircUsage` and `TargetCircUsage` fields gain new `country_code` members to allow filtering circuits by country - These are `()` in builds where the `geoip` feature is not enabled -- doing it this way means we don't have to copy and paste huge swathes of code, since we can't use `#[cfg]` in patterns - `ExitPathBuilder` gains (hacked-in) support for choosing a relay with the correct country code - Due to the lack of conjuction, we just copy and paste a small bit, pending further refactoring - `StreamPrefs` now lets you specify a country code, letting embedders make use of the feature
* Run maint/add_warning to add lint block everywhereIan Jackson2023-08-231-0/+1
|
* Resolve a pair of warnings about redundant closures.Nick Mathewson2023-08-221-2/+2
|
* pass reconfigure_lock guard into TorClient::reconfigure_innersw1tch2023-07-251-3/+8
|
* cargo fmtsw1tch2023-07-241-1/+3
|
* fixes deadlock in TorClient::reconfiguresw1tch2023-07-241-1/+34
|
* Revert "keymgr: Require callers to be explicit about which keystore to get ↵Gabriela Moldovan2023-07-211-6/+4
| | | | | | | | | keys from." This reverts commit 38a6c74c7894dc96b16c9039cacc2a4023977b05. This also updates some tests to make them compile with the reverted version of the code.
* keymgr: Require callers to be explicit about which keystore to get keys from.Gabriela Moldovan2023-07-201-4/+6
|
* keymgr: Explicitly specify the default keystore for `KeyMgr`.Gabriela Moldovan2023-07-201-4/+5
|