aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | proto: Clarify wording in relay reactor constructorGabriela Moldovan2026-06-291-1/+5
| | | | |
| * | | | proto: Say why INCOMING_BUFFER is set to STREAM_READER_BUFFERGabriela Moldovan2026-06-291-0/+5
| | | | |
| * | | | proto: Add expect(unused) where neededGabriela Moldovan2026-06-292-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now that relays no longer use `CtrlCmd::AwaitStreamRequests`, some of these fields are unused. I'm leaving them in for now, but we should remove them if they're still unused after we finish the circ reactor impl. I'm not removing `AwaitStreamRequests`, because it will be needed by onion services, when we replace the old client circuit reactor with the new one.
| * | | | proto: Remove RelayCirc::allow_stream_requests()Gabriela Moldovan2026-06-291-141/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We don't need it anymore now that `RelayCirc`s always allow incoming stream requests. The previous design, where you could build a `RelayCirc` that didn't allow stream requests, was a leftover from the onion service `ClientCirc` implementation that this was inspired from (onion services *do* need the two to be decoupled, because incoming stream requests are only allowed on the virtual hop, after it's established). Closes #2582
| * | | | proto: Pass an IncomingStreamRequestFilter factory to the create handlerGabriela Moldovan2026-06-295-3/+48
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This implements what we discussed in `doc/dev/notes/relay-streams.md` (lines 218-234): > Currently, to allow incoming stream requests on a circuit, > you first need to call `RelayCirc::allow_stream_requests()` > to install a `CmdChecker` and `IncomingStreamRequestFilter`. > This is not ideal, because `allow_stream_requests()` will need to be > called unconditionally, on each `RelayCirc`, > right after it's created in the `CreateHandler` impl > (which in turn, would mean making `handle_create()` async too, > because `allow_stream_requests()` is async, which wouldn't be great). > > So, the first step here is to rework the `RelayCirc` API to make relay circuits > be constructable with a list of allowed `RelayCmd`s and `IncomingStreamRequestFilter` > from the get-go ([#2582]), and to get rid of `allow_stream_requests()`, > which will enable the `CREATE*` handler to remain non-`async`. > > In any case, the `CREATE*` handler will still require some changes, > because it needs to be initialized with an `IncomingStreamRequestFilter`, I am not sure using an `IncomingStreamRequestFilter` "factory" is necessarily the right approach here, but the circuit `Reactor`'s constructor needs to take an `IncomingStreamRequestFilter`, and `IncomingStreamRequestFilter` is not `Clone` (and FWIW, I think it's better if we don't make it `Clone`). One obvious limitation is that the `IncomingStreamRequestFilter` of the circuit reactor is fixed for the entire lifetime of the circuit. In practice, I don't think this is going to be a problem, because the arti-relay `IncomingStreamRequestFilter` is only going be used for * preventing single-hop exit streams * per-circuit rate-limiting. Both of these checks will require the filter to have access to a recent `NetDir`, which is straightforward if the filter has an Arc<dyn NetDirProvider> (as mentioned in doc/dev/notes/relay-streams.md, `NetDirProvider` has a handy non-async `timely_netdir()` function we can use). And since these checks are based on consensus params, we don't really need to ever update an already-built circuit with a new `IncomingStreamRequestFilter` (because all `IncomingStreamRequestFilter` will have the ability to obtain a fresh `NetDir` as needed). Nevertheless, I left a TODO about this, because I expect this type to change once we figure out all the other pieces needed for #1448.
| * | | | proto: Return IncomingStreams stream from relay reactor constructor (fmt)Gabriela Moldovan2026-06-291-4/+4
| | | | |
| * | | | proto: Return IncomingStreams stream from relay reactor constructorGabriela Moldovan2026-06-292-52/+122
| | | | | | | | | | | | | | | | | | | | Part of #2582
| * | | | proto: Support passing a stream request filter to the reactorGabriela Moldovan2026-06-293-4/+83
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Relay circuits always need a filter, so it's best to set it via the constructor. Part of #2582 Closes #2577
| * | | | arti-relay: Add an unimplemented stream request filterGabriela Moldovan2026-06-292-0/+24
|/ / / / | | | | | | | | | | | | | | | | | | | | This is currently just a placeholder that accepts all stream requests. It will be fleshed out later, as part of #1448
* | | | Merge branch 'fix-ntor-range' into 'main'Ian Jackson2026-06-291-12/+5
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | tor-netdoc: Fix Ed25519NtorCrossCert range See merge request tpo/core/arti!4173
| * | | | tor-netdoc: Remove redundant .clone() callClara Engler2026-06-291-1/+1
| | | | | | | | | | | | | | | | | | | | No longer required because it implements Copy.
| * | | | tor-netdoc: Fix Ed25519NtorCrossCert rangeClara Engler2026-06-291-11/+4
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit fixes the range to NOT include SystemTime::UNIX_EPOCH. This is because TimerangeBound makes a difference between a lower bound being Some or None. This was discovered later during test and is crucial to properly detect a minimum in the yet-to-be-merged .verify() method for router descriptors.
* | | | Merge branch 'prefix-4137' into 'main'Ian Jackson2026-06-291-5/+1
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | removed unnecessary PinBox wrapper See merge request tpo/core/arti!4172
| * | | | removed unnecessary PinBox wrapperpryty262026-06-241-5/+1
| | | | |
* | | | | Merge branch 'expanded-keypair-ntor' into 'main'Ian Jackson2026-06-292-3/+4
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | tor-netdoc: ExpandedKeypair for Ed25519NtorCrossCert::new_signed() See merge request tpo/core/arti!4155
| * | | | | tor-netdoc: ExpandedKeypair for Ed25519NtorCrossCert::new_signed()Clara Engler2026-06-252-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit changes Ed25519NtorCrossCert::new_signed() to accept an ExpandedKeypair instead of a Keypair, because when converting the ntor key using convert_curve25519_to_ed25519_public(), only the ExpandedKeypair is returned, which is a one-way conversion from Keypair.
* | | | | | Merge branch 'expanded-keypair-public-key' into 'main'Ian Jackson2026-06-292-0/+7
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | tor-llcrypto: Implement Ed25519PublicKey for ExpandedKeypair See merge request tpo/core/arti!4154
| * | | | | tor-llcrypto: Implement Ed25519PublicKey for ExpandedKeypairClara Engler2026-06-252-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ExpandedKeypair already implements Ed25519SigningKey, so there is no reason to not implement Ed25519PublicKey on it.
* | | | | | Merge branch 'fallbackdir-25-06-2026' into 'main'David Goulet2026-06-261-899/+890
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | fallbackdir: Update list generated on June 25, 2026 See merge request tpo/core/arti!4157
| * | | | | | fallbackdir: Update list generated on June 25, 2026Tor CI Release2026-06-261-899/+890
|/ / / / / / | | | | | | | | | | | | | | | | | | Signed-off-by: Tor CI Release <[email protected]>
* | | | | | Merge branch 'create-fast' into 'main'opara2026-06-252-18/+132
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | tor-proto: Handle incoming CREATE2 with ntor (non-v3) handshakes See merge request tpo/core/arti!4149
| * | | | | | tor-proto: add some comments about handshake server argumentsSteven Engler2026-06-251-0/+5
| | | | | | |
| * | | | | | tor-proto: implement the ntor (non-v3) handshakeSteven Engler2026-06-241-5/+65
| | | | | | |
| * | | | | | tor-key-forge: add a `secret()` accessor to the derived keypair typeSteven Engler2026-06-241-0/+9
| | | | | | |
| * | | | | | tor-proto: update a comment in `CreateRequestHandler`Steven Engler2026-06-241-4/+2
| | | | | | |
| * | | | | | tor-proto: move `RelayLayer` split into helperSteven Engler2026-06-241-4/+21
| | | | | | |
| * | | | | | tor-proto: prepare for ntor handshakesSteven Engler2026-06-241-9/+34
| | | | | | |
* | | | | | | Merge branch 'tpa-runners' into 'main'gabi-2502026-06-251-4/+0
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Revert "ci: require 'tpa' tag for runners" See merge request tpo/core/arti!4156
| * | | | | | | Revert "ci: require 'tpa' tag for runners"Steven Engler2026-06-251-4/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 75c0ee2f90710b6d599076debcb6ffad49599823.
* | | | | | | | Merge branch 'trace-filter' into 'main'opara2026-06-252-2/+2
|\ \ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | arti: Fix option name in 'arti-example-config.toml' See merge request tpo/core/arti!4148
| * | | | | | | arti: remove references to old `trace_filter` in commentsSteven Engler2026-06-252-2/+2
| |/ / / / / /
* | | | | | | Merge branch 'fix-protover-zero-doc' into 'main'Nick Mathewson2026-06-251-2/+2
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | tor-protover: Fix documentation regarding version `0` See merge request tpo/core/arti!4151
| * | | | | | | tor-protover: Fix documentation regarding version `0`Clara Engler2026-06-251-2/+2
| |/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | See torspec!519. This is actually not legal and already rejected, the docs are just wrong.
* | | | | | | Merge branch 'microdesc-sha' into 'main'Clara Engler2026-06-258-76/+96
|\ \ \ \ \ \ \ | |_|/ / / / / |/| | | | | | | | | | | | | | | | | | | | tor-netdoc: Remove document hash from Microdesc struct (and add MicrodescAndHash for that) See merge request tpo/core/arti!4138
| * | | | | | Apply deferred rustfmt churnIan Jackson2026-06-223-10/+5
| | | | | | |
| * | | | | | Remove renaming aliases for MicrodescAndHashIan Jackson2026-06-225-28/+28
| | | | | | |
| * | | | | | tor-netdoc: Break Microdesc up into Microdesc and MicrodescAndHashIan Jackson2026-06-228-33/+55
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Microdesc type having a copy of the document hash was always weird, and it's weirder now that there's all these parse2 types that don't have it and parse2 derives on Microdesc that don't touch it. Make a new type for the descriptor and its hash. Use deref to arrange that the new type works almost like the old one. Adjust the use lines in the dependencies to temporarily import MicrodescAndHash as Microdesc.
| * | | | | | tor-netdoc: Move some Microdesc methodsIan Jackson2026-06-221-20/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Code motion, plus adding a new impl block, to make the next commit clearer.
* | | | | | | Merge branch 'trivial-encode-string-slice' into 'main'Clara Engler2026-06-251-2/+1
|\ \ \ \ \ \ \ | |_|/ / / / / |/| | | | | | | | | | | | | | | | | | | | tor-netdoc: Replace trivial string slice See merge request tpo/core/arti!4143
| * | | | | | tor-netdoc: Replace trivial string sliceClara Engler2026-06-241-2/+1
| | | | | | |
* | | | | | | Merge branch 'relay-early' into 'main'opara2026-06-244-6/+29
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | tor-proto: Pass the correct channel msg cmd to `decrypt_outbound()` See merge request tpo/core/arti!4146
| * | | | | | | tor-cell: remove `derive_more::Into` for `RelayEarly`Steven Engler2026-06-242-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We don't use this anymore, and it can lead to subtle bugs since we lose the original channel message command.
| * | | | | | | tor-proto: pass correct chan msg cmd to `decrypt_outbound()`Steven Engler2026-06-242-5/+27
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Instead of converting the `RelayEarly` message to a `Relay` message, we add a new `RelayMaybeEarlyChanMsg` restricted message set that can hold either. Previously we were passing the wrong channel message command to `decrypt_outbound()`, which would cause the decryption to fail for relay crypto algorithms that use the command.
* | | | | | | Merge branch 'tpa-runners' into 'main'opara2026-06-241-0/+4
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ci: Require 'tpa' tag for runners See merge request tpo/core/arti!4147
| * | | | | | | ci: require 'tpa' tag for runnersSteven Engler2026-06-241-0/+4
| |/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is to try to work around the following, since the OSUOSL runners are broken. https://gitlab.torproject.org/tpo/tpa/team/-/work_items/42705 We should revert this once they are working again. I'll open a ticket to remember do this.
* | | | | | | Merge branch 'netdoc-string-slice-doc' into 'main'Nick Mathewson2026-06-245-14/+23
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | | | | | | | | | | | | | | | tor-netdoc: Replace string slices with str::get() in doc See merge request tpo/core/arti!4142
| * | | | | | tor-netdoc: Replace string slices with str::get() in doc (fmt)Clara Engler2026-06-243-5/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | No functional change, just reformatting.
| * | | | | | tor-netdoc: Replace string slices with str::get() in docClara Engler2026-06-245-14/+9
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit replaces the use of string slices with str::get() in all document related code. While this is not a perfect replacement for it, the relevant parts in the code heavily depend upon the byte offsets returned by the low level (legacy) parser where changing it would lead to a very big refactoring. Nonetheless, this approach is better because returning a bug is better than crashing.
* | | | | | Merge branch 'intern' into 'main'Clara Engler2026-06-2418-59/+201
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Introduce Intern<T> Closes #2587 See merge request tpo/core/arti!4130
| * | | | | tor-netdoc: Fix rs.rs cache commentsClara Engler2026-06-241-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Removes a blocking comment and replaces it with a TODO DIRAUTH.
generated by cgit v1.2.3 (git 2.46.0) at 2026-08-27 08:45:53 +0000