aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | Make sure that rpc_state_sender lives as long as the proxies.Nick Mathewson2026-01-121-2/+8
| | | | | | | | | | | | | | | | | | | | | | | | Fixes bug introduced in 0cc367b9fef37c0f7d7f04d54c4687b27ef251d0. Without this fix, RPC's get_proxy_info command wouldn't work.
| * | | Remove a spurious debug_assert in arti-rpcserver.Nick Mathewson2026-01-122-1/+1
|/ / / | | | | | | | | | | | | | | | | | | This should never have been retained when we refactored our channels for reporting responses into a single channel. The bug became apparent when quicktest became derived from debug.
* | | Merge branch 'fixup-feats-1-9-0' into 'main'Clara Engler2026-01-124-1/+9
|\ \ \ | |/ / |/| | | | | | | | cargo: Run fixup-features for release See merge request tpo/core/arti!3569
| * | cargo: Run fixup-features for releaseClara Engler2026-01-124-1/+9
| | | | | | | | | | | | | | | | | | | | | Executed command: ``` cargo run -p fixup-features -- --exclude examples/ --exclude maint/ Cargo.toml ```
* | | Merge branch 'typo' into 'main'Clara Engler2026-01-121-1/+2
|\ \ \ | | | | | | | | | | | | | | | | tor-config: Small typo fix in docs See merge request tpo/core/arti!3564
| * | | tor-config: small typo fix in docsSteven Engler2026-01-071-1/+2
| |/ /
* | | Merge branch 'rustsec-2025-0141' into 'main'Ian Jackson2026-01-121-0/+10
|\ \ \ | |/ / |/| | | | | | | | | | | | | | maint: Ignore RUSTSEC-2025-0141 Closes #2311 See merge request tpo/core/arti!3568
| * | maint: Ignore RUSTSEC-2025-0141Clara Engler2026-01-121-0/+10
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bincode is unmaintained. Right now, we do not depend on it directly, but rather transitively through maybenot (with tor-proto) and typed-index-collections (with tor-netdoc). This has been reported upstream in the respective crates: * <https://github.com/zheland/typed-index-collections/issues/10> * <https://github.com/maybenot-io/maybenot/issues/40> It is pretty unfortunate, but there is not much we can do at the current moment, given that it is an external matter and we need it for the next arti release; also, as far as I am aware, there are no known security vulnerabilities in the current version of bincode. Therefore, this commit adds it to the list of exception. Fixes #2311 See #2312
* | Merge branch 'keymgr-describe' into 'main'gabi-2502026-01-0615-307/+328
|\ \ | | | | | | | | | | | | | | | | | | keymgr: Extend KeySpecifier macro to support describe() for C Tor paths Closes #2242 See merge request tpo/core/arti!3557
| * | keymgr: Remove redundant field name in struct initGabriela Moldovan2026-01-061-1/+1
| | | | | | | | | | | | Fixes a clippy warning.
| * | keymgr: Add tests for the unhappy path of from_ctor_path()Gabriela Moldovan2026-01-061-2/+34
| | |
| * | keymgr: Derive PartialEq for CTorPathErrorGabriela Moldovan2026-01-061-1/+1
| | |
| * | keymgr: Update tests to use the new d-d macro annotation for CTorPaths (fmt)Gabriela Moldovan2026-01-061-1/+3
| | |
| * | keymgr: Update tests to use the new d-d macro annotation for CTorPathsGabriela Moldovan2026-01-061-28/+14
| | |
| * | hsclient, hsservice: Remove no longer needed conversion functionsGabriela Moldovan2026-01-062-87/+1
| | |
| * | keymgr: Use d-d to generate CTorPath<->KeySpecifier conversionsGabriela Moldovan2026-01-063-29/+57
| | |
| * | keymgr: Add a CTorKeySpecifier trait (fmt)Gabriela Moldovan2026-01-061-4/+4
| | |
| * | keymgr: Add a CTorKeySpecifier traitGabriela Moldovan2026-01-062-1/+18
| | |
| * | keymgr: Make CTorPath more like the client/service specifiers (fmt)Gabriela Moldovan2026-01-066-19/+24
| | |
| * | keymgr: Make CTorPath more like the client/service specifiersGabriela Moldovan2026-01-068-88/+62
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This will make it easier to see the correspondence between CTorPaths and the HS client/service key specifiers. Initially, I was hoping this would make it easier to write a d-d macro that automatically derives a `CTorPath` variant (e.g. `HsClientDescEncKeypair`) from the KeySpecifier type name (`HsClientDescEncKeypairSpecifier`), but alas, I don't think d-d can "chop off" name suffixes ("Specifier", in this case). `from_ctor_path()`/`ctor_path()` implementations for converting `CTorPath`s to and from key specifiers.
| * | keymgr: Fix some recently broken doc linksGabriela Moldovan2026-01-063-6/+6
| | |
| * | keymgr: Resolve a handful of clippy warnings (fmt)Gabriela Moldovan2026-01-061-2/+1
| | |
| * | keymgr: Resolve a handful of clippy warningsGabriela Moldovan2026-01-062-4/+4
| | |
| * | keymgr: Push error handling into the from_ctor_path() functionsGabriela Moldovan2026-01-064-28/+35
| | |
| * | keymgr: Replace placeholder errors with CTorPathError (fmt)Gabriela Moldovan2026-01-061-4/+4
| | |
| * | keymgr: Replace placeholder errors with CTorPathErrorGabriela Moldovan2026-01-063-10/+35
| | |
| * | keymgr: Remove unused argument in helper function (fmt)Gabriela Moldovan2026-01-061-6/+1
| | |
| * | keymgr: Remove unused argument in helper functionGabriela Moldovan2026-01-061-3/+1
| | | | | | | | | | | | | | | Previously, the `arti_path` was needed to build the various `ArtiPath` errors, but that's no longer the case.
| * | keymgr: Remove redundant ArtiPath from error context (fmt)Gabriela Moldovan2026-01-061-4/+2
| | |
| * | keymgr: Remove redundant ArtiPath from error contextGabriela Moldovan2026-01-063-26/+9
| | | | | | | | | | | | | | | The `ArtiPath` is included in the `KeyPathError::Arti` outer error type, so there is no need to include it in `ArtiPathError` too.
| * | keymgr: Split out ArtiPathError from KeyPathError (fmt)Gabriela Moldovan2026-01-061-16/+19
| | |
| * | keymgr: Split out ArtiPathError from KeyPathErrorGabriela Moldovan2026-01-065-27/+44
| | | | | | | | | | | | | | | This makes the error handling around `KeyPath`s a bit more sensible, IMO, and it will make it easier to extend it for `CTorPath` errors.
| * | keymgr: Make describe_via_components() return BugGabriela Moldovan2026-01-061-1/+1
| | | | | | | | | | | | This never returns any other type of error.
| * | keymgr: Move Unrecognized errors out of KeyPathError (fmt)Gabriela Moldovan2026-01-061-3/+3
| | |
| * | keymgr: Move Unrecognized errors out of KeyPathErrorGabriela Moldovan2026-01-066-20/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Out of all the variants in `KeyPathError`, `Unrecognized` is the odd one out, because unlike the others, which are mainly just lower level parsing errors, `Unrecognized` is a higher level error constructed in `KeyMgr::describe()`. `KeyMgr::describe()` now returns an `Option`, because * the failure to describe a user provided `KeyPath` may or may not be an error * previously, `describe()` would only ever return `Ok` or `Err(KeyPathError::Unrecognized)`, which essentially a binary result. Also, `describe()` would never return any of the other `KeyPathError` kinds, which further suggests `Unrecognized` doesn't belong there The `Unrecognized` variant still exists, but is now part of `KeystoreCorruptionError`, (returned from `KeyMgr::validate_entry_integrity()`).
| * | keymgr: Fix clippy warning when KeySpecifier is used in tor-keymgrGabriela Moldovan2026-01-061-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | If you try to use this macro within `tor-keymgr` (as we do in the tests), clippy complains about the unreachable catch-all branch for `KeyPath`s (we can't get rid of the catch-all, because outside of `tor-keymgr` KeyPath` is non-exhaustive; but we should probably just go ahead and make `KeyPath` exhaustive at this point, because it's very unlikely it will ever grow new variants).
| * | proto: Use describe() unconditionally in validate_entry_integrity()Gabriela Moldovan2026-01-061-12/+5
| | | | | | | | | | | | | | | `KeyMgr::describe()` now works for `CTorPath`s too, so the key path validation can be the same as for `ArtiPath`s.
| * | keymgr: Update expected output in integration testsGabriela Moldovan2026-01-061-6/+6
| | | | | | | | | | | | | | | C Tor keystore entries now use the same output format as the non-C Tor entries.
| * | keymgr: Update test d-d macro with new ctor_path functionsGabriela Moldovan2026-01-061-17/+24
| | |
| * | arti: Remove no-longer needed helper functionGabriela Moldovan2026-01-061-23/+18
| | | | | | | | | | | | This folds `display_arti_entry()` into `display_entry()`.
| * | arti: Remove special handling for C Tor keys (fmt)Gabriela Moldovan2026-01-061-4/+1
| | |
| * | arti: Remove special handling for C Tor keysGabriela Moldovan2026-01-061-40/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is no longer needed now that `KeyMgr::describe()` works on `CTorPath`s. Removing this special handling has the added bonus that the keymgr CLI output is now uniform for all keystores (before this change, `keys list` used a slightly different output format for displaying C Tor entries). The corresponding tests will be updated in a future commit.
| * | keymgr: Specify ctor conversion functions as moduleGabriela Moldovan2026-01-063-71/+78
| | | | | | | | | | | | | | | | | | | | | This is similar to `#[serde(with = "...")]`, and feels a bit nicer than having to specify two separate functions for the conversions (because with two separate functions, you *can* technically only specify one of them, which shouldn't be allowed).
| * | keymgr: Extend KeySpecifier macro to support CTorPath conversionsGabriela Moldovan2026-01-063-5/+78
| | | | | | | | | | | | | | | This enables us to implement `KeyMgr::describe()`, which relies on the ability to extract the key specifier of the key from its `KeyPath`.
| * | keymgr: Make parse_key_path() only parse ArtiPathsGabriela Moldovan2026-01-061-18/+23
|/ / | | | | | | | | | | Unlike `ArtiPath`s, C Tor paths don't need to be parsed, because we have a predefined list of allowed C Tor paths (`CTorPath` is an enum with variants for each supported key type).
* | Merge branch 'authcert' into 'main'Ian Jackson2026-01-0612-478/+391
|\ \ | | | | | | | | | | | | tor-netdoc: Replace AuthCert with the version from tmp See merge request tpo/core/arti!3555
| * | tor-netdoc: authcert: Fix wrong linkIan Jackson2026-01-061-1/+1
| | |
| * | tor-netdoc: authcert: Add TODO about constructorsIan Jackson2026-01-061-0/+2
| | |
| * | tor-netdoc: authcert: rustfmtIan Jackson2026-01-061-5/+5
| | |
| * | tor-netdoc: authcert: Delete syntax info from rustdocsIan Jackson2026-01-061-37/+2
| | | | | | | | | | | | | | | This is in the spec. I don't think it is a great idea to duplicate it here.