aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | | tor-netdoc: use TryFrom impl in RelayWeight parserIan Jackson2026-05-271-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This makes the error handling a bit more regular. It will also make the code suit our further parsing changes better.
| * | | | | tor-netdoc: impl TryFrom<&NetParams<u32>> for RelayWeightIan Jackson2026-05-272-1/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Convert the from_net_params constructor into a TryFrom. Retain the bespoke method for the benefit of the old parser.
| * | | | | tor-netdoc: Unknown: provide into_retained even when retained disabledIan Jackson2026-05-272-1/+2
| | | | | |
| * | | | | tor-netdoc: impl encoding and parsing for NetParams<T>Ian Jackson2026-05-272-3/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Not just NetParams<i32>. We're going to want it for NetParams<u32> in a moment.
| * | | | | tor-netdoc: NetdocParseableFields: Pass ItemStream to finishIan Jackson2026-05-275-8/+24
| | | | | |
| * | | | | tor-netdoc: implement encoding for rs::SoftwareVersionIan Jackson2026-05-272-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | Call the existing string encoding code.
| * | | | | tor-netdoc: implement encoding for IgnoredPublicationTimeSpIan Jackson2026-05-272-0/+8
| | |/ / / | |/| | | | | | | | | | | | | | | | | | This seems trivial enough I don't feel the need to mark it "incomplete" even though there is no test case.
* | | | | Merge branch 'rd-or-address-sa' into 'main'Clara Engler2026-05-272-10/+9
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | tor-netdoc: Store or-address in a SocketAddr See merge request tpo/core/arti!4010
| * | | | | tor-netdoc: Spec link for RouterDesc::or_addressClara Engler2026-05-271-2/+1
| | | | | |
| * | | | | tor-netdoc: Store or-address in a SocketAddrClara Engler2026-05-272-8/+8
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit changes the data type of RouterDesc::or_address from Option<(net::IPv6Addr, u16)> to Vec<net::SocketAddr>. This is the correct behavior according to the spec, meaning I will not give a lengthy explanation on why this is better. Reviewers might now be questioning whether the spec is wrong and/or if this is a dangerous change, as Arti used to only extract the first IPv6 address and CTor doing a similar thing. Following an IRC discussion with nickm@, we came to the conclusion that both implementation techniques are right. It is okay for the document to hold multiple addresses, it is okay for the implementation to ignore all but the first (IPv6 address). What is not okay however, is for an implementation to reject documents with multiple addresses. Besides, router descriptors are not used in the existing code for selecting the address of a relay, meaning this change has very little practical meaning.
* | | | | Merge branch 'eq-certifiedkey' into 'main'Ian Jackson2026-05-271-2/+2
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | tor-cert: Derive Eq on CertifiedKey See merge request tpo/core/arti!4021
| * | | | tor-cert: Derive Eq on CertifiedKeyClara Engler2026-05-261-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit derives PartialEq and Eq on CertifiedKey and UnrecognizedKey in tor-cert. We will need this later for ntor cross certificates in tor-netdoc.
* | | | | Merge branch 'ns-parts' into 'main'Ian Jackson2026-05-2718-142/+422
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | tor-netdoc: Sort out most remaining structural parts of network status See merge request tpo/core/arti!3985
| * | | | | tor-netdoc: Restore one-line formatting of use lineIan Jackson2026-05-271-5/+1
| | | | | | | | | | | | | | | | | | | | | | | | I unwrapped this for conflict resolution.
| * | | | | tor-netdoc: Properly replace parse2::lex::NoFurtherArgumentsIan Jackson2026-05-273-18/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As pointed out in https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/3985#note_3413185 this was a duplicate. The new NoFurtherArguments * Implements encoding * Implements more traits * Is in the right module (types::misc - it's not just for parsing) * Has a slightly better name * Had an open-coded parsing impl (which we now replace) * Had minor differences to docs (so we add a line to NoFurtherArguments)
| * | | | | tor-netdoc: Remove duplicate semver entryIan Jackson2026-05-271-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/3985#note_3413184
| * | | | | tor-netdoc: Add some TODOsIan Jackson2026-05-271-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/3985#note_3413183
| * | | | | tor-netdoc: Rename FixedString to ConstantStringIan Jackson2026-05-275-34/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/3985#note_3413182 I left the word "fixed" in some of the docs and error messages, where it seemed to make sense.
| * | | | | tor-netdoc: Apply deferred rustfmt import churnIan Jackson2026-05-272-3/+5
| | | | | |
| * | | | | tor-netdoc: introduce VoteStatusConsensus and VoteStatusVoteIan Jackson2026-05-273-36/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Replacing poc's. The new define_fixed_string macro is really helping here.
| * | | | | tor-netdoc: NetworkStatusVersionItem, replacing poc's tupleIan Jackson2026-05-273-7/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Defining a struct gives us a place to hang the documentation, and avoids an accidentally-exhaustive tuple.
| * | | | | tor-netdoc: VarietyKeyword, replacing poc's flavour typeIan Jackson2026-05-274-27/+76
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is more code than the poc version but much of the extra is documentation, and it seems much less magical this way. We still need a handwritten parser for plain consensuses, sadly.
| * | | | | tor-netdoc: Promote/adjust poc's NetworkStatusSignaturesIan Jackson2026-05-272-10/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The order of arguments of poc's ns_type macro is different to that of the real code. This is very confusing! However, the type is correct, once we've added the singleton signature for votes.
| * | | | | tor-netdoc: Provide NoMoreArguments markerIan Jackson2026-05-273-2/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We're going to need this for type-driven parsing of the necessarily-absent flavour argument in a vote's `network-status-version`.
| * | | | | tor-netdoc: use DirectorySignaturesHashesAccu in SignatureGroupIan Jackson2026-05-274-9/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This will let us (re)use the existing signature checking code with the parse2 type, since we'll be able to make a SignatureGroup out of a parse2'd UnverifiedNetworkStatus.
| * | | | | tor-netdoc: Make fields of DirectorySignaturesHashesAccu publicIan Jackson2026-05-272-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This will allow it to be a replacement inside `SignatureHashes`. Keeping the fields private seems to have been an oversight.
| * | | | | tor-netdoc: SignatureGroup: add some notes to the docsIan Jackson2026-05-271-0/+4
| | | | | |
| * | | | | tor-netdoc: Replace poc's NddDirectoryFooter with new FooterIan Jackson2026-05-274-10/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is the whole of the footer section, with docs, appropriate derives, and so on.
| * | | | | tor-netdoc: ConsensusFooterFields: Constructor, parse, encodeIan Jackson2026-05-273-3/+14
| | | | | |
| * | | | | tor-netdoc: ConsensusFooterFields: Tidy docsIan Jackson2026-05-271-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add links to the spec, and delete explanatory text (that ought to be in the spec, not here).
| * | | | | tor-netdoc: ConsensusFooterFields: Rename weights field to bandwidth_weightsIan Jackson2026-05-274-6/+7
| | | | | | | | | | | | | | | | | | | | | | | | This matches the spec.
| * | | | | tor-netdoc: Rename Footer to ConsensusFooterFieldsIan Jackson2026-05-275-11/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This will allow us to include this, conditionally, in the new per-variety footer types for consensuses, without too much disruption to the existing code. We don't leave a compatibility alias because we're going to want a Footer in each_variety.rs which is the actual sub-document. This old struct isn't suitable because it doesn't have the intro item and is just for consensuses.
| * | | | | tor-netdoc: NetworkStatusVersion, replacing poc's with FixedStringIan Jackson2026-05-273-11/+15
| | | | | |
| * | | | | tor-netdoc: Provide FixedString and defined_fixed_stringIan Jackson2026-05-273-1/+146
| | | | | | | | | | | | | | | | | | | | | | | | We're going to want quite a lot of this for eg network-status-version.
* | | | | | Merge branch 'client_typestate' into 'main'Nick Mathewson2026-05-277-230/+482
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Client: Refactor most managers into a typestate, and construct it on bootstrap. See merge request tpo/core/arti!4011
| * | | | | | Apply 2 suggestion(s) to 1 file(s)Nick Mathewson2026-05-271-2/+2
| | | | | | | | | | | | | | | | | | | | | Co-authored-by: gabi-250 <[email protected]>
| * | | | | | client: Have launch_onion_service instantiate RunningInner as needed.Nick Mathewson2026-05-261-4/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Otherwise we either lose the property that you can call launch_onion_service before bootstrapping has begun, or we have to make launch_onion_service async.
| * | | | | | client: RunningInner::reconfigure: refactor running → selfNick Mathewson2026-05-262-43/+81
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (This is a separate commit in order make the code movement in the previous commit clearer.)
| * | | | | | client: Move dirmgr_store back into ClientShared.Nick Mathewson2026-05-261-9/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This will ensure that the TorClient takes its file locks immediately on construction.
| * | | | | | client: Fold wait_for_bootstrap{,_running} into a single method.Nick Mathewson2026-05-261-20/+14
| | | | | | |
| * | | | | | client: change remaining wait_for_bootstrap user.Nick Mathewson2026-05-261-5/+6
| | | | | | |
| * | | | | | client: Defer creation of most structures until bootstrap.Nick Mathewson2026-05-262-127/+226
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This will let us be more confident in the inertness of a not-bootstrapping TorClient, _and_ make it easier to reconfigure things before the client is started.
| * | | | | | client: Rename create_inner to create_implNick Mathewson2026-05-262-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now that we have a type called "inner", and will soon have a function to create it, we really don't want to retain this name.
| * | | | | | client: move bootstrap lock to the head of bootstrap_inner.Nick Mathewson2026-05-261-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We want this look to cover the whole function, to avoid weird duplicate behavior while creating our bridge desc manager.
| * | | | | | client: Factor out the "running a client" code into an inner typestateNick Mathewson2026-05-265-91/+186
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We'll use this to distinguish "not running" from "running", in order to make it easier to be sure that non-bootstrapping clients will definitely not try to connect to the network.
| * | | | | | client: rename ClientInner → ClientShared.Nick Mathewson2026-05-261-5/+5
| | | | | | |
* | | | | | | Merge branch 'rpc_config_part1_v3' into 'main'Nick Mathewson2026-05-2716-65/+365
|\ \ \ \ \ \ \ | |_|/ / / / / |/| | | | | | | | | | | | | | | | | | | | Implement configuration backend logic for RPC See merge request tpo/core/arti!4001
| * | | | | | config: Simplify ConfigurationTree::merge_from to take &mut self.Nick Mathewson2026-05-272-8/+9
| | | | | | |
| * | | | | | Apply 3 suggestion(s) to 2 file(s)Nick Mathewson2026-05-272-3/+3
| | | | | | | | | | | | | | | | | | | | | Co-authored-by: gabi-250 <[email protected]>
| * | | | | | config: Update doctests to use Deftly, and to passNick Mathewson2026-05-273-16/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some of the tests used derive(Builder), which is not current practice for our configuration. Additionally, they didn't implement the requisite ConfigBuilder logic to pass with the other changes in this branch.
generated by cgit v1.2.3 (git 2.46.0) at 2026-08-27 11:29:52 +0000