aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | arti-dirauth: FilenameOrStdio: Rename p to mainIan Jackson2026-07-301-3/+3
| | | | | | | | | | | | | | | | | | | | This is a better name, and will suit us better when we reorganise this code to allow incremental writing.
| * | | arti-dirauth: FilenameOrStdio: promote comment about .tmp cleanupIan Jackson2026-07-301-9/+12
| | | | | | | | | | | | | | | | | | | | | | | | Make this a doc comment. We're going to add an entrypoint that makes this more likely.
* | | | Merge branch 'cc-rate-fix' into 'main'Ian Jackson2026-08-031-0/+2
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | tor-cell: Add missing semver.md entries See merge request tpo/core/arti!4257
| * | | | tor-cell: add missing semver.md entriesSteven Engler2026-07-301-0/+2
| | | | | | | | | | | | | | | | | | | | I forgot to add these during a previous MR.
* | | | | Merge branch 'test-support-more' into 'main'Clara Engler2026-08-035-71/+74
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | tor-netdoc: testing: Expose some more test utilities See merge request tpo/core/arti!4250
| * | | | tor-netdoc: testing: Expose regsubIan Jackson2026-07-304-10/+16
| | | | | | | | | | | | | | | | | | | | Involves code motion. Review with --color-moved.
| * | | | tor-netdoc: testing: Expose assert_eq_or_diff (fmt)Ian Jackson2026-07-301-7/+1
| | | | | | | | | | | | | | | | | | | | I don't understand why this suddenly, but whatever.
| * | | | tor-netdoc: testing: Expose assert_eq_or_diffIan Jackson2026-07-304-61/+65
| | | | | | | | | | | | | | | | | | | | Involves lots of code motion. Review with --color-moved.
| * | | | tor-netdoc: testing: Remove a spurious cfgIan Jackson2026-07-301-1/+0
| | | | | | | | | | | | | | | | | | | | This whole module is gated by the very same condition.
| * | | | tor-netdoc: testing: Actually expose the test_support moduleIan Jackson2026-07-301-1/+1
| |/ / / | | | | | | | | | | | | I discovered this didn't work, when I tried to use it.
* | | | Merge branch 'cc-kbps-fix' into 'main'opara2026-07-3013-65/+68
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | | | | | | | | | tor-cell,tor-proto: Fix XON conversion from KB/s to B/s Closes #2650 See merge request tpo/core/arti!4255
| * | | tor-proto: fix XON conversion from KB/s to B/sSteven Engler2026-07-301-4/+4
| | | | | | | | | | | | | | | | | | | | We previously interpreted the rate in the XON message as being Kbits per second, but it's really Kbytes per second.
| * | | tor-cell: update docs and variable names for `Xon`Steven Engler2026-07-303-13/+16
| | | |
| * | | tor-cell: update docs and variable names for `XonKBpsEwma`Steven Engler2026-07-301-9/+9
| | | |
| * | | tor-cell: rename `XonKbpsEwma` to `XonKBpsEwma`Steven Engler2026-07-3013-44/+44
|/ / /
* | | Merge branch 'mock-net' into 'main'David Goulet2026-07-302-31/+69
|\ \ \ | | | | | | | | | | | | | | | | tor-proto: Small improvements to circuit handshake tests See merge request tpo/core/arti!4254
| * | | tor-proto: reuse existing channels in ntor testSteven Engler2026-07-301-8/+5
| | | | | | | | | | | | | | | | | | | | Now that we read all of the cells from the connection inspector, we can reuse the existing channel objects.
| * | | tor-proto: extend circ handshake tests to close the circuitSteven Engler2026-07-302-2/+38
| | | |
| * | | tor-proto: rename some methods on test `ConnInspector`Steven Engler2026-07-302-10/+10
| | | |
| * | | tor-proto: reword some TODOsSteven Engler2026-07-301-2/+2
| | | | | | | | | | | | | | | | These TODOs are for client issues, not relay isues.
| * | | tor-proto: don't drop stream rx in testsSteven Engler2026-07-302-10/+15
| | | | | | | | | | | | | | | | Otherwise the new circuit gets closed immediately by the relay.
* | | | Merge branch 'create-fast' into 'main'opara2026-07-305-37/+160
|\ \ \ \ | |/ / / |/| | | | | | | | | | | tor-protover,tor-proto: Add and use a new `subprotocol_restricted_set` macro See merge request tpo/core/arti!4241
| * | | tor-protover: set field visibility in `subprotocol_restricted_set`Steven Engler2026-07-301-5/+5
| | | |
| * | | tor-proto: use `subprotocol_restricted_set` macroSteven Engler2026-07-303-37/+19
| | | |
| * | | tor-protover: add a `subprotocol_restricted_set` macroSteven Engler2026-07-302-0/+135
| | | |
| * | | tor-protover: add `From<NamedSubver> for Protocols`Steven Engler2026-07-271-0/+6
| | | |
* | | | Merge branch 'uploader-arc' into 'main'opara2026-07-304-18/+21
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | tor-dirpublish: Change `Uploader::upload()` to not require `Arc<Self>` See merge request tpo/core/arti!4243
| * | | | tor-dirpublish: change `Uploader::upload()` to not require `Arc`Steven Engler2026-07-304-18/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I was a bit confused as to why `Uploader::upload()` required an `Arc<Self>`, and after looking at the code it appears that this `Arc` isn't needed anywhere outside of the `PublishReactor`. Instead `Uploader::upload()` now takes a `&self` instead of `Arc<Self>`.
* | | | | Merge branch 'verify-fix' into 'main'Clara Engler2026-07-301-7/+12
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Important pre-release fixes for RouterDescUnverified::verify() See merge request tpo/core/arti!4252
| * | | | | tor-netdoc: Mark RouterDescUnverified::verify() incompleteClara Engler2026-07-301-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | Better do it before the release so we can think about it a bit more.
| * | | | | tor-netdoc: Properly obtain min/max for start and end timeClara Engler2026-07-301-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We need to obtain the maximum of the lower bound and the minimum of the upper bound instead of vice versa. Another example on why we should replace this with a better implementation. Likewise, `expiry` in the legacy verification code is also obtained like that.
| * | | | | tor-netdoc: Rename min/max to start and end timeClara Engler2026-07-301-5/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This makes it more clear, besides it will sound more "correct" with the next commit applied.
* | | | | | Merge branch 'testdata-typo' into 'main'Ian Jackson2026-07-302-3/+3
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | tor-netdoc: Fix typo in testdata-live-download and RELAY_* constants See merge request tpo/core/arti!4249
| * | | | | | tor-netdoc: Fix typo in testdata-live-download and RELAY_* constantsIan Jackson2026-07-302-3/+3
| | |_|_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | I still had the previously downloaded full consensus locally, so running testdata-live-download fixed the Rust file.
* | | | | | Merge branch 'mock-net' into 'main'David Goulet2026-07-305-0/+476
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | | | | | | | | | | | | | tor-proto: Add some unit tests for circuit handshakes See merge request tpo/core/arti!4248
| * | | | | tor-proto: add unit tests for some circuit handshakesSteven Engler2026-07-291-0/+130
| | | | | |
| * | | | | tor-proto: add 'test_utils' mod for channel testsSteven Engler2026-07-292-0/+308
| | | | | | | | | | | | | | | | | | | | | | | | These help to establish connected channel objects to be used for tests.
| * | | | | tor-proto: add test-only `NoOpChannelProvider`Steven Engler2026-07-291-0/+22
| | | | | |
| * | | | | tor-proto: add test-only `NoOpRequestFilter`Steven Engler2026-07-291-0/+16
| | | | | |
* | | | | | Merge branch 'rd-verify' into 'main'Clara Engler2026-07-304-8/+359
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | | | | | | | | | | | | Add RouterDescUnverified::verify() See merge request tpo/core/arti!4144
| * | | | | tor-netdoc: Add various TODO follow-upsClara Engler2026-07-302-3/+8
| | | | | |
| * | | | | tor-netdoc: Make RouterDescUnverified::verify() publicClara Engler2026-07-302-2/+2
| | | | | |
| * | | | | tor-netdoc: Run cargo-fmtClara Engler2026-07-301-3/+13
| | | | | |
| * | | | | tor-netdoc: Allow dead_code for RouterDesc::verifyClara Engler2026-07-301-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | Otherwise clippy complains.
| * | | | | tor-netdoc: Add large RouterDesc verification testClara Engler2026-07-301-1/+169
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit adds a comprehensive test for router descriptor verification that tests various valid and invalid edge cases.
| * | | | | tor-netdoc: Enable cvt-x25519 for llcryptoClara Engler2026-07-301-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Required for convert_curve25519_to_ed25519_private().
| * | | | | tor-netdoc: Add test only rd_encode_sign() methodClara Engler2026-07-301-0/+46
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a bad encode_sign() method for RouterDesc that is testing only and will be used soon to implement testing for invalid router descriptors, for which we may need to create invalid ones in the first place.
| * | | | | tor-netdoc: Call .verify() in test_parse2_simpleClara Engler2026-07-301-1/+8
| | | | | |
| * | | | | tor-netdoc: Add RouterDescUnverified::verify()Clara Engler2026-07-301-5/+118
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit implements verification for router descriptors. 🎉 For this, the following checks are performed: * RouterDesc::identity_ed25519 is validly signed. * RouterDesc::master_key_ed25519 is as implied by identity_ed25519. * RouterDesc::fingerprint is as implied by RouterDesc::signing_key. * RouterDesc::ntor_onion_key_crosscert is validly signed. * RouterDesc::signing_key has correct length and exponent. * All RouterDesc::family_cert elements are valid. * The inner and outer RouterDescSignatures are valid. Unfortunately, we now have two implementations for that, as the legacy parse_internal() also implements its own verification logic for this. It seems merging these two together however would probably cause more harm than good, as the legacy verification is closely intertwined with legacy parsing, making a commonly shared verification logic hard to achieve. In other words: parse2 parses the descriptor in its entirety first, followed by verification afterwards, whereas the legacy code parses and verifies every field before advancing towards the next. Instead, I suggest to read through RouterDesc::parse_internal() and ensure that every verification related check present there is also present here. The notable exception to this is everything TAP related, which is absent on purpose here. Right now, this code is untested. I will add unit tests shortly afterwards.
| * | | | | tor-netdoc: Derive Copy for Ed25519PublicClara Engler2026-07-292-1/+2
| |/ / / / | | | | | | | | | | | | | | | The underlying type also implements Copy. We will need it later.