mirrors/arti.git - mirror of https://gitlab.torproject.org/tpo/core/arti

	Commit message (Collapse)	Author	Age	Files	Lines
...
\| * \| \| \| \| \| \| \|	tor-netdoc: tests: Move poc authcert test to authcert.rs	Ian Jackson	2026-06-17	2	-16/+18
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	There is no separate poc authcert type any more. This is a perfectly fine test case. Almost entirely code motion; review with git show --color-moved --color-moved-ws=allow-indentation-change
\| * \| \| \| \| \| \| \|	tor-netdoc: poc tests: drop some unneeded &'s	Ian Jackson	2026-06-17	1	-3/+3
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	clippy complains (clippy::needless_borrows_for_generic_args). In poc, we have an allow with a TODO asking for this to be done generally in the Arti codebase. Let's postpone shaving that yak.
\| * \| \| \| \| \| \| \|	tor-netdoc: poc tests: use normal names for authcerts	Ian Jackson	2026-06-17	1	-6/+4
\| \| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \| \|	tor-netdoc: poc tests: simulate normal outside-poc variety module names	Ian Jackson	2026-06-17	1	-2/+4
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	We are going to reuse/move this test code. Ie, it is going to be testing the real network document types. The naming outside poc is different. To make future diffs a bit less noisy, change some type names in the test code and fudge it up with a use.
\| * \| \| \| \| \| \| \|	tor-netdoc: un-cfg-gate some use's	Ian Jackson	2026-06-17	1	-5/+2
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	We have the #1645 allow at the top of lib.rs, so this is unnecessary bureaucracy. Let's simplify this before adding more to it.
\| * \| \| \| \| \| \| \|	tor-netdoc: provide verify methods on new consensus types (fmt)	Ian Jackson	2026-06-17	1	-3/+2
\| \| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \| \|	tor-netdoc: provide verify methods on new consensus types	Ian Jackson	2026-06-17	2	-2/+116
\| \| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \| \|	tor-netdoc: Break out consensus_threshold fn	Ian Jackson	2026-06-17	2	-3/+31
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This calculation appeared 3 times.
\| * \| \| \| \| \| \| \|	tor-netdoc: NetworkStatus: derive Encode	Ian Jackson	2026-06-17	1	-1/+1
\| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \|	Merge branch 'sp-fingerprint-encode' into 'main'	Clara Engler	2026-06-17	2	-5/+32
\|\ \ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Encode for SpFingerprint See merge request tpo/core/arti!4116
\| * \| \| \| \| \| \| \| \|	tor-netdoc: Round-trip test SpFingerprint encoding	Clara Engler	2026-06-17	1	-1/+12
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This commit adds a round-trip encoding for SpFingerprint to the already existing parsing test.
\| * \| \| \| \| \| \| \| \|	tor-netdoc: Small SpFingerprint test refactoring	Clara Engler	2026-06-17	1	-4/+4
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Do not shadow s and provide access to Wrapper instead of just the inner fingerprint. We will make use of this soon.
\| * \| \| \| \| \| \| \| \|	tor-netdoc: Encode for SpFingerprint	Clara Engler	2026-06-17	2	-0/+16
\| \|/ / / / / / / / \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Implements encode::ItemArgument for SpFignerprint. A test will be added in the next commit.
* \| \| \| \| \| \| \| \|	Merge branch 'ntor-cc-rd' into 'main'	Ian Jackson	2026-06-17	3	-7/+25
\|\ \ \ \ \ \ \ \ \ \| \|/ / / / / / / / \|/\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Add ntor onion key cross certificate to RouterDesc See merge request tpo/core/arti!4109
\| * \| \| \| \| \| \| \|	tor-netdoc: Create NtorOnionKeyCrossCert at better place	Clara Engler	2026-06-17	1	-9/+9
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This commit moves the construction place for the NtorOnionKeyCrossCert from the final RouterDesc construction to the crosscert code block, which should be more correct.
\| * \| \| \| \| \| \| \|	tor-netdoc: Add ntor_onion_key_crosscert to RouterDesc	Clara Engler	2026-06-15	2	-0/+13
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This commit adds ntor_onion_key_crosscert to RouterDesc as well as integrating it into the legacy parser.
\| * \| \| \| \| \| \| \|	tor-netdoc: Extract ntor bit and cert in legacy parser (fmt)	Clara Engler	2026-06-15	1	-3/+6
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	No functional change.
\| * \| \| \| \| \| \| \|	tor-netdoc: Extract ntor bit and cert in legacy parser	Clara Engler	2026-06-15	1	-3/+3
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	We will soon need it for the ntor cross certificate.
\| * \| \| \| \| \| \| \|	tor-netdoc: Make dangerous_new_unverified available outside tests	Clara Engler	2026-06-15	1	-2/+4
\| \| \|_\|_\|_\|/ / / \| \|/\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	We will need it for compatibility with the legacy parser soon. Not super nice.
* \| \| \| \| \| \| \|	Merge branch 'trivial-encode-derive' into 'main'	Clara Engler	2026-06-17	2	-3/+6
\|\ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Trivial ItemValueEncodable dervies See merge request tpo/core/arti!4115
\| * \| \| \| \| \| \| \|	tor-netdoc: ItemValueEncodable for ExtraInfoDigests	Clara Engler	2026-06-17	2	-1/+2
\| \| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \| \|	tor-netdoc: ItemValueEncodable for RouterDescIntroItem	Clara Engler	2026-06-17	2	-1/+2
\| \| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \| \|	tor-netdoc: ItemValueEncodable for OverloadGeneral	Clara Engler	2026-06-17	2	-1/+2
\|/ / / / / / / /
* \| \| \| \| \| \| \|	Merge branch 'display-range' into 'main'	Clara Engler	2026-06-17	2	-24/+61
\|\ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	tor-netdoc: port policies: Encode with reject if it's shorter See merge request tpo/core/arti!4108
\| * \| \| \| \| \| \| \|	tor-netdoc: placate clippy	Ian Jackson	2026-06-16	1	-1/+1
\| \| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \| \|	tor-netdoc: port policies: Encode with reject if it's shorter	Ian Jackson	2026-06-15	1	-9/+16
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	When trying to repro a live consensus, I discovered that `reject 25` turned into `accept 1-24,26-65535`.
\| * \| \| \| \| \| \| \|	tor-netdoc: port policies: tests: reformat	Ian Jackson	2026-06-15	1	-2/+14
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Use // to force rustdoc to multi-line layout. That makes the layout uniform across all these test cases, and will make the next commit clearer.
\| * \| \| \| \| \| \| \|	tor-netdoc: port policies: Provide .inverted	Ian Jackson	2026-06-15	1	-3/+10
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	We'll want this in a moment, not just invert in place. I was tempted to remove the mutating form, but there are at least two call sites.
\| * \| \| \| \| \| \| \|	tor-netdoc: port policies: Simplify display with iter_join	Ian Jackson	2026-06-15	1	-6/+2
\| \| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \| \|	tor-netdoc: port policies: Declare iter return value as Clone	Ian Jackson	2026-06-15	1	-1/+1
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	It's Copy, in fact. But Copy iterators are a hazard.
\| * \| \| \| \| \| \| \|	tor-netdoc: port policies: Provide display method on PortRanges	Ian Jackson	2026-06-15	2	-11/+26
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	We're going to want this for a more clever formatting algorithm.
* \| \| \| \| \| \| \| \|	Merge branch 'ahf/fix-wasm-build' into 'main'	David Goulet	2026-06-16	1	-1/+1
\|\ \ \ \ \ \ \ \ \ \| \|_\|_\|_\|_\|_\|/ / / \|/\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Use wasm_js for getrandom in tor-bytes. See merge request tpo/core/arti!4119
\| * \| \| \| \| \| \| \|	Use wasm_js for getrandom in tor-bytes.	Alexander Hansen Færøy	2026-06-16	1	-1/+1
\|/ / / / / / / /
* \| \| \| \| \| \| \|	Merge branch 'relay-platform-encode' into 'main'	Ian Jackson	2026-06-16	2	-4/+21
\|\ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Encoding for RelayPlatform See merge request tpo/core/arti!4114
\| * \| \| \| \| \| \| \|	tor-netdoc: Add ItemValueEncodable for RelayPlatform	Clara Engler	2026-06-16	2	-0/+14
\| \| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \| \|	tor-netdoc: Implement ItemValueParseable instead for RelayPlatform	Clara Engler	2026-06-16	2	-4/+7
\| \| \|_\|_\|_\|/ / / \| \|/\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	ItemArgumentParseable does not make much sense because the field is effectively a free-form field similar to ContactInfo.
* \| \| \| \| \| \| \|	Merge branch 'edcert-papercuts' into 'main'	Ian Jackson	2026-06-16	1	-38/+8
\|\ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Fix small edcert papercuts See merge request tpo/core/arti!4112
\| * \| \| \| \| \| \| \|	tor-netdoc: Remove unequal key check from edcerts	Clara Engler	2026-06-16	1	-16/+4
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	As a follow up to !4022 and discussed on IRC: > Since we don't think we need to check the keys are different I think > it's OK to delete the thing in the tests that insists we have such a > check. > [...] > We are the relying party here. That MUST is directed to the signing > party. As reliers we don't need to check it.
\| * \| \| \| \| \| \| \|	tor-netdoc: Merge edcert tests together	Clara Engler	2026-06-16	1	-22/+4
\| \|/ / / / / / / \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Fixes a TODO as discussed in !4022. Review with --color-moved.
* \| \| \| \| \| \| \|	Merge branch 'reconfig-check' into 'main'	David Goulet	2026-06-16	1	-15/+42
\|\ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	arti-client: Warn if `reconfigure()` possibly left the client in an inconsistent state See merge request tpo/core/arti!4101
\| * \| \| \| \| \| \| \|	arti-client: warn if reconfig left client in inconsistent state	Steven Engler	2026-06-11	1	-15/+42
\| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \|	Merge branch 'flowctrl-tests' into 'main'	opara	2026-06-16	3	-15/+435
\|\ \ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	tor-proto: Add unit test for `XonXoffReader` See merge request tpo/core/arti!4093
\| * \| \| \| \| \| \| \| \|	tor-proto: add a unit test for `XonXoffReader`	Steven Engler	2026-06-16	2	-1/+399
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	The 'futures' version bump is needed so that our test can use `UnboundedSender::try_recv()` in the minimal-versions CI test.
\| * \| \| \| \| \| \| \| \|	tor-proto: add `DrainRateNotifier` trait for `XonXoffReader`	Steven Engler	2026-06-10	1	-13/+35
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This will allow us to add a unit test for `XonXoffReader`.
\| * \| \| \| \| \| \| \| \|	tor-cell: impl `PartialEq + Eq` on `XonKbpsEwma`	Steven Engler	2026-06-10	1	-1/+1
\| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \|	Merge branch 'bump-chutney-2026-06' into 'main'	Jim Newsome	2026-06-16	2	-5/+11
\|\ \ \ \ \ \ \ \ \ \ \| \|_\|_\|/ / / / / / / \|/\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Bump chutney and add additional middle nodes to chutney test net Closes #2463 See merge request tpo/core/arti!4111
\| * \| \| \| \| \| \| \| \|	chutney test network: add 4 suitable middle/guard/vg relays	Jim Newsome	2026-06-15	1	-3/+9
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	With the chutney bump in the previous commit alone, we hit arti#2463 consistently. According to the spec, a hidden service using vanguards-lite needs 2 guards and 4 vanguards <https://spec.torproject.org/vanguards-spec/index.html>. All 6 of those relays need to be Fast and Stable. At least the 2 guards also need to be Measured. (Probably the 4 vanguards too, but I haven't verified). authority relays are never considered Measured. Prior to the chutney bump, none of the relays were, but since chutney!142, we create a bandwidth file to ensure the non-authorities are Measured, and will get the Fast flag. (IIUC, tor doesn't apply the bandwidth measurements to authorities). Maybe the presence of some measured relays gets us out of some fallback path that was getting used before to allow unmeasured relays? Adding the additional relays seems to fix the issue.
\| * \| \| \| \| \| \| \| \|	Bump chutney to get Stable flag fix	Jim Newsome	2026-06-15	1	-2/+2
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This is primarily to get chutney!149. This should fix arti#2463, but I haven't been able to repro locally to verify. I suspect it'll mitigate some of the other difficult-to-repro cases of arti#2209 as well.
* \| \| \| \| \| \| \| \| \|	Merge branch 'fix-authcert' into 'main'	Clara Engler	2026-06-16	1	-1/+2
\|\ \ \ \ \ \ \ \ \ \ \| \|/ / / / / / / / / \|/\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	tor-netdoc: fix EncodedAuthCert parsing See merge request tpo/core/arti!4104
\| * \| \| \| \| \| \| \| \|	tor-netdoc: fix EncodedAuthCert parsing	Ian Jackson	2026-06-15	1	-1/+2
\| \| \|_\|/ / / / / / \| \|/\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	It would swallow the whole rest of the document, leading to bizarre output on re-encoding. There is no test case for this in-tree (which is why this is cfg "incomplete"), but I have a full roundtrip test of a vote (which contains an authcert) in a wip branch, which detected this problem.