| Commit message (Collapse) | Author | Age | Files | Lines |
| ... | |
| |\ \ \ \
| |/ / /
|/| | |
| | | |
| | | | |
Uncontroversial RouterDesc field additions
See merge request tpo/core/arti!4006
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
It is weird to have three possible states for truthiness here.
This commit removes the Option in favor of the inner type while adding a
TODO comment to somehow find a way to skip this during encoding.
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | | |
Adds a TODO for using ConstantString for overload_general.
|
| | | | |
| | | |
| | | |
| | | | |
This field is taken from the spec.
|
| | | | |
| | | |
| | | |
| | | | |
This commit adds the contact field to RouterDesc.
|
| | | | |
| | | |
| | | |
| | | | |
This commit adds support for the overload-general field to RouterDesc.
|
| |/ / / |
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
tor-netdoc Rename NetdocUnverified trait to NetdocParseableUnverified
See merge request tpo/core/arti!4043
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Apparently, it is only correct to write
[`NetdocParseableUnverified`](derive_deftly_template_NetdocParseableUnverified),
*after* the definition of that template. Before then, the macro isn't
in scope.
Worse, rustdoc just treats it as a filename and doesn't spot the link,
so you don't get any kind of warning. I think this is an upstream bug,
https://github.com/rust-lang/rust/issues/157304
I found rustdoc's behaviour capricious. I don't intend to go through
the arti tree right now looking for similar patterns. Instead let's
hope the upstream bug gets fixed, and in the meantime do this crate::
thing when we notice we need it.
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The NetdocParseableUnverified derive macro implements this
trait (amongst other things). Traits and derive macros should have
aligned names.
This is only used for parsing, so let's keep the "Parseable" part of
the name.
I don't think the effort of deprecated alias, for downstream
compatibility, is worth it, our compatibility policy notwithstanding.
|
| | |/ /
| | |
| | |
| | |
| | |
| | |
| | | |
The trait is called NetdocUnverified, but the template is
NetdocParseableUnverified. This fixes a dead docs link (which somehow
isn't spotted by rustdoc, but is instead taken to refer to a
nonexistent file).
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
Run routine cargo update
See merge request tpo/core/arti!4045
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Without this, the shadow integration tests fail because
`touch_instance_dir()` isn't able to set the mtime on the state dir:
```
Err(Error { source: IoError(Os { code: 14, kind: Uncategorized, message: "Bad address" }), action: Initializing, resource: Directory { dir: "./hss/tgen_hs" } })
```
I suspect switching to the stblib implementation of these functions in
https://github.com/alexcrichton/filetime/pull/121 is what broke things
for us.
The new implementation calls into rust's `set_times()` impl, which calls
the `utimensat64` libc function under the hood. I suspect the underlying
syscall used by this function is not supported by shadow.
|
| | |/ /
| | |
| | |
| | | |
Part of #2599
|
| |\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
proto: Fix inverted cert sig and AUTHENTICATE compare
Closes #2501 and #2502
See merge request tpo/core/arti!4048
|
| | | | |
| | | |
| | | |
| | | | |
Signed-off-by: David Goulet <[email protected]>
|
| |/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Missed at review and no unit tests at the time catched those. The next
commit has a unit tests to make sure these checks are now valid.
Fixes #2501
Fixes #2502
Special thanks to Moumen Alaoui for reporting this early!
Signed-off-by: David Goulet <[email protected]>
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
client: Reflect manually disabled bootstrap in status
See merge request tpo/core/arti!4047
|
| | |/ /
| | |
| | |
| | |
| | | |
If we have made bootstrapping manual, and not launched a bootstrap,
we now reflect this as the reason that bootstrapping is blocked.
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
tor-chanmgr: Add metrics.
See merge request tpo/core/arti!4018
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This fixes the minimal-versions test, since the new code in chanmgr sets
descriptions for the metrics, which is a feature not supported by the
previous version.
|
| |/ / /
| | |
| | |
| | |
| | |
| | | |
This adds a structure to initialize metrics when the `ChanMgr` is
created, and adds a counter for the total number of channels built,
broken down by success and failure.
|
| |\ \ \
| |/ /
|/| |
| | |
| | | |
tor-netdoc: Internal docs improvements
See merge request tpo/core/arti!4044
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
At some earlier point in the development of this scheme, the ordering
was different (as it is in poc).
Update all the references in the docs, to the various varieties, so
that they are always plain, md, vote, like ns_type! et al take.
|
| | | | |
|
| |/ /
| |
| |
| | |
We do now support encoding.
|
| |\ \
| | |
| | |
| | |
| | | |
proto: Fix typo in ResolveCmdChecker docs
See merge request tpo/core/arti!4035
|
| | | |
| | |
| | |
| | | |
This returns a boxed `ResolveCmdChecker`, not a `DataCmdChecker`.
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
Improvements for RelayPlatform
See merge request tpo/core/arti!4024
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | | |
No functional change, just rustfmt.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This commit changes RelayPlatform::TorVersion to store the platform to
an Option<String> instead of a String because storing a missing/not
present platform as the empty String feels wrong in my opinion.
Besides, we will soon need to add encoding for this type, making now a
good time to change it.
|
| |/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This refactors the RelayPlatform test to store the test vectors in an
array and iterate over it, comparing it with the expected output. This
is a lot better than the current version, where there is not just a lot
of copy and pasted code but also some tests that only check for an okay
value.
Unfortunately, there is not an easy way to review this with
--color-moved or something. Personally, I would recommend to review
each original test vector (i.e. a line starting with `let p =` followed
by a string literal) and verify that the exact same string literal is
still present within the new test vector. Afterwards, verifying the
assertion logic should be easy, as it is a one-liner.
|
| |\ \ \
| |_|/
|/| |
| | |
| | | |
NetDir::pick_relay: preemptively handle empty sequence
See merge request tpo/core/arti!4034
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The `choose_weighted` behavior given an empty sequence isn't well
documented and has changed over time. Handle it ourselves for
consistency.
Currently, the `choose_weighted` behavior appears to be to return
WeightError::InvalidInput. This means the corresponding `is_empty`
branch when handling WeightError::InsufficientNonZero was never
exercised. (Though may have been with previous versions of the rand
crate).
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
Remove semver.md files post-release
See merge request tpo/core/arti!4041
|
| |/ / / |
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
Version bumps for the 2.4.0 release
See merge request tpo/core/arti!4039
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Done using:
```
for crate in $(./maint/list-crates | rg '^(tor|arti-)'); do
cargo set-version -p $crate 0.43.0
done
```
|