aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | Merge branch 'rd-misc-fields' into 'main'Clara Engler2026-06-032-0/+36
|\ \ \ \ | |/ / / |/| | | | | | | | | | | Uncontroversial RouterDesc field additions See merge request tpo/core/arti!4006
| * | | tor-netdoc: Add TODO for eventdnsClara Engler2026-06-031-0/+1
| | | |
| * | | tor-netdoc: Change Option<NumericBoolean> to NumericBooleanClara Engler2026-06-031-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | It is weird to have three possible states for truthiness here. This commit removes the Option in favor of the inner type while adding a TODO comment to somehow find a way to skip this during encoding.
| * | | tor-netdoc: Replace some item docs with spec linksClara Engler2026-06-031-6/+3
| | | |
| * | | tor-netdoc: Add TODO for overload_generalClara Engler2026-06-031-0/+1
| | | | | | | | | | | | | | | | Adds a TODO for using ConstantString for overload_general.
| * | | tor-netdoc: Add extra_info_digest to RouterDescClara Engler2026-06-032-0/+9
| | | | | | | | | | | | | | | | This field is taken from the spec.
| * | | tor-netdoc: Add contact to RouterDescClara Engler2026-06-032-0/+9
| | | | | | | | | | | | | | | | This commit adds the contact field to RouterDesc.
| * | | tor-netdoc: Add overload_general to RouterDescClara Engler2026-06-032-0/+9
| | | | | | | | | | | | | | | | This commit adds support for the overload-general field to RouterDesc.
| * | | tor-netdoc: Add hibernating field to RouterDescClara Engler2026-06-032-0/+9
|/ / /
* | | Merge branch 'netdoc-unverified-trait-name' into 'main'Clara Engler2026-06-039-24/+25
|\ \ \ | | | | | | | | | | | | | | | | tor-netdoc Rename NetdocUnverified trait to NetdocParseableUnverified See merge request tpo/core/arti!4043
| * | | tor-netdoc: Add crate:: to docs xrefs to avoid broken linksIan Jackson2026-06-021-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Apparently, it is only correct to write [`NetdocParseableUnverified`](derive_deftly_template_NetdocParseableUnverified), *after* the definition of that template. Before then, the macro isn't in scope. Worse, rustdoc just treats it as a filename and doesn't spot the link, so you don't get any kind of warning. I think this is an upstream bug, https://github.com/rust-lang/rust/issues/157304 I found rustdoc's behaviour capricious. I don't intend to go through the arti tree right now looking for similar patterns. Instead let's hope the upstream bug gets fixed, and in the meantime do this crate:: thing when we notice we need it.
| * | | tor-netdoc: Rename NetdocUnverified trait to NetdocParseableUnverified (fmt)Ian Jackson2026-06-022-6/+6
| | | |
| * | | tor-netdoc: Rename NetdocUnverified trait to NetdocParseableUnverifiedIan Jackson2026-06-029-18/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The NetdocParseableUnverified derive macro implements this trait (amongst other things). Traits and derive macros should have aligned names. This is only used for parsing, so let's keep the "Parseable" part of the name. I don't think the effort of deprecated alias, for downstream compatibility, is worth it, our compatibility policy notwithstanding.
| * | | tor-netdoc: Fix two references to NetdocUnverified d-d templateIan Jackson2026-06-021-2/+2
| |/ / | | | | | | | | | | | | | | | | | | The trait is called NetdocUnverified, but the template is NetdocParseableUnverified. This fixes a dead docs link (which somehow isn't spotted by rustdoc, but is instead taken to refer to a nonexistent file).
* | | Merge branch 'cargo-update' into 'main'Alexander Hansen Færøy2026-06-021-182/+182
|\ \ \ | | | | | | | | | | | | | | | | Run routine cargo update See merge request tpo/core/arti!4045
| * | | Downgrade filetime to 0.2.27Gabriela Moldovan2026-06-021-3/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Without this, the shadow integration tests fail because `touch_instance_dir()` isn't able to set the mtime on the state dir: ``` Err(Error { source: IoError(Os { code: 14, kind: Uncategorized, message: "Bad address" }), action: Initializing, resource: Directory { dir: "./hss/tgen_hs" } }) ``` I suspect switching to the stblib implementation of these functions in https://github.com/alexcrichton/filetime/pull/121 is what broke things for us. The new implementation calls into rust's `set_times()` impl, which calls the `utimensat64` libc function under the hood. I suspect the underlying syscall used by this function is not supported by shadow.
| * | | Run routine cargo updateGabriela Moldovan2026-06-021-201/+182
| |/ / | | | | | | | | | Part of #2599
* | | Merge branch 'ticket2501_01' into 'main'David Goulet2026-06-022-5/+81
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | proto: Fix inverted cert sig and AUTHENTICATE compare Closes #2501 and #2502 See merge request tpo/core/arti!4048
| * | | proto: add regression tests for verify_link_auth_certmoumenalaoui2026-06-021-0/+79
| | | | | | | | | | | | | | | | Signed-off-by: David Goulet <[email protected]>
| * | | proto: Fix inverted cert sig and AUTHENTICATE compareDavid Goulet2026-06-022-5/+2
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Missed at review and no unit tests at the time catched those. The next commit has a unit tests to make sure these checks are now valid. Fixes #2501 Fixes #2502 Special thanks to Moumen Alaoui for reporting this early! Signed-off-by: David Goulet <[email protected]>
* | | Merge branch 'client_bootstrap_ctd' into 'main'gabi-2502026-06-022-4/+101
|\ \ \ | | | | | | | | | | | | | | | | client: Reflect manually disabled bootstrap in status See merge request tpo/core/arti!4047
| * | | client: Reflect manually disabled bootstrap in statusNick Mathewson2026-06-022-4/+101
| |/ / | | | | | | | | | | | | If we have made bootstrapping manual, and not launched a bootstrap, we now reflect this as the reason that bootstrapping is blocked.
* | | Merge branch 'chanmgr-metrics' into 'main'wesleyac2026-06-028-10/+251
|\ \ \ | | | | | | | | | | | | | | | | tor-chanmgr: Add metrics. See merge request tpo/core/arti!4018
| * | | tor-chanmgr: Add doccomments and fix typo.Wesley Aptekar-Cassels2026-06-022-2/+4
| | | |
| * | | tor-chanmgr: Refactor metrics code slightly.Wesley Aptekar-Cassels2026-06-022-194/+161
| | | |
| * | | tor-chanmgr: Split out channels built error metrics.Wesley Aptekar-Cassels2026-06-022-7/+206
| | | |
| * | | tor-chanmgr: Separate inbound/outbound channel metrics.Wesley Aptekar-Cassels2026-06-022-8/+10
| | | |
| * | | metrics: Add descriptions and units for existing metrics.Wesley Aptekar-Cassels2026-06-021-5/+29
| | | |
| * | | Upgrade metrics to 0.24.6.Wesley Aptekar-Cassels2026-06-023-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | This fixes the minimal-versions test, since the new code in chanmgr sets descriptions for the metrics, which is a feature not supported by the previous version.
| * | | tor-chanmgr: Add metrics.Wesley Aptekar-Cassels2026-06-025-3/+50
|/ / / | | | | | | | | | | | | | | | This adds a structure to initialize metrics when the `ChanMgr` is created, and adds a counter for the total number of channels built, broken down by success and failure.
* | | Merge branch 'netdoc-docs-ordering' into 'main'Clara Engler2026-06-022-9/+8
|\ \ \ | |/ / |/| | | | | | | | tor-netdoc: Internal docs improvements See merge request tpo/core/arti!4044
| * | tor-netdoc: ns_variety_definition_macros: Use coherent orderingIan Jackson2026-06-021-7/+7
| | | | | | | | | | | | | | | | | | | | | | | | At some earlier point in the development of this scheme, the ordering was different (as it is in poc). Update all the references in the docs, to the various varieties, so that they are always plain, md, vote, like ns_type! et al take.
| * | tor-netdoc: ns_variety_definition_macros: Minor grammar fixIan Jackson2026-06-021-1/+1
| | |
| * | tor-netdoc: Remove a TODO that we've doneIan Jackson2026-06-021-1/+0
|/ / | | | | | | We do now support encoding.
* | Merge branch 'minor-doc-fix' into 'main'gabi-2502026-06-021-1/+1
|\ \ | | | | | | | | | | | | proto: Fix typo in ResolveCmdChecker docs See merge request tpo/core/arti!4035
| * | proto: Fix typo in ResolveCmdChecker docsGabriela Moldovan2026-05-281-1/+1
| | | | | | | | | | | | This returns a boxed `ResolveCmdChecker`, not a `DataCmdChecker`.
* | | Merge branch 'relay-platform-improvements' into 'main'Clara Engler2026-06-022-24/+56
|\ \ \ | | | | | | | | | | | | | | | | Improvements for RelayPlatform See merge request tpo/core/arti!4024
| * | | tor-netdoc: Add spec link for RelayPlatformClara Engler2026-06-021-0/+3
| | | |
| * | | tor-netdoc: Round-trip test for RelayPlatform encodingClara Engler2026-06-021-0/+7
| | | |
| * | | tor-netdoc: Implement Display for RelayPlatformClara Engler2026-06-022-0/+12
| | | |
| * | | tor-netdoc: Store platform of TorVersion in Option (fmt)Clara Engler2026-06-021-1/+3
| | | | | | | | | | | | | | | | No functional change, just rustfmt.
| * | | tor-netdoc: Store platform of TorVersion in OptionClara Engler2026-06-022-7/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit changes RelayPlatform::TorVersion to store the platform to an Option<String> instead of a String because storing a missing/not present platform as the empty String feels wrong in my opinion. Besides, we will soon need to add encoding for this type, making now a good time to change it.
| * | | tor-netdoc: Refactor RelayPlatform testsClara Engler2026-06-021-21/+28
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This refactors the RelayPlatform test to store the test vectors in an array and iterate over it, comparing it with the expected output. This is a lot better than the current version, where there is not just a lot of copy and pasted code but also some tests that only check for an okay value. Unfortunately, there is not an easy way to review this with --color-moved or something. Personally, I would recommend to review each original test vector (i.e. a line starting with `let p =` followed by a string literal) and verify that the exact same string literal is still present within the new test vector. Afterwards, verifying the assertion logic should be easy, as it is a one-liner.
* | | Merge branch 'debug-weights' into 'main'Jim Newsome2026-06-011-9/+17
|\ \ \ | |_|/ |/| | | | | | | | NetDir::pick_relay: preemptively handle empty sequence See merge request tpo/core/arti!4034
| * | NetDir::pick_relay: preemptively handle empty sequenceJim Newsome2026-05-271-9/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The `choose_weighted` behavior given an empty sequence isn't well documented and has changed over time. Handle it ourselves for consistency. Currently, the `choose_weighted` behavior appears to be to return WeightError::InvalidInput. This means the corresponding `is_empty` branch when handling WeightError::InsufficientNonZero was never exercised. (Though may have been with previous versions of the rand crate).
* | | Merge branch 'rm-semver' into 'main'gabi-2502026-06-019-66/+0
|\ \ \ | | | | | | | | | | | | | | | | Remove semver.md files post-release See merge request tpo/core/arti!4041
| * | | Remove semver.md files post-releaseGabriela Moldovan2026-06-019-66/+0
|/ / /
* | | Merge branch '2.4.0-bumps' into 'main'arti-v2.4.0gabi-2502026-06-0172-765/+853
|\ \ \ | | | | | | | | | | | | | | | | Version bumps for the 2.4.0 release See merge request tpo/core/arti!4039
| * | | Bump arti crate to 2.4.0Gabriela Moldovan2026-06-014-4/+4
| | | |
| * | | Bump all the unstable tor- and arti- crates to 0.43.0Gabriela Moldovan2026-06-0166-611/+611
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Done using: ``` for crate in $(./maint/list-crates | rg '^(tor|arti-)'); do cargo set-version -p $crate 0.43.0 done ```