summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * | doc/Compatibility.md: tick the box for link protocol 5Ian Jackson2022-08-171-1/+1
| | | | | | | | | | | | | | | We do this now. As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/657#note_2828364
| * | channel padding: Only do anything with link protocol 5Ian Jackson2022-08-171-0/+7
| | | | | | | | | | | | | | | | | | | | | Or rather, if we *didn't* negotiate 4, which is too old. As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/657#note_2828354
| * | channel padding: Properly advertise link protocol 5Ian Jackson2022-08-171-3/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | We already actually send and negotiate the padding, since !657, but we ought to negotiate a protocol version where that's not a violation! As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/657#note_2828354
| * | tor-netdoc: if_ito: Add expansion of acronymIan Jackson2022-08-171-0/+2
| | |
| * | channel padding: Move initial config of ChannelPaddingInstructionsIan Jackson2022-08-172-7/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Making ChannelPaddingInstructions::default() accurately reflect the initial state of the reactor's padding timer simplifies the code somewhat. (When padding is wanted, parameters are computed and inserted explicitly, so the only change is that if we start out dormant, we defer setting the timer parameters until necessary.) As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/657#note_2827249
| * | channel padding: Parameters: default_padding replaces Default implIan Jackson2022-08-172-1/+7
| | | | | | | | | | | | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/657#note_2827249
| * | channel usage: Rename CU::UserTraffic from CU::ExitIan Jackson2022-08-176-25/+37
| | | | | | | | | | | | | | | As suggested in https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/657#note_2827246
| * | chanmgr padding: Correct docs for padding_parameters*Ian Jackson2022-08-171-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/657#note_2827242 These texts were out of date; one of them still mentioned `all_zeroes`.
| * | Improve comment for ChannelUsage::ExitNick Mathewson2022-08-171-1/+1
| | |
| * | Fix typo in commentNick Mathewson2022-08-171-1/+1
| | |
| * | tor-chanmgr tests: Fix a minimal-versions failure (actually)Ian Jackson2022-08-171-1/+1
| | |
| * | tor-chanmgr tests: Fix a minimal-versions failureIan Jackson2022-08-171-2/+2
| | |
| * | arti: Fix a minimal-versions failureIan Jackson2022-08-171-1/+1
| | |
| * | Add semver notesIan Jackson2022-08-176-0/+17
| | |
| * | channel reactor: Add some commented-out debug for paddingIan Jackson2022-08-171-1/+5
| | |
| * | channel padding: Correctly always send the timer parametersIan Jackson2022-08-172-6/+13
| | | | | | | | | | | | Fixes "chanmgr configuration: Avoid sending needless initial update(s)"
| * | channel padding: Abolish ARTI_EXPERIMENTAL_CHANNEL_PADDING env varIan Jackson2022-08-171-8/+0
| | | | | | | | | | | | This was for testing and is no longer needed.
| * | channel engage_padding_activities: swap docs to tor0protoIan Jackson2022-08-172-11/+13
| | | | | | | | | | | | This allow us to make a working cross-reference.
| * | channel fake_channel_details: Use precise cfgIan Jackson2022-08-171-1/+1
| | | | | | | | | | | | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/657#note_2826169
| * | tor-netdir: testnet: construct_custom_netdir_with_params: Fix docIan Jackson2022-08-171-1/+2
| | | | | | | | | | | | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/657#note_2826168
| * | ChannelPaddingInstructions: Update and expand docsIan Jackson2022-08-172-11/+41
| | |
| * | ChannelPaddingInstructions: Rename `params` field to `insns`Ian Jackson2022-08-171-6/+6
| | |
| * | Rename ChannelsParams types to ChannelPaddingInstructions (fmt)Ian Jackson2022-08-174-7/+22
| | | | | | | | | | | | Run rustfmt; no other changes.
| * | Rename ChannelsParams types to ChannelPaddingInstructionsIan Jackson2022-08-178-63/+63
| | | | | | | | | | | | | | | | | | | | | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/657#note_2826167 This makes some lines too long; I will run rustfmt in a separate commit for clarity.
| * | chanmgr: Fix typoIan Jackson2022-08-171-1/+1
| | | | | | | | | | | | | | | Reported here https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/657#note_2826166
| * | chanmgr parameterize: Correct doc commentIan Jackson2022-08-171-1/+4
| | | | | | | | | | | | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/657#note_2826164
| * | Rename PaddingParameters::all_zeroes constructor to disabledIan Jackson2022-08-171-4/+2
| | |
| * | chamgr NetParamsExtract: Replace direct nf_ito accessIan Jackson2022-08-171-4/+23
| | | | | | | | | | | | | | | It turns out that the TryFrom was infallible, which wasn't obvious with the previous code structure.
| * | Channel: Make mutable() and engage_padding_activities infallibleIan Jackson2022-08-175-18/+12
| | | | | | | | | | | | | | | | | | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/657#note_2826151 This gets rid of quite some Bug error paths.
| * | Move ChannelUsage from tor_proto to tor_chanmgrIan Jackson2022-08-179-76/+85
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Replace Channel::note_usage with Channel::engage_padding_activities, which unconditionally causes the channel to (start to) do netflow padding things. The condition now lives in chanmgr. Addresses https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/657#note_2826094
| * | tor-chanmgr: Expand docs for map::Inner dormancy fieldIan Jackson2022-08-171-0/+4
| | | | | | | | | | | | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/657#note_2826093
| * | tor-cell: PaddingNegotiate::default_reducedIan Jackson2022-08-171-10/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Get rid of unneeded constructor. We never need to use hardcoded reduced padding parameters during negotiation cell construction. If we are using reduced padding parameters, the layers which decide this have netparams to use. Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/657#note_2826092
| * | tor-cell: PaddingNegotiate::start: take IntegerMillisecondsIan Jackson2022-08-175-6/+10
| | |
| * | chanmgr padding_parameters: Use OptionIan Jackson2022-08-172-40/+41
| | | | | | | | | | | | | | | | | | | | | | | | | | | The network consensus parameters use (0,0) to mean "no padding" (which is not the same as (0,0) means in a PADDING_NEGOTIATE cell). Representing "no padding" this way is actually quite convoluted and un-Rustic. Ensure that we convert (0,0) to None, and do the primary logic in Option.
| * | tor-cell: PaddingNegotiate: give better spec xrefsIan Jackson2022-08-171-0/+6
| | |
| * | channel: Clarify (and in some places replace) "frontend" terminologyIan Jackson2022-08-173-7/+10
| | |
| * | tor-proto channel padding: Document PADDING_NEGOTIATE overwritingIan Jackson2022-08-171-0/+3
| | | | | | | | | | | | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/657#note_2825979
| * | chanmgr: padding: Split IEFI into named functionIan Jackson2022-08-171-19/+27
| | | | | | | | | | | | | | | | | | | | | Roughly as suggested in https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/657#note_2826160 IMO this is less clear, because of the way it splits the logic up.
| * | chanmgr: NetParamsExtract: extend docs for nf_itoIan Jackson2022-08-171-2/+2
| | |
| * | chanmgr: Get rid of final Result relating to netdir/netparamsIan Jackson2022-08-172-32/+29
| | | | | | | | | | | | No functional change. (The error tyep was Void.)
| * | chanmgr: Use NetDirProvider::params and Arc<dyn..Netparameters>Ian Jackson2022-08-177-91/+100
| | | | | | | | | | | | | | | | | | | | | | | | | | | This gets rid of many Result(). Many parameters are renamed. Test cases of the now-impossible branch are removed. Deleting the match from padding_parameters will come in a moment. I've split off that commit since it has much whitespace noise. for now, change the error type to Void.
| * | chanmgr: Add a TODO for renaming NetDirExtractIan Jackson2022-08-171-0/+3
| | |
| * | chanmgr ChannelUsage: Fix and clarify docsIan Jackson2022-08-171-2/+3
| | |
| * | chanmgr set_dormancy: Remove obsolete commentIan Jackson2022-08-171-4/+0
| | |
| * | chanmgr: Extend doc comments for DormancyIan Jackson2022-08-171-0/+6
| | | | | | | | | | | | | | | Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/657#note_2825962
| * | Fix typos in comments.eta2022-08-172-2/+2
| | |
| * | channel padding: Rename low_ms and high_msIan Jackson2022-08-174-23/+27
| | | | | | | | | | | | | | | These have the unit in the type. Putting that in the field name too is otiose.
| * | channel padding: Test through most of the layersIan Jackson2022-08-174-0/+367
| | |
| * | chanmgr testing: FakeChannel: retain the ChannelsParamsUpdatesIan Jackson2022-08-161-1/+4
| | |
| * | tor-proto, testing: Provide accessors for ChannelsParamsUpdatesIan Jackson2022-08-161-0/+11
| | |