aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | Merge branch 'feat' into 'main'Nick Mathewson2023-07-072-1/+12
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | arti: Build with HS client support by default Closes #948 See merge request tpo/core/arti!1382
| * | | | | Document (retrospectively) the behaviour of 1.1.6 re HS clientIan Jackson2023-07-071-0/+2
| | | | | |
| * | | | | arti: Build with HS client support by defaultIan Jackson2023-07-071-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | Fixes #948
| * | | | | arti Cargo.tomL: wrap default features listIan Jackson2023-07-071-1/+9
| |/ / / /
* | | | | Merge branch 'event_report_everywhere' into 'main'Nick Mathewson2023-07-0726-116/+98
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Throughout: Use event_report!() macros for reporting Errors. Closes #949 See merge request tpo/core/arti!1383
| * | | | | Throughout: Use *_report!() macros for reporting Errors.Nick Mathewson2023-07-0726-116/+98
| | |_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I identified the cases to replace by searching for the string `.report()`. There are a few that I didn't change: * A couple of cases that used anyhow::Error, * One case that reported two Errors. * Two cases in `tor_hsclient::err` that just did `error!("Bug: {}")`. I have also not audited the cases in `tor-hsclient` where we're using `tor_error::Report` manually. Nonetheless, closes #949.
* | | | | Merge branch 'fix-os-onionbalance' into 'main'Nick Mathewson2023-07-071-1/+6
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | be more lenient while parsing inner hs desc Closes #952 See merge request tpo/core/arti!1389
| * | | | | be more lenient while parsing inner hs desctrinity-1686a2023-07-071-1/+6
|/ / / / /
* | | | | Merge branch 'report' into 'main'Ian Jackson2023-07-073-92/+56
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | tor-error: tracing module: Use macro to generate macros See merge request tpo/core/arti!1386
| * | | | | tor-error: tracing module: Use macro to generate macrosIan Jackson2023-07-073-91/+55
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This abolishes some quintuplication. The output is identical except that: * The syntax display in the rustdoc output for the resulting macros seems to have somewhat less whitepsace. * The whimsical error messages in the examples are all identical. Ah well.
| * | | | | tor-error: tracing module: Fix link to tracing macroIan Jackson2023-07-071-1/+1
| |/ / / /
* | | | | Merge branch 'inclusive' into 'main'Nick Mathewson2023-07-074-4/+4
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | rng ranges: Use inclusive Duration ranges in several places See merge request tpo/core/arti!1385
| * | | | rng ranges: Use inclusive Duration ranges in several placesIan Jackson2023-07-074-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Many of these call sites would panic if, somehow, the upper bound was zero. In most cases it is very complicated to see if whether this could happen. However, there is a better answer: Durations are (conceptually) dense, so picking the closed set (which includes its boundary) rather than the open one (which doesn't) will make little practical difference. So change four call sites to use `..=` instead of just `..`.
* | | | | Merge branch 'report-bugs-v2' into 'main'Nick Mathewson2023-07-0710-44/+231
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | Optional tracing support in tor-error for error reporting See merge request tpo/core/arti!1379
| * | | | event_report: assert correctness of format endingNick Mathewson2023-07-073-0/+24
| | | | | | | | | | | | | | | | | | | | | | | | | (Also, document that this static assertion is the reason why you are seeing a confusing error message.)
| * | | | circmgr: Use event_report!() and similar macrosNick Mathewson2023-07-076-43/+30
| | | | | | | | | | | | | | | | | | | | This simplifies our logging a little, and implements part of
| * | | | tor-error: Add optional tracing supportNick Mathewson2023-07-074-1/+177
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The main contribution here is a set of convenience macros for logging error `Report`s. Notably, this macros always logs `Internal` and `BadAspiUsage` errors at `WARN`, unless they are already at `ERROR` or more. This is a little tricky because `tracing::event!()` requires its Level argument to be a constant.
* | | | Merge branch 'allow_missing_panics' into 'main'Ian Jackson2023-07-0751-60/+2
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | add_warning: Tolerate clippy::missing_panics_doc Closes #950 See merge request tpo/core/arti!1380
| * | | | Remove explicit allows for missing_panics_docs.Nick Mathewson2023-07-066-14/+2
| | | | | | | | | | | | | | | | | | | | These are no longer needed.
| * | | | Run add_warning to remove `missing_panics_doc` deny.Nick Mathewson2023-07-0645-45/+0
| | | | | | | | | | | | | | | | | | | | Closes #950.
| * | | | add_warning: Tolerate clippy::missing_panics_docNick Mathewson2023-07-061-1/+0
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | As of current nightly, this lint now includes expect()s, which makes it trigger way more than we'd like. See discussion on #950.
* | | | Merge branch 'clippy-nightly-20230703' into 'main'Nick Mathewson2023-07-077-17/+17
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | Fix various warnings from clippy nightly Closes #943 See merge request tpo/core/arti!1369
| * | | Avoid matches!(x, None), matches!(x, Ok(_))Nick Mathewson2023-07-063-5/+5
| | | | | | | | | | | | | | | | This appeases clippy-nightly.
| * | | tor-rtcompat: Simplify trivial all() expressions.Nick Mathewson2023-07-063-11/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Clippy nightly doesn't like `#[cfg(all(...))]` with only a single expression inside the `all(...)`. This requires an adjustment in check_doc_features.
| * | | tor-config: Use next_back() instead of rev().next()Nick Mathewson2023-07-031-1/+1
| | | | | | | | | | | | | | | | This is a new warning^Wsuggestion from clippy nightly.
* | | | Merge branch 'task5' into 'main'gabi-2502023-07-064-10/+14
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | tor-rtmock: Minor followups for impl_runtime See merge request tpo/core/arti!1378
| * | | | tor-rtmock: statically assert that the macro makes a Runtime implIan Jackson2023-07-061-0/+6
| | | | |
| * | | | tor-rtmock: Use the same specified field for BlockOn and SpawnIan Jackson2023-07-064-10/+8
|/ / / / | | | | | | | | | | | | These are always the same and probably always will be.
* | | | Merge branch 'task4' into 'main'Ian Jackson2023-07-0614-454/+1488
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | Introduce a MockExecutor for fully-isolated test cases See merge request tpo/core/arti!1375
| * | | | tor-rtmock: Add semver.mdIan Jackson2023-07-061-0/+3
| | | | |
| * | | | tor-rtmock: task: Fix a typoIan Jackson2023-07-061-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1375#note_2919976
| * | | | tor-rtmock: task: clarify progress_until_stalled a littleIan Jackson2023-07-062-1/+5
| | | | |
| * | | | tor-rtmock: Runtime: Expand on "allowed" documentationIan Jackson2023-07-061-3/+33
| | | | |
| * | | | tor-rtmock: task: Remove a () assignmentIan Jackson2023-07-061-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | Discussion: https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1375#note_2919928
| * | | | tor-rtmock: task: Abolish TaskFutureInfo alias (fmt)Ian Jackson2023-07-061-1/+3
| | | | |
| * | | | tor-rtmock: task: Abolish TaskFutureInfo aliasIan Jackson2023-07-061-7/+6
| | | | | | | | | | | | | | | | | | | | | | | | | Requested by: https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1375#note_2919926
| * | | | tor-rtmock: Net: Make UDP sockets un-constructableIan Jackson2023-07-061-14/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This will hopefully mean anyone trying to use this will notice that it's not implemented. Prompted by: https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1375#note_2919925
| * | | | tor-rtmock: Add a cross-reference from MockSleepRuntime::wait_forIan Jackson2023-07-061-0/+4
| | | | |
| * | | | tor-dirmgr: bridge descriptor tests: Add a missing #[traced_test]Ian Jackson2023-07-061-0/+1
| | | | | | | | | | | | | | | | | | | | This seems to have been overlooked.
| * | | | tor-dirmgr: bridge descriptor tests: Use MockRuntime (drop Tokio dep)Ian Jackson2023-07-062-2/+0
| | | | | | | | | | | | | | | | | | | | This isn't used any more.
| * | | | tor-dirmgr: bridge descriptor tests: Use MockRuntime (fmt)Ian Jackson2023-07-061-270/+271
| | | | | | | | | | | | | | | | | | | | Run rustfmt.
| * | | | tor-dirmgr: bridge descriptor tests: Use MockRuntimeIan Jackson2023-07-061-35/+25
| | | | | | | | | | | | | | | | | | | | This abolishes a bodge sleep. It should make the tests deterministic.
| * | | | tor-dirmgr: bridge descriptor tests: Fix a v. low prob. raceIan Jackson2023-07-061-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Drain a number of events, not just one. The stream might yield many events, as explained in this new comment. This fails every time with MockExecutor::try_test_with_various(). I think it might fail with the tokio exeuctor too, but evidently not with high probability or we would have noticed.
| * | | | tor-hsclient: Abolish ad-hoc real-world-time sleepsIan Jackson2023-07-061-12/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now we can reliably wait precisely for the tasks to be all waiting. This test case no longer involves any real executor.
| * | | | tor-rtmock: MockRuntime: provide test_with_variousIan Jackson2023-07-063-0/+45
| | | | | | | | | | | | | | | | | | | | In both fallible and infallible variants, for convenience.
| * | | | tor-rtmock: MockExecutor: Configurable scheduling policyIan Jackson2023-07-064-5/+76
| | | | |
| * | | | tor-rtmock: Provide MockRuntimeIan Jackson2023-07-064-0/+133
| | | | |
| * | | | tor-rtmock: Unit tests for MockExecutorIan Jackson2023-07-063-0/+108
| | | | |
| * | | | tor-rtmock: Provide MockExecutorIan Jackson2023-07-064-0/+588
| | | | |
| * | | | tor-rtmock: impl Default for MockNetProviderIan Jackson2023-07-061-0/+6
| | | | |