| Commit message (Collapse) | Author | Age | Files | Lines |
| ... | |
| | | | |
| | | |
| | | |
| | | |
| | | | |
Nothing actually used these accessor functions, and it's not clear
what would. We can add them later if they're needed.
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
These probably aren't for things that will fail IRL, but it's nice
to have coverage on the code, just in case.
|
| | | | |
| | | |
| | | |
| | | | |
Now there's much less copy-and-paste.
|
| | |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This makes our layout more similar to our other crates, and
successfully informs our grcov exclusion pattern that these tests
are indeed tests.
Doing this knocks down the reported coverage for the tor-rtcompat
crate, but that's okay: we hadn't earned it.
I hereby promise that this commit is only code-movement.
|
| |\ \ \
| |/ /
|/| |
| | |
| | | |
doc/Release.md: add note to check feature combinations
See merge request tpo/core/arti!265
|
| | | |
| | |
| | |
| | | |
This is a nice reminder to have before we solve arti#303 for good.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Shellcheck doesn't like it when you do `rm -r "$A/$B"` : it worries
that the path might accidentally expand to /.
That shouldn't actually be possible in this case, but let's avoid
being the people who accidentally remove somebody's filesystem.
|
| | | |
| | |
| | |
| | |
| | | |
This was added in !210; looks like it got removed by mistake with
!221.
|
| | |/
|/|
| |
| |
| | |
This makes it easier to see when they're changing, and will make
future patches easier to review.
|
| |\ \
| |/
|/|
| |
| |
| |
| | |
Refactor the tor-rtcompat API.
Closes #301 and #300
See merge request tpo/core/arti!263
|
| | | |
|
| | |
| |
| | |
Comment-only.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
Previously it didn't enable any TLS provider, since we made
native-tls optional a few commits ago. Now it enables rustls,
so that rustls also gets a quick check along with async-std.
I've also switched this test to use "cargo clippy" in place of
"cargo test" because it's a strict superset.
|
| | | |
|
| | | |
|
| | |
| |
| |
| |
| | |
This avoids a future confusion with the new `SpawnBlocking` trait in
async_executors v0.5, and better describes what the trait provides.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This took some refactoring, so that I wouldn't need to define 9
different versions of the function. It also required that we change
the behavior of test_with_all_runtimes slightly, so that it asserts
on _any_ failure rather than asserting on most but returning Err()
for others. That in turn required changes to a few of its callers.
There's probably a better way to do all of this macro business, but
this is the best I could find.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This commit puts the native-tls crate behind a feature. The feature
is off-by-default in the tor-rtcompat crate, but can be enabled
either from arti or arti-client.
There is an included script that I used to test that tor-rtcompat
could build and run its tests with all subsets of its features.
Closes #300
|
| | |
| |
| |
| |
| | |
This helps us simplify our code in a few ways, and will help even
more once native_tls is optional.
|
| | |
| |
| |
| |
| | |
This should help avoid some amount of temptation towards API
proliferation.
|
| | | |
|
| | |
| |
| |
| |
| | |
If we implement our own clone on CompoundRuntime, we no longer need
Clone implementations on our TlsProvider implementations.
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
Having separate types here doesn't justify the (very limited)
benefit of distinguishing between the case where we have created an
executor that we own and the case where we have a handle to an
already-running tokio executor.
Part of #301.
|
| | | |
|
| | | |
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Add test coverage tracking with CI/CD
Closes #250
See merge request tpo/core/arti!221
|
| | | | |
|
| | | | |
|
| | | |
| | |
| | |
| | | |
Follows up on changes from https://gitlab.torproject.org/trinity-1686a/arti/-/merge_requests/2/diffs#bc2cc73a8917fa6fed183148df69119665eb4e55
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | | |
Following suggestion here:
`https://gitlab.torproject.org/tpo/core/arti/-/issues/250#note_2764010`
|
| | | | |
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | |
| | | |
Following instructions at:
`https://www.collabora.com/news-and-blog/blog/2021/03/24/rust-integrating-llvm-source-base-code-coverage-with-gitlab/`
|
| |\ \ \
| |_|/
|/| |
| | |
| | | |
doc/CONFIG-NOTES.md: config proposal
See merge request tpo/core/arti!248
|
| | | | |
|
| | | | |
|
| | | | |
|
| |\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
tor-rtcompat: Add support for a rustls backend
Closes #86
See merge request tpo/core/arti!260
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
Also, more comments on why these limitations are safe within the
context of Tor, but you wouldn't want to use them elsewhere.
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
Previously we expected the reader to automatically know why it was
called "SNI", which really isn't fair.
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
This change uses the async-native-tls crate for everything, and
deletes some duplicated code.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This is based on @janimo's approach in !74, but diverges in a few
important ways.
1. It assumes that something like !251 will merge, so that we can
have separate implementations for native_tls and rustls compiled
at the same time.
2. It assumes that we can implement this for the futures::io traits
only with no real penalty.
3. It uses the `x509-signature` crate to work around the pickiness of
the `webpki` crate. If webpki eventually solves their
[bug 219](https://github.com/briansmith/webpki/issues/219), we
can remove a lot of that workaround.
Closes #86.
|
| |/ / /
| | |
| | |
| | |
| | | |
We should never use this for anything but making the testing
certificates we use for making sure our TLS implementation works.
|