mirrors/arti.git - mirror of https://gitlab.torproject.org/tpo/core/arti

	Commit message (Collapse)	Author	Age	Files	Lines
...
* \| \| \| \| \| \| \| \|	Merge branch 'hashx-fuzz-rand-fix' into 'main'	Ian Jackson	2026-05-13	2	-8/+11
\|\ \ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	hashx: Update rand version used in fuzz tests. See merge request tpo/core/arti!3987
\| * \| \| \| \| \| \| \| \|	hashx: Update rand version used in fuzz tests.	Wesley Aptekar-Cassels	2026-05-13	2	-8/+11
\| \| \|/ / / / / / / \| \|/\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This is less important now that we've disabled these tests, but might as well make it easier if anyone picks these up in the future.
* \| \| \| \| \| \| \| \|	Merge branch 'expectation' into 'main'	opara	2026-05-13	1	-1/+1
\|\ \ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Turn an expectation into an allow See merge request tpo/core/arti!3983
\| * \| \| \| \| \| \| \| \|	Turn an expectation into an allow	Ian Jackson	2026-05-13	1	-1/+1
\| \| \|/ / / / / / / \| \|/\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Fixes `cargo clippy --locked --all-features -p arti`
* \| \| \| \| \| \| \| \|	Merge branch 'connect_error' into 'main'	opara	2026-05-13	4	-32/+80
\|\ \ \ \ \ \ \ \ \ \| \|_\|/ / / / / / / \|/\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	chanmgr: Do not turn connect errors into proxy errors. Closes #2459 See merge request tpo/core/arti!3932
\| * \| \| \| \| \| \| \|	chanmgr: report target address, not proxy address, in error	Nick Mathewson	2026-05-07	4	-6/+12
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Also, change the address type in the error to String for now. In reality we need a better representation of this error, but that shouldn't block this.
\| * \| \| \| \| \| \| \|	chanmgr: refactor error types	Nick Mathewson	2026-05-07	4	-21/+46
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Proxy belonged as a subcase of ChannelBuild. And ChannelBuild was only about making an initial connection.
\| * \| \| \| \| \| \| \|	chanmgr: Do not turn connect errors into proxy errors.	Nick Mathewson	2026-05-07	2	-15/+32
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This fixes the problem where we'd report all connect failures as proxy failures. Closes #2459.
* \| \| \| \| \| \| \| \|	Merge branch 'random-range' into 'main'	Ian Jackson	2026-05-13	2	-1/+14
\|\ \ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	clippy: Work around bug where it claims method doesn't exist See merge request tpo/core/arti!3982
\| * \| \| \| \| \| \| \| \|	clippy: Add an xref re random_range to the comment	Ian Jackson	2026-05-13	1	-0/+1
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/3982#note_3410614
\| * \| \| \| \| \| \| \| \|	clippy: disallow random_range standalone method too	Ian Jackson	2026-05-13	1	-0/+1
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Upstream rand have provided a convenient alias for causing your program to panic. How helpful.
\| * \| \| \| \| \| \| \| \|	clippy: Work around bug where it claims method doesn't exist	Ian Jackson	2026-05-13	2	-1/+12
\| \| \|/ / / / / / / \| \|/\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Fixes warning: `rand::RngExt::random_range` does not refer to a reachable function --> /volatile/rustcargo/Rustup/Arti/arti/clippy.toml:7:5 \| 7 \| { path = "rand::RngExt::random_range", reason = "Prefer tor_basic_utils::RngExt::gen_range_checked to avoid uncontrolled panics, or gen_range_infallible if applicable" }, \| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ \| = help: add `allow-invalid = true` to the entry to suppress this warning
* \| \| \| \| \| \| \| \|	Merge branch 'vae-and-preamble' into 'main'	Ian Jackson	2026-05-13	9	-36/+202
\|\ \ \ \ \ \ \ \ \ \| \|/ / / / / / / / \|/\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Complete vote preamble and authority section enough for consensus calculations See merge request tpo/core/arti!3948
\| * \| \| \| \| \| \| \|	tor-netdoc: SharedRandParticipate: Add TODO re "presence" type	Ian Jackson	2026-05-13	1	-0/+2
\| \| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \| \|	tor-netdoc: SharedRandCommitV1: Improve type of reveal	Ian Jackson	2026-05-13	1	-1/+4
\| \| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \| \|	tor-netdoc: SharedRandCommitV1: Improve type of commit	Ian Jackson	2026-05-13	1	-1/+7
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Use FixedB64 since it is in fact fixed length. While we're here, add the docs link I had to follow to figure this out.
\| * \| \| \| \| \| \| \|	tor-netdoc: VoteAuthorityEntry: reorder fields to spec order	Ian Jackson	2026-05-13	1	-4/+4
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Only SharedRandStatuses was out of place.
\| * \| \| \| \| \| \| \|	tor-netdoc: rustfmt (re-alphabetise and re-wrap imports)	Ian Jackson	2026-05-13	1	-2/+1
\| \| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \| \|	tor-netdoc: vote authority entry: declare it complete	Ian Jackson	2026-05-13	1	-3/+0
\| \| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \| \|	tor-netdoc: vote authority entry: parse shared-rand-commit	Ian Jackson	2026-05-13	1	-2/+89
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This is rather ugly, because the protocol is being ad-hoc again.
\| * \| \| \| \| \| \| \|	tor-netdoc: vote authority entry: parse shared-rand-participate	Ian Jackson	2026-05-13	1	-1/+21
\| \| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \| \|	tor-netdoc: vote authority entry: parse legacy-dir-key	Ian Jackson	2026-05-13	1	-1/+6
\| \| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \| \|	tor-netdoc: Soften a TODO.	Ian Jackson	2026-05-13	1	-2/+2
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Preamble now doesn't contain anything that's wrong. It is missing a couple of fields that will be wanted when we generate votes.
\| * \| \| \| \| \| \| \|	tor-netdoc: Add a ticket reference for a TODO	Ian Jackson	2026-05-13	1	-1/+1
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This isn't needed for the arti dirauth consensus method, but it will be needed for arti dirauth vote calculator.
\| * \| \| \| \| \| \| \|	tor-netdoc: Add shared-rand-*-status to VoteAuthorityEntry	Ian Jackson	2026-05-13	2	-5/+4
\| \| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \| \|	tor-netdoc: Break out SharedRandStatuses, and remove it from votes	Ian Jackson	2026-05-13	6	-14/+40
\| \| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \| \|	tor-netdoc: impl Ord and PartialOrd for byte wrapper types	Ian Jackson	2026-05-13	2	-2/+15
\| \| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \| \|	tor-netdoc: derive Ord and PartialOrd for RSA fingerprint types	Ian Jackson	2026-05-13	2	-4/+5
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This will let us use them in types in ordered lists in netdocs, without fuss.
\| * \| \| \| \| \| \| \|	tor-netdoc: impl NetdocEncodableFields for NotPresent	Ian Jackson	2026-05-13	1	-1/+4
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	And document its meaning when parsing and encoding as flattened fields.
\| * \| \| \| \| \| \| \|	tor-netdoc: NetdocEncodableFields: Suppress warnings for empty structs	Ian Jackson	2026-05-13	1	-0/+2
\| \| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \| \|	tor-netdoc: NetdocEncodableFields: Suppress warnings for empty structs (pre-fmt)	Ian Jackson	2026-05-13	1	-1/+4
\| \| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \| \|	tor-netdoc: Parsing with `#[netdoc(flatten)]`: cope with non-path types	Ian Jackson	2026-05-13	1	-1/+1
\|/ / / / / / / / \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	ns_type! is a non-path type.
* \| \| \| \| \| \| \|	Merge branch 'rd-fingerprint' into 'main'	Clara Engler	2026-05-13	3	-6/+24
\|\ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Store fingerprint in Option<SpFingerprint> See merge request tpo/core/arti!3978
\| * \| \| \| \| \| \| \|	tor-netdoc: Change fingerprint to Option<SpFingerprint>	Clara Engler	2026-05-12	2	-2/+3
\| \| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \| \|	tor-netdoc: Obtain RSA identity from signing key	Clara Engler	2026-05-12	1	-2/+1
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Will be required and unavoidable as we will change fingerprint to Option<SpFingerprint> in the next commit.
\| * \| \| \| \| \| \| \|	tor-netdoc: Return copy in RouterDesc::rsa_identity()	Clara Engler	2026-05-12	3	-4/+22
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This change might seem pointless for now but it will be required and unavoidable later on, because we will have to change RouterDesc::fingerprint from RsaIdentity to Option<SpFingerprint> which will make it impossible to be used inside the getter anymore. With this change, our only resort is to obtain the RSA identity from the signing key but we can only return a copy then because that RSA identity is created ad-hoc then.
* \| \| \| \| \| \| \| \|	Merge branch 'directory-signature-3' into 'main'	Clara Engler	2026-05-13	9	-584/+620
\|\ \ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	tor-netdoc: Sort out netstatus signatures See merge request tpo/core/arti!3937
\| * \| \| \| \| \| \| \| \|	tor-netdoc: Replace an IEFE with use of .and_then() (fmt)	Ian Jackson	2026-05-05	1	-6/+5
\| \| \| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \| \| \|	tor-netdoc: Replace an IEFE with use of .and_then()	Ian Jackson	2026-05-05	1	-3/+4
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/3937#note_3405033 Suggested-by: Clara Engler <[email protected]>
\| * \| \| \| \| \| \| \| \|	tor-netdoc: Apply deferred rustfmt churn	Ian Jackson	2026-04-29	4	-37/+42
\| \| \| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \| \| \|	tor-netdoc: Turn DirectorySignatureHashAlgo back into a normal struct	Ian Jackson	2026-04-29	2	-31/+12
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Abolish the terrible macro. Review with --color-moved-ws=allow-indentation-change --color-moved.
\| * \| \| \| \| \| \| \| \|	tor-netdoc: re-privatise some methods	Ian Jackson	2026-04-29	1	-6/+4
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	hash_slice_for_verification is still needed by code in poc, that we're not replacing in this MR. So that TODO gets downgraded, instead.
\| * \| \| \| \| \| \| \| \|	tor-netdoc: directory-signature: don't re-hash unnecessarily	Ian Jackson	2026-04-29	1	-3/+4
\| \| \| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \| \| \|	tor-netdoc: Fix handling of explicit vs implicit dir sig SHA1 hash	Ian Jackson	2026-04-29	1	-6/+2
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Now that everything is prepared, we can add the sha1_unnamed field in the hash accumulator.
\| * \| \| \| \| \| \| \| \|	tor-netdoc: Fix signature of hash_slice_for_verification	Ian Jackson	2026-04-29	2	-14/+10
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	In order to handle marked vs unmarked SHA1 correctly, it needs the original DigestAlgoInSignature. The only call site is in poc's verification code.
\| * \| \| \| \| \| \| \| \|	tor-netdoc: Fix signature of hash_slice_for_verification (pre-fmt)	Ian Jackson	2026-04-29	1	-1/+4
\| \| \| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \| \| \|	tor-netdoc: Abolish poc's netstatus signature type	Ian Jackson	2026-04-29	3	-173/+19
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Use prod's Signature instead. This gets rid of: * The old parsing code. We have a new approach based on ItemValueParseable, KeywordOrString and and DigestAlgoInSignature. * The duplicate DirectorySignaturesHashesAccu and its temporary conversions. poc's verify_timeless function needs a little adjustment for the new struct layout.
\| * \| \| \| \| \| \| \| \|	tor-netdoc: Promote hash_slice_for_verification to prod	Ian Jackson	2026-04-29	2	-13/+13
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This function is not right, yet. We're going to fix it later. Review with --color-moved.
\| * \| \| \| \| \| \| \| \|	tor-netdoc: impl SignatureItemParseable for netstatus::Signature	Ian Jackson	2026-04-29	1	-1/+14
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This is now pretty straightforward. The functions it calls need some work - we have blocking TODOs for that.
\| * \| \| \| \| \| \| \| \|	tor-netdoc: Introduce DirectorySignaturesHashesAccu::update_from	Ian Jackson	2026-04-29	2	-16/+53
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This now contains the hashing code that was in poc. In poc it was entangled with the signature type, mostly because once upon a time the hash was inside the signature. In the real code we can make it a standalone method. It takes DigestAlgoInSignature so that it will be able to handle the explicit vs implicit sha1 anomaly correctly - but it can't do that yet because the necessary field doesn't exist yet. Also, we are going to want to make it a bit lazier - preserve the MR-blocking todo for that. A handful of lines are being actually moved verbatim, so --color-moved may help a bit.