| Commit message (Collapse) | Author | Age | Files | Lines |
| ... | |
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
"Regular" is confusing, especially since in American English it tends
to mean "usual" - whereas, there are no orderly signatures in Tor
netdocs.
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | | |
I have been losing my way in this file a lot. This may help.
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
This could allow users to attach and detach signatures, hash (only)
the body part, etc.
|
| | | | |
| | | |
| | | |
| | | | |
Such an impl is a footgun. Explain this in docs & comments.
|
| | | | |
| | | |
| | | |
| | | | |
(pre-fmt)
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
We want to stop deriving NetdocParseable directly for body structs.
This test case does in fact parse a signed authcert and extract just
the body without verifying the signatures. That's fine in a test, but
we're going to make it involve some hoop-jumping. So, jump those
hoops.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
We want to stop deriving NetdocParseable directly for body structs.
Doing so reveals a call site here in tor-dirmirror where a consensus
is parsed and the body data used, but without verifying the
signatures.
Do this explicitly with the hoop-jumping which is going to become
deliberately unavoidable. Add a TODO comment because I'm not sure we
have decided explicitloy that this is OK.
|
| | | | |
| | | |
| | | |
| | | | |
Formatting changes which make the next commit more readable.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Replace the two separate NetdocParseable and NetdocUnverified derives,
for toplevel signed documents, with a single derive.
This makes the derive API simpler. It will also make it reasonably
possible to avoid deriving NetdocParseable directly for body structs.
Such impls are a security hazard!
In detail:
* Rename NetdocUnverified to NetdocParseableUnverified
* Have it use $IMPL_NETDOC_PARSEABLE from the NetdocParseable deftly
module so that it derives NetdocParseable for the body.
(We'll change this later in the series.)
* Adjust the docs and all call sites.
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
We are going to want to reuse this parsing implementation in another
top-level deftly template.
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
Run rustfmt and selectively apply the hunks that are relevant to the
previous commit.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
During encoding, including these hashes in the signature items makes
no sense. The hashes are an *input* to the signature items, but not
part of them.
Move the hashes out of the items. Instead, provide each signatures
section type with a hash accumulator type, in which the hash(es) are
stored.
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
Nonfunctional and formatting changes which reduce noise in the next
commit.
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | | |
This is going to contain body information, and the hashes, too.
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This is going to be its own trait and it is usually best if macros are
named after traits, rather than having the macro derive a different
trait depending on meta attributes.
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
We're going to want this for cases where the hash computation
machinery didn't DTRT.
|
| | | | |
| | | |
| | | |
| | | | |
We're going to want this for sets of netdoc signature hashes.
|
| | | | |
| | | |
| | | |
| | | | |
For reuse when we split up the NetdocParseable derive.
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | | |
But, all signatures in the current protocol are irregular :-/.
|
| |/ / / |
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
chanmgr: Add a list of unauthenticated channels
See merge request tpo/core/arti!3790
|
| | | | |
| | | |
| | | |
| | | | |
Signed-off-by: David Goulet <[email protected]>
|
| | | | |
| | | |
| | | |
| | | | |
Signed-off-by: David Goulet <[email protected]>
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Put channel without relay identities in the unauth_channels list.
Signed-off-by: David Goulet <[email protected]>
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Needed to handle client/bridge -> relay channels which are not
authenticated meaning they don't have a RelayIds so they can't be put in
the ListByRelayIds<>.
Feature gate it to "relay" as a client will never have those kind of
channels.
Signed-off-by: David Goulet <[email protected]>
|
| |\ \ \ \
| |/ / /
|/| | |
| | | |
| | | | |
arti-extra build: enable everything in full and experimental
See merge request tpo/core/arti!3759
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Including these would introduce flakiness, until arti#2400 is resolved.
This also adds a general mechanism for omitting specific features in the
arti-extra build.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Previously we enabled features piecemeal to avoid enabling `rpc`, which
resulted in breakage when running under shadow. Experimentally, this
appears to no longer be the case.
Enabling everything in `full` and `experimental` gives us at least a
little bit of testing of those features (that they don't break the build
or other usage), even if we don't specifically exercise them (yet) in
the CI tests.
|
| |\ \ \ \
| |/ / /
|/| | |
| | | |
| | | | |
Http connect outbound rebased
See merge request tpo/core/arti!3789
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
chutney test: include arti-extra bin
See merge request tpo/core/arti!3772
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Test the arti-extra bin, which includes most of `full` and
`experimental` features, too.
|
| | | | | | |
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The default has been increased to 300, so there's no need to override it
here.
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This will give us a bit more flexibility, e.g. to pass additional
arguments.
Now that the python linters understand it, we fix some linting issues.
We preserve the ability to run the test on other networks by making the
Config.network optional. The new default of `None` means to use the
built-in module to create the network.
The functionality of the test itself is the same.
|
| |\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
tor-dirclient: Support for extra-info requests
See merge request tpo/core/arti!3764
|