summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | | chutney test setup: fix override for arti-bench-binJim Newsome2026-03-091-1/+1
| | |_|/ / | |/| | | | | | | | | | | | | | | | | | We were accidentally using the arti-bin command-line arg to also override arti-bench-bin.
* | | | | Merge branch 'keymgr-test-cleanup' into 'main'David Goulet2026-03-101-212/+182
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | keymgr: Test helper cleanup See merge request tpo/core/arti!3761
| * | | | keymgr: Remove unnecessary TestItem building (fmt)Gabriela Moldovan2026-03-101-1/+4
| | | | |
| * | | | keymgr: Remove unnecessary TestItem buildingGabriela Moldovan2026-03-101-4/+1
| | | | |
| * | | | keymgr: Remove unnecessary parenthesesGabriela Moldovan2026-03-101-1/+1
| | | | | | | | | | | | | | | | | | | | Resolves a clippy warning.
| * | | | keymgr: Replace .find(...).is_some() with .any() (fmt)Gabriela Moldovan2026-03-101-9/+4
| | | | |
| * | | | keymgr: Replace .find(...).is_some() with .any()Gabriela Moldovan2026-03-101-3/+2
| | | | | | | | | | | | | | | | | | | | Resolves a clippy warning.
| * | | | keymgr: Replace Result<> with type alias (fmt)Gabriela Moldovan2026-03-101-5/+5
| | | | |
| * | | | keymgr: Replace match with if letGabriela Moldovan2026-03-101-4/+1
| | | | | | | | | | | | | | | | | | | | As suggested by clippy
| * | | | keymgr: Replace Result<> with type alias (fmt)Gabriela Moldovan2026-03-101-3/+5
| | | | |
| * | | | keymgr: Replace Result<> with type aliasGabriela Moldovan2026-03-101-1/+1
| | | | |
| * | | | keymgr: Remove unnecessary type annotationGabriela Moldovan2026-03-101-4/+1
| | | | |
| * | | | keymgr: Replace macro-generated Keystore impls with a single Keystore type (fmt)Gabriela Moldovan2026-03-101-162/+156
| | | | |
| * | | | keymgr: Replace macro-generated Keystore impls with a single Keystore typeGabriela Moldovan2026-03-101-33/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This doesn't really need to be macro-generated, because these impls only differ in the `KeystoreId`. The code is intentionally misindented to make reviewing the diff a bit easier. A future commit will reformat it all.
| * | | | keymgr: Move unrecognized entry building logic out of macro (fmt)Gabriela Moldovan2026-03-101-22/+14
| | | | |
| * | | | keymgr: Move unrecognized entry building logic out of macroGabriela Moldovan2026-03-101-29/+34
| | |/ / | |/| | | | | | | | | | | | | | I am about to remove this macro altogether and simplify the keystore impls, so I am preemptively moving this into a separate function.
* | | | Merge branch 'chutney-finish-test-to-py' into 'main'Jim Newsome2026-03-096-135/+170
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | chutney test: finish converting to python See merge request tpo/core/arti!3756
| * | | | chutney scripts: opt into strict typecheckingJim Newsome2026-03-092-1/+7
| | | | |
| * | | | chutney setup: no longer dump shell snippetJim Newsome2026-03-091-13/+0
| | | | | | | | | | | | | | | | | | | | Everything now uses the json version, instead.
| * | | | chutney teardown: convert from shell to pythonJim Newsome2026-03-091-10/+15
| | | | |
| * | | | chutney integration-e2e: convert from shell to pythonJim Newsome2026-03-091-7/+16
| | | | |
| * | | | chutney integration-e2e-shadow: redirect stderr to stdoutJim Newsome2026-03-092-2/+8
| | | | | | | | | | | | | | | | | | | | | | | | | No particular need to separate them, and the merged version is easier to follow.
| * | | | chutney test: use unittest frameworkJim Newsome2026-03-091-103/+125
|/ / / / | | | | | | | | | | | | | | | | | | | | This organizes the code a bit better and gives nicer output. It also separates individual test cases and subcases, continuing to try to complete other tests when one fails instead of exiting.
* | | | Merge branch 'dirmirror-fsm' into 'main'Clara Engler2026-03-0919-1540/+3558
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | tor-dirserver: FSM Migration See merge request tpo/core/arti!3664
| * | | tor-dirserver: Require AuthCerts to make progressClara Engler2026-03-091-37/+54
| | | | | | | | | | | | | | | | | | | | | | | | This commit changes the functionality of the AuthCerts state to only report a success when at least a single certificate was included in the response.
| * | | tor-dirserver: Add retry logic POC TODOClara Engler2026-03-091-0/+4
| | | | | | | | | | | | | | | | | | | | Adds a small TODO with regard to a potentially broken retry logic in the proof-of-concept.
| * | | tor-dirserver: SQL comment for unsigned hashesClara Engler2026-03-091-0/+11
| | | | | | | | | | | | | | | | | | | | This commit documents why and how we use the `unsigned_` fields in the `consensus_router_descriptor_member` table alongside SQL limitations.
| * | | tor-dirserver: Move POC to own moduleClara Engler2026-03-092-73/+91
| | | | | | | | | | | | | | | | | | | | This commit moves dirserver POC code to an own module to semantically indicate it is not production ready.
| * | | tor-dirserver: Document stream dropClara Engler2026-03-091-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | This commit documents why we drop the HTTP TCP stream and why this is fine, namely because this is compliant HTTP/1.0 behavior where there is no connection reuse.
| * | | tor-dirserver: Link to discussion regarding TODOClara Engler2026-03-091-0/+3
| | | | | | | | | | | | | | | | | | | | This commit links the discussion for the TODO for the dirmirror's handling of forward compatibility with netdocs.
| * | | parse2: Add TODO for netstatus traitClara Engler2026-03-091-0/+5
| | | | | | | | | | | | | | | | | | | | This commit adds a TODO to implement a trait combining the common fields in a network status documents.
| * | | tor-dirserver: Use collect instead of mutable forClara Engler2026-03-091-18/+9
| | | |
| * | | tor-dirserver: Remove fiddly SQL CHECKClara Engler2026-03-091-5/+1
| | | |
| * | | tor-dirserver: Use tor-llcrypto for digestsClara Engler2026-03-093-10/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit replaces the uses of sha1, sha2, and sha3 with their respective pedants from tor-llcrypto for better consistency. Internally, they still use the same logic and underlying crates but let's use this encapsulation nonetheless.
| * | | tor-dirserver: Improve hash wrapper macro docsClara Engler2026-03-091-0/+19
| | | |
| * | | tor-dirserver: Move schema to own fileClara Engler2026-03-092-170/+167
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit moves the database schema into schema_v1.sql and uses include_str to include it. For now, the schema lives in the `src/` directory. If this becomes a problem because we get more schemas and schema upgrades, we can move it into another sub directory, but let's not overengineer the hierarchy there.
| * | | tor-dirserver: PoC for FSM main loopClara Engler2026-03-091-2/+73
| | | | | | | | | | | | | | | | | | | | This commit implements a PoC serving as the main loop for the FSM, demonstrating how invocation and error handling works.
| * | | tor-dirserver: TODO a torspec DoS issueClara Engler2026-03-091-0/+9
| | | | | | | | | | | | | | | | Discussed with nickm on IRC, there will be a torspec issue soon.
| * | | tor-dirserver: Implement `State::AuthCerts`Clara Engler2026-03-093-7/+986
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit implements the logic required for retrieving, validating, and storing authority certificates. The implementation determines the missing certificates by looking at the signatories of the unvalidated consensus and checking them in the db. Afterwards, they will be queried and individually filtered and verified before being inserted into the database. A return of this implementation notably DOES NOT imply all missing certificates have been downloaded. This was chosen for a simplified retry logic.
| * | | tor-dirserver: Add `StaticEngine::send_request()`Clara Engler2026-03-092-47/+104
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit adds a new method to static engine that serves as a convenience wrapper around `tor_dirclient::send_request`. The reason for that is, that fetch_consensus is not the only method that requires performing download requests, so it makes sense to generalize it. Besides, it also adds support for parsing multiple netdocs alongside storing their raw variant, which is required for inserting them into the database at one point eventually.
| * | | tor-dirserver: Add IsFatal traitClara Engler2026-03-092-19/+24
| | | | | | | | | | | | | | | | | | | | This commit adds the IsFatal trait to the err module for having a generic signature for the fatality of certain error variants.
| * | | tor-dirservert: Implement FetchConsensus stateClara Engler2026-03-092-2/+167
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit implements the `FetchConsensus` state by adding a method to `StaticEngine` called `fetch_consensus`, which retrieves the consensus from an upstream directory authority. Likewise, it also implements a new error type called `AuthorityRequestError`. The retry logic is handled externally which will be done in later commits.
| * | | tor-dirserver: Derive PartialEq and Eq for StateClara Engler2026-03-091-2/+2
| | | | | | | | | | | | | | | | Required to test state transitions properly.
| * | | tor-dirserver: PreferredRuntime in StaticEngineClara Engler2026-03-091-2/+9
| | | | | | | | | | | | | | | | This is required for compatibility with other crates in arti.
| * | | tor-dirserver: Remove unused error variantsClara Engler2026-03-091-62/+0
| | | |
| * | | tor-dirserver: Remove download moduleClara Engler2026-03-092-367/+0
| | | | | | | | | | | | | | | | | | | | This commit removes the download manager module because it does not fit well into the mental model of our current finite state machine anymore.
| * | | tor-dirserver: Remove `preferred` from dataClara Engler2026-03-091-9/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit removes the `preferred` member field from the `Unverified` and `Verified` variant in `ConsensusBoundData` while adding it as a parameter to `StaticEngine::execute`, with the idea being that the retry logic is handled by the caller anyways, involving the selection of authorities. Right now, I am still a bit unsure how this will play out.
| * | | tor-dirserver: Fix rustdoc commentsClara Engler2026-03-092-5/+5
| | | |
| * | | tor-dirserver: Implement consensus loadingClara Engler2026-03-092-16/+347
| | | | | | | | | | | | | | | | | | | | | | | | This commit implements the consensus loading mechanism by glueing together the logic from the database module with regard to querying missing descriptors.
| * | | tor-dirserver: Query missing descriptor logicClara Engler2026-03-099-1/+656
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit implements the logic for querying missing descriptors by adding three new methods to ConsensusMeta: * missing_servers * missing_extras * missing_micros All of them essentially work the same, namely by querying the consensus_router_descriptor_member database table alongside the docid of the current consensus, left joining the respective router_descriptor and returning the digests on all rows where the left join resulteed in a NULL. A small exception are extra-info descriptors. There, we can only return the ones where we have an accompanying server descriptor, hence why we perform an inner join with the server descriptors between the from and the left join.