| Commit message (Collapse) | Author | Age | Files | Lines |
| ... | |
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Closes #2418.
Fixes TROVE-2026-005, where we would use a less cryptographically
secure (and probably less DoS resistant) hash function for these
tables if:
- We are built alongside another crate that uses `weak-table`
- That crate enables the `weak-table/ahash` feature.
- We are running on a system without hardware AES.
Severity: Low
|
| |\ \
| | |
| | |
| | |
| | | |
arti-relay: Change a 'debug' log to 'info'
See merge request tpo/core/arti!3803
|
| |/ /
| |
| |
| |
| | |
I had intended for this to be 'info' in f287ec7910, but must have
accidentally wrote 'debug'.
|
| |\ \
| |/
|/|
| |
| | |
Fix typos
See merge request tpo/core/arti!3792
|
| |/
|
|
| |
Typos found with codespell
|
| |\
| |
| |
| |
| | |
RPC: C/Python wrappers and integration tests for nonblocking and polling IO
See merge request tpo/core/arti!3771
|
| | | |
|
| | | |
|
| | |
| |
| |
| |
| | |
This provides an API and tests for create_polling(), poll(), and
related APIs.
|
| | |
| |
| |
| |
| |
| |
| | |
These wrappers present a "pythonic" API to the C functions for
submit and wait.
Tests included.
|
| | |
| |
| |
| |
| | |
These are low-level wrappers that let us call the relevant C code,
but are not suitable for general use.
|
| | | |
|
| | |
| |
| |
| |
| | |
This commit adds FFI wrappers for the "poll" API, which lets the
user integrate with a poll(2)-style event loop.
|
| |/
|
|
|
|
| |
This commit adds wrappers for the "submit/wait" methods on RpcConn
(which are used to submit tagged requests,
and then wait for responses to all tagged requests at once).
|
| |\
| |
| |
| |
| |
| |
| | |
proto: Replace TimeoutEstimator with opaque handler
Closes #2410
See merge request tpo/core/arti!3794
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This replaces the client-specific half-stream expiry calculation from
the stream reactor (which is meant to be implementation agnostic) with a
call to the new `StreamHandler::halfstream_expiry()`, which abstracts
away the implementation-specific half-stream expiry calculation (for
example, on the client-side, the calculation takes into account the CBT,
which we don't have on the relay side).
Note that there is currently no `StreamHandler` implementation on the
client-side (because we haven't ported the client circuit reactor to the
new reactor yet).
Closes #2410
|
| | | |
|
| | |
| |
| |
| |
| | |
This will enable us to handle half-stream expiry differently on the
client side vs the exit side.
|
| |\ \
| | |
| | |
| | |
| | | |
Bump to latest webpki (0.103.10) to resolve RUSTSEC-2026-0049
See merge request tpo/core/arti!3798
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
Advisory at https://rustsec.org/advisories/RUSTSEC-2026-0049
This issue doesn't affect Arti itself, since Arti doesn't actually
_use_ regular X.509 CAs or CRLs.
|
| |\ \ \
| |/ /
|/| |
| | |
| | | |
cell, proto, cert: Simplify CERTS cell building.
See merge request tpo/core/arti!3795
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Formerly we required the caller for push_cert_body to specify the
type of the cert that they were pushing. But in nearly every case,
the certificate object that the caller is holding knows what its
own type is! This makes the tor_proto build_certs_cell function
a bit less error-prone, since we don't have to worry about mismatch.
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
proto: Remove unnecessary test-gating
See merge request tpo/core/arti!3796
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
`test_utils` is not exposed outside of `tor-proto`, so the feature
gating here isn't needed (we typically use the `testing` feature for
exposing testing utilities outside the current crate, but that's not the
case here).
|
| | | |/
| |/|
| | |
| | |
| | | |
The `test_util` modules is already gated behind
`#[cfg(any(test, feature = "testing"))]`.
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
retry-error: Allow dedup_by to merge ranges
See merge request tpo/core/arti!3784
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Spotted during review by gabi-250 in another test.
Signed-off-by: Tobias Stoeckmann <[email protected]>
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
With the newly introduced count function, extend_from_retry_error can be
simplified by spliting n_errors calculation from new_attempt creation.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The dedup_by function grows the "last_attempt" always by one, even if a
range is encountered. A mergeable range can be encountered if the
RetryError has been extended by another RetryError already containing a
range.
Take this special case into account by using the actual amount of
failures of the attempt when growing.
Signed-off-by: Tobias Stoeckmann <[email protected]>
|
| | | | |
| | | |
| | | |
| | | | |
The function argument is named same_err, not dedup.
|
| |\ \ \ \
| |_|_|/
|/| | |
| | | |
| | | |
| | | |
| | | | |
proto: Fix channel responder expecting a peer certificate
Closes #2388
See merge request tpo/core/arti!3791
|
| | | | |
| | | |
| | | |
| | | | |
Signed-off-by: David Goulet <[email protected]>
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
In other words kp_relaysign_ed.
Signed-off-by: David Goulet <[email protected]>
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
As a responder, we should check the AUTHENTICATE auth type and make sure
we support it. We were not doing that, we were simply putting in our max
version.
Signed-off-by: David Goulet <[email protected]>
|
| | | | |
| | | |
| | | |
| | | | |
Signed-off-by: David Goulet <[email protected]>
|
| | | | |
| | | |
| | | |
| | | | |
Signed-off-by: David Goulet <[email protected]>
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Proper error to use and better code to use checked_sub().
Signed-off-by: David Goulet <[email protected]>
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The AUTHENTICATE cell contents depends on all bytes sent on the channel
before the AUTHENTICATE cell itself is sent (the CLOG). So we can only
build a correct AUTHENTICATE cell after the CERTS cell has been sent.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Remove the is_equal_no_sig() and instead add a getter that returns a
reference to the body without the random part so it can be used to
verify the signature.
The caller now checks the equality with what it is expected.
Signed-off-by: David Goulet <[email protected]>
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This fixes two things.
1. The "is_equal_no_sig()", if true, was going into the error path.
2. The signature verification is done against the body of the
AUTHENTICATE cell that is all fields except the signature.
Next commit will change the is_equal_no_sig() to make more sense with
the "body" semantic.
Signed-off-by: David Goulet <[email protected]>
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
It used to work for an initiator to set the link protocol once a
VERSIONS is received because initiator send their VERSIONS before. This
failed with responders because a responder channel sends their VERSIONS
after receiving one from the initiator.
This reverse logic means that the channel cell handler was transitionned
to the Handshake state before a responder was able to send a VERSIONS
cell leading to a failure because VERSIONS cell aren't allowed at the
Handshake state.
To fix this, the send/recv or recv/send is now explicit per channel type
and once this is done and successful, the link protocol is set. A
`set_link_protocol()` is added to the ChannelBaseHandshake trait so it
can be used to set the cell handler.
Signed-off-by: David Goulet <[email protected]>
|
| | | | |
| | | |
| | | |
| | | | |
Signed-off-by: David Goulet <[email protected]>
|
| | | | |
| | | |
| | | |
| | | | |
Signed-off-by: David Goulet <[email protected]>
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
No initiator present a TLS certificate and so don't try to get one.
Fixes #2388
Signed-off-by: David Goulet <[email protected]>
|