summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | | | | | | Merge branch 'nd-test' into 'main'Ian Jackson2025-11-253-17/+23
|\ \ \ \ \ \ \ \ \ \ | |_|_|_|/ / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | tor-netdoc: Move parse2/test.rs to test2.rs See merge request tpo/core/arti!3486
| * | | | | | | | | tor-netdoc: test2: Run rustfmtIan Jackson2025-11-241-10/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Tidy up the imports.
| * | | | | | | | | tor-netdoc: test2: Adjust type aliasesIan Jackson2025-11-241-14/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now that this module is not inside parse2 its identifier namespace oughtn't to be parse-specific. Rename things so that every imports/aliases related to parsing implies parsing in its name.
| * | | | | | | | | tor-netdoc: Move parse2/test.rs to test2.rsIan Jackson2025-11-243-7/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We're going to use this for the encoder testing too, so it needs to be not buried inside parse2. This commit is the file rename plus minimal changes to make it compile.
* | | | | | | | | | Merge branch 'intro-dos' into 'main'gabi-2502025-11-252-1/+22
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | arti: Add rate_limit_at_intro to the example config See merge request tpo/core/arti!3493
| * | | | | | | | | | arti: Clarify that the "burst" is not per second.Gabriela Moldovan2025-11-251-1/+1
| | | | | | | | | | |
| * | | | | | | | | | arti: Add rate_limit_at_intro to the example configGabriela Moldovan2025-11-251-0/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is mostly c&p from the `rate_limit_at_intro` docs, I just added an extra paragraph to clarify the meaning of the tuple elements (i.e. `(rate, burst)`).
| * | | | | | | | | | hsservice: Fix typo in rate_limit_at_intro docsGabriela Moldovan2025-11-251-1/+1
| | | | | | | | | | |
* | | | | | | | | | | Merge branch 'max-concurrent-streams' into 'main'Nick Mathewson2025-11-252-0/+10
|\ \ \ \ \ \ \ \ \ \ \ | |/ / / / / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | hsservice: Clarify what max_concurrent_streams_per_circuit does See merge request tpo/core/arti!3492
| * | | | | | | | | | hsservice: Clarify what max_concurrent_streams_per_circuit doesGabriela Moldovan2025-11-252-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | At first glance, this might seem equivalent to C Tor's `HiddenServiceMaxStreams` option, but it's actually `HiddenServiceMaxStreamsCloseCircuit` (Arti doesn't implement the former).
* | | | | | | | | | | Merge branch 'p2-mult' into 'main'Ian Jackson2025-11-255-70/+56
|\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | tor-netdoc: parse2: Combine MultiplicitySelector See merge request tpo/core/arti!3478
| * | | | | | | | | | | tor-netdoc: Add a comment explaining why P2MultiplicitySelectorIan Jackson2025-11-241-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | as per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/3478#note_3291482 encode::MultiplicitySelector doesn't actually exist yet in this branch, but it will do. Don't mention that fact as we'll probably just forget to update this comment...
| * | | | | | | | | | | semver.md: Document change to parse2::MultiplicitySelectorIan Jackson2025-11-241-0/+1
| | | | | | | | | | | |
| * | | | | | | | | | | tor-netdoc: rustfmt to tidy up importsIan Jackson2025-11-192-5/+2
| | | | | | | | | | | |
| * | | | | | | | | | | tor-netdoc: avoid importing MultiplicitySelector outside parse2Ian Jackson2025-11-191-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The encoder is going to need to have a different MultiplicitySelector (just because of different variance, really) so we mustn't import it under this name.
| * | | | | | | | | | | tor-netdoc: parse2: Combine all the multiplicity SelectorsIan Jackson2025-11-194-53/+38
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There is no conflict between the different uses. Having just one type makes things simpler.
| * | | | | | | | | | | tor-netdoc: parse2: Move multiplicity docs examples into Methods traitsIan Jackson2025-11-191-32/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We're going to combine all the Selector types, so it won't be able to have these. The diff is misleading: it's docs for the Selectors that's moving.
* | | | | | | | | | | | Merge branch 'fix-shadow-test-hosts' into 'main'gabi-2502025-11-251-1/+1
|\ \ \ \ \ \ \ \ \ \ \ \ | |_|_|_|_|/ / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | tests: Fix error in shadow checking script. See merge request tpo/core/arti!3490
| * | | | | | | | | | | tests: Fix error in shadow checking script.Wesley Aptekar-Cassels2025-11-241-1/+1
| | |_|_|/ / / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | articlient-onion-auth was included twice on this list. From looking at 9ad23705e4, where the second instance was introduced, it seems that this was meant to be articlient-onion-artiserver-auth.
* | | | | | | | | | | Merge branch 'hsc-doc-fixes' into 'main'gabi-2502025-11-241-33/+51
|\ \ \ \ \ \ \ \ \ \ \ | | |_|/ / / / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | doc/hsc.md: An assortment of fixes and clarifications See merge request tpo/core/arti!3485
| * | | | | | | | | | doc/hsc.md: Add clarification about KeystoreIdsIan Jackson2025-11-241-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Applies @Dizet's suggestion from https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/3485#note_3291709
| * | | | | | | | | | doc/hsc.md: Use toml block for config exampleGabriela Moldovan2025-11-241-1/+1
| | | | | | | | | | |
| * | | | | | | | | | doc/hsc.md: Remove note about invalid keystoresGabriela Moldovan2025-11-241-7/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I don't think we need to tell users a C Tor keystore cannot have more than one client entry for the same onion service, because they already know that: C Tor doesn't allow it, so if they are migrating an existing C Tor configuration, it will likely be valid. And if not, the error message will inform them what went wrong. So I am removing this section in the interest in keeping this guide short and sweet and straight to the point.
| * | | | | | | | | | doc/hsc.md: Warn against running tor/arti during the migrationGabriela Moldovan2025-11-241-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is analogous to the warning from `doc/hss.md`.
| * | | | | | | | | | doc/hsc.md: s/ctor-keystore-id/ctor-clientGabriela Moldovan2025-11-241-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Otherwise users might think it's idiomatic/necessary to add the `-id` suffix to their keystore identifiers.
| * | | | | | | | | | doc/hsc.md: Rephrase section about --batchGabriela Moldovan2025-11-241-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This makes the language more consistent with the `hss ctor-migrate` docs.
| * | | | | | | | | | doc/hsc.md: Add missing text before example invocationGabriela Moldovan2025-11-241-0/+2
| | | | | | | | | | |
| * | | | | | | | | | doc/hsc.md: Say keystore identifiers must be uniqueGabriela Moldovan2025-11-241-0/+3
| | | | | | | | | | |
| * | | | | | | | | | doc/hsc.md: Add comments to the config exampleGabriela Moldovan2025-11-241-0/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This should help clarify what each of those options means. It's also consistent with the analogous example from `doc/hss.md`.
| * | | | | | | | | | doc/hsc.md: Remove config from usage exampleGabriela Moldovan2025-11-241-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There's no need to pass a config file when using `-o`.
| * | | | | | | | | | doc/hsc.md: Rewrite usage section for better readabilityGabriela Moldovan2025-11-241-5/+3
| | | | | | | | | | |
| * | | | | | | | | | doc/hsc.md: Move warning higher up in the documentGabriela Moldovan2025-11-241-12/+12
| | | | | | | | | | |
| * | | | | | | | | | doc/hsc.md: Add a more user-friendly introGabriela Moldovan2025-11-241-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This a bit more user-friendly, because not all users will know what "a registered C Tor keystore is". It's also more consistent with the style from the `hss ctor-migrate` docs (for migrating service keys).
| * | | | | | | | | | doc/hsc.md: Use gerund in headingsGabriela Moldovan2025-11-241-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For consistency with the other headings.
* | | | | | | | | | | Merge branch 'end_reason_handling' into 'main'Nick Mathewson2025-11-241-1/+38
|\ \ \ \ \ \ \ \ \ \ \ | |_|/ / / / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | http-connect: use end reason for http status if possible See merge request tpo/core/arti!3481
| * | | | | | | | | | http-connect: use end reason for http status if possibleNick Mathewson2025-11-241-1/+38
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The spec includes a direct conversion from END reason fields to HTTP status codes, so we should follow it if we have an END reason.
* | | | | | | | | | | Merge branch 'otel-more-spans' into 'main'wesleyac2025-11-2441-20/+196
|\ \ \ \ \ \ \ \ \ \ \ | |_|_|_|_|_|_|_|_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | opentelemetry: Instrument a bunch of functions. See merge request tpo/core/arti!3403
| * | | | | | | | | | opentelemetry: Instrument a bunch of functions.Wesley Aptekar-Cassels2025-11-2441-20/+196
|/ / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These are all aimed at figuring out in more detail what's going on in #2079 and related issues.
* | | | | | | | | | Merge branch 'bug2172' into 'main'Nick Mathewson2025-11-243-3/+3
|\ \ \ \ \ \ \ \ \ \ | |_|/ / / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | tor-llcrypto: Stop deriving Deref in CtByteArray Closes #2172 See merge request tpo/core/arti!3432
| * | | | | | | | | tor-llcrypto: Stop deriving Deref in CtByteArrayNeel Chauhan2025-11-243-3/+3
| | |_|_|_|_|_|_|/ | |/| | | | | | |
* | | | | | | | | Merge branch '2213-hsc-ctor-migrate' into 'main'gabi-2502025-11-2425-12/+222
|\ \ \ \ \ \ \ \ \ | |_|_|_|/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add `hsc key ctor-migrate` subcommand Closes #2213 See merge request tpo/core/arti!3390
| * | | | | | | | Add `hsc key ctor-migrate` subcommandhjrgrn2025-11-2425-12/+222
|/ / / / / / / /
* | | | | | | | Merge branch 'hashx-lint' into 'main'opara2025-11-201-0/+1
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | hashx: Gate as_u8() behind the compiler feature See merge request tpo/core/arti!3483
| * | | | | | | | hashx: Gate as_u8() behind the compiler featureGabriela Moldovan2025-11-201-0/+1
|/ / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This resolves a dead code warning when building without the `compiler` feature: ``` warning: method `as_u8` is never used --> crates/hashx/src/register.rs:39:19 | 27 | impl RegisterId { | --------------- method in this implementation ... 39 | pub(crate) fn as_u8(&self) -> u8 { | ^^^^^ | = note: `#[warn(dead_code)]` on by default ```
* | | | | | | | Merge branch 'readd-error-deduping' into 'main'Ian Jackson2025-11-202-23/+16
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Revert "retry-error: stop trying to dedup error msgs" See merge request tpo/core/arti!3474
| * | | | | | | | retry-error: add comment in `fmt_error_with_sources`Steven Engler2025-11-181-0/+4
| | | | | | | | |
| * | | | | | | | Revert "retry-error: stop trying to dedup error msgs"Steven Engler2025-11-182-23/+12
| | |_|_|/ / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit e0efb477df868baf09d37de99e8e346136e66140. There wasn't a consensus on this change, so sticking with the status quo.
* | | | | | | | Merge branch 'hsonly' into 'main'Nick Mathewson2025-11-191-0/+1
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | tor-circmgr: Fix incorrect match on `HsOnly` See merge request tpo/core/arti!3482
| * | | | | | | | tor-circmgr: fix incorrect match on `HsOnly`Steven Engler2025-11-191-0/+1
|/ / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rust was treating this as a wildcard match if the `hs-common` feature wasn't enabled. This shouldn't have caused any bugs since the other match arms were already exhaustive, but this could have lead to a bug if new enum variants were added to `SupportedTunnelUsage`. ```text warning: variable `HsOnly` should have a snake case name --> crates/tor-circmgr/src/usage.rs:600:13 | 600 | HsOnly => { | ^^^^^^ help: convert the identifier to snake case: `hs_only` | = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default warning: `tor-circmgr` (lib) generated 1 warning ```
* | | | | | | | Merge branch 'relay-split-channels' into 'main'David Goulet2025-11-198-319/+577
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | proto: Split UnverifiedChannel and VerifiedChannel into client/relay module See merge request tpo/core/arti!3401