summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | tor-circmgr: put vegas cc in `CircParameters` behind `if false`Steven Engler2025-04-232-22/+55
| | | | | | | | | | | | | | | | | | | | | | | | | This means that even with the "flowctl-cc" feature enabled, we shouldn't try to negotiate congestion control.
| * | | | tor-circmgr: only use congestion control if "flowctl-cc" feature is enabledSteven Engler2025-04-232-3/+7
| | | | |
| * | | | tor-proto: only use congestion control if "flowctl-cc" feature is enabledSteven Engler2025-04-235-19/+46
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Congestion control is not completely working correctly, and is not fully implemented (XON/XOFF). This commit adds a new experimental "flowctl-cc" feature to enable the congestion control extension during the ntor-v3 handshake.
| * | | | tor-proto: expand docs for `CongestionWindowParams::set_sendme_inc`Steven Engler2025-04-231-1/+5
| | | | |
| * | | | tor-circmgr: switch from `supports_{known,named}_subver()`Steven Engler2025-04-231-3/+3
| | | | |
| * | | | tor-proto: rename `stream_sendme_required` to `uses_stream_sendme`Steven Engler2025-04-234-9/+9
| | | | |
| * | | | tor-proto: rename `allow_stream_sendme` to `uses_stream_sendme`Steven Engler2025-04-234-10/+10
| | | | | | | | | | | | | | | | | | | | | | | | | We use this method to decide whether to allow receiving stream SENDMEs, and also whether we should send stream SENDMEs.
| * | | | tor-proto: remove redundant `allow_stream_sendme` checkSteven Engler2025-04-231-15/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `OpenStreamEnt::put_for_incoming_sendme()` calls `StreamSendFlowControl::put_for_incoming_sendme()`, which returns an error if the `StreamSendFlowControl` is in XON/XOFF mode. So we don't need this extra check.
| * | | | tor-proto: initialize `StreamSendFlowControl` based on CCSteven Engler2025-04-231-2/+6
| | | | | | | | | | | | | | | | | | | | | | | | | Congestion control tells us whether we should use stream or XON/XOFF flow control.
| * | | | tor-proto: new stream entries now take `StreamSendFlowControl`Steven Engler2025-04-232-15/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously new stream entries required a `StreamSendWindow`, but to support other flow control algorithms, we want new stream entries to take a `StreamSendFlowControl` instead. This also deduplicates the `StreamSendWindow` creation code.
| * | | | tor-proto: add no-op XON/XOFF flow control variantSteven Engler2025-04-231-8/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This doesn't do anything yet, so is effectively like not having stream flow control. This should be implemented as part of arti#534.
| * | | | tests: Add CC ntorv3 negotiation unit testDavid Goulet2025-04-233-10/+86
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Also add one for the sendme_inc validity function. Part of #1817 Signed-off-by: David Goulet <[email protected]>
| * | | | circ: Don't pin CC algorithm to FixedWindow anymoreDavid Goulet2025-04-231-4/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Circuit handshake negotiation for congestion control has been added in previous commit so stop pinning the algorithm. This commit marks the start of congestion control usage by arti client. Closes #1817 Signed-off-by: David Goulet <[email protected]>
| * | | | circ: Don't allow stream level SENDME with CCDavid Goulet2025-04-231-2/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If we ever receive a stream-level SENDME from the Exit while the circuit is under congestion control (Vegas), it is a protocol violation so close the circuit. This is important in order to avoid yet another side channel with cells that would be essentially ignored silently. Part of #1817 Signed-off-by: David Goulet <[email protected]>
| * | | | circ: Don't send stream level SENDME with CCDavid Goulet2025-04-235-7/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This adds a new function to the CongestionControl object that returns true or false on if stream level SENDMEs are allowed by the underlying algorithm. Congestion control Vegas doesn't allow them as in it retires them and so we avoid sending them for that algorithm. Part of #1817 Signed-off-by: David Goulet <[email protected]>
| * | | | tor-proto: added `stream_sendme_required` methodsSteven Engler2025-04-233-0/+23
| | | | | | | | | | | | | | | | | | | | | | | | | These pass through congestion control state to the reactor, and aren't actually hooked up to the congestion control code yet.
| * | | | tor-proto: added accessors for circuit legs/hopsSteven Engler2025-04-232-1/+11
| | | | |
| * | | | circ: Request congestion control with ntorv3 extensionDavid Goulet2025-04-232-5/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This puts in, based on the circuit parameters, the CC extension request in the CREATE and EXTEND requests. Part of #1817 Signed-off-by: David Goulet <[email protected]>
| * | | | circ: Apply possible subprotocol changes to circ paramsDavid Goulet2025-04-232-6/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Congestion control can change the circuit parameters if the relay we are negotiating with doesn't support FlowCtrl=2. This commit adds a function in the circuit builder that will apply any changes to the circuit parameters of the hop based on the hop protocol values. For now, only congestion control applies. Part of #1817 Signed-off-by: David Goulet <[email protected]>
| * | | | circ: Remove CircParameters reference in call stackDavid Goulet2025-04-237-31/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This avoids cloning the object and instead allows us to have a CircParameters per hop on the circuit path. This will come handy with congestion control where each hop might have different congestion control parameters. Part of #1817 Signed-off-by: David Goulet <[email protected]>
| * | | | congestion: Setup a fallback algorithm in the paramsDavid Goulet2025-04-233-1/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | CircParameters is built before path selection and thus once we start building the hops, we can't access the consensus values that were used to build it in the first place. For congestion control, we require a fallback algorithm in case the hop doesn't support FlowCtrl=2. This commit adds a "fallback_alg" to the CC parameters which will be used for this exact case. Part of #1817 Signed-off-by: David Goulet <[email protected]>
| * | | | circ: Set the negotiated CC sendme_inc from handshakeDavid Goulet2025-04-232-7/+70
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When receiving the congestion control response extension, evaluate our state and set the sendme_inc if valid in our circuit parameters. For this, a series of helper functions is needed. Part of #1817 Signed-off-by: David Goulet <[email protected]>
| * | | | circ: Make CircParameters mutable in the call stackDavid Goulet2025-04-233-12/+15
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is required because circuit ntor v3 handshake can negotiate circuit level parameters and thus able to change any values. Needed for congestion control ntorv3 handshake extension for which the sendme increment is negotiated. Part of #1817 Signed-off-by: David Goulet <[email protected]>
* | | | Merge branch 'todos-msrv' into 'main'Jim Newsome2025-04-248-14/+12
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | various crates: MSRV TODO standardization and cleanup of an old TODO See merge request tpo/core/arti!2945
| * | | | tor-consdiff: Replaced an old MSRV TODO with a link to why it shouldn't be donehashcatHitman2025-04-231-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - After spending quite a while trying to figure out why the tests kept failing after making the change, I eventually stumbled upon the netdoc syntax specification, which helpfully informs me that newlines MUST be ignored and discarded. Switching to using [`str::split_inclusive`] would either require extra lines to workaround and recreate the current expected behavior or changing the spec and correcting the tests to align with the new expected behavior.
| * | | | tor-consdiff: standardized MSRV TODOhashcatHitman2025-04-161-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Part of a series of commits aimed at replacing all MSRV-related TODOs with a standardized format, which should be easier to find when the MSRV is bumped. For this one in particular, we actually do already meet the MSRV specified, but I want to check on the implementation details to see if this is still desired, since the TODO is 4 years old.
| * | | | tor-hsservice: standardized MSRV TODOhashcatHitman2025-04-161-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | - Part of a series of commits aimed at replacing all MSRV-related TODOs with a standardized format, which should be easier to find when the MSRV is bumped.
| * | | | tor-memquota: standardized MSRV TODOhashcatHitman2025-04-161-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | - Part of a series of commits aimed at replacing all MSRV-related TODOs with a standardized format, which should be easier to find when the MSRV is bumped.
| * | | | tor-rpc-connect: standardized MSRV TODOhashcatHitman2025-04-161-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | - Part of a series of commits aimed at replacing all MSRV-related TODOs with a standardized format, which should be easier to find when the MSRV is bumped.
| * | | | arti-relay: standardized MSRV TODOhashcatHitman2025-04-161-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | - Part of a series of commits aimed at replacing all MSRV-related TODOs with a standardized format, which should be easier to find when the MSRV is bumped.
| * | | | tor-basic-utils: standardized MSRV TODOshashcatHitman2025-04-162-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | - Part of a series of commits aimed at replacing all MSRV-related TODOs with a standardized format, which should be easier to find when the MSRV is bumped.
| * | | | tor-netdir: remove lint allow as per TODOhashcatHitman2025-04-161-3/+0
| | | | | | | | | | | | | | | | | | | | | | | | | - https://github.com/rust-lang/rust-clippy/issues/11764 was fixed upstream, so this is no longer needed.
* | | | | Merge branch 'remove-note' into 'main'Ian Jackson2025-04-241-1/+0
|\ \ \ \ \ | |_|/ / / |/| | | | | | | | | | | | | | arti-client: Remove incorrect note about `StateDirectory` usage See merge request tpo/core/arti!2952
| * | | | arti-client: remove incorrect note about `StateDirectory` usageSteven Engler2025-04-231-1/+0
|/ / / /
* | | | Merge branch 'chutney-shadow-flakiness' into 'main'Jim Newsome2025-04-232-5/+35
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | integration-e2e-shadow flakiness debugging and workaround See merge request tpo/core/arti!2950
| * | | | integration-e2e-shadow: move simulation seed to yamlJim Newsome2025-04-231-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since this significantly affects the behavior of the simulation, it's probably worth having it in the yaml. (It can of course still be overridden from the command-line).
| * | | | integration-e2e-shadow: move unblocked-syscall-latency to yamlJim Newsome2025-04-231-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since this significantly affects the behavior of the simulation, it's useful to have it in the yaml for reference or if the simulation is manually rerun from the yaml.
| * | | | arti-bench: work around shadow writer shutdown bugJim Newsome2025-04-231-1/+11
| | | | |
| * | | | integration-e2e-shadow: use a larger max_unapplied_cpu_latencyJim Newsome2025-04-231-0/+20
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | This should make the simulation results generally more stable with respect to small perturbations, such as adding logging. It also causes a previous "heisenbug" failure in this test to reliably reproduce in every run.
* | | | Merge branch 'proto_enforce' into 'main'Nick Mathewson2025-04-2239-48/+1666
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Enforce recommended and required protocol versions in arti-client Closes #1849 and #1923 See merge request tpo/core/arti!2929
| * | | | Rename recommended_protocols to protocol_statuses.Nick Mathewson2025-04-166-17/+17
| | | | | | | | | | | | | | | | | | | | | | | | | This name reflects its purpose better than the original one, since it includes required protocols as well as recommended ones.
| * | | | netdoc: Require serde feature from tor-protover.Nick Mathewson2025-04-161-1/+1
| | | | |
| * | | | arti-client: Document spec of checking date on cached protosNick Mathewson2025-04-161-3/+6
| | | | | | | | | | | | | | | | | | | | | | | | | Also move the comment outside the block it documents, to prevent a too-long line.
| * | | | arti-client: On shutdown for missing proto, print to stderrNick Mathewson2025-04-161-1/+17
| | | | | | | | | | | | | | | | | | | | Also wait a little so logs can flush.
| * | | | arti-client README: Document undesirable exit(1) behavior.Nick Mathewson2025-04-161-1/+12
| | | | |
| * | | | netdoc: improve documentation for check_protocolsNick Mathewson2025-04-161-1/+7
| | | | |
| * | | | protover, *: Add documentation about what "supported" means.Nick Mathewson2025-04-167-6/+32
| | | | |
| * | | | protover: Enforce that every unrecognized protocol entry is nonzero.Nick Mathewson2025-04-161-1/+5
| | | | | | | | | | | | | | | | | | | | This rule makes PartialEq more sensible.
| * | | | Fix a pair of documentation links.Nick Mathewson2025-04-161-2/+2
| | | | |
| * | | | dirmgr: Always apply changes before advancing consensus.Nick Mathewson2025-04-161-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In the directory code, we have functionality to advance the consensus download state whenever possible, even if there is more we could download in the current state. That's fine, but when we're in this position, we need to be sure that we're taking any action based on the current state (such as installing notably parameters or, notably, protocol recommendations) before we move on.
generated by cgit v1.2.3 (git 2.46.0) at 2026-08-27 20:58:26 +0000