summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | Produce better error messages from bad field types (fmt)Ian Jackson2025-09-022-4/+16
| | | | | | | | | | | | | | | | | | | | Worsify formatting as demanded by rustfmt.
| * | | | Produce better error messages from bad field typesIan Jackson2025-09-022-0/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | With this change, this diff > --- a/crates/tor-netdoc/src/parse2/poc/netstatus.rs > +++ b/crates/tor-netdoc/src/parse2/poc/netstatus.rs > @@ -24,5 +24,4 @@ pub enum NdaNetworkStatusVersion { > /// `params` value > #[derive(Clone, Debug, Default, Deftly)] > -#[derive_deftly(ItemValueParseable)] > #[non_exhaustive] > pub struct NdiParams { gives the errors below. So the first reported error points to the errant field, albeit with the slightly mendacious phrasing "this call". Previously there was only the 2nd message. Disagnosing that requires hunting through the document struct looking for fields of the right type, which can be seriously awkward when there are type aliases involved as there often are in tor-netdoc. > error[E0277]: the trait bound `parse2::poc::netstatus::NdiParams: parse2::traits::ItemValueParseable` is not satisfied > --> crates/tor-netdoc/src/parse2/poc/netstatus/flavoured.rs:27:10 > | > 27 | #[derive(Deftly, Clone, Debug)] > | ^^^^^^ the trait `parse2::traits::ItemValueParseable` is not implemented for `parse2::poc::netstatus::NdiParams` > ... > 55 | pub params: NdiParams, > | ------ required by a bound introduced by this call > | > = help: the following other types implement trait `parse2::traits::ItemValueParseable`: > () > (T0, T1) > (T0, T1, T2) > (T0, T1, T2, T3) > (T0, T1, T2, T3, T4) > (T0, T1, T2, T3, T4, T5) > (T0, T1, T2, T3, T4, T5, T6) > (T0, T1, T2, T3, T4, T5, T6, T7) > and 16 others > note: required by a bound in `parse2::multiplicity::ItemSetMethods::check_item_value_parseable` > --> crates/tor-netdoc/src/parse2/multiplicity.rs:109:59 > | > 109 | fn check_item_value_parseable(self) where Self::Each: ItemValueParseable {} > | ^^^^^^^^^^^^^^^^^^ required by this bound in `ItemSetMethods::check_item_value_parseable` > > error[E0277]: the trait bound `parse2::poc::netstatus::NdiParams: parse2::traits::ItemValueParseable` is not satisfied > --> crates/tor-netdoc/src/parse2/derive.rs:438:34 > | > 438 | let item = ItemValueParseable::from_unparsed(item)?; > | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `parse2::traits::ItemValueParseable` is not implemented for `parse2::poc::netstatus::NdiParams` > | > ::: crates/tor-netdoc/src/parse2/poc/netstatus/flavoured.rs:27:10 > | > 27 | #[derive(Deftly, Clone, Debug)] > | ------ in this derive macro expansion > | > = help: the following other types implement trait `parse2::traits::ItemValueParseable`: > () > (T0, T1) > (T0, T1, T2) > (T0, T1, T2, T3) > (T0, T1, T2, T3, T4) > (T0, T1, T2, T3, T4, T5) > (T0, T1, T2, T3, T4, T5, T6) > (T0, T1, T2, T3, T4, T5, T6, T7) > and 16 others > = note: this error originates in the macro `derive_deftly_template_NetdocParseable` which comes from the expansion of the derive macro `Deftly` (in Nightly builds, run with -Z macro-backtrace for more info)
| * | | | tor-netdoc: parse2: Bind a `selector` localIan Jackson2025-09-021-1/+2
| | | | | | | | | | | | | | | | | | | | We're going to reuse this.
* | | | | Merge branch 'maybenot-backend' into 'main'Nick Mathewson2025-09-027-2/+1414
|\ \ \ \ \ | |/ / / / |/| | | / | | |_|/ | |/| | Define and implement a backend padding API, based on maybenot. See merge request tpo/core/arti!3185
| * | | padding: document when we set next_scheduled_wakeupNick Mathewson2025-09-021-0/+3
| | | |
| * | | padding: Call hops "target" rather than "final" for clarityNick Mathewson2025-09-021-4/+6
| | | |
| * | | padding: s/can_bypass/is_bypassable/ for clarity.Nick Mathewson2025-09-022-10/+11
| | | |
| * | | padding: Clarify next_expiration vs next_scheduled_wakeupNick Mathewson2025-09-021-4/+9
| | | |
| * | | padding: Several comment/style fixes from @gabi-250Nick Mathewson2025-09-024-8/+11
| | | |
| * | | Define and implement a backend padding API, based on maybenot.Nick Mathewson2025-09-027-2/+1400
| | |/ | |/| | | | | | | | | | | | | | | | | | | There are incomplete pieces, marked with "TODO circpad". There is no integration into the circuit reactor code yet. Part of #63
* | | Merge branch 'chan-handshake-refactor' into 'main'David Goulet2025-09-021-121/+262
|\ \ \ | |/ / |/| | | | | | | | proto: Refactor channel handshake code for upcoming relay handshake See merge request tpo/core/arti!3182
| * | proto: Move is_authenticating() into the base initiator handshake traitDavid Goulet2025-09-021-7/+10
| | | | | | | | | | | | | | | | | | | | | | | | Initiator always know if they will authenticate or not. Responder is different as a relay doesn't know until the end of the handshake if it is responding to a relay or a client. Signed-off-by: David Goulet <[email protected]>
| * | proto: Various channel handshake fixesDavid Goulet2025-09-021-21/+38
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These are following the review of MR 3182. They are put in a single commit because the git absorb has a large amount of conflicts on rebase and this commit allows the reviewers to see what happened. The base branch was rebased on main due to the need for 3184. Signed-off-by: David Goulet <[email protected]>
| * | proto: Fix unit tests after changesDavid Goulet2025-09-021-5/+5
| | | | | | | | | | | | Signed-off-by: David Goulet <[email protected]>
| * | proto: Add a helper to calculate the handshake clock skewDavid Goulet2025-09-021-12/+33
| | | | | | | | | | | | | | | | | | In the spirit of avoidin code duplication. Signed-off-by: David Goulet <[email protected]>
| * | proto: Add a channel initiator handshake base traitDavid Goulet2025-09-021-76/+118
| | | | | | | | | | | | | | | | | | | | | | | | | | | All initiator handshake will implement this in order to get access to the helper function to receive the relay responder cells. Relay will implement this in future commits. Signed-off-by: David Goulet <[email protected]>
| * | proto: Introduce a ChannelBaseHandshake traitDavid Goulet2025-09-021-37/+96
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Client and relay handhsake share a lot of code because they both send/recv the same cells, just handles them differently for verification. This is the base trait for all handshake implementing basic getters and VERSIONS cell handling. This will allow the RelayInitiatorHandshake and RelayResponderHandshake to use this common code. See, traits are fun. Win-win-win. Signed-off-by: David Goulet <[email protected]>
| * | proto: Put in a ChannelFrame<T> into the client handshakeDavid Goulet2025-09-021-10/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The ClientInitiatorHandshake holds a "tls" sink but the very first thing we do is transform it to a ChannelFrame<T>. Instead, just store the frame to the object directly so we can then use a channel frame uniformily accross its lifetime. This will be useful for the future refactoring paving the way for relay channel authentication. Signed-off-by: David Goulet <[email protected]>
* | | Merge branch 'rustsec-2025-0055' into 'main'Nick Mathewson2025-09-0214-48/+26
|\ \ \ | | | | | | | | | | | | | | | | Require tracing-subscriber 0.3.20 See merge request tpo/core/arti!3221
| * | | Require tracing-subscriber 0.3.20Nick Mathewson2025-09-0214-48/+26
| |/ / | | | | | | | | | Fixes RUSTSEC-2025-0055.
* | | Merge branch 'const-assert-cleanly' into 'main'Nick Mathewson2025-09-026-11/+4
|\ \ \ | | | | | | | | | | | | | | | | various crates: Switch to "assert in const" pattern See merge request tpo/core/arti!3217
| * | | tor-proto: Switched to "assert in const" patternhashcatHitman2025-09-011-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Replaced use of [`static_assertions::const_assert`] with the newly available "assert in const" pattern. Signed-off-by: hashcatHitman <[email protected]>
| * | | tor-netdir: Removed dependency on `static_assertions`hashcatHitman2025-09-013-4/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Replaced use of [`static_assertions::const_assert`] with the newly available "assert in const" pattern. This completely removes the dependency on `static_assertions` for `tor-netdir`. Signed-off-by: hashcatHitman <[email protected]>
| * | | tor-circmgr: Removed dependency on `static_assertions`hashcatHitman2025-09-013-5/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Replaced use of [`static_assertions::const_assert`] with the newly available "assert in const" pattern. This completely removes the dependency on `static_assertions` for `tor-circmgr`. Signed-off-by: hashcatHitman <[email protected]>
* | | | Merge branch 'ci-case' into 'main'David Goulet2025-09-022-0/+16
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | maint: Add a check for case-insensitive files See merge request tpo/core/arti!3207
| * | | | maint: Add a check for case-insensitive filesClara Engler2025-08-282-0/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Filenames within the tree that exists in multiple versions only differing by their case cause problems on case-insensitive filesystems. This commit introduces a simple check that lists all files indexes by git and searches for duplicate lines while ignoring case during comparison. See !3166, #2144
* | | | | Merge branch '2144-fix-keys-test' into 'main'David Goulet2025-09-022-2/+2
|\ \ \ \ \ | |_|_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | arti: test: Fix `keys` integration test Closes #2144 See merge request tpo/core/arti!3209
| * | | | arti: test: Fix `keys` integration testhjrgrn2025-08-282-2/+2
| | | | | | | | | | | | | | | | | | | | The `keys` integration test now accounts for case-insensitive filesystems
* | | | | Merge branch 'deftly-1-3-0' into 'main'Nick Mathewson2025-09-0227-58/+58
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Update to derive-deftly 1.3.0 See merge request tpo/core/arti!3219
| * | | | | Update to derive-deftly 1.3.0Ian Jackson2025-09-0227-58/+58
|/ / / / /
* | | | | Merge branch 'parse2-flatten' into 'main'Ian Jackson2025-09-026-25/+242
|\ \ \ \ \ | |_|_|/ / |/| | | | | | | | | | | | | | tor-netdoc: parse2: Provide for "flattening" See merge request tpo/core/arti!3186
| * | | | tor-netdoc: parse2: derive: Remove an unneeded nested ${concat }Ian Jackson2025-09-021-1/+1
| | | | | | | | | | | | | | | | | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/3186#note_3249820
| * | | | tor-netdoc: parse2: Speak of non-structural *items* rather than fieldsIan Jackson2025-09-021-1/+1
| | | | |
| * | | | tor-netdoc: parse2: Explicitly define "structural item"Ian Jackson2025-09-021-0/+7
| | | | |
| * | | | tor-netdoc: parse2: Report unexpected subdoc multiplicity at the intro itemIan Jackson2025-09-022-3/+5
| | | | |
| * | | | tor-netdoc: multiplicity: Introduce can_accumulateIan Jackson2025-09-021-2/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We're going to use this to check that we can accept a sub-document before we parse it. That will make the error come out in the right place.
| * | | | tor-netdoc: parse2 tests: Add test case for flatteningIan Jackson2025-09-021-2/+42
| | | | |
| * | | | tor-netdoc: parse2 tests: Use sval in one place rather than open-codingIan Jackson2025-09-021-1/+1
| | | | |
| * | | | tor-netdoc: parse2: Provide flattening and NetdocParseableFieldsIan Jackson2025-09-024-8/+155
| | | | |
| * | | | tor-netdoc: parse2: Preparatory rework for flatteningIan Jackson2025-09-021-8/+10
| | | | | | | | | | | | | | | | | | | | | | | | | Change from two loops over fields and two ${when}, to one loop with ${select1}. There will be another arm in a moment.
| * | | | tor-netdoc: parse2: Specify `for struct` in one of the derivesIan Jackson2025-09-021-1/+1
| | | | | | | | | | | | | | | | | | | | None of these things support enums or unions.
| * | | | tor-netdoc: parse2: tests: Include the test doc in more error msgsIan Jackson2025-09-021-5/+6
|/ / / /
* | | | Merge branch 'bigger-xfers' into 'main'Ian Jackson2025-09-0111-20/+20
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | CI: increase test-transfer sizes See merge request tpo/core/arti!3047
| * | | | shadow CI: less-verbose loggingJim Newsome2025-08-271-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | With the increased transfer sizes and simulation run-time, the previous log levels resulted in excessively large log files.
| * | | | CI shadow test: increase transfer sizes to 5 MBJim Newsome2025-08-2710-19/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is the transfer size used in the tor CI chutney tests, to more-fully exercise SENDMEs / congestion control. We also increase the simulation run time to allow time for the larger transfers.
* | | | | Merge branch 'fix-clippy' into 'main'Ian Jackson2025-09-011-1/+1
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | proto: Use allow(unused) instead of expect(unused). See merge request tpo/core/arti!3213
| * | | | | proto: Use allow(unused) instead of expect(unused).Gabriela Moldovan2025-08-291-1/+1
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | With rustc 1.85, this `expect(unused)` triggers a "lint expectation unfulfilled" error, because rust thinks the struct *is* used (because of the d-d `TryFrom` implementation), despite the fact that it's never actually constructed. This isn't a problem on newer versions (it's correctly identified as unused/dead code on 1.89, for example). Using `allow` instead of `expect` is slightly less nice, but it makes `clippy` pass on 1.85 too.
* | | | | Merge branch 'ticket-2145' into 'main'Nick Mathewson2025-08-281-8/+1
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fix documentation for StreamPrefs::connect_to_onion_services to match changes in !2506 Closes #2145 See merge request tpo/core/arti!3212
| * | | | | fix documentation for StreamPrefs::connect_to_onion_services to match ↵Aiden McClelland2025-08-281-8/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | changes in !2506 Signed-off-by: Aiden McClelland <[email protected]>
* | | | | | Merge branch 'publish-too' into 'main'opara2025-08-291-1/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Release.md: Tweak one of the checklist items See merge request tpo/core/arti!3211
generated by cgit v1.2.3 (git 2.46.0) at 2026-08-27 16:53:34 +0000