summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * | circmgr: Remove the CircParameters build .expect()David Goulet2025-01-166-55/+30
| | | | | | | | | | | | | | | | | | Instead, return an error and make all call site handle it. Signed-off-by: David Goulet <[email protected]>
| * | congestion: Use getters for all parametersDavid Goulet2025-01-164-68/+94
| | | | | | | | | | | | | | | | | | Allows us to remove the pub. Signed-off-by: David Goulet <[email protected]>
| * | circ: Specialize the circparams from netparams functionDavid Goulet2025-01-167-70/+106
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Congestion control parameters have specific values depending on the circuit type. Instead of using a CircuitType, which is removed in this commit, specialize the function in this case onion and exit. This allows us to get rid of CircuitType and solely use TargetCircUsage instead. At this commit, we use .expect() on the Builder. Future commit will remove this to return a Result in case of failure. Worth noting that we don't expect one. Signed-off-by: David Goulet <[email protected]>
| * | congestion: Remove Default from every parametersDavid Goulet2025-01-163-24/+8
| | | | | | | | | | | | | | | | | | | | | Important to enforce that every field is explicitely set so we avoid forgetting fields. Signed-off-by: David Goulet <[email protected]>
| * | units: Getters for bounds of a BoundedInt32David Goulet2025-01-161-0/+14
| | | | | | | | | | | | | | | | | | | | | | | | Add lower() and upper() so we can access the bounds of a BoundedInt32. This is useful to get the min and max of a consensus parameter value which are always the bounds of the parameters. Signed-off-by: David Goulet <[email protected]>
| * | congestion: Make the cc_alg values a caret_int for better code semanticDavid Goulet2025-01-164-4/+20
| | | | | | | | | | | | Signed-off-by: David Goulet <[email protected]>
| * | congestion: Move test code in test module for VegasDavid Goulet2025-01-161-16/+15
| | | | | | | | | | | | Signed-off-by: David Goulet <[email protected]>
| * | congestion: Remove duplicated commentsDavid Goulet2025-01-161-13/+0
| | | | | | | | | | | | | | | | | | No need to have these comments in the implementation of the Trait. Signed-off-by: David Goulet <[email protected]>
| * | congestion: Move code to test moduleDavid Goulet2025-01-161-10/+14
| | | | | | | | | | | | | | | | | | | | | Put code for test inside the test module instead of gated by a cfg(test). Signed-off-by: David Goulet <[email protected]>
| * | congestion: Remove FixedWindow start window default valueDavid Goulet2025-01-163-13/+18
| | | | | | | | | | | | | | | | | | | | | | | | In unit tests, we set a 1000 by default but else, we don't set a default so our implementation doesn't forget to set the right value from the consensus. Signed-off-by: David Goulet <[email protected]>
| * | congestion: Add standard clippy checks to testsDavid Goulet2025-01-163-0/+42
| | | | | | | | | | | | Signed-off-by: David Goulet <[email protected]>
| * | congestion: Some comments and mod syntax tweakingDavid Goulet2025-01-161-7/+1
| | | | | | | | | | | | | | | | | | | | | Don't put in the comments, let the top-level module comments do that job. Signed-off-by: David Goulet <[email protected]>
| * | congestion: Make a test_utils.rsDavid Goulet2025-01-164-45/+60
| | | | | | | | | | | | | | | | | | | | | | | | Instead of having the congestion.rs test module public, make a test_utils.rs file that contains code for other unit tests within the congestion module. Signed-off-by: David Goulet <[email protected]>
| * | congestion: Remove duplicate RttParameters structDavid Goulet2025-01-161-39/+7
| | | | | | | | | | | | | | | | | | | | | Turns out that RoundTripEstimatorParams is the same exact thing so one less data structure. Signed-off-by: David Goulet <[email protected]>
| * | test: Fix circuit unit testsDavid Goulet2025-01-162-5/+9
| | | | | | | | | | | | Signed-off-by: David Goulet <[email protected]>
| * | proto: Remove unused circuit/sendme.rsDavid Goulet2025-01-162-459/+0
| | | | | | | | | | | | Signed-off-by: David Goulet <[email protected]>
| * | proto: Notify CC when a SENDME is receivedDavid Goulet2025-01-162-8/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | We also pass along congestion signals that may or may not be used by our congestion control algorithm. Part of #534 Signed-off-by: David Goulet <[email protected]>
| * | proto: Use congestion control in circuit reactorDavid Goulet2025-01-166-49/+48
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It is official, congestion control is now used at this commit by the circuit reactor making circuit/sendme.rs unused. Will be removed with another commit. Related #534 Signed-off-by: David Goulet <[email protected]>
| * | circmgr: Modify CircParameters for congestion controlDavid Goulet2025-01-1612-89/+160
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The congestion control parameters are created from the consensus parameters (netparams) and then put into the CircParameters object that is then passed down the tor-proto crate. Because different parameters are selected depending on the circuit type (onion vs exit vs sbws), a CircuitType enum is introduced for the sole purpose of being used to select the right parameters. Related #534 Signed-off-by: David Goulet <[email protected]>
| * | proto: Add Vegas congestion control algorithmDavid Goulet2025-01-163-0/+599
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The big one! This is the Vegas algorithm implementation that is hooked to the CongestionControl object by implementing the algorithm trait. Still, at this commit, nothing is being used by the circuit reactor yet. Related #534 Signed-off-by: David Goulet <[email protected]>
| * | proto: New CongestionControl object and fixed window algorithmDavid Goulet2025-01-164-7/+745
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add the top level CongestionControl object that will allow the circuit reactor to use it in order to decide if a cell can be sent or not. In order to be used, it is configured with an algorithm that implements the CongestionControlAlgorithm trait. The Fixed Window algorithm is also added which essentially implements the SENDME logic as arti knows it today with a fixed window size. The SENDME code has been refactor in two different logical steps in order to accomodate the future Vegas algorithm for which the congestion window logic and SENDME validity is seperated. There is now a SENDME validator that takes care of tracking the tags (authenticated SENDMEs) and validating them upon reception. Then, if valid, the window management is passed down the congestion control algorithm, at this commit, FixedWindow object. Related #534 Signed-off-by: David Goulet <[email protected]>
| * | proto: Add generic objects for congestion controlDavid Goulet2025-01-164-0/+658
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit adds the congestion window object, a round trip estimator (RTT) and a state enum. These 3 entities are used by congestion control in a generic way that is they are passed and used by any algorithm. At this commit, they are not used hence the allow deadcode attribute for now in order to minimize the build warnings. We also introduce the params.rs file containing the parameters, taken from consensus, used to configure these objects. They will be exposed to the tor-cirmgr crate to build the CircParameters. More will come. This also introduces the congestion/ directory that will contain more code in future commits. Related #534 Signed-off-by: David Goulet <[email protected]>
| * | netdir: Add congestion control consensus parametersDavid Goulet2025-01-161-22/+101
| | | | | | | | | | | | | | | | | | Related #534 Signed-off-by: David Goulet <[email protected]>
| * | crates: Remove tor-congestionDavid Goulet2025-01-166-473/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | Crate is unused and most of its code will be reworked and folded into tor-proto in the future commit with the Congestion Control work. Related #534 Signed-off-by: David Goulet <[email protected]>
* | | Merge branch 'rpc-connect-clarify' into 'main'Nick Mathewson2025-01-163-14/+56
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | rpc: Clarify and fix some issues surrounding relative paths. Closes #1748 and #1749 See merge request tpo/core/arti!2712
| * | rpc: Ignore non-absolute paths if they are default.Nick Mathewson2025-01-151-11/+41
| | |
| * | rpc-book: Decline non-absolute paths in our default paths.Nick Mathewson2025-01-151-1/+3
| | | | | | | | | | | | Closes #1748.
| * | rpc: Reject relative unix paths.Nick Mathewson2025-01-151-0/+9
| | |
| * | rpc-book: Clarify that relative unix paths should abort.Nick Mathewson2025-01-151-2/+3
| | | | | | | | | | | | Closes #1749.
* | | Merge branch 'fs-mistrust-windows-fix' into 'main'gabi-2502025-01-161-1/+2
|\ \ \ | |_|/ |/| | | | | | | | fs-mistrust: Fix test compilation on windows. See merge request tpo/core/arti!2718
| * | fs-mistrust: Fix test compilation on windows.Nick Mathewson2025-01-161-1/+2
|/ / | | | | | | | | | | | | | | | | `std::os::unix::fs::MetadataExt` was indeed the right trait to import, but it doesn't exist on non-unix platforms. This is another bugfix on !2707. It should retain the fix of !2717. I've confirmed that it builds on Windows and passes tests on Linux and Mac.
* | Merge branch 'fix/compile' into 'main'gabi-2502025-01-161-5/+5
|\ \ | | | | | | | | | | | | | | | | | | Fix: Tests fails to run on macos Closes #1809 See merge request tpo/core/arti!2717
| * | Fix: Tests fails to run on macoshhamud2025-01-161-5/+5
|/ /
* | Merge branch 'rpc-clean-up-after-auth' into 'main'Nick Mathewson2025-01-155-13/+24
|\ \ | | | | | | | | | | | | rpclib: Clean up after performing cookie auth See merge request tpo/core/arti!2716
| * | Run cbindgen for changed warnings.Nick Mathewson2025-01-151-1/+1
| | |
| * | rpc: More documentation on cookie_continue.Nick Mathewson2025-01-151-0/+5
| | |
| * | rpclib: Add a note about where cookie auth is documented.Nick Mathewson2025-01-151-0/+1
| | |
| * | rpclib: Clean up after performing cookie authNick Mathewson2025-01-153-12/+17
| | | | | | | | | | | | | | | | | | Previously we never released the intermediary cookie-auth object, which would have left it kicking around on the RPC server side until we finally closed our connection.
* | | Merge branch 'rpc-renaming-2' into 'main'Nick Mathewson2025-01-154-65/+62
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | rpc: Rename new_stream_handle to new_oneshot_client. Closes #1664 See merge request tpo/core/arti!2715
| * | | rpc: Clean up documenation surrounding OneshotClientNick Mathewson2025-01-151-11/+13
| | | |
| * | | rpc: Rename new_stream_handle to new_oneshot_client.Nick Mathewson2025-01-154-55/+50
| |/ / | | | | | | | | | | | | | | | | | | | | | This method doesn't actually create a new stream; it creates a single-use client object that can be used with SOCKS to launch a new stream, and capture an RPC object for that stream. Closes #1664.
* | | Merge branch 'rpc-renaming-1' into 'main'Nick Mathewson2025-01-154-5/+5
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | arti-rpcserver: Rename MethodNotFound to NoSuchMethod. Closes #1500 See merge request tpo/core/arti!2714
| * | | rpc-meta-draft.md: Fix a dangling reference to RpcMethodNotFound.Nick Mathewson2025-01-151-1/+1
| | | |
| * | | arti-rpcserver: Rename MethodNotFound to NoSuchMethod.Nick Mathewson2025-01-153-4/+4
| |/ / | | | | | | | | | Closes #1500.
* | | Merge branch 'rpc-windows-default' into 'main'Nick Mathewson2025-01-152-1/+7
|\ \ \ | |/ / |/| | | | | | | | | | | | | | rpc: Document windows USER_DEFAULT connect point. Closes #1798 See merge request tpo/core/arti!2713
| * | rpc: Document windows USER_DEFAULT connect point.Nick Mathewson2025-01-152-1/+7
|/ /
* | Merge branch 'rpc-cookie' into 'main'Nick Mathewson2025-01-1524-350/+1029
|\ \ | | | | | | | | | | | | | | | | | | RPC: Implement cookie authentication Closes #1529 See merge request tpo/core/arti!2702
| * | rpc: Expose Cookie::load unconditionally.Nick Mathewson2025-01-151-2/+0
| | |
| * | arti-rpcserver: require latest tiny-keccak.Nick Mathewson2025-01-151-1/+1
| | |
| * | rpc: Clarify auth-repetition rules.Nick Mathewson2025-01-151-2/+5
| | |
generated by cgit v1.2.3 (git 2.46.0) at 2026-08-27 22:54:35 +0000