summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | tor-proto: added accessors for circuit legs/hopsSteven Engler2025-04-232-1/+11
| | | |
| * | | circ: Request congestion control with ntorv3 extensionDavid Goulet2025-04-232-5/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This puts in, based on the circuit parameters, the CC extension request in the CREATE and EXTEND requests. Part of #1817 Signed-off-by: David Goulet <[email protected]>
| * | | circ: Apply possible subprotocol changes to circ paramsDavid Goulet2025-04-232-6/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Congestion control can change the circuit parameters if the relay we are negotiating with doesn't support FlowCtrl=2. This commit adds a function in the circuit builder that will apply any changes to the circuit parameters of the hop based on the hop protocol values. For now, only congestion control applies. Part of #1817 Signed-off-by: David Goulet <[email protected]>
| * | | circ: Remove CircParameters reference in call stackDavid Goulet2025-04-237-31/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This avoids cloning the object and instead allows us to have a CircParameters per hop on the circuit path. This will come handy with congestion control where each hop might have different congestion control parameters. Part of #1817 Signed-off-by: David Goulet <[email protected]>
| * | | congestion: Setup a fallback algorithm in the paramsDavid Goulet2025-04-233-1/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | CircParameters is built before path selection and thus once we start building the hops, we can't access the consensus values that were used to build it in the first place. For congestion control, we require a fallback algorithm in case the hop doesn't support FlowCtrl=2. This commit adds a "fallback_alg" to the CC parameters which will be used for this exact case. Part of #1817 Signed-off-by: David Goulet <[email protected]>
| * | | circ: Set the negotiated CC sendme_inc from handshakeDavid Goulet2025-04-232-7/+70
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When receiving the congestion control response extension, evaluate our state and set the sendme_inc if valid in our circuit parameters. For this, a series of helper functions is needed. Part of #1817 Signed-off-by: David Goulet <[email protected]>
| * | | circ: Make CircParameters mutable in the call stackDavid Goulet2025-04-233-12/+15
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is required because circuit ntor v3 handshake can negotiate circuit level parameters and thus able to change any values. Needed for congestion control ntorv3 handshake extension for which the sendme increment is negotiated. Part of #1817 Signed-off-by: David Goulet <[email protected]>
* | | Merge branch 'todos-msrv' into 'main'Jim Newsome2025-04-248-14/+12
|\ \ \ | | | | | | | | | | | | | | | | various crates: MSRV TODO standardization and cleanup of an old TODO See merge request tpo/core/arti!2945
| * | | tor-consdiff: Replaced an old MSRV TODO with a link to why it shouldn't be donehashcatHitman2025-04-231-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - After spending quite a while trying to figure out why the tests kept failing after making the change, I eventually stumbled upon the netdoc syntax specification, which helpfully informs me that newlines MUST be ignored and discarded. Switching to using [`str::split_inclusive`] would either require extra lines to workaround and recreate the current expected behavior or changing the spec and correcting the tests to align with the new expected behavior.
| * | | tor-consdiff: standardized MSRV TODOhashcatHitman2025-04-161-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Part of a series of commits aimed at replacing all MSRV-related TODOs with a standardized format, which should be easier to find when the MSRV is bumped. For this one in particular, we actually do already meet the MSRV specified, but I want to check on the implementation details to see if this is still desired, since the TODO is 4 years old.
| * | | tor-hsservice: standardized MSRV TODOhashcatHitman2025-04-161-1/+1
| | | | | | | | | | | | | | | | | | | | - Part of a series of commits aimed at replacing all MSRV-related TODOs with a standardized format, which should be easier to find when the MSRV is bumped.
| * | | tor-memquota: standardized MSRV TODOhashcatHitman2025-04-161-1/+2
| | | | | | | | | | | | | | | | | | | | - Part of a series of commits aimed at replacing all MSRV-related TODOs with a standardized format, which should be easier to find when the MSRV is bumped.
| * | | tor-rpc-connect: standardized MSRV TODOhashcatHitman2025-04-161-1/+1
| | | | | | | | | | | | | | | | | | | | - Part of a series of commits aimed at replacing all MSRV-related TODOs with a standardized format, which should be easier to find when the MSRV is bumped.
| * | | arti-relay: standardized MSRV TODOhashcatHitman2025-04-161-1/+1
| | | | | | | | | | | | | | | | | | | | - Part of a series of commits aimed at replacing all MSRV-related TODOs with a standardized format, which should be easier to find when the MSRV is bumped.
| * | | tor-basic-utils: standardized MSRV TODOshashcatHitman2025-04-162-4/+4
| | | | | | | | | | | | | | | | | | | | - Part of a series of commits aimed at replacing all MSRV-related TODOs with a standardized format, which should be easier to find when the MSRV is bumped.
| * | | tor-netdir: remove lint allow as per TODOhashcatHitman2025-04-161-3/+0
| | | | | | | | | | | | | | | | | | | | - https://github.com/rust-lang/rust-clippy/issues/11764 was fixed upstream, so this is no longer needed.
* | | | Merge branch 'remove-note' into 'main'Ian Jackson2025-04-241-1/+0
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | arti-client: Remove incorrect note about `StateDirectory` usage See merge request tpo/core/arti!2952
| * | | arti-client: remove incorrect note about `StateDirectory` usageSteven Engler2025-04-231-1/+0
|/ / /
* | | Merge branch 'chutney-shadow-flakiness' into 'main'Jim Newsome2025-04-232-5/+35
|\ \ \ | | | | | | | | | | | | | | | | integration-e2e-shadow flakiness debugging and workaround See merge request tpo/core/arti!2950
| * | | integration-e2e-shadow: move simulation seed to yamlJim Newsome2025-04-231-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | Since this significantly affects the behavior of the simulation, it's probably worth having it in the yaml. (It can of course still be overridden from the command-line).
| * | | integration-e2e-shadow: move unblocked-syscall-latency to yamlJim Newsome2025-04-231-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Since this significantly affects the behavior of the simulation, it's useful to have it in the yaml for reference or if the simulation is manually rerun from the yaml.
| * | | arti-bench: work around shadow writer shutdown bugJim Newsome2025-04-231-1/+11
| | | |
| * | | integration-e2e-shadow: use a larger max_unapplied_cpu_latencyJim Newsome2025-04-231-0/+20
|/ / / | | | | | | | | | | | | | | | | | | | | | This should make the simulation results generally more stable with respect to small perturbations, such as adding logging. It also causes a previous "heisenbug" failure in this test to reliably reproduce in every run.
* | | Merge branch 'proto_enforce' into 'main'Nick Mathewson2025-04-2239-48/+1666
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Enforce recommended and required protocol versions in arti-client Closes #1849 and #1923 See merge request tpo/core/arti!2929
| * | | Rename recommended_protocols to protocol_statuses.Nick Mathewson2025-04-166-17/+17
| | | | | | | | | | | | | | | | | | | | This name reflects its purpose better than the original one, since it includes required protocols as well as recommended ones.
| * | | netdoc: Require serde feature from tor-protover.Nick Mathewson2025-04-161-1/+1
| | | |
| * | | arti-client: Document spec of checking date on cached protosNick Mathewson2025-04-161-3/+6
| | | | | | | | | | | | | | | | | | | | Also move the comment outside the block it documents, to prevent a too-long line.
| * | | arti-client: On shutdown for missing proto, print to stderrNick Mathewson2025-04-161-1/+17
| | | | | | | | | | | | | | | | Also wait a little so logs can flush.
| * | | arti-client README: Document undesirable exit(1) behavior.Nick Mathewson2025-04-161-1/+12
| | | |
| * | | netdoc: improve documentation for check_protocolsNick Mathewson2025-04-161-1/+7
| | | |
| * | | protover, *: Add documentation about what "supported" means.Nick Mathewson2025-04-167-6/+32
| | | |
| * | | protover: Enforce that every unrecognized protocol entry is nonzero.Nick Mathewson2025-04-161-1/+5
| | | | | | | | | | | | | | | | This rule makes PartialEq more sensible.
| * | | Fix a pair of documentation links.Nick Mathewson2025-04-161-2/+2
| | | |
| * | | dirmgr: Always apply changes before advancing consensus.Nick Mathewson2025-04-161-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In the directory code, we have functionality to advance the consensus download state whenever possible, even if there is more we could download in the current state. That's fine, but when we're in this position, we need to be sure that we're taking any action based on the current state (such as installing notably parameters or, notably, protocol recommendations) before we move on.
| * | | arti-client: Small test for evaluating protocol status.Nick Mathewson2025-04-163-0/+73
| | | |
| * | | arti,arti-client: Add an option to override required protocolsNick Mathewson2025-04-166-6/+92
| | | | | | | | | | | | | | | | | | | | (This isn't a boolean, because we really don't want people ignoring all possible required protocols.)
| * | | arti-client: Keep a somewhat accurate notion of our release date.Nick Mathewson2025-04-168-4/+172
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This doesn't need to be perfect, but we need to use it to see if a consensus is new enough that we should obey its recommendations. This commit also adds a script to update or check our release date, and calls this script from our cargo-publish script.
| * | | Add warnings about removing supported protocols.Nick Mathewson2025-04-167-0/+48
| | | |
| * | | arti-client: Implement the basics of protocol enforcement.Nick Mathewson2025-04-165-2/+266
| | | | | | | | | | | | | | | | This is the major part of #1849.
| * | | Implement PartialEq for ProtoStatuses unconditionally.Nick Mathewson2025-04-161-4/+2
| | | |
| * | | netdir: Add a recommended_protocols() to NetDirProviderNick Mathewson2025-04-164-0/+25
| | | |
| * | | dirmgr, netdir: Store protocol requirments as soon as they are validated.Nick Mathewson2025-04-165-5/+60
| | | |
| * | | dirmgr: Backend support for cacheing protocol status.Nick Mathewson2025-04-165-3/+140
| | | | | | | | | | | | | | | | | | | | | | | | | | | | We want to store this separately from the consensus, because we want to access it very early in our load-from-cache process, without checking the consensus that contains it for timeliness.
| * | | protover,netdoc: Implement serde for Protocols etc.Nick Mathewson2025-04-165-4/+47
| | | |
| * | | netdoc: Put all ProtoStatuses into a single Arc<>d objectNick Mathewson2025-04-162-19/+55
| | | | | | | | | | | | | | | | | | | | We'll want this so that we can expose them before we expose the rest of the consensus (which we need to do for spec conformance).
| * | | netdoc: functionality for detecting missing subprotos.Nick Mathewson2025-04-162-2/+100
| | | | | | | | | | | | | | | | Also, add a new ErrorKind for this sort of error.
| * | | New functions to report supported subprotocolsNick Mathewson2025-04-1612-0/+276
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Part of #1849. Note that these functions are distributed across crates, so that if (in the future) we stop doing API breaks with every release, we will get the right outputs. Note also that these functions build the list of protocols out of specific symbolic features, rather than numbers: this makes it easier to avoid errors about "which feature was Relay=4 again", and easier to avoid accidentally referring to a protocol that doesn't exist, like "Consensus" (should be "Cons") or "HsDir" (case is wrong).
| * | | Fix another miscapitalized "MicroDesc"Nick Mathewson2025-04-161-1/+1
| | | |
| * | | protover: Correct capitalization of Micro[Dd]escNick Mathewson2025-04-163-10/+12
| | | | | | | | | | | | | | | | Closes #1923
| * | | protover: Add an implementation for FromIteratorNick Mathewson2025-04-161-0/+37
| | | |