| Commit message (Collapse) | Author | Age | Files | Lines |
| ... | |
| |\ \ \ \
| |/ / /
|/| | |
| | | |
| | | | |
tor-keymgr: Add missing docs for keypair_specifier.
See merge request tpo/core/arti!2532
|
| | | | |
| | | |
| | | |
| | | | |
This breaks up a long statement to improve readability.
|
| |/ / /
| | |
| | |
| | |
| | | |
This is a follow-up to !2393, which added support for the
`key_specifier` top-level attribute.
|
| |\ \ \
| |/ /
|/| |
| | |
| | | |
Proof-of-work client
See merge request tpo/core/arti!2486
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Cover some of the novel edge cases we're introducing around object
parameters and repetition. This still feels awfully ad-hoc, but it's
better than nothing.
Co-authored-by: Micah Elizabeth Scott <[email protected]>
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
We should not be restricting pow-params to occur only once at the rule
level, and we shouldn't be disallowing object parameters at that level
either. Instead, the v1 scheme itself needs to check for and disallow
objects. Future schemes may allow object parameters.
Test cases for this will be added in a subsequent commit.
Co-authored-by: Micah Elizabeth Scott <[email protected]>
|
| | | |
| | |
| | |
| | |
| | |
| | | |
Looks like a copy/paste error.
Co-authored-by: Micah Elizabeth Scott <[email protected]>
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This proliferates the canned hsdesc inner doc testing strategy, adding
another file with data encoded with onion-pow-example running on C
tor. Tests that it parses successfully, and asserts that the pow params
line contents are correct. This is a positive test only.
This strategy seems problematic, but it's better than nothing.
Co-authored-by: Micah Elizabeth Scott <[email protected]>
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
Adds another breadcrumb as requested so new folks happening upon this in
the docs can get oriented.
Co-authored-by: Micah Elizabeth Scott <[email protected]>
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
This can now notice pow_params lines which are invalid because they have
no parameters.
Co-authored-by: Micah Elizabeth Scott <[email protected]>
|
| | | |
| | |
| | |
| | | |
Co-authored-by: Micah Elizabeth Scott <[email protected]>
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Instead of min/max pairs, we can use clamp. And since it's a little
clearer, let's go a bit further and use the same clamp construct with a
lower bound of zero in the other spot we had a min().
Co-authored-by: Micah Elizabeth Scott <[email protected]>
|
| | | |
| | |
| | |
| | |
| | |
| | | |
Feedback from the hs-pow code review, the internal seed heading member
should be seed_head instead of seed, for consistency. Very low impact
change since the field name is not public.
|
| | | |
| | |
| | |
| | | |
Co-authored-by: Micah Elizabeth Scott <[email protected]>
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The Effort type didn't have any const constructor and we had to
disassemble it to do any arithmetic. This adds a const constructor and
int/float saturating arithmetic methods.
Co-authored-by: Micah Elizabeth Scott <[email protected]>
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
The fully qualified name earlier was helpful when this was optional, but
now that it's required let's stick it with the other 'use crate'.
Co-authored-by: Micah Elizabeth Scott <[email protected]>
|
| | | |
| | |
| | |
| | | |
Co-authored-by: Micah Elizabeth Scott <[email protected]>
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
In this design, the thin multiplexing layer between PoW types is always
available when onion services are in use, but the specific pow schemes
(and their dependency libraries) are gated by crate features everywhere.
There are now no new cfg() gates.
When the pow-v1 scheme is disabled, we can parse `pow-params v1` lines
into an empty type (so clients know a PoW scheme exists that might be
supported if they were configured differently). We currently don't save
the contents of unknown hsdesc items.
On the relaycell side, the hs ext module already sets a strong precedent
for keeping unrecognized data as a byte vec, and it doesn't provide a
good way to signal soft parse errors like unrecognized optional
extensions. There, the `v1` type is completely optional, and services
lacking a pow scheme suggested by a client would see one of these
'unrecognized' blobs. This isn't necessarily helpful but it fits the
rest of the design.
Co-authored-by: Micah Elizabeth Scott <[email protected]>
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
My previous strategy here was to try and centralize hspow in one crate,
writing it like a self-contained feature. That introduced friction in
the data types, prompting the use of simplistic types at the netdoc/cell
layers and full-featured types in the optional modules.
This changes tactics, dissolving the low-level parts of tor-hspow into
tor-hscrypto and the high-level parts into hsclient/hsservice. Full
featured types are used everywhere now, but the tradeoff is that
compile-time configurability is a lot more pervasive. Anything that
knows about PoW types at all needs to be fully configured out. I took
this opportunity to try a more complete set of crate features, allowing
users to configure individual PoW schemes.
Co-authored-by: Micah Elizabeth Scott <[email protected]>
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The proof-of-work libraries are off by default in part because they
depend on libraries that are currently GPL licensed. This precludes
the use of this option in closed-source binaries, but here in the
open-source arti tool (or consumers that bundle the binary) it's fine.
Co-authored-by: Micah Elizabeth Scott <[email protected]>
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This adds a module to tor-hspow for version-independent client logic.
The entire module and its invocations are disabled unless the new
"hs-pow" compile time feature is set.
Co-authored-by: Micah Elizabeth Scott <[email protected]>
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Some noisy but low-impact changes. We don't yet do this but it's
possible to disable the 'solve' and 'verify' modules individually now
without breaking the API.
Co-authored-by: Micah Elizabeth Scott <[email protected]>
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Like parameters, PoW solutions are versioned to account for multiple
algorithms over time. A single solution of a specific version may
accompany an INTRO1/2 as part of the encrypted extensions section. Its
encoding may depend on the version.
Co-authored-by: Micah Elizabeth Scott <[email protected]>
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This implements support for extensible proof-of-work parameters. Right
now only a single type is defined, but in theory we can see up to one
line per type on an onion service.
Co-authored-by: Micah Elizabeth Scott <[email protected]>
|
| | |/
| |
| |
| | |
Co-authored-by: Micah Elizabeth Scott <[email protected]>
|
| |\ \
| | |
| | |
| | |
| | | |
Start a set of integration tests in python
See merge request tpo/core/arti!2515
|
| | | | |
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | | |
(This is all on the theory that any formatting standard is better
than none.)
|
| | | |
| | |
| | |
| | |
| | |
| | | |
Right now, we only support two things in the CLI:
overriding ARTI_RPC_TEST_DIR, and passing additional arguments to
arti_rpc_tests.
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
We use the `tomli_w` package to generate reasonable toml output,
instead of trying to use `str.format`.
Without this, there's not an easy way to tell string.Formatter
to convert Path('/abc/"def"') to `"abc/\"def\""`.
Something like this would be necessary even if we weren't using
Path, since the toml rules for sring encoding aren't the same as
produced by Python's repr(), which we were using before.
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
These tests are loosely modeled after stem's test suite for Tor and
the Tor control port. They're meant to exercise Arti, Arti RPC, and
the Arti RPC client library.
(For now, they exercise very little.)
|
| | | | |
|
| |\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
arti-relay: Change it to a binary crate only
Closes #1674
See merge request tpo/core/arti!2525
|
| | | | |
| | | |
| | | |
| | | | |
Signed-off-by: David Goulet <[email protected]>
|
| | | | |
| | | |
| | | |
| | | | |
Signed-off-by: David Goulet <[email protected]>
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The "pub" and "pub(crate)" visibility in a binary crate is essentially
the same except for the dead_code warning analysis which ignores "pub"
but will warn at "pub(crate)".
This should get fixed soon according to:
https://github.com/rust-lang/rust/issues/74970
However, for now, lets catch all this dead code :).
Part of #1674
Signed-off-by: David Goulet <[email protected]>
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Simply, the lib.rs is renamed to relay.rs (containing TorRelay object)
so this crate can never be used as a library.
This is important because at the moment, we don't want to have a relay
stable API that can be used to embed relays in applications.
Closes #1674
Signed-off-by: David Goulet <[email protected]>
|
| | |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
At the moment, it is an empty main() acting as a place holder for this
crate to become solely a binary crate.
Write up a basic README.md in order to explain the current state. Next
commit will remove the libary component by renaming lib.rs
Part of #1674
Signed-off-by: David Goulet <[email protected]>
|
| |\ \ \
| |/ /
|/| |
| | |
| | | |
tor-chanmgr: some cleanup and comments
See merge request tpo/core/arti!2523
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| |\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Use memquota queue for channel->circuit RX data
Closes #1682
See merge request tpo/core/arti!2518
|