mirrors/arti.git - mirror of https://gitlab.torproject.org/tpo/core/arti

	Commit message (Collapse)	Author	Age	Files	Lines
...
* \| \| \| \| \|	Merge branch 'rpc-connect-sketch' into 'main'	Nick Mathewson	2024-10-17	1	-0/+464
\|\ \ \ \ \ \ \| \|/ / / / / \|/\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	RPC: Sketch for how connect strings work See merge request tpo/core/arti!2439
\| * \| \| \| \|	rpc-connect-sketch: Clarify and restrict socket addr format	Nick Mathewson	2024-10-17	1	-8/+16
\| \| \| \| \| \|
\| * \| \| \| \|	rpc-connect: add some example connect strings.	Nick Mathewson	2024-10-17	1	-1/+32
\| \| \| \| \| \|
\| * \| \| \| \|	rpc-connect: clarify that "embedded" is not final.	Nick Mathewson	2024-10-17	1	-0/+10
\| \| \| \| \| \|
\| * \| \| \| \|	rpc-connect: unknown builtins are "decline".	Nick Mathewson	2024-10-17	1	-2/+2
\| \| \| \| \| \|
\| * \| \| \| \|	rpc-connect: replace a "may" with a "must"	Nick Mathewson	2024-10-17	1	-1/+1
\| \| \| \| \| \|
\| * \| \| \| \|	Apply suggestions about authentication/socket relationships.	Nick Mathewson	2024-10-17	1	-3/+6
\| \| \| \| \| \|
\| * \| \| \| \|	rpc-connect-sketch: Slightly clarify escaping.	Nick Mathewson	2024-10-17	1	-5/+4
\| \| \| \| \| \|
\| * \| \| \| \|	rpc-connect-sketch: Revise connect string spec.	Nick Mathewson	2024-10-17	1	-118/+130
\| \| \| \| \| \|
\| * \| \| \| \|	rpc-connect-sketch: Revise search-order-and-config section	Nick Mathewson	2024-10-17	1	-38/+76
\| \| \| \| \| \|
\| * \| \| \| \|	rpc-connect-sketch: Add suggested "security concerns" section.	Nick Mathewson	2024-10-17	1	-1/+34
\| \| \| \| \| \|
\| * \| \| \| \|	rpc-connect-sketch: Add suggested clarifications about cookie file.	Nick Mathewson	2024-10-17	1	-1/+16
\| \| \| \| \| \|
\| * \| \| \| \|	rpc-connect-sketch: Remove file type indicator.	Nick Mathewson	2024-10-17	1	-3/+0
\| \| \| \| \| \|
\| * \| \| \| \|	rpc-connect-sketch: Classify our previously-undecided error cases	Nick Mathewson	2024-10-17	1	-6/+7
\| \| \| \| \| \|
\| * \| \| \| \|	rpc-connect-sketch: call setuid-detection nice-to-have.	Nick Mathewson	2024-10-17	1	-0/+1
\| \| \| \| \| \|
\| * \| \| \| \|	RPC: Sketch for how connect strings work	Nick Mathewson	2024-10-17	1	-0/+316
\|/ / / / / \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This is based on conversations with Diziet, and is a followup from arti!2388 and arti!2429.
* \| \| \| \|	Merge branch 'fs-watcher-poll' into 'main'	gabi-250	2024-10-17	6	-4/+57
\|\ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	tor-config: Use a polling watcher on non-windows platforms that don't have inotify. Closes #1644 See merge request tpo/core/arti!2547
\| * \| \| \| \|	arti: Add a warning about watch_configuration's performance issues.	Gabriela Moldovan	2024-10-17	1	-0/+7
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Part of #1644
\| * \| \| \| \|	tor-config: Document the limitations of the FileWatcher.	Gabriela Moldovan	2024-10-16	2	-0/+11
\| \| \| \| \| \|
\| * \| \| \| \|	arti: Enable tor-config/testing when testing.	Gabriela Moldovan	2024-10-16	1	-0/+1
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This enables us to make use of the unfortunately-necessary test-specific code path.
\| * \| \| \| \|	tor-config: Compare the file contents when testing.	Gabriela Moldovan	2024-10-16	1	-0/+7
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	When testing, compare the contents of the files too, not just their mtime Otherwise, because the polling backend detects changes based on mtime, if the test creates/writes files too fast, it will fail to notice changes (this can happen, for example, on a tmpfs).
\| * \| \| \| \|	tor-config: Configure the polling interval.	Gabriela Moldovan	2024-10-16	1	-2/+17
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	The default is 30s, which feels a bit too long. Also, when testing, we use a much shorter interval. This is meant to be a temporary solution, so we hard-code the interval rather than make it configurable.
\| * \| \| \| \|	tor-config: Use a polling watcher on non-windows platforms that don't have ↵	Gabriela Moldovan	2024-10-16	3	-2/+11
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	inotify. On windows and platforms that support inotify (i.e. linux and android), we continue using the recommended watcher. On platforms that use kqueue, we switch to a polling watcher to work around a [notify bug] that manifests when using a non-recursive watcher to watch a directory. This commit is best reviewed with `git diff --ignore-all-space`. Closes #1644 [notify bug]: https://github.com/notify-rs/notify/issues/644
\| * \| \| \| \|	tor-config: Add a type alias for the underlying watcher (fmt).	Gabriela Moldovan	2024-10-16	1	-2/+2
\| \| \| \| \| \|
\| * \| \| \| \|	tor-config: Add a type alias for the underlying watcher.	Gabriela Moldovan	2024-10-16	1	-3/+6
\| \| \|_\|/ / \| \|/\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This type will soon become platform-dependent, so I am preemptively adding a type alias.
* \| \| \| \|	Merge branch 'general_socketaddr_ops' into 'main'	Nick Mathewson	2024-10-17	7	-2/+526
\|\ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	general::SocketAddr: Specify and implement string representations. Closes #1681 See merge request tpo/core/arti!2519
\| * \| \| \| \|	rtcompat: Add a fuzzer for round-trip general::SocketAddr parsing.	Nick Mathewson	2024-10-16	5	-1/+81
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	(This turned up another place where we need documentation.)
\| * \| \| \| \|	rtcompat: Add a fuzzer for general::SocketAddr parsing	Nick Mathewson	2024-10-16	3	-0/+43
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	The fuzzer makes sure that whatever we can parse, we can format into an object that is parsed in the same way.
\| * \| \| \| \|	general::SocketAddr: Format the unnamed address as "unix:"	Nick Mathewson	2024-10-16	1	-5/+12
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This matches our parsing, and our general rule that our parser defers to SocketAddr::from_pathname.
\| * \| \| \| \|	Add reverse-enginered description of Rust socketaddr formats.	Nick Mathewson	2024-10-16	1	-0/+32
\| \| \| \| \| \|
\| * \| \| \| \|	general::SocketAddr: Add unit tests	Nick Mathewson	2024-10-16	3	-38/+77
\| \| \| \| \| \|
\| * \| \| \| \|	general::SocketAddr: Implement PartialEq.	Nick Mathewson	2024-10-16	1	-0/+39
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Needed for tests.
\| * \| \| \| \|	general::SocketAddr: Specify and implement string representations.	Nick Mathewson	2024-10-16	1	-1/+285
\| \| \|_\|/ / \| \|/\| \| \| \| \| \| \| \| \| \| \| \| \|	Closes #1681.
* \| \| \| \|	Merge branch 'fix-arti-relay-deps' into 'main'	opara	2024-10-16	5	-51/+1
\|\ \ \ \ \ \| \|_\|/ / / \|/\| \| \| \| \| \| \| \| \| \| \| \| \| \|	arti: remove 'relay' subcommand and 'arti-relay' dependency See merge request tpo/core/arti!2542
\| * \| \| \|	arti: remove 'relay' subcommand and 'arti-relay' dep	Steven Engler	2024-10-15	5	-51/+1
\| \|/ / /
* \| \| \|	Merge branch 'mq-feat-1' into 'main'	Jim Newsome	2024-10-16	15	-33/+54
\|\ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	memquota features, preparation See merge request tpo/core/arti!2545
\| * \| \| \|	Rename "memquota" feature to "memquota-memcost" when it's just HasMemoryCost ↵	Ian Jackson	2024-10-16	4	-5/+25
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	(fmt)
\| * \| \| \|	Rename "memquota" feature to "memquota-memcost" when it's just HasMemoryCost	Ian Jackson	2024-10-16	11	-26/+26
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	It's not documented anywhere ATM. I will do that in a followup MR.
\| * \| \| \|	Apply `default-features = false` to all tor-memquota deps	Ian Jackson	2024-10-16	7	-7/+8
\| \| \|_\|/ \| \|/\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This will allow us to make `tor-memquota/memquota` enabled by default, without forcing it to be compiled in everywhere. I don't change that in this MR, though.
* \| \| \|	Merge branch 'rpc_verb_methods' into 'main'	David Goulet	2024-10-16	2	-1/+15
\|\ \ \ \ \| \|/ / / \|/\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	rpc spec: Start to document method naming convention Closes #1678 See merge request tpo/core/arti!2539
\| * \| \|	RPC: Rename "arti:isolated_client" to "arti:new_isolated_client".	Nick Mathewson	2024-10-09	1	-1/+1
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Closes #1678.
\| * \| \|	rpc spec: Start to document method naming convention	Nick Mathewson	2024-10-09	1	-0/+14
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	All but one of our current methods follows this convention, and we're about to rename it.
* \| \| \|	Merge branch 'netbsd' into 'main'	gabi-250	2024-10-16	2	-145/+51
\|\ \ \ \ \| \|_\|/ / \|/\| \| \| \| \| \| \| \| \| \| \|	Update to pwd-grp 1.x to fix NetBSD build See merge request tpo/core/arti!2540
\| * \| \|	Update to pwd-grp 1.x	Ian Jackson	2024-10-15	2	-145/+51
\|/ / / \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Should fix the build on NetBSD, see rust-pwd-grp#4. Also, eliminates the last use of derive-adhoc, the old name for derive-deftly.
* \| \|	Merge branch 'mq-prevent' into 'main'	Ian Jackson	2024-10-15	17	-15/+84
\|\ \ \ \| \|_\|/ \|/\| \| \| \| \| \| \| \| \| \| \| \| \| \|	Use clippy to prevent non-mq use of mpsc::channel Closes #1659 See merge request tpo/core/arti!2536
\| * \|	clippy-nontest.toml: Fix a typo	Ian Jackson	2024-10-15	1	-1/+1
\| \| \|
\| * \|	CI: forbid non-mq mpsc channels	Ian Jackson	2024-10-15	1	-0/+7
\| \| \|
\| * \|	CI: Add a job to run clippy with different parameters, excluding tests	Ian Jackson	2024-10-15	2	-0/+13
\| \| \|
\| * \|	Use mpsc_channel_no_memquota next to a TODO	Ian Jackson	2024-10-15	1	-3/+2
\| \| \| \| \| \| \| \| \| \| \| \|	We have a ticket for this. But the ticket number was wrong, so fix that.
\| * \|	Use mpsc_channel_no_memquota in the RPC system (adding a TODO)	Ian Jackson	2024-10-15	1	-2/+5
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	We need to decide whether RPC will participate in memquota. Perhaps it should. But that's for the future.