summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | | | | tor-bytes: Only report Truncated for errors at the outer level (fmt)Ian Jackson2024-09-111-2/+10
| | | | | | | |
| * | | | | | | tor-bytes: Only report Truncated for errors at the outer levelIan Jackson2024-09-114-17/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is item 1 from https://gitlab.torproject.org/tpo/core/arti/-/issues/1614#note_3074562 and the alternative to item 2 presented in the 2nd half of https://gitlab.torproject.org/tpo/core/arti/-/issues/1614#note_3074648 (Item 3 was done earlier, but now we change the behaviour.) Fixes #1614.
| * | | | | | | tor-bytes: Error: provide and call Error::incomplete_error (tidy)Ian Jackson2024-09-111-4/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Tidy up an error message. Now this can be on one line with variable name interpolation.
| * | | | | | | tor-bytes: Error: provide and call Error::incomplete_error (fmt)Ian Jackson2024-09-112-8/+11
| | | | | | | |
| * | | | | | | tor-bytes: Error: provide and call Error::incomplete_errorIan Jackson2024-09-114-10/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We introduce the new constructor and call it at the error generation sites. But there is still not yet any functional change. Change the type of Truncated's field to be Sensitive. The original reason for not doing this no longer applies, since we don't generally want to open-code construction of this variant. Conveniently, changing the type means we get to find all the sites where one *is* constructed and adjust them. In reader.rs and tor-proto we can just call incomplete_error. In tor-cell, there's a call site where we previously provided an underestimate, and where the Reader isn't available. We adjust that ad-hoc but this is fine because the error variant will change. (relaycell is using a Reader from from_slice.)
| * | | | | | | tor-bytes: Add a Reader constructor for tor-socksproto's use caseIan Jackson2024-09-113-11/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Here we add the constructor, and document it, and change the call sites. No functional change yet.
| * | | | | | | tor-bytes: Add a test case with missing inner dataIan Jackson2024-09-111-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some tests in other crates test this, but none in tor-bytes!
| * | | | | | | tor-bytes: Add a Reader constructor for use in testsIan Jackson2024-09-115-25/+37
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We could call from_possibly_incomplete_slice in these, but that's confusing and distracting. Here we add this constructor, and document it (in terms of the constructor to come), and change the call sites. No functional change. Doing this now will prevent unwanted changes to test behaviours when we change the behaviour of Readers made by Reader::from_slice.
| * | | | | | | tor-bytes: derive impl PartialEq for ErrorIan Jackson2024-09-113-17/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I just perpetrated a bug by adding a variant to this which ended up not PartialEq to itself. This open-coded match is a footgun. No functional change.
| * | | | | | | tor-cell: No longer treat certain tor-bytes errors as EK::InternalIan Jackson2024-09-111-5/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I don't see a justification for this. Rather than updating this code for the new distinction between what is going to be Incomplete (ie, our buffer didn't contain enough data and we want to read more) and MissingData, I think we can just do away with it. Perhaps in the future, tor_bytes::Error would implement HasKind.
| * | | | | | | Change tor_bytes::Readable name to `b` in many placesIan Jackson2024-09-115-160/+160
| | |/ / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The codebase uses `r` sometimes and `b` at other times. Making this consistent makes widespread changes easier, and is clearer for humans. I think `b` is better than `r` because `r` might be "return". It is indeed used that way in a couple of places in reader.rs, even. I haven't changed *everywhere*, just Readable impls (where `r` is particularly likely to be "return value") and occurrences in tor-bytes. No functional change.
* | | | | | | Merge branch 'single-onion-svc' into 'main'Nick Mathewson2024-09-125-33/+17
|\ \ \ \ \ \ \ | |_|/ / / / / |/| | | | | | | | | | | | | | | | | | | | tor-hsservice: Remove the anonymity setting from the config. See merge request tpo/core/arti!2413
| * | | | | | tor-hsservice: Satisfy cargo fmt.Gabriela Moldovan2024-09-121-2/+0
| | | | | | |
| * | | | | | arti: Remove onion service anonymity setting.Gabriela Moldovan2024-09-121-7/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | We don't support this yet, see #727.
| * | | | | | tor-hsservice: Remove the anonymity setting from the config.Gabriela Moldovan2024-09-124-26/+19
|/ / / / / / | | | | | | | | | | | | | | | | | | As mentioned in #727, this is not supported yet.
* | | | | | Merge branch 'bug_1613' into 'main'gabi-2502024-09-125-15/+231
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bug 1613: Add support for inserting externally generated and removing arbitrary service discovery keys Closes #1613 See merge request tpo/core/arti!2396
| * | | | | arti-client: implemented insert_service_discovery_key and ↵Morgan2024-09-101-1/+168
| | | | | | | | | | | | | | | | | | | | | | | | remove_service_discovery_key methods
| * | | | | tor-keymgr: add an overwrite flag to KeyMgr::insert()Morgan2024-09-104-14/+63
| | |_|_|/ | |/| | |
* | | | | Merge branch 'vanguards' into 'main'gabi-2502024-09-111-1/+2
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | tor-guardmgr: Convert a TODO into a NOTE. Closes #1352 See merge request tpo/core/arti!2405
| * | | | | tor-guardmgr: Convert a TODO into a NOTE.Gabriela Moldovan2024-09-101-1/+2
| | |/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This behavior is OK, so this doesn't need to be a TODO. See the discussion at https://gitlab.torproject.org/tpo/core/arti/-/issues/1352#note_3015217 Closes #1352
* | | | | Merge branch 'rpc-draft-revision' into 'main'Nick Mathewson2024-09-111-182/+326
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | Revisions to rpc-meta-draft See merge request tpo/core/arti!2386
| * | | | rpc-draft: move cancel method to connection object.Nick Mathewson2024-09-111-1/+1
| | | | |
| * | | | rpc: Add a "client implementation strategies" section.Nick Mathewson2024-09-111-1/+24
| | | | |
| * | | | rpc: Document pipelining and concurrency.Nick Mathewson2024-09-111-2/+15
| | | | |
| * | | | rpc: Add a "Cancelled" code to our docs.Nick Mathewson2024-09-111-0/+1
| | | | |
| * | | | rpc: Replace strong/weak objectIds with reference/handle againNick Mathewson2024-09-111-5/+18
| | | | | | | | | | | | | | | | | | | | | | | | | Diziet prefers this terminology; we'll defer a reckoning here till #849 is resolved.
| * | | | rpc-draft: Adopt a stricter-but-looser rule for anti-framing defenseNick Mathewson2024-09-111-13/+46
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Instead of saying "no errors before authentication", we now say "no syntax errors ever." This should be easier to implement.
| * | | | rpc-draft: A few more tweaks based on review.Nick Mathewson2024-09-111-10/+12
| | | | |
| * | | | Several rpc-draft suggestions from diziet.Nick Mathewson2024-09-111-11/+22
| | | | |
| * | | | rpc-meta: Note that the appendix is obsolete.Nick Mathewson2024-09-111-0/+3
| | | | |
| * | | | rpc-meta: Note that most listed requests are hypotheticalNick Mathewson2024-09-111-0/+4
| | | | |
| * | | | rpc-meta: remove example apis sectionNick Mathewson2024-09-111-58/+0
| | | | | | | | | | | | | | | | | | | | (This is obsoleted by arti-rpc-client-core.)
| * | | | rpc-meta: update cancellation to latest thinkingNick Mathewson2024-09-111-16/+6
| | | | |
| * | | | rpc-meta: Tweaks to "authentication" section.Nick Mathewson2024-09-111-5/+10
| | | | |
| * | | | rpc-meta: clarify current method name rules.Nick Mathewson2024-09-111-8/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Notably, identifiers SHOULD be C identifiers, and everything has a namespace. Reserve "rpc" as a namespace for things that were previously unnamespaced.
| * | | | rpc-meta: Light edits to parameter description.Nick Mathewson2024-09-111-3/+3
| | | | |
| * | | | rpc-meta: Rewrite and move documentation on object semantics.Nick Mathewson2024-09-111-32/+117
| | | | | | | | | | | | | | | | | | | | | | | | | This is probably still far too informal, but it is better than our previous documentation.
| * | | | rpc-meta: clarify status of Sessions.Nick Mathewson2024-09-111-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | (Note what isn't implemented, and one more kind of authentication we'll likely build someday.)
| * | | | rpc-meta: rewrite front matterNick Mathewson2024-09-111-29/+38
| | | | |
| * | | | rpc-meta: Add a top-level heading, and shift other headingsNick Mathewson2024-09-111-35/+37
|/ / / / | | | | | | | | | | | | (Markdown convention deprecates having more than one top-level heading.)
* | | | Merge branch 'publisher-svc-status' into 'main'David Goulet2024-09-1019-176/+667
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | tor-hsservice: Improve descriptor publisher status reporting Closes #1216 and #1572 See merge request tpo/core/arti!2397
| * | | | tor-hsservice: Add tests for status changes induced by descriptor uploads.Gabriela Moldovan2024-09-091-1/+185
| | | | |
| * | | | tor-netdir: Allow access to the `ConsensusBuilder` when building test ↵Gabriela Moldovan2024-09-091-1/+6
| | | | | | | | | | | | | | | | | | | | netdirs (fmt).
| * | | | tor-netdir: Allow access to the `ConsensusBuilder` when building test netdirs.Gabriela Moldovan2024-09-0911-31/+32
| | | | | | | | | | | | | | | | | | | | | | | | | This allows us to set SRVs for example (needed because by default, the test `NetDir` is built from a consensus that doesn't contain any SRVs).
| * | | | tor-hsservice: Include descriptor upload errors in onion service status.Gabriela Moldovan2024-09-091-9/+17
| | | | |
| * | | | tor-hsservice: Change the error type in Problem::DescriptorUpload.Gabriela Moldovan2024-09-093-3/+41
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We will need to return a list of descriptor upload errors. We can't return a `Vec<RetryError<DescUploadError>>` here because `DescUploadError` is a lower-level error type that can't express that e.g. the upload timed out.
| * | | | tor-hsservice: Remove unused UploadError variant (fmt).Gabriela Moldovan2024-09-091-3/+1
| | | | |
| * | | | tor-hsservice: Remove unused UploadError variant.Gabriela Moldovan2024-09-092-6/+2
| | | | | | | | | | | | | | | | | | | | | | | | | We never return `UploadError::Timeout` (timeouts are represented as `BackoffError::Timeout`).
| * | | | tor-hsservice: Rename UploadStatus to UploadResult.Gabriela Moldovan2024-09-091-4/+4
| | | | | | | | | | | | | | | | | | | | This type is a `Result`, renaming for clarity.
| * | | | tor-hsservice: Remove outdated comment about publisher.Gabriela Moldovan2024-09-091-17/+0
| | | | | | | | | | | | | | | | | | | | The descriptor publisher docs live in the `publisher` module.
generated by cgit v1.2.3 (git 2.46.0) at 2026-08-27 21:03:54 +0000