summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | | tor-chanmgr: added `PendingChannelHandle`Steven Engler2024-10-152-36/+64
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This handle contains all of the details required to remove or replace a pending channel entry from the channel map.
| * | | | | tor-chanmgr: refactor so we don't need `with_channels{,_and_params}`Steven Engler2024-10-152-78/+76
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These methods on `MgrState` acquire a lock, and it's easy for calling code to also try to acquire the same lock within the closure, causing a deadlock. It's better to not expose these methods.
| * | | | | tor-chanmgr: fix some incorrect commentsSteven Engler2024-10-152-5/+3
| | | | | |
| * | | | | tor-chanmgr: removed use of `with_channels` within `request_channel`Steven Engler2024-10-151-61/+66
| | | | | | | | | | | | | | | | | | | | | | | | Best reviewed with the '-w' flag to hide whitespace changes.
| * | | | | tor-chanmgr: refactored `AbstractChanMgr::choose_action`Steven Engler2024-10-152-109/+145
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This moves most of the channel map logic from `AbstractChanMgr::choose_action` to `MgrState::request_channel`. This is working towards being able to remove `MgrState::with_channels{,_and_params}`.
* | | | | | Merge branch 'non-linux-fix' into 'main'Nick Mathewson2024-10-171-1/+3
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | rtcompat: Fix android compilation in `general` See merge request tpo/core/arti!2553
| * | | | | | rtcompat: Fix android compilation in `general`Nick Mathewson2024-10-171-1/+3
| | |_|_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously I had assumed that `std::os::linux` also existed on android, based on the documentation of `std::os::linux::net::SocketAddrExt`. That is not, however, true. This should fix the `check-targets` CI job.
* | | | | | Merge branch 'rpc-connect-sketch' into 'main'Nick Mathewson2024-10-171-0/+464
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | | | | | | | | | | | | RPC: Sketch for how connect strings work See merge request tpo/core/arti!2439
| * | | | | rpc-connect-sketch: Clarify and restrict socket addr formatNick Mathewson2024-10-171-8/+16
| | | | | |
| * | | | | rpc-connect: add some example connect strings.Nick Mathewson2024-10-171-1/+32
| | | | | |
| * | | | | rpc-connect: clarify that "embedded" is not final.Nick Mathewson2024-10-171-0/+10
| | | | | |
| * | | | | rpc-connect: unknown builtins are "decline".Nick Mathewson2024-10-171-2/+2
| | | | | |
| * | | | | rpc-connect: replace a "may" with a "must"Nick Mathewson2024-10-171-1/+1
| | | | | |
| * | | | | Apply suggestions about authentication/socket relationships.Nick Mathewson2024-10-171-3/+6
| | | | | |
| * | | | | rpc-connect-sketch: Slightly clarify escaping.Nick Mathewson2024-10-171-5/+4
| | | | | |
| * | | | | rpc-connect-sketch: Revise connect string spec.Nick Mathewson2024-10-171-118/+130
| | | | | |
| * | | | | rpc-connect-sketch: Revise search-order-and-config sectionNick Mathewson2024-10-171-38/+76
| | | | | |
| * | | | | rpc-connect-sketch: Add suggested "security concerns" section.Nick Mathewson2024-10-171-1/+34
| | | | | |
| * | | | | rpc-connect-sketch: Add suggested clarifications about cookie file.Nick Mathewson2024-10-171-1/+16
| | | | | |
| * | | | | rpc-connect-sketch: Remove file type indicator.Nick Mathewson2024-10-171-3/+0
| | | | | |
| * | | | | rpc-connect-sketch: Classify our previously-undecided error casesNick Mathewson2024-10-171-6/+7
| | | | | |
| * | | | | rpc-connect-sketch: call setuid-detection nice-to-have.Nick Mathewson2024-10-171-0/+1
| | | | | |
| * | | | | RPC: Sketch for how connect strings workNick Mathewson2024-10-171-0/+316
|/ / / / / | | | | | | | | | | | | | | | | | | | | This is based on conversations with Diziet, and is a followup from arti!2388 and arti!2429.
* | | | | Merge branch 'fs-watcher-poll' into 'main'gabi-2502024-10-176-4/+57
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | tor-config: Use a polling watcher on non-windows platforms that don't have inotify. Closes #1644 See merge request tpo/core/arti!2547
| * | | | | arti: Add a warning about watch_configuration's performance issues.Gabriela Moldovan2024-10-171-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | Part of #1644
| * | | | | tor-config: Document the limitations of the FileWatcher.Gabriela Moldovan2024-10-162-0/+11
| | | | | |
| * | | | | arti: Enable tor-config/testing when testing.Gabriela Moldovan2024-10-161-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This enables us to make use of the unfortunately-necessary test-specific code path.
| * | | | | tor-config: Compare the file contents when testing.Gabriela Moldovan2024-10-161-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When testing, compare the contents of the files too, not just their mtime Otherwise, because the polling backend detects changes based on mtime, if the test creates/writes files too fast, it will fail to notice changes (this can happen, for example, on a tmpfs).
| * | | | | tor-config: Configure the polling interval.Gabriela Moldovan2024-10-161-2/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The default is 30s, which feels a bit too long. Also, when testing, we use a much shorter interval. This is meant to be a temporary solution, so we hard-code the interval rather than make it configurable.
| * | | | | tor-config: Use a polling watcher on non-windows platforms that don't have ↵Gabriela Moldovan2024-10-163-2/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | inotify. On windows and platforms that support inotify (i.e. linux and android), we continue using the recommended watcher. On platforms that use kqueue, we switch to a polling watcher to work around a [notify bug] that manifests when using a non-recursive watcher to watch a directory. This commit is best reviewed with `git diff --ignore-all-space`. Closes #1644 [notify bug]: https://github.com/notify-rs/notify/issues/644
| * | | | | tor-config: Add a type alias for the underlying watcher (fmt).Gabriela Moldovan2024-10-161-2/+2
| | | | | |
| * | | | | tor-config: Add a type alias for the underlying watcher.Gabriela Moldovan2024-10-161-3/+6
| | |_|/ / | |/| | | | | | | | | | | | | | | | | | This type will soon become platform-dependent, so I am preemptively adding a type alias.
* | | | | Merge branch 'general_socketaddr_ops' into 'main'Nick Mathewson2024-10-177-2/+526
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | general::SocketAddr: Specify and implement string representations. Closes #1681 See merge request tpo/core/arti!2519
| * | | | | rtcompat: Add a fuzzer for round-trip general::SocketAddr parsing.Nick Mathewson2024-10-165-1/+81
| | | | | | | | | | | | | | | | | | | | | | | | (This turned up another place where we need documentation.)
| * | | | | rtcompat: Add a fuzzer for general::SocketAddr parsingNick Mathewson2024-10-163-0/+43
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The fuzzer makes sure that whatever we can parse, we can format into an object that is parsed in the same way.
| * | | | | general::SocketAddr: Format the unnamed address as "unix:"Nick Mathewson2024-10-161-5/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This matches our parsing, and our general rule that our parser defers to SocketAddr::from_pathname.
| * | | | | Add reverse-enginered description of Rust socketaddr formats.Nick Mathewson2024-10-161-0/+32
| | | | | |
| * | | | | general::SocketAddr: Add unit testsNick Mathewson2024-10-163-38/+77
| | | | | |
| * | | | | general::SocketAddr: Implement PartialEq.Nick Mathewson2024-10-161-0/+39
| | | | | | | | | | | | | | | | | | | | | | | | Needed for tests.
| * | | | | general::SocketAddr: Specify and implement string representations.Nick Mathewson2024-10-161-1/+285
| | |_|/ / | |/| | | | | | | | | | | | | Closes #1681.
* | | | | Merge branch 'fix-arti-relay-deps' into 'main'opara2024-10-165-51/+1
|\ \ \ \ \ | |_|/ / / |/| | | | | | | | | | | | | | arti: remove 'relay' subcommand and 'arti-relay' dependency See merge request tpo/core/arti!2542
| * | | | arti: remove 'relay' subcommand and 'arti-relay' depSteven Engler2024-10-155-51/+1
| |/ / /
* | | | Merge branch 'mq-feat-1' into 'main'Jim Newsome2024-10-1615-33/+54
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | memquota features, preparation See merge request tpo/core/arti!2545
| * | | | Rename "memquota" feature to "memquota-memcost" when it's just HasMemoryCost ↵Ian Jackson2024-10-164-5/+25
| | | | | | | | | | | | | | | | | | | | (fmt)
| * | | | Rename "memquota" feature to "memquota-memcost" when it's just HasMemoryCostIan Jackson2024-10-1611-26/+26
| | | | | | | | | | | | | | | | | | | | It's not documented anywhere ATM. I will do that in a followup MR.
| * | | | Apply `default-features = false` to all tor-memquota depsIan Jackson2024-10-167-7/+8
| | |_|/ | |/| | | | | | | | | | | | | | | | | | | | | | This will allow us to make `tor-memquota/memquota` enabled by default, without forcing it to be compiled in everywhere. I don't change that in this MR, though.
* | | | Merge branch 'rpc_verb_methods' into 'main'David Goulet2024-10-162-1/+15
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | rpc spec: Start to document method naming convention Closes #1678 See merge request tpo/core/arti!2539
| * | | RPC: Rename "arti:isolated_client" to "arti:new_isolated_client".Nick Mathewson2024-10-091-1/+1
| | | | | | | | | | | | | | | | Closes #1678.
| * | | rpc spec: Start to document method naming conventionNick Mathewson2024-10-091-0/+14
| | | | | | | | | | | | | | | | | | | | All but one of our current methods follows this convention, and we're about to rename it.
* | | | Merge branch 'netbsd' into 'main'gabi-2502024-10-162-145/+51
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | Update to pwd-grp 1.x to fix NetBSD build See merge request tpo/core/arti!2540