| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| ... | |
| | | | |
| | | |
| | | |
| | | |
| | | | |
Now the constructor is able to return other data to the caller,
passing it through the mtracker machinery.
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
I just want this for a test right now, bui it seems like it would be
good to expose it publicly.
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
We're going to want this as the return value from an accessor
function, which cannot fail for any other reason.
|
| |\ \ \ \
| |/ / /
|/| | |
| | | |
| | | | |
tor-memquota: Provide destroy_participant
See merge request tpo/core/arti!2281
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
As per
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2281#note_3051105
|
| | | | |
| | | |
| | | |
| | | | |
The stream wrapper is going to want this.
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
There is no `p_used` here; what we meant was the very same
`ClaimedQty.`
|
| |/ / / |
|
| |\ \ \
| |/ /
|/| |
| | |
| | | |
Tweak documentation for wait_for_stop slightly.
See merge request tpo/core/arti!2278
|
| |/ / |
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | | |
tor-netdoc: Dangerously expose annotation fields
Closes #1469
See merge request tpo/core/arti!2213
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This commit exposes the fields of `routerdesc::AnnotatedRouterDesc` and
`routerdesc::RouterAnnotation` with the enabled feature
`dangerous-expose-struct-fields`.
On one side, it achieves a greater consistency among the other
structures found within this module; On the other side it makes the
already public API (assuming the feature above is enabled) useable.
Fixes #1469
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
Bump openssl to 0.10.66 to satisfy cargo-audit.
See merge request tpo/core/arti!2276
|
| |/ / /
| | |
| | |
| | | |
See RUSTSEC-2024-0357.
|
| |\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
tor-keymgr: Fix bug in ArtiNativeKeystore::contains
Closes #1492
See merge request tpo/core/arti!2274
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This fixes a bug in `ArtiNativeKeystore`'s `Keystore::contains()`
implementation: previously, it called Path::exists() on the relative
path (built by concatenating the key specifier and the extension), so
unless your current directory happened to be the root of the keystore,
`contains()` would always return `false`.
`KeyMgr::generate` uses `Keystore::contains()` under the hood, so it
was affected by this bug too: if called `overwrite = false`, it would
misbehave and overwrite any existing keys.
Internally, we call `KeyMgr::generate` in a couple of places:
* `tor-hsservice/src/lib.rs`, to generate the `hsid` if it doesn't
already exist. This callsite is not affected by the bug, because
`KeyMgr::generate` is only called if `KeyMgr::get` returns `None`
* `tor-hsservice/src/ipt_mgr.rs`, to generate `KS_hss_ntor` and
`KS_hs_ipt_sid` keys for intro point establishment. This callsite is
also not affected (because it too calls `get()` before attempting to
`generate()`)
The bug affects any downstream users that use `KeyMgr::generate`
with a key manager backed by `ArtiNativeKeystore`.
------
`KeyMgr::get_or_generate` is not affected, even though it calls
`Keymgr::generate` (it performs a separate extra check before calling
`generate()`). (Both suffer from a known TOCTOU race, but that's a
separate matter.) As an aside, I'd like to somehow unify
`KeyMgr::get_or_generate` and `KeyMgr::get` (I've had some attempts in
the past but ended up abandoning them because the result was more
unergonomic than the existing APIs).
Part of #1492
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This new assertion fails, because the implementation of
`ArtiNativeKeystore::contains()` is buggy: it calls Path::exists() on
the relative path built by concatenating the key specifier and the
extension (so unless your current directory happens to be the root of
the keystore, contains() is always going to return false).
Part of #1492
|
| |\ \ \ \
| |/ / /
|/| | |
| | | |
| | | |
| | | |
| | | | |
Switch many scripts to rust-maint-common
Closes #1300 and #1
See merge request tpo/core/arti!2267
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
These are not hardcoded, whatever they are, so they're not the
principal thing we're trying to prevent. Previously, this would trip
on this in arti.git:maint/cargo-publish:
maint="$(dirname "$0")"
...
# shellcheck source=maint/crates-io-utils.sh
source "$maint/crates-io-utils.sh"
Ideally we'd teach this script to be able to check and maintain
includes for scripts that aren't in common/, but I think that's a task
for another day.
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
set -o pipefail is defused by the if. And we should properly check
the expected statuses from git.
If git isn't found, this script would otherwise spuriously think
everything is fine.
|
| | | | |
| | | |
| | | |
| | | | |
Without this, maint/shebang is broken.
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
This changes from `apt install` (which is not supposed to be used in
scripts) to `apt-get install`.
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | | |
And delete our old version of the script.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
See docs in maint/common/via-cargo-install-in-ci
This is not the same id as in our maint/via-cargo-install-in-ci,
which is deliberate. Let's flush this cache, just in case.
|
| | | | |
| | | |
| | | |
| | | | |
We're about to switch to a version that doesn't support this.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
* Change all in-tree reference
* Delete our copy of script, which now lives
in the rust-maint-common subtree.
* Leave a symlink behind, so that old git hooks that people
(IMO possibly unwisely) installed, still work.
|
| | | | |
| | | |
| | | |
| | | | |
As recommended by the README there
|
| | |\ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
'be8ec72c0b0ced653c618af564387079d9ea8e5f'
git-subtree-dir: maint/rust-maint-common
git-subtree-mainline: c05af7edf8f715b31d90d128ba6078a8094f440c
git-subtree-split: be8ec72c0b0ced653c618af564387079d9ea8e5f
|
| | | |\ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
for-every-commit: Copy from derive-deftly
See merge request tpo/core/rust-maint-common!5
|
| | | | | | | |
|
| | | | | | | |
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | | |
Resolves semantic conflict with !7
|
| | | | | | | |
|
| | | | | | | |
|
| | | | | | | |
|
| | | | | | | |
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | | |
This rune appears *so much*!
|
| | | | | | | |
|
| | | | | | | |
|
