summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * | rpc: Explain _why_ utf-8 in Utf8CString is a safety requirement.Nick Mathewson2024-07-311-0/+6
| | | | | | | | | | | | (and to what extent)
| * | Rename Utf8CStr=>Utf8CStringNick Mathewson2024-07-315-18/+18
| | |
| * | Copy suggestions from .h file to cbindgen.tomlNick Mathewson2024-07-311-7/+9
| | |
| * | Add a missing "-".Nick Mathewson2024-07-311-1/+1
| | |
| * | rpclib: Suggestions from @diziet for improving safety docs.Nick Mathewson2024-07-312-8/+11
| | |
| * | rpclib ffi: Grand identifier renamingNick Mathewson2024-07-315-71/+92
| | | | | | | | | | | | In brief: Everything now starts with ARTI_RPC, arti_rpc, or ArtiRpc.
| * | rpclib: Revise/condense "safety" docs for C functionsNick Mathewson2024-07-314-98/+78
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These documents are no longer called "safety". They are now mostly collected as a big list of "correctness requirements" at the start of the cbindgen header. Because of these requirements, most functions no longer need their own "safety" sections. I am explicitly using `#[allow(clippy::missing_safety_doc)]` on each function, rather than adding a blanket exception: - There are other unsafe functions in this code, to which we wouldn't want an exception to apply. - Documenting the safety^W correctness requirements of a function is important enough to make sure that we aren't skipping out on it unintentionally.
| * | rpc: Rename OutPtr functions for clarityNick Mathewson2024-07-313-13/+13
| | |
| * | rpclib: Grand error refactoring: outparam, not thread-localNick Mathewson2024-07-316-155/+138
| | | | | | | | | | | | | | | | | | | | | | | | Per discussion, we'd rather have an optional output parameter for error objects rather than mess with thread-local variables. This is possibly less convenient for direct usage from C, but likely more convenient for wrapper functions in other languages.
| * | rpclib: _Sketch_ of string API.Nick Mathewson2024-07-316-40/+66
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In this API, borrowed strings are `const char *`, and owned strings are `ArtiRpcStr *`. You can get the former from the latter with `arti_rpc_str_get()`, which returns a `const char *` in hopes that you will neither modify nor free() that `const char *` (Note that there are no places where string ownership needs to be passed into this library; and at present, there is only one case where it is passed out. I do not anticipate that we will need to do intake of owned strings. We will probably need to return these in a few more cases as we add more API surface.)
| * | rpclib: Add "STATUS" to status codes.Nick Mathewson2024-07-312-16/+16
| | |
| * | rpc: Improve documentation and strings for FFI status codes.Nick Mathewson2024-07-312-6/+54
| | |
| * | rpclib: Tweaks from review to header documentation.Nick Mathewson2024-07-312-6/+12
| | |
| * | rpc ffi: Try a more reference-driven approach to pointer handling.Nick Mathewson2024-07-315-31/+198
| | |
| * | Add a script to run cbindgen and check its outputs.Nick Mathewson2024-07-315-3/+550
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a bit complicated since: - Using cbindgen with macro expansion requires a nightly rust: so, we have to look for one. - There are some cbindgen warnings which I cannot find any way to suppress, so instead of giving all warnings, it seems better to give a diff from the old list of warnings to the new list.
| * | rpc: Initial core of an FFI interface.Nick Mathewson2024-07-3110-6/+830
| | | | | | | | | | | | | | | | | | | | | | | | | | | This only covers the absolute minimal API in order to launch a connection and run simple requests, and it doesn't document anything nearly well enough. Nonetheless I think it's good enough for an initial review, to make sure that we've got the basics right (as well as a general consensus on the error handling API, naming, and so forth).
| * | RPC: Make message types able to be CStr or str.Nick Mathewson2024-07-313-22/+65
| | | | | | | | | | | | (Internally, it is a boxed CStr that is always UTF-8.)
* | | Merge branch 'ci-bis' into 'main'Nick Mathewson2024-07-311-11/+17
|\ \ \ | |/ / |/| | | | | | | | CI: Fix file overlap errors on main See merge request tpo/core/arti!2297
| * | CI: Only preserve rust-recent artifacts, don't process rust-latest onesIan Jackson2024-07-311-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | The -latest jobs don't actually have artifacts. But: In the -latest jobs this can cause errors due to duplication: the artifacts from the -recent jobs in the same pipeline result in EEXIST errors.
| * | CI: Use YAML anchors rather than .extends for rust-recent/rust-latestIan Jackson2024-07-311-6/+12
|/ / | | | | | | | | This will let us make the artifact processing only happen when we want to save artifacts.
* | Merge branch 'bytemuck-update' into 'main'Ian Jackson2024-07-311-2/+2
|\ \ | | | | | | | | | | | | Update bytemuck to 1.16.3; previous version was yanked. See merge request tpo/core/arti!2294
| * | Update bytemuck to 1.16.3; previous version was yanked.Nick Mathewson2024-07-311-2/+2
|/ /
* | Merge branch 'sqlite-race' into 'main'gabi-2502024-07-312-9/+62
|\ \ | | | | | | | | | | | | | | | | | | tor-dirmgr: Return an error if storage is readonly and DB is missing/incompatbile. Closes #1497 See merge request tpo/core/arti!2283
| * | tor-dirmgr: Replace from_conn impl with a call to from_conn_internal helper.Gabriela Moldovan2024-07-301-7/+16
| | |
| * | tor-dirmgr: Return an error if storage is readonly and DB is ↵Gabriela Moldovan2024-07-302-14/+58
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | missing/incompatbile. This fixes a bug in `SqliteStore`'s constructor: previously, it would unconditionally try to create the missing database, even if it didn't have write access. As a result, it was impossible to reliably start multiple concurrent arti processes configured with the same (empty or nonexistent) cache_dir, because many of them would fail with errors such as ``` attempt to write a readonly database: Error code 8: Attempt to write a readonly database ``` Returning a `LocalResourceAlreadyInUse` error kind here enables us to leverage the retry loop from `TorClientBuilder::create_unbootstrapped` (which retries on local resource errors if `local_resource_timeout` is set). Closes #1497
* | | Merge branch 'cli-tests' into 'main'gabi-2502024-07-3134-0/+491
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | arti: Add tests for the hss/hsc subcomands Closes #1250 See merge request tpo/core/arti!2275
| * | | CI: Add TODOs about rethinking matrix_test.Gabriela Moldovan2024-07-301-0/+9
| | | | | | | | | | | | | | | | Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2275#note_3054040
| * | | editorconfig: Ignore the files from the test state dirs.Gabriela Moldovan2024-07-301-0/+8
| | | |
| * | | arti: Add tests for the arti hsc subcommand.Gabriela Moldovan2024-07-3020-0/+146
| | | |
| * | | CI: Add cli-test job.Gabriela Moldovan2024-07-301-0/+11
| | | |
| * | | arti: Add tests for the arti hss subcommand.Gabriela Moldovan2024-07-3013-0/+317
| |/ / | | | | | | | | | Closes #1250
* | | Merge branch 'rtmock-doc' into 'main'Ian Jackson2024-07-301-3/+20
|\ \ \ | | | | | | | | | | | | | | | | tor-rtmock docs: Improve discussions of mocked time See merge request tpo/core/arti!2286
| * | | tor-rtmock docs: Add some more discussion of the simulated timeIan Jackson2024-07-301-1/+17
| | | |
| * | | tor-rtmock docs: We have CoarseTimeProvider nowIan Jackson2024-07-301-2/+3
| |/ / | | | | | | | | | Improve/replace some out-of-date notes in the docs.
* | | Merge branch 'forbid-path-exists' into 'main'Ian Jackson2024-07-306-11/+19
|\ \ \ | |/ / |/| | | | | | | | | | | | | | clippy: Disallow Path::exists(). Closes #1493 See merge request tpo/core/arti!2293
| * | arti: Use Path::try_exists() instead of Path::exists().Gabriela Moldovan2024-07-301-1/+1
| | |
| * | tor-dirmgr: Use Path::try_exists() instead of Path::exists().Gabriela Moldovan2024-07-301-1/+1
| | |
| * | fs-mistrust: Use Path::try_exists() instead of Path::exists().Gabriela Moldovan2024-07-301-2/+2
| | |
| * | tor-keymgr: Use Path::try_exists() instead of Path::exists().Gabriela Moldovan2024-07-301-3/+10
| | |
| * | fslock-guard: Use Path::try_exists() instead of Path::exists().Gabriela Moldovan2024-07-301-4/+4
| | |
| * | clippy: Disallow Path::exists().Gabriela Moldovan2024-07-301-0/+1
|/ / | | | | | | Part of #1493
* | Merge branch 'pin' into 'main'David Goulet2024-07-291-31/+43
|\ \ | | | | | | | | | | | | CI: Pin Rust compiler version (mostly) See merge request tpo/core/arti!2290
| * | CI: Rename "latest" jobs to "recent"; pin them; and replace them.Ian Jackson2024-07-291-10/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We replace uses of `amd64/rust:bookworm` in the `recent-*` jobs. We add new latest-* jobs which * aren't used for artifacts * occur later in the pipeline * only run on main, since we don't want them to block MRs This is done with templates, to reuse the script parts.
| * | CI: Use RECENT_RUST_IMAGE instead of unpinned Rust, in most jobsIan Jackson2024-07-291-21/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Replace almost all the open-coded occurrences of `amd64/rust:bookworm`. This rewinds us to Rust 1.79. We can update after https://github.com/rustsec/rustsec/issues/1217 is fixed upstream. We're going to handle the rust-latest-* jobs specially. There are still a few other images that look, from the name, like they might be uncontrolled inputs into our CI, but they don't look risky. Let's leave them for now.
| * | CI: Introduce RECENT_RUST_IMAGE variableIan Jackson2024-07-291-1/+4
| | | | | | | | | | | | So far only used by the cargo-audit job.
* | | Merge branch 'circuit-reactor-tests' into 'main'Jim Newsome2024-07-292-96/+45
|\ \ \ | |/ / |/| | | | | | | | Circuit reactor test cleanup See merge request tpo/core/arti!2287
| * | tor-proto::circuit: Move test-only methods into test moduleJim Newsome2024-07-291-12/+14
| | |
| * | tor-proto circuit tests: dedupe circid magic numberJim Newsome2024-07-291-6/+15
| | |
| * | tor-proto circuit test: Move to tighter scope and shadow outer defJim Newsome2024-07-291-15/+17
| | |
| * | tor-proto circuit tests: delete stale commented-out testJim Newsome2024-07-291-66/+0
| | |
generated by cgit v1.2.3 (git 2.46.0) at 2026-08-27 15:30:11 +0000