summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* | | Merge branch 'ticket1674_01' into 'main'David Goulet2024-10-107-20/+67
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | arti-relay: Change it to a binary crate only Closes #1674 See merge request tpo/core/arti!2525
| * | | arti-relay: Rename remaining XXXs to be TODOsDavid Goulet2024-10-102-4/+4
| | | | | | | | | | | | | | | | Signed-off-by: David Goulet <[email protected]>
| * | | arti-relay: Fix cargo doc issuesDavid Goulet2024-10-102-3/+3
| | | | | | | | | | | | | | | | Signed-off-by: David Goulet <[email protected]>
| * | | arti-relay: Remove the use of pub and pub useDavid Goulet2024-10-103-10/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The "pub" and "pub(crate)" visibility in a binary crate is essentially the same except for the dead_code warning analysis which ignores "pub" but will warn at "pub(crate)". This should get fixed soon according to: https://github.com/rust-lang/rust/issues/74970 However, for now, lets catch all this dead code :). Part of #1674 Signed-off-by: David Goulet <[email protected]>
| * | | arti-relay: Remove its library crateDavid Goulet2024-10-103-6/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Simply, the lib.rs is renamed to relay.rs (containing TorRelay object) so this crate can never be used as a library. This is important because at the moment, we don't want to have a relay stable API that can be used to embed relays in applications. Closes #1674 Signed-off-by: David Goulet <[email protected]>
| * | | arti-relay: Add a binary to the crateDavid Goulet2024-10-103-1/+44
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | At the moment, it is an empty main() acting as a place holder for this crate to become solely a binary crate. Write up a basic README.md in order to explain the current state. Next commit will remove the libary component by renaming lib.rs Part of #1674 Signed-off-by: David Goulet <[email protected]>
* | | Merge branch 'orport' into 'main'David Goulet2024-10-103-20/+27
|\ \ \ | |/ / |/| | | | | | | | tor-chanmgr: some cleanup and comments See merge request tpo/core/arti!2523
| * | tor-chanmgr: fix `unused_imports` warning on `ChannelAccount`Steven Engler2024-10-091-1/+3
| | |
| * | tor-chanmgr: note API causes deadlocks under some conditionsSteven Engler2024-10-092-3/+16
| | |
| * | tor-chanmgr: minor code cleanupSteven Engler2024-10-091-5/+5
| | |
| * | tor-chanmgr: remove unused code pathSteven Engler2024-10-091-11/+3
| | |
* | | Merge branch 'mq-circ' into 'main'David Goulet2024-10-107-35/+39
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Use memquota queue for channel->circuit RX data Closes #1682 See merge request tpo/core/arti!2518
| * | | Apply deferred rustfmt churnIan Jackson2024-10-095-13/+7
| | | |
| * | | memquota: Use an mq_queue for channel->circuit RX queueIan Jackson2024-10-095-16/+18
| | | | | | | | | | | | | | | | | | | | | | | | Fixes #1682. (This involves some noise in the tests.)
| * | | memquota: Introduce type aliases for channel->circuit RX queueIan Jackson2024-10-094-13/+18
| | | | | | | | | | | | | | | | | | | | This is neater and will make changing the type (in a moment) less noisy.
| * | | memquota: impl HasMemoryCost for ClientCircChanMsgIan Jackson2024-10-091-1/+4
| | | | | | | | | | | | | | | | We'll need this in a moment.
* | | | Merge branch 'rpclib-dependency-reduction' into 'main'Nick Mathewson2024-10-108-9/+24
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | Use cargo features to reduce needless dependencies from arti-rpc-client-core See merge request tpo/core/arti!2522
| * | | | arti-rpc-client-core: remove dependency on unused tor-error feature.Nick Mathewson2024-10-091-1/+1
| | | | |
| * | | | tor-socksproto: Require fewer features from dependenciesNick Mathewson2024-10-091-2/+2
| | | | |
| * | | | tor-bytes: Make "tor-llcrypto" dependency optional.Nick Mathewson2024-10-093-3/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is part of an effort to make arti-rpc-client-core (and future similar tools) able to use our very-low-level crates without depending on things they don't need.
| * | | | tor-error: Make "futures" dependency optional.Nick Mathewson2024-10-093-3/+5
| | |/ / | |/| | | | | | | | | | | | | | | | | | This is part of an effort to make arti-rpc-client-core (and future similar tools) able to use our very-low-level crates without depending on things they don't need.
* | | | Merge branch 'c-str' into 'main'Nick Mathewson2024-10-103-25/+16
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | arti-rpc-client-core: remove 'c_str_macro' dependency See merge request tpo/core/arti!2524
| * | | | arti-rpc-client-core: remove 'c_str_macro' dependencySteven Engler2024-10-093-25/+16
| |/ / / | | | | | | | | | | | | | | | | Arti has a MSRV of rust 1.77 which supports C string literals, so 'c_str_macro' isn't needed.
* | | | Merge branch 'ctor-keystore-shadow' into 'main'gabi-2502024-10-1013-1/+102
|\ \ \ \ | |/ / / |/| | | | | | | | | | | shadow CI: Add a couple of tests involving C Tor keystores See merge request tpo/core/arti!2514
| * | | shadow CI: Add arti hidden service test using a C Tor keystore.Gabriela Moldovan2024-10-0812-0/+101
| | | |
| * | | shadow CI: Build arti with ctor-keystore support.Gabriela Moldovan2024-10-081-1/+1
| | | | | | | | | | | | | | | | This is needed to test C Tor keystore support in shadow.
* | | | Merge branch 'rpc-error-data' into 'main'Nick Mathewson2024-10-091-38/+46
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | RPC spec: try to define a little more semantics and extensibility for `data`. See merge request tpo/core/arti!2512
| * | | | rpc spec: use valid JS syntax.Nick Mathewson2024-10-091-1/+1
| | | | |
| * | | | rpc-draft: clarify how we should handle error changes.Nick Mathewson2024-10-091-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is based on a suggestion from @diziet, but edited to say that: - we will take this approach when possible, and that we're not making a categorical promise. - this approach only applies to stable fields.
| * | | | rpc spec: Revise design for `error.data` fieldNick Mathewson2024-10-091-24/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | IIUC: Previously, `error.data` was meant to be the serialized error object from Arti. As such, it was specified to be deliberately unstable, and likely to change. This didn't seem like such great idea, especially as we started to come up with structured and stable data that we _did_ want to put in `error.data`. With this commit I'm taking a new approach to `error.data`. Specifically: * `error.data`, if present, is always an object. * Unlike before, it can have multiple keys. * The keys of `error.data` are always namespaced. * There is a requirement that documentation exist for every key in an`error.data` document, including the type, semantics, and stability of its values. There is also new "anticipated use of error.data" section to clarify our plans: * We plan to use error.data deliberately when it actually serves a purpose. * We don't plan to have an on-by-default serialization or Debug of every Arti error. (If we wanted an optional one, there is a short sketch of what it might look like.)
| * | | | RPC spec: move the data field back into ErrorNick Mathewson2024-10-091-30/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is *not* how we actually want the `data` field to behave! But moving it as a separate commit will make it easier to see what changes we do make.
* | | | | Merge branch 'fix-clippy-redux' into 'main'Nick Mathewson2024-10-091-1/+1
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | tor-config: Fix indentation in doc comment. See merge request tpo/core/arti!2520
| * | | | | tor-config: Fix indentation in doc comment.Gabriela Moldovan2024-10-091-1/+1
| | |_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | It looks like my previous attempt from !2516 didn't fix it. This adds an extra space to fix the `doc_lazy_continuation` lint.
* | | | | Merge branch 'mq-doc' into 'main'Ian Jackson2024-10-095-29/+108
|\ \ \ \ \ | |/ / / / |/| | | / | | |_|/ | |/| | | | | | | | | | memquota architecture documentation Closes #1660 See merge request tpo/core/arti!2509
| * | | memquota: Expand on ChannelAccountIan Jackson2024-10-091-0/+1
| | | | | | | | | | | | | | | | | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2509#note_3089914
| * | | memquota: Add docs and TODOs re inbound channel->circuit dataIan Jackson2024-10-092-0/+3
| | | | | | | | | | | | | | | | | | | | See https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2509#note_3089913
| * | | emquota: Clarify circuit data queueIan Jackson2024-10-091-1/+1
| | | |
| * | | memquota: Further docs tweaksIan Jackson2024-10-092-2/+5
| | | |
| * | | mq docs: Clarity that chanmgr and circmgr share the ToplevelAccountIan Jackson2024-10-071-1/+3
| | | |
| * | | mq docs: Add some formulaic cross-references to memquota newtypesIan Jackson2024-10-071-0/+12
| | | |
| * | | mq docs: Rewrite and expand overview/architecture doc in tor-protoIan Jackson2024-10-071-16/+66
| | | |
| * | | mq docs: Add some cross-references from tor-memquota to tor-protoIan Jackson2024-10-072-0/+8
| | | | | | | | | | | | | | | | These can't be rustdoc links because they point up the crate hierarchy.
| * | | mq docs: Add a linkIan Jackson2024-10-071-1/+1
| | | |
| * | | mq docs: Move arti queues text to tor_proto::memquotaIan Jackson2024-10-072-24/+24
| | | |
| * | | mq docs: Uncomment docs about mq_queue, and remove the TODOIan Jackson2024-10-071-4/+4
| | | |
* | | | Merge branch 'miri-1' into 'main'Ian Jackson2024-10-0918-28/+90
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | Add some more miri tests See merge request tpo/core/arti!2502
| * | | | tor-rtmock: Add some commentary about SleepLocationIan Jackson2024-10-081-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2502#note_3090557
| * | | | tor-rtmock: Simplify two cfgIan Jackson2024-10-082-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Discussion here https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2502#note_3090554 https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2502#note_3090556
| * | | | CI: run miri on tor-persist tooIan Jackson2024-10-081-1/+1
| | | | |
| * | | | tor-persist: miri: disable tests that involve fs accessIan Jackson2024-10-084-4/+10
| | | | |