summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | tor-keymgr: Test that KeyMgr::list_matching returns the right descriptors.Gabriela Moldovan2024-02-191-2/+16
| | | |
| * | | tor-keymgr: Test KeyMgr::{get_entry, remove_entry}.Gabriela Moldovan2024-02-191-0/+27
| | | |
| * | | tor-keymgr: Remove a TODO.Gabriela Moldovan2024-02-191-2/+0
| | | | | | | | | | | | | | | | | | | | I am not so sure it makes sense to unify these functions, so let's remove the TODO.
| * | | tor-keymgr: Remove outdated reference to KeyMgr::get_with_type.Gabriela Moldovan2024-02-191-1/+1
| | | |
| * | | tor-keymgr: Replace KeyMgr::get_with_type with KeyMgr::get_entry (fmt).Gabriela Moldovan2024-02-191-4/+1
| | | |
| * | | tor-keymgr: Replace KeyMgr::get_with_type with KeyMgr::get_entry.Gabriela Moldovan2024-02-193-10/+11
| | | | | | | | | | | | | | | | Part of #1271
| * | | tor-keymgr: Rename KeyMgr::remove_with_type to KeyMgr::remove_entry.Gabriela Moldovan2024-02-194-9/+15
| | | | | | | | | | | | | | | | Part of #1271
| * | | tor-keymgr: Make KeyMgr::remove_with_type take a KeystoreEntry (fmt).Gabriela Moldovan2024-02-191-4/+1
| | | |
| * | | tor-keymgr: Make KeyMgr::remove_with_type take a KeystoreEntry.Gabriela Moldovan2024-02-194-16/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | NB: `KeyMgr::remove_with_type` will need to be renamed to `KeyMgr::remove_entry`. Part of #1271
| * | | tor-keymgr: Derive From for KeystoreSelector.Gabriela Moldovan2024-02-191-2/+2
| | | | | | | | | | | | | | | | We will soon use this in `KeyMgr`.
| * | | tor-keymgr: Make KeyMgr::list_matching return `KeystoreEntry`s.Gabriela Moldovan2024-02-195-9/+20
| | | | | | | | | | | | | | | | Part of #1271
| * | | tor-keymgr: Add KeystoreEntry.Gabriela Moldovan2024-02-193-1/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This type will soon replace `(KeyPath, KeyType)` in `KeyMgr::list_matching`. The KeystoreEntry documentation mentions a couple of functions that don't exist right now (they will be added in a subsequent commit). Part of #1271
* | | | Merge branch 'generational-exception' into 'main'Ian Jackson2024-02-191-0/+8
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | cargo_audit: Add an exception for RUSTSEC-2024-0014. See merge request tpo/core/arti!1990
| * | | | cargo_audit: Add an exception for RUSTSEC-2024-0014.Gabriela Moldovan2024-02-191-0/+8
|/ / / / | | | | | | | | | | | | | | | | We should migrate to `slotmap`, but in the meantime let's just add an exception to unblock CI.
* | | | Merge branch 'better_hints' into 'main'Ian Jackson2024-02-197-56/+195
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | Refactor and improve error hinting. Closes #1165 See merge request tpo/core/arti!1986
| * | | Add tests for finding (or not) hints in our error types.Nick Mathewson2024-02-161-0/+58
| | | |
| * | | Discourage providing HintableErrorImpl without using the macro.Nick Mathewson2024-02-161-3/+10
| | | |
| * | | Rename one of the hint methods to hint_specificNick Mathewson2024-02-161-3/+10
| | | |
| * | | Use and document the new arti-client/anyhow featureNick Mathewson2024-02-152-1/+5
| | | |
| * | | Refactor and improve error hinting.Nick Mathewson2024-02-145-55/+118
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Instead of using complicated match statements, use downcasting to find error types that define specific hints. This also lets us define a reasonable hint-extractor for anyhow::Error, and use it when reporting errors in main. I've left an implementation of hint() in `impl Error`, to avoid breaking backward compatibility. Closes #1165.
* | | | Merge branch 'shadow-igraph' into 'main'Alexander Færøy2024-02-151-23/+4
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | shadow ci: stop pulling libigraph from bullseye See merge request tpo/core/arti!1958
| * | | | shadow ci: stop pulling libigraph from bullseyeJim Newsome2024-02-051-19/+2
| | | | | | | | | | | | | | | | | | | | | | | | | Now that https://github.com/shadow/tgen/issues/44 is fixed, we no longer need to do this.
| * | | | shadow ci: bump to latest tgen releaseJim Newsome2024-02-051-1/+1
| | | | |
| * | | | shadow ci: bump to latest shadow releaseJim Newsome2024-02-051-3/+1
| | | | |
* | | | | Merge branch 'expire-ipts-bis' into 'main'Nick Mathewson2024-02-155-101/+129
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Code cleanup for IPT external state expiry See merge request tpo/core/arti!1982
| * | | | | tor-hsservice: ipt mgr: Remove/downgrade two allowsIan Jackson2024-02-131-2/+1
| | | | | |
| * | | | | tor-hsservice: ipt mgr: expiry: Add some commentsIan Jackson2024-02-131-0/+4
| | | | | |
| * | | | | tor-hsservice: ipt mgr: expiry: Break out all_ipts (fmt)Ian Jackson2024-02-131-4/+1
| | | | | |
| * | | | | tor-hsservice: ipt mgr: expiry: Break out all_iptsIan Jackson2024-02-131-8/+15
| | | | | | | | | | | | | | | | | | | | | | | | And clarify docs for the *current* ipt functions.
| * | | | | tor-hsservice: ipt mgr: expiry: rename a variableIan Jackson2024-02-131-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | "current" has a special meaning here: it means an IPT that we haven't replaced with another at the same relay due to number of requests.
| * | | | | tor-hsservice: replay: Fix an error message slightlyIan Jackson2024-02-131-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | On Windows filenames are WTF-16, not bytes, so a weird filename fails to be UTF-16 rather than failing to be UTF-8.
| * | | | | tor-hsservice: ipt mgr: Move/rename to StateExpiryError (fmt)Ian Jackson2024-02-131-3/+1
| | | | | |
| * | | | | tor-hsservice: ipt mgr: Move/rename to StateExpiryError (followup)Ian Jackson2024-02-131-4/+4
| | | | | |
| * | | | | tor-hsservice: ipt mgr: Move/rename to StateExpiryErrorIan Jackson2024-02-132-39/+41
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The private ExpiryError type is now err::StateExpiryError. We'll fix up the local alias in the HasKind impl in a moment.
| * | | | | tor-hsservice: replay: Move replay filename knowledge into replay.rs (fmt)Ian Jackson2024-02-131-10/+5
| | | | | |
| * | | | | tor-hsservice: replay: Move replay filename knowledge into replay.rsIan Jackson2024-02-132-41/+58
| | | | | |
| * | | | | tor-hsservice: tests: Greak out mk_state_instance helperIan Jackson2024-02-131-3/+12
| | | | | |
| * | | | | tor-hsservice: Expose HsNickname::newIan Jackson2024-02-131-1/+1
| | |/ / / | |/| | | | | | | | | | | | | | | | | | The non-visibility of this method seems like it must have been an oversight.
* | | | | Merge branch 'publisher-bug-upload-res' into 'main'Nick Mathewson2024-02-151-1/+2
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | tor-hsservice: The publisher should process all upload results. See merge request tpo/core/arti!1983
| * | | | tor-hsservice: The publisher should process all upload results.Gabriela Moldovan2024-02-141-1/+2
|/ / / / | | | | | | | | | | | | | | | | | | | | If one of the upload results is for an HsDir that went away, the publisher should continue processing the remaining ones, not disregard them entirely.
* | | | Merge branch 'empty_data' into 'main'Nick Mathewson2024-02-134-15/+43
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | tor_cell: Reject empty DATA messages Closes #1269 See merge request tpo/core/arti!1981
| * | | | tor_cell: never construct empty DATA messages.Nick Mathewson2024-02-134-15/+40
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We never actually constructed these before, but now we enforce it at the API level. Part of #1269.
| * | | | tor_cell: Reject empty DATA messagesNick Mathewson2024-02-131-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If we don't reject these, they are a way to inject an undetected traffic signal. (This is LOW severity, since we only accept DATA when a stream is open, since DATA messages are rate-limited, and since using length==1 is nearly as effective.) Closes #1269. This is TROVE-2024-001.
* | | | | Merge branch 'expire-ipts' into 'main'Ian Jackson2024-02-133-22/+261
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | tor-hsservice: Expire old on-disk IPT state See merge request tpo/core/arti!1977
| * | | | tor-hsservice: ipt mgr: Temporarily suppress a lintIan Jackson2024-02-131-0/+1
| | | | |
| * | | | tor-hsservice: ipt mgr: Check that file expiry happens precisely when wantedIan Jackson2024-02-131-4/+20
| | | | | | | | | | | | | | | | | | | | | | | | | This test detects the bug mentioned here https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1977#note_2995265
| * | | | tor-hsservice: ipt mgr: Add a test hook for expiryIan Jackson2024-02-131-0/+24
| | | | |
| * | | | tor-hsservice: ipt mgr: Do old IPT file cleanup on startup tooIan Jackson2024-02-131-0/+4
| | | | | | | | | | | | | | | | | | | | This isn't strictly necessary, but it's better.
| * | | | tor-hsservice: ipt mgr: Explain about the ipt_set invariantIan Jackson2024-02-131-0/+6
| | | | | | | | | | | | | | | | | | | | This seemed to warrant some discussion and a cross-reference.
| * | | | tor-hsservice: ipt mgr: Rewrite state expiry doc commentIan Jackson2024-02-131-3/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1977#note_2994999 https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1977#note_2995000