| Commit message (Collapse) | Author | Age | Files | Lines | ||
|---|---|---|---|---|---|---|
| ... | ||||||
| | * | | tor-hsservice: IptKeyRole: impl FromStr and KeySpecifierComponent | Ian Jackson | 2023-12-07 | 1 | -1/+4 | |
| | | | | ||||||
| | * | | tor-hsservice: IptLocalId: impl KeySpecifierComponent | Ian Jackson | 2023-12-07 | 1 | -0/+3 | |
| | | | | ||||||
| | * | | tor-hsservice: IptLocalId: impl FromStr (fmt) | Ian Jackson | 2023-12-07 | 1 | -4/+2 | |
| | | | | ||||||
| | * | | tor-hsservice: IptLocalId: impl FromStr | Ian Jackson | 2023-12-07 | 2 | -27/+18 | |
| | | | | | | | | | | | | | And implement serde that way, using SerdeStringOrTransparent. | |||||
| | * | | tor-hsservice: Expose SerdeStringOrTransparent to crate | Ian Jackson | 2023-12-07 | 2 | -2/+4 | |
| | | | | | | | | | | | | | | | | And make it useable elsewhere by not expecting the particular error type. | |||||
| | * | | tor-keymgr: Make KeySpecifierComponent::as_component fallible (fmt) | Ian Jackson | 2023-12-07 | 1 | -3/+8 | |
| | | | | ||||||
| | * | | tor-keymgr: Make KeySpecifierComponent::as_component fallible | Ian Jackson | 2023-12-07 | 2 | -29/+36 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This allows a principled implentation via Display. The alternative would be to have runtime panics whenever someone uses KeySpecifierComponentViaDisplayFromStr but the Display impl can produce wrong syntax (that doesn't fit in an ArtiPathComponent). Bug seems like the right error since implemnting KeySpecifierComponent implies that every value is representable in an ArtiPathComponent. | |||||
| | * | | tor-keymgr: Introduce InvalidKeyPathComponentValue errors (fmt) | Ian Jackson | 2023-12-07 | 2 | -11/+9 | |
| | | | | ||||||
| | * | | tor-keymgr: Introduce InvalidKeyPathComponentValue errors | Ian Jackson | 2023-12-07 | 3 | -15/+74 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | This is a variant in KeyPathError, which contains the actual wrong value, and the key name. But it is also a unit struct to return from the trait impl. This replaces ArtiPathError::InvalidDenotator. | |||||
| | * | | tor-hsservice: Prepare for different denotator error handling | Ian Jackson | 2023-12-07 | 1 | -5/+6 | |
| | | | | | | | | | | | | | | | | Save the ArtiPathComponent in a variable and separate out the Ok(tp) for clarity. No functional change. | |||||
| | * | | tor-keymgr: Have KeySpecifierComponent::from_component take a ref | Ian Jackson | 2023-12-07 | 2 | -7/+7 | |
| | | | | | | | | | | | | | | | | Call sites are shortly going to need the component on the error path, so this function ought probably not to consume it. | |||||
| | * | | tor-keymgr: Make two errors not be Copy | Ian Jackson | 2023-12-07 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | This is a hostage to fortune. (In a previous version of !1796 I wanted to make it untrue.) | |||||
| | * | | tor-keymgr: KeySpecifierDefault: role: allow runtime value | Ian Jackson | 2023-12-07 | 1 | -15/+72 | |
| | | | | | | | | | | | | | Make it possible for the role to be a field. | |||||
| | * | | tor-keymgr: KeySpecifierDefault: Use meta as str | Ian Jackson | 2023-12-07 | 1 | -3/+6 | |
| | | | | | | | | | | | | | This saves on some stringify! and improves error checking. | |||||
| | * | | tor-keymgr: KeySpecifierDefault: fixed_path_component feature | Ian Jackson | 2023-12-07 | 1 | -0/+29 | |
| | | | | ||||||
| | * | | tor-keymgr: KeySpecifierDefault: recast field loop | Ian Jackson | 2023-12-07 | 1 | -1/+2 | |
| | | | | | | | | | | | | | | | | We're going to do another per-field thing that doesn't want this condition. | |||||
| | * | | tor-keymgr: KeySpecifierDefault: ctor_path feature | Ian Jackson | 2023-12-07 | 1 | -8/+47 | |
| | | | | ||||||
| | * | | tor-keymgr: KeySpecifierDefault: Document attributes more formally | Ian Jackson | 2023-12-07 | 1 | -1/+20 | |
| | | | | | | | | | | | | | | | | | | | The `summary` attribute refers to a field in KeyPathInfo but this field isn't public. We can refer to builder, but there should be getters or something. | |||||
| | * | | tor-keymgr: KeySpecifierDefault: Move dead code allow | Ian Jackson | 2023-12-07 | 1 | -5/+1 | |
| | | | | ||||||
| | * | | tor-keymgr: KeyPathInfo: Provide builder() method | Ian Jackson | 2023-12-07 | 1 | -4/+11 | |
| | | | | | | | | | | | | | Otherwise the KeyPathInfo rustdocs don't have a method for making one. | |||||
| | * | | tor-keymgr: Replace assert_key_specifier_rountrip macro with function (fmt) | Ian Jackson | 2023-12-07 | 2 | -26/+8 | |
| | | | | | | | | | | | | | Formatting churn at call sites. | |||||
| | * | | tor-keymgr: Replace assert_key_specifier_rountrip macro with function | Ian Jackson | 2023-12-07 | 3 | -45/+50 | |
| | | | | | | | | | | | | | The new function checks both directions. The (misspelled) macro didn't. | |||||
| | * | | tor-keymgr: provide KeySpecifierComponentViaDisplayFromStr and use it | Ian Jackson | 2023-12-07 | 3 | -39/+24 | |
| | | | | | | | | | | | | | Now the only manual impl is TimePeriod, which is indeed special. | |||||
| | * | | ArtiPaths: derive FromStr for ArtiPath ArtiPathComponent HsNickname (fmt) | Ian Jackson | 2023-12-07 | 2 | -4/+27 | |
| | | | | | | | | | | | | | Mandatory horrible formatting. | |||||
| | * | | ArtiPaths: derive FromStr for ArtiPath ArtiPathComponent HsNickname | Ian Jackson | 2023-12-07 | 2 | -0/+3 | |
| | | | | ||||||
| * | | | Merge branch 'hss_status' into 'main' | Nick Mathewson | 2023-12-07 | 5 | -13/+184 | |
| |\ \ \ | | | | | | | | | | | | | | | | | Add a status API to OnionService. See merge request tpo/core/arti!1797 | |||||
| | * | | | Add a "Shutdown" status, and clarify places where status should change. | Nick Mathewson | 2023-12-07 | 4 | -5/+19 | |
| | | | | | ||||||
| | * | | | Add a status API to OnionService. | Nick Mathewson | 2023-12-07 | 3 | -11/+168 | |
| | |/ / | | | | | | | | | | | | | | | | (This doesn't yet send any status events.) Begins work on arti#1083. | |||||
| * | | | Merge branch 'new-toml' into 'main' | Nick Mathewson | 2023-12-07 | 10 | -21/+33 | |
| |\ \ \ | |/ / |/| | | | | | | | | upgrade to toml 0.8.8 See merge request tpo/core/arti!1794 | |||||
| | * | | upgrade to toml 0.8.8 | Nick Mathewson | 2023-12-05 | 10 | -21/+33 | |
| | |/ | ||||||
| * | | Merge branch 'warn' into 'main' | Ian Jackson | 2023-12-06 | 2 | -5/+6 | |
| |\ \ | | | | | | | | | | | | | tor-keymgr: Fix some docs warnings See merge request tpo/core/arti!1803 | |||||
| | * | | tor-keymgr: Fix some docs warnings | Ian Jackson | 2023-12-06 | 2 | -5/+6 | |
| | | | | | | | | | | | | | | | | Fixes cargo doc --locked --workspace --all-features --document-private-items | |||||
| * | | | Merge branch 'audit' into 'main' | gabi-250 | 2023-12-06 | 1 | -4/+4 | |
| |\| | | | | | | | | | | | | | | Update zerocopy See merge request tpo/core/arti!1804 | |||||
| | * | | Update zerocopy | Ian Jackson | 2023-12-06 | 1 | -4/+4 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The version in our lockfile was yanked because of this bug https://github.com/google/zerocopy/pull/672 Our use of zerocopy is only via ahash and AFAICT it doesn't provide it with any affected types. It's not clear to me if the bug is an unsoundness bug. There isn't a RustSec advisory atm. | |||||
| * | | | Merge branch 'publisher-wallclock-bug' into 'main' | Ian Jackson | 2023-12-06 | 1 | -3/+12 | |
| |\ \ \ | |/ / |/| | | | | | | | | tor-hsservice: Add more info to an internal error. See merge request tpo/core/arti!1799 | |||||
| | * | | tor-hsservice: Add more info to an internal error (fmt). | Gabriela Moldovan | 2023-12-05 | 1 | -6/+7 | |
| | | | | ||||||
| | * | | tor-hsservice: Add more info to an internal error. | Gabriela Moldovan | 2023-12-05 | 1 | -1/+9 | |
| |/ / | | | | | | | | | Logging the current time and the start of the time period might help us debug #1143 (we'll at least know how far off `now` is from `start`). | |||||
| * | | Merge branch 'expire-old-keys' into 'main' | gabi-250 | 2023-12-05 | 18 | -143/+720 | |
| |\ \ | |/ |/| | | | | | | | | | tor-keymgr, tor-hsservice: Add functions for extracting key info and add KeystoreSweeper Closes #1127 and #1043 See merge request tpo/core/arti!1784 | |||||
| | * | tor-hsservice: Fix clippy warning. | Gabriela Moldovan | 2023-12-05 | 1 | -1/+1 | |
| | | | ||||||
| | * | tor-hsservice: Wrap some long lines in a helper macro. | Gabriela Moldovan | 2023-12-05 | 1 | -4/+11 | |
| | | | ||||||
| | * | tor-keymgr: Update wording in TODO. | Gabriela Moldovan | 2023-12-05 | 1 | -1/+1 | |
| | | | ||||||
| | * | tor-hsservice: Add a cross-reference to KeystoreSweeper. | Gabriela Moldovan | 2023-12-05 | 1 | -0/+7 | |
| | | | ||||||
| | * | tor-keymgr: Call inventory::collect in the dummy keymgr too. | Gabriela Moldovan | 2023-12-05 | 1 | -0/+2 | |
| | | | | | | | | | | | Not calling it results in an error (it instantiates the plugin registry for our type). | |||||
| | * | tor-keymgr: Mention KeyMgr::describe in the KeyInfoExtractor docs. | Gabriela Moldovan | 2023-12-05 | 1 | -0/+3 | |
| | | | ||||||
| | * | tor-keymgr: Remove outdated references to KeyDenotator. | Gabriela Moldovan | 2023-12-05 | 1 | -6/+6 | |
| | | | ||||||
| | * | tor-keymgr: Explain when KeySpecifierComponent should be implemented. | Gabriela Moldovan | 2023-12-05 | 1 | -0/+6 | |
| | | | ||||||
| | * | tor-keymgr: Abolish the KeyDenotator trait in favour of KeyPathComponent (fmt). | Gabriela Moldovan | 2023-12-05 | 3 | -9/+19 | |
| | | | ||||||
| | * | tor-keymgr: Abolish the KeyDenotator trait in favour of KeyPathComponent. | Gabriela Moldovan | 2023-12-05 | 3 | -68/+29 | |
| | | | ||||||
| | * | tor-keymgr: Use Bug instead of KeyPathInfoBuild. | Gabriela Moldovan | 2023-12-05 | 1 | -6/+5 | |
| | | | ||||||
| | * | tor-keymgr: Describe the key, not the specifier in the test key summaries. | Gabriela Moldovan | 2023-12-05 | 1 | -5/+5 | |
| | | | ||||||
