summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * | state_dir sketch: Use KIND/INSTANCE rather than KIND_INSTANCEIan Jackson2024-01-121-10/+10
| | | | | | | | | | | | | | | | | | Both my colleages prefer it that way. There's no implementation yet to change.
| * | state_dir sketch: Introduce InstanceRawSubdir including the lock guardIan Jackson2024-01-121-2/+17
| | | | | | | | | | | | | | | Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1853#note_2983413
| * | state_dir sketch: Reference the slug ticketIan Jackson2024-01-121-0/+4
| | |
| * | state_dir sketch: Provide a comprehensive exampleIan Jackson2024-01-121-0/+70
| | |
| * | state_dir sketch: Fix API: InstanceIdStringIan Jackson2024-01-121-1/+21
| | | | | | | | | | | | It should have as_ref and as_str and Display and TryFrom<String>.
| * | state_dir sketch: Fix API: Fallible methodsIan Jackson2024-01-121-3/+3
| | | | | | | | | | | | Some methods were missing the Result.
| * | state_dir sketch: Fix API: Fix SlugIan Jackson2024-01-121-3/+5
| | | | | | | | | | | | | | | We need to implement it. And we need to take it ?Sized so that &str works without the user having to write another &.
| * | state_dir sketch: Fix API: Add missing self paraemetersIan Jackson2024-01-121-2/+2
| | |
| * | state_dir sketch: Fix API: make things pubIan Jackson2024-01-121-8/+8
| | | | | | | | | | | | These should have been pub all along.
| * | state_dir sketch: Make the module public for doctestsIan Jackson2024-01-122-1/+7
| | | | | | | | | | | | This will let us make a tested example in the module doc.
| * | state_dir sketch: Pass more information to disposeIan Jackson2024-01-123-3/+23
| | | | | | | | | | | | | | | Provide the last modification time too, since we have it. This allows handlers to things not contemplated by the convenience API.
| * | state_dir sketch: Fix purge trait APIIan Jackson2024-01-121-13/+32
| | | | | | | | | | | | | | | | | | | | | | | | This needs to take a value. The caller is going to have some context, eg a configured list of instances. This means that it no longer has InstanceIdentity as a supertrait. Have the purge handler return the retain for time as a method.
| * | state_dir sketch: Rename "expire" to "purge"Ian Jackson2024-01-121-9/+9
| | | | | | | | | | | | | | | Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1853#note_2983029
| * | state_dir sketch: Make flock guards and locking clearerIan Jackson2024-01-121-3/+8
| | |
| * | state_dir sketch: Rename Liveness::PossiblyUnused from UnusedIan Jackson2024-01-121-3/+5
| | | | | | | | | | | | | | | | | | It is OK to return this even for used things, or if you don't know - the API user (trait implementor) gets a second bite at the cherry in `dispose`.
| * | state_dir sketch: Make an ExpirableInstanceIdentity traitIan Jackson2024-01-121-10/+31
| | | | | | | | | | | | | | | Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1853#note_2982352
| * | state_dir sketch: Make an InstanceIdentity traitIan Jackson2024-01-121-19/+45
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This gives us somewhere central to hang the rules about names, and avoids us passing un-typed strings into the StateDirectory methods. This inhibits certain kinds of future dynamism, without more work, but that's fine. (It also produces more generics in the functions, but we can avoid too much monomorphisation with the inner function pattern.) Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1853#note_2982354
| * | state_dir sketch: Make a Slug traitIan Jackson2024-01-121-7/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | This gives us somewhere central to hang the rules about slugs. (The trait is just an alias for ToString.) Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1853#note_2982354
| * | state_dir sketch: Rename InstanceIdString (from InstanceIdentity)Ian Jackson2024-01-121-5/+5
| | | | | | | | | | | | | | | We're going to want the InstanceIdentity name for a trait. Also this is clearer I think.
| * | Proposed new state facilityIan Jackson2024-01-123-0/+418
| |/ | | | | | | | | | | | | | | | | | | | | | | A proposal for #1163. I haven't updated any of the calling code in tor-hsservice yet. I think the way this will be used ought to be fairly obvious from the API. This commit also contains a file of notes about stuff I found in an arti state directory. These may be too random even to put in doc/dev/notes, so for now I've put them next to state_dir.rs.
* | Merge branch 'netdoc-todo-triage' into 'main'Nick Mathewson2024-01-122-3/+4
|\ \ | | | | | | | | | | | | netdoc: Triage some TODO HSS See merge request tpo/core/arti!1878
| * | tor-netdoc: Turn a TODO HSS into #1221.Gabriela Moldovan2024-01-111-1/+2
| | |
| * | tor-netdoc: Downgrade some TODO HSS to TODO.Gabriela Moldovan2024-01-112-2/+2
| |/
* | Merge branch 'downgrade-todo' into 'main'Nick Mathewson2024-01-121-1/+1
|\ \ | | | | | | | | | | | | tor-hsservice: Downgrade a TODO HSS to TODO. See merge request tpo/core/arti!1877
| * | tor-hsservice: Downgrade a TODO HSS to TODO.Gabriela Moldovan2024-01-111-1/+1
| |/
* | Merge branch 'hsservice-state-triage' into 'main'Nick Mathewson2024-01-121-2/+2
|\ \ | |/ |/| | | | | tor-hsservice: Replace TODO HSS with references to gitlab issues. See merge request tpo/core/arti!1876
| * tor-hsservice: Replace TODO HSS with references to gitlab issues.Gabriela Moldovan2024-01-111-2/+2
|/ | | | | This whole file will go away when this comment is addressed: https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1837#note_2977513
* Merge branch 'ratelim' into 'main'Nick Mathewson2024-01-113-7/+14
|\ | | | | | | | | tor-hsservice: todos: Use log_ratelim at one call site See merge request tpo/core/arti!1871
| * tor-hsservice: todos: Use log_ratelim at one call siteIan Jackson2024-01-113-7/+14
| |
* | Merge branch 'todo-replay' into 'main'gabi-2502024-01-111-3/+3
|\ \ | | | | | | | | | | | | tor-hsservice: todos in replay.rs See merge request tpo/core/arti!1869
| * | tor-hsservice: todos: Remove blanket allowIan Jackson2024-01-111-2/+0
| | | | | | | | | | | | We now have more fine-grained allows.
| * | tor-hsservice: todos: reference a new ticket about flushingIan Jackson2024-01-111-0/+1
| | | | | | | | | | | | | | | Deciding what to do about this *is* a MUST, but maybe we'll downgrade that ticket.
| * | tor-hsservice: todos: reference a new ticket about the partial write bugIan Jackson2024-01-111-1/+1
| | | | | | | | | | | | This *is* a MUST.
| * | tor-hsservice: todos: reference the ephemeral services ticketIan Jackson2024-01-111-0/+1
| |/ | | | | | | This isn't a MUST.
* | Merge branch 'todo-iptset' into 'main'gabi-2502024-01-111-2/+1
|\ \ | | | | | | | | | | | | tor-hsservice: todos: triage for ipt_set See merge request tpo/core/arti!1872
| * | tor-hsservice: todos: Remove a done TODOIan Jackson2024-01-111-1/+0
| | | | | | | | | | | | The call to `load` is right there!
| * | tor-hsservice: todos: Add another parameter to the ticketIan Jackson2024-01-111-1/+1
| |/ | | | | | | This is a MUST ticket.
* | Merge branch 'todo-ttd' into 'main'gabi-2502024-01-111-1/+0
|\ \ | | | | | | | | | | | | tor-hsservice: todos: Drop one now-unneeded allow See merge request tpo/core/arti!1873
| * | tor-hsservice: todos: Drop one now-unneeded allowIan Jackson2024-01-111-1/+0
| |/
* | Merge branch 'todo-errorkind' into 'main'Alexander Færøy2024-01-111-1/+1
|\ \ | | | | | | | | | | | | todos: Reference a new ticket about errorkinds See merge request tpo/core/arti!1874
| * | todos: Reference a new ticket about errorkindsIan Jackson2024-01-111-1/+1
| |/
* | Merge branch 'todo-mgr' into 'main'Nick Mathewson2024-01-111-92/+24
|\ \ | |/ |/| | | | | | | | | tor-hsservice: todos: Triage/downgrade/ticketfy in ipt_mgr.rs Closes #1074 See merge request tpo/core/arti!1870
| * tor-hsservice: todos: Reference the general status ticketIan Jackson2024-01-111-1/+1
| |
| * tor-hsservice: todos: Reference a new logging ticketIan Jackson2024-01-111-1/+1
| | | | | | | | I have tagged this as UX but *not* MUST.
| * tor-hsservice: todos: Reference the tickets for expiryIan Jackson2024-01-111-1/+2
| | | | | | | | | | The referenced #1198 is a MUST ticket. #1067 relates to no-longer-configred services and is in the Security milestone.
| * tor-hsservice: todos: Reference the ticket for ipt mgr testsIan Jackson2024-01-111-5/+5
| | | | | | | | This is *not* a MUST ticket.
| * tor-hsservice: todos: Permanently accept 2 clippy warningsIan Jackson2024-01-111-2/+2
| |
| * tor-hsservice: todos: Remove an obsolete allow.Ian Jackson2024-01-111-1/+0
| |
| * tor-hsservice: todos: Remove unused merge_join_subset_byIan Jackson2024-01-111-67/+1
| | | | | | | | | | | | | | This is a rather specialised function which we had for a previous data structure but no longer use. Just get rid of it.
| * tor-hsservice: todos: Add more work to #1210Ian Jackson2024-01-111-4/+4
| |
generated by cgit v1.2.3 (git 2.46.0) at 2026-08-27 17:28:24 +0000