summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | Give an error on duplicate call to allow_stream_requests.Nick Mathewson2024-01-172-8/+2
| | | | | | | | | | | | | | | | Closes #1190
| * | | proto: Close circuit _intentionally_ when Request Sink is dropped.Nick Mathewson2024-01-172-8/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In theory, it might be better to just un-register the IncomingStreamRequestHandler when the Receiver for the stream requests is dropped. However, there are two reasons not to do so: 1. It's tricky. We never actually poll on the corresponding Sink, so there isn't a place where the Reactor would expect to get a prompt notification of closure. We only find out that the Receiver has been dropped when an attempt to send on the Sink returns an `is_disconnected` error. 2. It's unnecessary. In the Tor protocols, once we have decided to accept incoming stream requests on a circuit, we want to continue to do so until one of the parties closes the circuit. I've documented this in several comments, in case whe want to get fancier in the future. Closes #1188.
| * | | proto: Send END when buffer of IncomingRequests is fullNick Mathewson2024-01-172-13/+14
| | |/ | |/| | | | | | | Closes #1189.
* | | Merge branch 'close_1224' into 'main'gabi-2502024-01-172-5/+9
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | hsservice: Document circ lifetime in OpenSession. Closes #1224 See merge request tpo/core/arti!1894
| * | | hsservice: Document circ lifetime in OpenSession.Nick Mathewson2024-01-172-5/+9
| |/ / | | | | | | | | | | | | Closes #1224, by making it more clear that we aren't keeping a circuit alive indefinitely.
* | | Merge branch 'close_1191' into 'main'gabi-2502024-01-171-3/+0
|\ \ \ | |/ / |/| | | | | | | | | | | | | | Remove TODO for #1191 Closes #1191 See merge request tpo/core/arti!1893
| * | Remove TODO for #1191Nick Mathewson2024-01-171-3/+0
|/ / | | | | | | | | | | The bug described here was already fixed as #1065 via !1681. Closes #1191.
* | Merge branch 'is_hs_intro_point' into 'main'Nick Mathewson2024-01-165-16/+22
|\ \ | | | | | | | | | | | | | | | | | | RouterStatus: Add test functions for Fast and Stable flags. Closes #1240 See merge request tpo/core/arti!1884
| * | semver note.Nick Mathewson2024-01-161-0/+1
| | |
| * | ipt_mgr: Remove todo-#1211Nick Mathewson2024-01-161-12/+7
| | | | | | | | | | | | | | | | | | All appropriate checks here should be in `is_hs_intro_point()`. Closes #1211.
| * | netdir: Only choose Stable relays as introduction points.Nick Mathewson2024-01-161-3/+1
| | | | | | | | | | | | | | | | | | This implements Relay::is_hs_intro_point. Close #1240.
| * | netdir: flag every testnet relay as Fast and StableNick Mathewson2024-01-161-1/+5
| | | | | | | | | | | | | | | As we enforce these flags in more places, it will be handy for our default network to have them for its relays.
| * | RouterStatus: Add test functions for Fast and Stable flags.Nick Mathewson2024-01-161-0/+8
| | | | | | | | | | | | | | | (We don't need Fast right now, but we will certainly need it down the line.)
* | | Merge branch 'err_on_no_onion_service_support' into 'main'Nick Mathewson2024-01-165-6/+53
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | Give an error when user configured onion services with no support. Closes #1184 See merge request tpo/core/arti!1885
| * | On error, suggest recompiling with onion-service-servicegabi-2502024-01-161-1/+1
| | |
| * | Give an error when user configured onion services with no support.Nick Mathewson2024-01-164-5/+52
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We do this by adding a stub config and config builder type, whose only purpose is to generate an error if anything is deserialized into it. (If this turns out not to be the best pattern, we can change it later, since this is all internal to the `arti` crate.) Closes #1184.
| * | config: Fix output of NoCompileTimeSupport::withinNick Mathewson2024-01-161-1/+1
| |/ | | | | | | | | Previously, within() would transform this error variant into Invalid.
* | Merge branch 'remove_unimplemented_unix_proxy' into 'main'gabi-2502024-01-164-13/+26
|\ \ | |/ |/| | | | | | | | | hsrproxy: Temporarily remove ability to config unix addresses Closes #1245 See merge request tpo/core/arti!1886
| * hsrproxy: Temporarily remove ability to config unix addressesNick Mathewson2024-01-164-13/+26
|/ | | | | | | | I'm taking this out for now since we don't have support for actually making these addresses work, and the current behavior will just ignore connections silently. Closes #1245
* Merge branch 'hsservice_todos_misc_part2' into 'main'Nick Mathewson2024-01-152-43/+57
|\ | | | | | | | | Triage most remaining TODO HSS items in tor-hsservice See merge request tpo/core/arti!1880
| * Typo fixesgabi-2502024-01-151-2/+2
| |
| * Downgrade a TODO about dropping unlisted ipts to #1239Nick Mathewson2024-01-131-1/+1
| |
| * hsservice: Replace TODO comment about intro_established checking with #1238.Nick Mathewson2024-01-131-1/+1
| |
| * Rename IptEstablisher::{new => launch}Nick Mathewson2024-01-132-3/+2
| |
| * hsservice: Turn TODOs about ipt_establisher error handling to #1237Nick Mathewson2024-01-131-6/+6
| |
| * hsservice: Remove TODO HSS about a type that is already Arc.Nick Mathewson2024-01-131-2/+0
| |
| * hsservice: Replace shutdown-TODO HSS with references to #1236Nick Mathewson2024-01-131-2/+2
| |
| * Downgrade a TODO about wanting a better API.Nick Mathewson2024-01-131-1/+1
| |
| * hsservice: Remove an erroneous TODONick Mathewson2024-01-131-1/+1
| | | | | | | | | | k_sid was not redundant with RequestContext: the latter only held the public key, but the reactor here needed the entire keypair.
| * hsservice: Convert TODOs about ipt reconfiguration to refer to #1209.Nick Mathewson2024-01-131-2/+2
| | | | | | | | | | (I've expanded #1209 to give us the option to either _implement_ these transitions, or _forbid_ them. We shouldn't just ignore them, though.)
| * hsservice: Convert TODOs about documentation to refer to #1235.Nick Mathewson2024-01-131-3/+3
| |
| * hsservice: Remove an outdated TODO: Ipt ids are indeed unique.Nick Mathewson2024-01-131-3/+0
| |
| * hsservice: Remove now-needless "allows".Nick Mathewson2024-01-131-1/+0
| |
| * hsservice: Remove the unused n_faults fieldNick Mathewson2024-01-132-11/+0
| | | | | | | | (We can revert this later if it turns out to be needed.)
| * hsservice: Turn a TODO into #1234.Nick Mathewson2024-01-131-1/+1
| | | | | | | | This is a MUST.
| * hsservice: Resolve some TODO HSS items in IptParameters declarationNick Mathewson2024-01-131-5/+37
| | | | | | | | | | Mostly, this is just adding documentation, but it is also removing a couple of no-longer-relevant TODOs.
* | Merge branch 'keymgr-fs-mistrust-err' into 'main'Alexander Færøy2024-01-154-2/+5
|\ \ | | | | | | | | | | | | | | | | | | tor-keymgr: Use keystore_error_kind() to get the error kind. Closes #1215 See merge request tpo/core/arti!1883
| * | tor-keymgr: Use keystore_error_kind() to get the error kind.Gabriela Moldovan2024-01-154-2/+5
|/ / | | | | | | Closes #1215
* | Merge branch 'netdir-etc-todos' into 'main'gabi-2502024-01-153-12/+24
|\ \ | | | | | | | | | | | | Triage TODOs in tor-netdir See merge request tpo/core/arti!1881
| * | netdir: Downgrade a TODO in a deprecated, unused function.Nick Mathewson2024-01-141-1/+5
| | |
| * | netdir: Make TODOs on is_hs_intro_point refer to #1240Nick Mathewson2024-01-141-3/+3
| | |
| * | netdir: Downgrade or remove several "TODO HSS" comments.Nick Mathewson2024-01-141-7/+5
| | | | | | | | | | | | These are not release-blockers.
| * | netdir: Explain why there is no HsRend WeightRule.Nick Mathewson2024-01-142-1/+11
| |/
* | Merge branch 'hscrypto-todos' into 'main'gabi-2502024-01-151-1/+1
|\ \ | |/ |/| | | | | hscrypto: Downgrade a TODO HSS comment. See merge request tpo/core/arti!1882
| * hscrypto: Downgrade a TODO HSS comment.Nick Mathewson2024-01-141-1/+1
|/ | | | | This is not a blocker; it's just a code movement or duplication issue IIUC.
* Merge branch 'hsservice_todos_misc' into 'main'Nick Mathewson2024-01-139-91/+80
|\ | | | | | | | | Triage most TODO HSS items in tor-hsservice See merge request tpo/core/arti!1879
| * Add a couple more TODO references (to #1227)gabi-2502024-01-131-2/+2
| |
| * Remove a TODO HSS about introduce rate-limiting.Nick Mathewson2024-01-121-2/+0
| | | | | | | | This misunderstands the way that introduce rate-limiting works.
| * Remove a TODO HSS that is not a TODO, just a noteNick Mathewson2024-01-121-1/+1
| |
| * Convert a TODO HSS about write failure into a ref to #1226Nick Mathewson2024-01-121-1/+1
| |
generated by cgit v1.2.3 (git 2.46.0) at 2026-08-27 16:53:05 +0000