| Commit message (Collapse) | Author | Age | Files | Lines |
| ... | |
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| |\ \
| | |
| | |
| | |
| | | |
Proposed new state facility
See merge request tpo/core/arti!1853
|
| | | | |
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | |
| | | |
Both my colleages prefer it that way.
There's no implementation yet to change.
|
| | | |
| | |
| | |
| | |
| | | |
Prompted by
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1853#note_2983413
|
| | | | |
|
| | | | |
|
| | | |
| | |
| | |
| | | |
It should have as_ref and as_str and Display and TryFrom<String>.
|
| | | |
| | |
| | |
| | | |
Some methods were missing the Result.
|
| | | |
| | |
| | |
| | |
| | | |
We need to implement it. And we need to take it ?Sized so that &str
works without the user having to write another &.
|
| | | | |
|
| | | |
| | |
| | |
| | | |
These should have been pub all along.
|
| | | |
| | |
| | |
| | | |
This will let us make a tested example in the module doc.
|
| | | |
| | |
| | |
| | |
| | | |
Provide the last modification time too, since we have it. This allows
handlers to things not contemplated by the convenience API.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This needs to take a value. The caller is going to have some context,
eg a configured list of instances. This means that it no longer has
InstanceIdentity as a supertrait.
Have the purge handler return the retain for time as a method.
|
| | | |
| | |
| | |
| | |
| | | |
Prompted by
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1853#note_2983029
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | |
| | | |
It is OK to return this even for used things, or if you don't know -
the API user (trait implementor) gets a second bite at the cherry in
`dispose`.
|
| | | |
| | |
| | |
| | |
| | | |
Prompted by
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1853#note_2982352
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This gives us somewhere central to hang the rules about names,
and avoids us passing un-typed strings into the StateDirectory methods.
This inhibits certain kinds of future dynamism, without more work, but
that's fine. (It also produces more generics in the functions, but we
can avoid too much monomorphisation with the inner function pattern.)
Prompted by
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1853#note_2982354
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This gives us somewhere central to hang the rules about slugs.
(The trait is just an alias for ToString.)
Prompted by
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1853#note_2982354
|
| | | |
| | |
| | |
| | |
| | | |
We're going to want the InstanceIdentity name for a trait. Also this
is clearer I think.
|
| | |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
A proposal for #1163.
I haven't updated any of the calling code in tor-hsservice yet.
I think the way this will be used ought to be fairly obvious from the
API.
This commit also contains a file of notes about stuff I found in an
arti state directory. These may be too random even to put in
doc/dev/notes, so for now I've put them next to state_dir.rs.
|
| |\ \
| | |
| | |
| | |
| | | |
netdoc: Triage some TODO HSS
See merge request tpo/core/arti!1878
|
| | | | |
|
| | |/ |
|
| |\ \
| | |
| | |
| | |
| | | |
tor-hsservice: Downgrade a TODO HSS to TODO.
See merge request tpo/core/arti!1877
|
| | |/ |
|
| |\ \
| |/
|/|
| |
| | |
tor-hsservice: Replace TODO HSS with references to gitlab issues.
See merge request tpo/core/arti!1876
|
| |/
|
|
|
| |
This whole file will go away when this comment is addressed:
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1837#note_2977513
|
| |\
| |
| |
| |
| | |
tor-hsservice: todos: Use log_ratelim at one call site
See merge request tpo/core/arti!1871
|
| | | |
|
| |\ \
| | |
| | |
| | |
| | | |
tor-hsservice: todos in replay.rs
See merge request tpo/core/arti!1869
|
| | | |
| | |
| | |
| | | |
We now have more fine-grained allows.
|
| | | |
| | |
| | |
| | |
| | | |
Deciding what to do about this *is* a MUST, but maybe we'll downgrade
that ticket.
|
| | | |
| | |
| | |
| | | |
This *is* a MUST.
|
| | |/
| |
| |
| | |
This isn't a MUST.
|
| |\ \
| | |
| | |
| | |
| | | |
tor-hsservice: todos: triage for ipt_set
See merge request tpo/core/arti!1872
|
| | | |
| | |
| | |
| | | |
The call to `load` is right there!
|
| | |/
| |
| |
| | |
This is a MUST ticket.
|
| |\ \
| | |
| | |
| | |
| | | |
tor-hsservice: todos: Drop one now-unneeded allow
See merge request tpo/core/arti!1873
|
| | |/ |
|
| |\ \
| | |
| | |
| | |
| | | |
todos: Reference a new ticket about errorkinds
See merge request tpo/core/arti!1874
|
| | |/ |
|
| |\ \
| |/
|/|
| |
| |
| |
| | |
tor-hsservice: todos: Triage/downgrade/ticketfy in ipt_mgr.rs
Closes #1074
See merge request tpo/core/arti!1870
|