summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * | chanmgr: fix a unit-default warning from clippy nightly.Nick Mathewson2023-05-181-1/+1
| | | | | | | | | | | | | | | | | | I could also have stopped using `::default()` to construct this (testing-only) object, but I think it makes more sense to turn it into a non-unit object.
| * | guardmgr, netdir: fix some needless-mut warningsNick Mathewson2023-05-182-4/+4
| | | | | | | | | | | | Found by clippy nightly
| * | guardmgr: suppress a clippy-nightly warning.Nick Mathewson2023-05-181-0/+1
| |/ | | | | | | | | I don't love this change, but apparently we are trying for "consistency".
* | Merge branch 'escorted_25519_secrets' into 'main'Nick Mathewson2023-05-189-89/+120
|\ \ | | | | | | | | | | | | | | | | | | Refactor code not to use unescorted ed25519 secrets Closes #798 See merge request tpo/core/arti!1192
| * | hscrypto: Remove an incorrect comment.Nick Mathewson2023-05-181-5/+0
| | | | | | | | | | | | | | | (It said that we want to deprecate all unescorted secret keys; in fact, only unescorted EdDSA secrets are bad.)
| * | key-management.md: Add a note deprecating unescorted ed secretsNick Mathewson2023-05-181-0/+1
| | |
| * | netdoc, hsclient: Update remaining ed25519::SecretKey usersNick Mathewson2023-05-184-25/+24
| | | | | | | | | | | | | | | | | | Fortunately, these are all in experimental code. Closes #798
| * | hscrypto: Replace ed25519 secret keys with keypairsNick Mathewson2023-05-181-42/+32
| | | | | | | | | | | | Part of #798: We no longer use unescorted ed25519 secret keys.
| * | llcrypto: Don't take or return "unescorted" ed25519 keys.Nick Mathewson2023-05-182-20/+41
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Per #798, we want to make sure that we never pass around an `ed25519::SecretKey`; only an `ed25519::Keypair` (or `ExpandedKeypair`). This is because, when you're computing an ed25519 signature, you have to use the public key as one of your inputs, and if you ever use a mismatched public key you are vulnerable to a nonce reuse attack. (For more info see https://moderncrypto.org/mail-archive/curves/2020/001012.html )
| * | llcrypto: Add an `ed25519::ExpandedKeypair` type.Nick Mathewson2023-05-181-0/+25
| | | | | | | | | | | | | | | | | | | | | | | | This is like an `ed25519::Keypair`, except that instead of a `SecretKey` it contains an `ExpandedSecretKey`. We'll be using this to implement #798, where we impose a rule that there must be no "unescorted" ed25519 secret keys.
* | | Merge branch 'virtual_hop' into 'main'Nick Mathewson2023-05-185-38/+245
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | tor-proto: Add support for extending circuits through virtual hops. Closes #726 See merge request tpo/core/arti!1191
| * | proto: Explain "virtual" hops better.Nick Mathewson2023-05-181-0/+4
| | | | | | | | | | | | Based on text from @diziet
| * | proto: Try to improve the documentation in crypto/cell.rsNick Mathewson2023-05-181-24/+86
| | |
| * | proto: Allow circuit Paths to represent virtual hops.Nick Mathewson2023-05-183-14/+57
| | | | | | | | | | | | | | | Sadly, this adds a few more `TODO HS` entries, but I think we can clean them up later after a bit of discussion.
| * | proto: Implement Circuit::extend_virtual.Nick Mathewson2023-05-182-2/+59
| | | | | | | | | | | | | | | | | | | | | There are a few new TODO hs comments, though, and an XXXX I'll need to fix up in the next commit. Implements #726.
| * | tor-proto: Code to construct crypto layers for virtual hops.Nick Mathewson2023-05-183-1/+42
| | | | | | | | | | | | | | | This is fairly straightforward, thanks to our existing design work on this code.
* | | Merge branch 'logging-tweaks' into 'main'Nick Mathewson2023-05-182-4/+4
|\ \ \ | |_|/ |/| | | | | | | | tor-guardmgr, tor-proto: minor logging tweaks See merge request tpo/core/arti!1190
| * | tor-guardmgr, tor-proto: minor logging tweakseta2023-05-182-4/+4
|/ / | | | | | | | | | | | | | | - We make the tor-guardmgr "We have found that {} is usable" line include the word "guard", otherwise it doesn't appear very useful to a user in safe logging mode, since the guard gets replaced with [scrubbed]. - The "Actually got an end cell..." message is downgraded to DEBUG.
* | Merge branch 'hs_handshake' into 'main'Nick Mathewson2023-05-183-130/+230
|\ \ | | | | | | | | | | | | | | | | | | Clean up hs_ntor.rs, add test vectors generated by C tor, and fix some bugs Closes #865 See merge request tpo/core/arti!1189
| * | hs_ntor: several documentation cleanups.Nick Mathewson2023-05-171-6/+14
| | |
| * | hs_ntor: make encrypt_and_mac take a typed public keyNick Mathewson2023-05-171-10/+6
| | | | | | | | | | | | This is still not the most beautiful interface, but it'll do for now.
| * | hs_ntor: remove the last lingering AsRef<[u8]>Nick Mathewson2023-05-171-7/+7
| | |
| * | hs_ntor: Add a test vector case extracted from C tor.Nick Mathewson2023-05-171-0/+104
| | |
| * | hs_ntor: Calculate MAC on introduce1 message correctly.Nick Mathewson2023-05-171-3/+12
| | | | | | | | | | | | | | | | | | There were two bugs here that made the behavior unlike that of C tor: we had swapped the MAC inputs, and we had forgotten to include the public key X in the input.
| * | hs_ntor: Make internal no-rng variants of the handshake functions.Nick Mathewson2023-05-171-2/+25
| | | | | | | | | | | | We'll want these so we can implement some test vectors.
| * | hs_ntor: Move extra data outside of the "input" fields.Nick Mathewson2023-05-171-59/+33
| | | | | | | | | | | | | | | | | | | | | I think that these Input structs had been defined so that we could use hs_ntor interchangeably with other handshakes. The trouble is, though, that it doesn't really work like any other handshakes we have.
| * | hs_ntor: Use MAC implementation from tor-hscryptoNick Mathewson2023-05-171-35/+16
| | | | | | | | | | | | | | | | | | Note that some of the invocations for this function seem to put the key and the message in a questionable order. But that's a thing to figure out later, while debugging.
| * | hs_ntor: Use correct PK types from tor_hscrypto.Nick Mathewson2023-05-171-20/+24
| | |
| * | hs_ntor: Use Subcredential type from tor-hscryptoNick Mathewson2023-05-173-5/+6
| |/
* | Merge branch 'hs-intro-msg-refactor-again' into 'main'Nick Mathewson2023-05-171-26/+83
|\ \ | |/ |/| | | | | | | | | Refactor Introduce messages to support looking at encoded headers Closes #866 See merge request tpo/core/arti!1188
| * cell: Make Introduce2::new testing-only.Nick Mathewson2023-05-171-1/+6
| | | | | | | | | | | | We never want to create one of these from its parts except when we are testing it; we only want to forward an Introduce1 message with a new command on it.
| * cell: Record the text of an INTRODUCE2 headerNick Mathewson2023-05-171-9/+39
| | | | | | | | | | We'll need to store this so that it can later on be used to complete the hs_ntor handshake.
| * cell: extract introduce headers into a new type.Nick Mathewson2023-05-171-20/+42
|/ | | | | | | | We'll want this because our hs_ntor handshake requires access to an encoded version of the header independent from the actual encrypted message. part of #866.
* Merge branch 'info-to-warn' into 'main'gabi-2502023-05-171-5/+8
|\ | | | | | | | | | | | | Change log levels of messages from INFO to others Closes #854 See merge request tpo/core/arti!1172
| * Change log level to debug and warn for certain appropriate situationsSaksham Mittal2023-05-171-5/+8
| | | | | | | | | | | | This commit changes certain log messages to debug for recoverable errors and a warn if all such attempts fail, in order to not clutter up the info messages that end users get to see.
* | Merge branch 'arc_circ' into 'main'gabi-2502023-05-1714-74/+83
|\ \ | | | | | | | | | | | | | | | | | | Refactor ClientCirc APIs to use Arc<ClientCirc>. Closes #846 See merge request tpo/core/arti!1187
| * | Refactor ClientCirc APIs to use Arc<ClientCirc>.Nick Mathewson2023-05-1614-74/+83
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now ClientCirc is no longer `Clone`, and the things that need it to be `Clone` instead return and use an Arc<ClientCirc> We're doing this so that ClientCirc can participate in the RPC system, and so that its semantics are more obvious. Closes #846. Thanks to the type system, this was a much simpler refactoring than I had feared it would be.
* | | Merge branch 'ticket_759' into 'main'Nick Mathewson2023-05-169-17/+66
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | tor-cert: Replace the KeyUnknownCert::check_key API Closes #759 See merge request tpo/core/arti!1184
| * | | Deprecate check_key, and refactor its logic into the new functions.Nick Mathewson2023-05-161-16/+33
| | | | | | | | | | | | | | | | Closes #759
| * | | Replace usage of KeyUnknownCert::check_key.Nick Mathewson2023-05-167-11/+11
| | | |
| * | | tor-cert: Add new functions to replace KeyUnknownCert::check_key.Nick Mathewson2023-05-162-0/+32
| | |/ | |/| | | | | | | | | | | | | | | | These should have a cleaner API than check_key, and be easier to understand. Part of #759
* | | Merge branch 'resolve_relay' into 'main'Nick Mathewson2023-05-161-0/+142
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | netdir: New function to check consistency of a HasRelayIds Closes #855 See merge request tpo/core/arti!1186
| * | | netdir: New function to check consistency of a HasRelayIdsNick Mathewson2023-05-161-0/+142
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This function will be used to look up a relay by a set of LinkSpecs given from an incoming HsDesc or INTRODUCE2 message. It differs from other "lookup relay by IDs" functions in that it needs to be able to return "here's a relay", "couldn't found a relay", or "learned that this relay is impossible." Closes #855: This is the only new API needed for ChanTarget validation, I think.
* | | Merge branch 'key-mgmt-api-updates-v2' into 'main'gabi-2502023-05-161-81/+208
|\ \ \ | | | | | | | | | | | | | | | | dev docs: key-management.md updates and clarifications See merge request tpo/core/arti!1185
| * | | dev docs: The key store version file should specify a minimum supported version.Gabriela Moldovan2023-05-161-2/+10
| | | | | | | | | | | | | | | | Signed-off-by: Gabriela Moldovan <[email protected]>
| * | | dev docs: Remove unused arguments.Gabriela Moldovan2023-05-161-12/+9
| | | | | | | | | | | | | | | | | | | | | | | | There are several places where he `KeyType` isn't needed anymore. Signed-off-by: Gabriela Moldovan <[email protected]>
| * | | dev docs: Clarify how C Tor key store loads keys from multiple different key ↵Gabriela Moldovan2023-05-161-26/+66
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | dirs. This also moves the `extension` function out of `KeyType` because for the C Tor key store, a key's file extension depends on the role/user of the key, which isn't known by `KeyType` (`KeyType` is a tor-agnostic key type such as `Ed25519Private`). Signed-off-by: Gabriela Moldovan <[email protected]>
| * | | dev docs: Distinguish between arti_extension and ctor_extension.Gabriela Moldovan2023-05-161-2/+7
| | | | | | | | | | | | | | | | Signed-off-by: Gabriela Moldovan <[email protected]>
| * | | dev docs: Clarify that ArtiPath/CTorPath are relative to the key store root.Gabriela Moldovan2023-05-161-1/+9
| | | | | | | | | | | | | | | | Signed-off-by: Gabriela Moldovan <[email protected]>
| * | | dev docs: Add note about key store versioning.Gabriela Moldovan2023-05-161-0/+9
| | | | | | | | | | | | | | | | Signed-off-by: Gabriela Moldovan <[email protected]>
generated by cgit v1.2.3 (git 2.46.0) at 2026-08-28 16:56:59 +0000