| Commit message (Collapse) | Author | Age | Files | Lines | ||
|---|---|---|---|---|---|---|
| ... | ||||||
| * | | Merge branch 'reactor-error-3-bis' into 'main' | gabi-250 | 2023-11-20 | 2 | -2/+7 | |
| |\ \ | | | | | | | | | | | | | tor-hsservice: Clarify a message See merge request tpo/core/arti!1750 | |||||
| | * | | HSS publisher error: lack of netdir: clarify message | gabi-250 | 2023-11-20 | 1 | -1/+1 | |
| | | | | ||||||
| | * | | tor-error: fmt_ending_ok: Permit messages ending in ascii ellipsis | Ian Jackson | 2023-11-20 | 1 | -0/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Tbis will result in "some message ...: the error" which I think is OK. We don't use a Unicode single-character ellipsis because that character can be hard to read at font sizes which are otherwise OK for text, and because use of non-ascii in logfiles and error messages is unecessary and might cause unnecessary trouble (for example, if the log messages end up going somewhere which isn't 100% valid UTF-8). | |||||
| | * | | tor-error: fmt_ending_ok: Implement with a direct match | Ian Jackson | 2023-11-20 | 1 | -1/+5 | |
| |/ / | | | | | | | | | Possibly at some point in the past, matching a slice directly wasn't possible. But it is now. | |||||
| * | | Merge branch 'reactor-error-3' into 'main' | Ian Jackson | 2023-11-20 | 5 | -14/+58 | |
| |\ \ | |/ |/| | | | | | HSS publisher, do some work on ReactorErrors See merge request tpo/core/arti!1724 | |||||
| | * | HSS publisher: do not crash reactor if netdir unavailable | Ian Jackson | 2023-11-20 | 1 | -7/+19 | |
| | | | | | | | | | | | | | | | It might come back. This introduces a new bug relating to logging, but it does abolish one of the variants of ReactorError. | |||||
| | * | HSS errors: expose and sort out NetdirProviderShutdown error type (fmt) | Ian Jackson | 2023-11-20 | 1 | -1/+1 | |
| | | | | | | | | | IHNI why rustfmt wants to do this *now* | |||||
| | * | HSS errors: expose and sort out NetdirProviderShutdown error type | Ian Jackson | 2023-11-20 | 4 | -3/+16 | |
| | | | | | | | | | | | | | We're going have it in an variant in FatalError. Also make it impl HasKind and have IptError delegate to that. | |||||
| | * | HSS publisher errors: Declare that we want to abolish ReactorError | Ian Jackson | 2023-11-20 | 1 | -2/+23 | |
| | | | | | | | | | And explain why this isn't just a question of merging it with FatalError. | |||||
| | * | HSS publisher: Remove a redundant debug message | Ian Jackson | 2023-11-20 | 1 | -2/+0 | |
| | | | | | | | | | The call to reactor.run() in publish.rs, launch(), calls warn_report. | |||||
| * | | Merge branch 'more-denotators' into 'main' | gabi-250 | 2023-11-20 | 1 | -14/+83 | |
| |\ \ | |/ |/| | | | | | | | | | tor-keymgr: Support encoding more than one denotator in an ArtiPath. Closes #1093 and #1112 See merge request tpo/core/arti!1747 | |||||
| | * | tor-keymgr: Update ArtiPath docs. | Gabriela Moldovan | 2023-11-20 | 1 | -5/+9 | |
| | | | ||||||
| | * | tor-keymgr: Remove now-outdated TODO HSSs. | Gabriela Moldovan | 2023-11-20 | 1 | -6/+0 | |
| | | | ||||||
| | * | tor-keymgr: Support encoding more than one denotator in an ArtiPath. | Gabriela Moldovan | 2023-11-20 | 1 | -3/+74 | |
| | | | | | | | | | Closes arti#1112 | |||||
| * | | Merge branch 'deprecate-hs-client-intro-auth' into 'main' | gabi-250 | 2023-11-20 | 7 | -37/+34 | |
| |\ \ | |/ |/| | | | | | | | | | tor-hscrypto: Deprecate HsClientIntroAuth{Key, Keypair}. Closes #1037 See merge request tpo/core/arti!1749 | |||||
| | * | tor-keymgr: Remove the ToEncodableKey impl of HsClientIntroAuthKeypair. | Gabriela Moldovan | 2023-11-20 | 1 | -15/+0 | |
| | | | | | | | | | | | `HsClientIntroAuthKeypair` is deprecated and no longer used as an "encodable key". | |||||
| | * | arti-client: Stop using HsClientIntroAuthKeypair for client auth. | Gabriela Moldovan | 2023-11-20 | 1 | -15/+1 | |
| | | | | | | | | | Closes #1037 | |||||
| | * | tor-hsclient: Deprecate HsClientSecretKeysBuilder::ks_hsc_intro_auth(). | Gabriela Moldovan | 2023-11-20 | 3 | -1/+8 | |
| | | | ||||||
| | * | tor-keymgr: Allow the use of the newly deprecated HsClientIntroAuthKeypair ↵ | Gabriela Moldovan | 2023-11-20 | 1 | -4/+4 | |
| | | | | | | | | | (fmt). | |||||
| | * | tor-keymgr: Allow the use of the newly deprecated HsClientIntroAuthKeypair. | Gabriela Moldovan | 2023-11-20 | 1 | -1/+4 | |
| | | | ||||||
| | * | tor-hscrypto: Move HsClientIntroAuthKey to a separate module (fmt). | Gabriela Moldovan | 2023-11-20 | 1 | -16/+15 | |
| | | | ||||||
| | * | tor-hscrypto: Move HsClientIntroAuthKey to a separate module. | Gabriela Moldovan | 2023-11-20 | 1 | -0/+13 | |
| | | | | | | | | | | | | | | | | | | | We need to add a module-global `#[allow(deprecated)]` to silence the deprecation warnings coming from the derived `derive_more` impls of the 2 newly deprecated structs. Since we don't want the `allow` to apply to the entire `pk` module, let's put `HsClientIntroAuthKey` and `HsClientIntroAuthKeypair` in a separate module and apply the `#[allow(deprecated)]` there. | |||||
| | * | tor-hscrypto: Deprecate HsClientIntroAuth{Key, Keypair}. | Gabriela Moldovan | 2023-11-20 | 2 | -1/+5 | |
| | | | | | | | | | Part of #1037 | |||||
| * | | Merge branch 'send_dos_params' into 'main' | Nick Mathewson | 2023-11-20 | 7 | -26/+116 | |
| |\ \ | | | | | | | | | | | | | | | | | | | HSS: Send DosParams extension to introduction points. Closes #723 See merge request tpo/core/arti!1740 | |||||
| | * | | Add more reference links. | Nick Mathewson | 2023-11-20 | 1 | -1/+5 | |
| | | | | ||||||
| | * | | Send DosParams conditionally on HsIntro support. | Nick Mathewson | 2023-11-20 | 3 | -4/+13 | |
| | | | | | | | | | | | | | It's available when the HsIntro=5 subprotocol version is present. | |||||
| | * | | Improve documentation in/around DosParams extension | Nick Mathewson | 2023-11-20 | 3 | -8/+32 | |
| | | | | | | | | | | | | | | | | | | | It does not help that C tor has a set of parameters and a set of configuration options with exactly the same names which configure the same thing in two slightly different ways. | |||||
| | * | | hss: Take intro_dos extension from configuration and send it. | Nick Mathewson | 2023-11-20 | 2 | -4/+44 | |
| | | | | | | | | | | | | | Closes #723. | |||||
| | * | | hss: pipe config watchers into ipt_establish. | Nick Mathewson | 2023-11-20 | 2 | -9/+22 | |
| | | | | | | | | | | | | | | | | | | | We want the configuration, at least, so that we can see our DoS settings. I expect we'll also want the watcher so that we can see _changes_ in the DoS settings. | |||||
| * | | | Merge branch 'derive-adhoc' into 'main' | gabi-250 | 2023-11-20 | 10 | -419/+246 | |
| |\ \ \ | |/ / |/| | | | | | | | | | | | | | | tor-keymgr: Rewrite define_key_specifier using derive-adhoc. Closes #1093 See merge request tpo/core/arti!1733 | |||||
| | * | | tor-keymgr: Add TODO about possibly abolishing arti_pattern. | Gabriela Moldovan | 2023-11-20 | 1 | -0/+3 | |
| | | | | ||||||
| | * | | tor-keymgr: Make the arti_path_prefix() helper private. | Gabriela Moldovan | 2023-11-20 | 1 | -1/+1 | |
| | | | | ||||||
| | * | | tor-keymgr: Abolish the `role()` public key specifier function. | Gabriela Moldovan | 2023-11-20 | 1 | -9/+0 | |
| | | | | | | | | | | | | | We don't use this anymore. | |||||
| | * | | tor-hsservice: Update MissingHsIdKey docs, remove outdated TODO HSS. | Gabriela Moldovan | 2023-11-20 | 2 | -32/+2 | |
| | | | | ||||||
| | * | | tor-hsservice: Rename MissingKey to MissingHsIdKeypair. | Gabriela Moldovan | 2023-11-20 | 4 | -9/+11 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | We only return this error if the identity key is missing from the keystore. This change will also help us abolish the `.role()` method on `KeySpecifier`s (it was only needed for populating the string of a `MissingKey` error). | |||||
| | * | | tor-keymgr: Use ${for fields} to count the number of denotators (fmt). | Gabriela Moldovan | 2023-11-20 | 1 | -5/+4 | |
| | | | | ||||||
| | * | | tor-keymgr: Use ${for fields} to count the number of denotators. | Gabriela Moldovan | 2023-11-20 | 1 | -8/+3 | |
| | | | | ||||||
| | * | | tor-keymgr: Refactor a commonly used condition into a defcond. | Gabriela Moldovan | 2023-11-20 | 1 | -5/+8 | |
| | | | | ||||||
| | * | | tor-keymgr: Apply review suggestions to various doc comments. | Gabriela Moldovan | 2023-11-20 | 2 | -6/+13 | |
| | | | | ||||||
| | * | | tor-keymgr: Do not require owned types in arti_pattern(). | Gabriela Moldovan | 2023-11-20 | 1 | -3/+3 | |
| | | | | | | | | | | | | | This also fixes a clippy warning about a needless borrow. | |||||
| | * | | tor-keymgr: Suppress a confused clippy warning. | Gabriela Moldovan | 2023-11-20 | 1 | -0/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | Clippy is wrong here: it's complaining about us not using `$crate`, when we _are_ using `$crate`. See https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1733#note_2965924 | |||||
| | * | | tor-keymgr: Remove unused macro. | Gabriela Moldovan | 2023-11-20 | 1 | -241/+0 | |
| | | | | ||||||
| | * | | tor-hsservice: Remove unused macro. | Gabriela Moldovan | 2023-11-20 | 1 | -83/+1 | |
| | | | | | | | | | | | | | We don't need this macro now that we adhoc-derive the implementation. | |||||
| | * | | tor-hsservice: Derive the service key specifier implementations (fmt). | Gabriela Moldovan | 2023-11-20 | 1 | -54/+54 | |
| | | | | ||||||
| | * | | tor-hsservice: Derive the service key specifier implementations. | Gabriela Moldovan | 2023-11-20 | 1 | -24/+43 | |
| | | | | ||||||
| | * | | tor-keymgr: Rewrite define_key_specifier using derive-adhoc (fmt). | Gabriela Moldovan | 2023-11-20 | 1 | -37/+36 | |
| | | | | ||||||
| | * | | tor-keymgr: Rewrite define_key_specifier using derive-adhoc. | Gabriela Moldovan | 2023-11-20 | 4 | -18/+152 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | For the most part, this is just code movement. The implementation was copied over to `define_derive_adhoc` from `define_key_specifier`, with some minor adjustments that were needed to make it compile. Closes #1093 | |||||
| | * | | tor-keymgr: Add tests for arti_prefix(). | Gabriela Moldovan | 2023-11-20 | 1 | -0/+11 | |
| | | | | ||||||
| | * | | tor-keymgr: Add tests for arti_pattern(). | Gabriela Moldovan | 2023-11-20 | 1 | -0/+15 | |
| |/ / | | | | | | | | | | | | | | | | | `T::arti_pattern()` returns an `ArtiPath` pattern that can can match any key of type `T`, regardless of the values of its denotators (the denotators are replaced by wildcards in the pattern). These tests will allow us to check we're not breaking pattern matching when we transition to derive-adhoc. | |||||
| * | | Merge branch 'publisher-todo' into 'main' | Ian Jackson | 2023-11-20 | 3 | -5/+3 | |
| |\ \ | |/ |/| | | | | | tor-hsservice: Remove and downgrade several TODO HSS See merge request tpo/core/arti!1742 | |||||
