summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * | dev notes: Draft IPT algorithm: note re unpublished IPTIan Jackson2023-07-261-0/+5
| | | | | | | | | | | | | | | Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1429#note_2924483
| * | dev notes: Draft IPT algorithm: note re intro pt verificationIan Jackson2023-07-261-1/+4
|/ / | | | | | | | | | | Discussions here: https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1429#note_2924481 https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1429#note_2924495
* | Merge branch 'typos' into 'main'Ian Jackson2023-07-262-4/+4
|\ \ | | | | | | | | | | | | Fix typos See merge request tpo/core/arti!1436
| * | Fix typosDimitris Apostolou2023-07-252-4/+4
| | |
* | | Merge branch 'sw1tch/fix_reconfigure_deadlock' into 'main'Ian Jackson2023-07-261-2/+42
|\ \ \ | |/ / |/| | | | | | | | fixes deadlock in TorClient::reconfigure See merge request tpo/core/arti!1432
| * | pass reconfigure_lock guard into TorClient::reconfigure_innersw1tch2023-07-251-3/+8
| | |
| * | cargo fmtsw1tch2023-07-241-1/+3
| | |
| * | fixes deadlock in TorClient::reconfiguresw1tch2023-07-241-1/+34
| |/
* | Merge branch 'ipts' into 'main'Nick Mathewson2023-07-251-0/+266
|\ \ | | | | | | | | | | | | dev notes: Draft IPT algorithm See merge request tpo/core/arti!1429
| * | dev notes: Draft IPT algorithmIan Jackson2023-07-211-0/+266
| | |
* | | Merge branch 'onion-service-notes-v1' into 'main'Nick Mathewson2023-07-251-0/+276
|\ \ \ | | | | | | | | | | | | | | | | Initial notes about onion service structs and APIs See merge request tpo/core/arti!1422
| * | | Change keyid to nicknameNick Mathewson2023-07-241-7/+4
| | | |
| * | | Mention anti-DOS options.Nick Mathewson2023-07-241-1/+11
| | | |
| * | | Mention ob_config. Not sure we will want to build it like this.Nick Mathewson2023-07-241-0/+6
| | | |
| * | | Initial notes about onion service structs and APIsNick Mathewson2023-07-191-0/+263
| | | |
* | | | Merge branch 'keymgr-keygen-key-list' into 'main'gabi-2502023-07-251-0/+81
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | keymgr-doc: Document the list of keys the keymgr needs to generate. See merge request tpo/core/arti!1413
| * | | | keymgr-doc: Add columns with additional details about the keys.Gabriela Moldovan2023-07-201-19/+28
| | | | |
| * | | | keymgr-doc: Rename ambiguous `--onion` flag to `--service`.Gabriela Moldovan2023-07-201-1/+1
| | | | |
| * | | | keymgr-doc: Add note about the key names.Gabriela Moldovan2023-07-201-0/+6
| | | | |
| * | | | keymgr-doc: Document the list of keys the keymgr needs to generate.Gabriela Moldovan2023-07-181-0/+66
| | | | |
* | | | | Merge branch 'safer_build' into 'main'Ian Jackson2023-07-252-0/+63
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add `doc/safer_build.md` to explain path anonymization Closes #957 See merge request tpo/core/arti!1435
| * | | | | Add `doc/safer_build.md` to explain path anonymizationNick Mathewson2023-07-242-0/+63
| | |_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | Otherwise our default build instructions will lead people to build binaries that include their home directory. Closes #957 for now.
* | | | | Merge branch 'fmt' into 'main'Nick Mathewson2023-07-245-27/+45
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | Run cargo +nightly fmt to format many let ... else ... See merge request tpo/core/arti!1434
| * | | | Run cargo +nightly fmt to format many let ... else ...Ian Jackson2023-07-245-27/+45
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | rustfmt has grown opinions about how let ... else ... ought to be formatted. They don't always agree with our previous manual decisions. I think our policy is to always insist on rustfmt. When that version of rustfmt hits stable, our CI will start to fail for everyone. (Right now this discrepancy just causes trouble for contributors who are using nightly by default.)
* | | | Merge branch 'typos' into 'main'Nick Mathewson2023-07-2217-37/+37
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | Fix typos See merge request tpo/core/arti!1431
| * | | | Fix typosDimitris Apostolou2023-07-2217-37/+37
|/ / / /
* | | | Merge branch 'keymgr-api-updates' into 'main'gabi-2502023-07-2113-151/+499
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | keymgr: API updates and other improvements Closes #903 See merge request tpo/core/arti!1421
| * \ \ \ Merge branch 'keymgr-api-updates-minor-fixes' into 'keymgr-api-updates'gabi-2502023-07-213-11/+1
| |\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Keymgr api updates minor fixes See merge request gabi-250/arti!1
| | * | | | keymgr: Remove unnecessary dependency.Gabriela Moldovan2023-07-202-2/+0
| | | | | |
| | * | | | keymgr: Use std::cfg instead of if_cfg.Gabriela Moldovan2023-07-201-9/+1
| | | | | |
| * | | | | Merge branch 'keymgr-api-updates-more-fixes' into 'keymgr-api-updates'gabi-2502023-07-219-139/+100
| |\ \ \ \ \ | | |/ / / / | |/| | | | | | | | | | | | | | | | Address review comments See merge request gabi-250/arti!5
| | * | | | keymgr: Use KeystoreId instead of a static string.Gabriela Moldovan2023-07-214-30/+50
| | | | | |
| | * | | | keymgr: Add a newtype for keystore identifiers.Gabriela Moldovan2023-07-211-0/+22
| | | | | |
| | * | | | keymgr, tor-error: Remove unused error type and HasKind.Gabriela Moldovan2023-07-213-29/+2
| | | | | |
| | * | | | keymgr: Use BadApiUsage instead of KeystoreMisuse.Gabriela Moldovan2023-07-211-9/+7
| | | | | | | | | | | | | | | | | | | | | | | | Trying to use a keystore that doesn't exist is `bad_api_usage!`.
| | * | | | keymgr: Remove unused KeystoreSelector::All variant.Gabriela Moldovan2023-07-212-30/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This also removes the corresponding `KeyMgrError::UnsupportedKeystoreSelector` error, because it's not needed anymore.
| | * | | | Revert "keymgr: Require callers to be explicit about which keystore to get ↵Gabriela Moldovan2023-07-211-16/+7
| | | | | | | | | | | | | | | | | | | | | | | | keys from." (fmt)
| | * | | | Revert "keymgr: Require callers to be explicit about which keystore to get ↵Gabriela Moldovan2023-07-214-41/+28
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | keys from." This reverts commit 38a6c74c7894dc96b16c9039cacc2a4023977b05. This also updates some tests to make them compile with the reverted version of the code.
| * | | | keymgr: Require callers to be explicit about where to remove keys from.Gabriela Moldovan2023-07-202-16/+67
| | | | | | | | | | | | | | | | | | | | | | | | | As with `KeyMgr::insert`, only `KeystoreSelector::Id` and `KeystoreSelector::Default` are supported.
| * | | | keymgr: Add tests for KeyMgr.Gabriela Moldovan2023-07-201-0/+213
| | | | |
| * | | | keymgr: Add EncodableKey::to_bytes for encoding keys.Gabriela Moldovan2023-07-202-0/+13
| | | | | | | | | | | | | | | | | | | | We'll need this to implement `Keystore::insert`.
| * | | | keymgr: Add some extra derives to ArtiPath and KeyType.Gabriela Moldovan2023-07-203-4/+5
| | | | |
| * | | | keymgr: Require callers to be explicit about which keystore to get keys from.Gabriela Moldovan2023-07-204-12/+27
| | | | |
| * | | | keymgr: Move KeyMgr::get impl to Keymgr::get_from_store.Gabriela Moldovan2023-07-201-26/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This refactoring will make more sense later, when we give `KeyMgr::get` an extra parameter that specifies which keystore to retrieve the key from.
| * | | | keymgr: Remove unimplemented/unnecessary has_key_bundle function.Gabriela Moldovan2023-07-203-16/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The concept of a "key bundle" would introduce a lot of complexity while providing little to no gain. Some context: ``` Originally, "key bundles" were meant to be the answer to the question "which keystore should insert place keys in?": https://gitlab.torproject.org/tpo/core/arti/-/blob/36606a66ddca9abd1595d13c9397bc812bf24cb5/crates/tor-keymgr/src/mgr.rs#L60-69 However, I'm not so sure anymore that "key bundles" are the answer. I don't think there is any way we can "guess" where a key should go. When inserting/generating a new key, we should either: always write to the same, primary key store, OR require the user to be explicit about which key store the new key should go in (by assigning an ID to each key store and expecting the user to provide it when inserting/generating new keys) I prefer the latter option, because it provides more flexibility, which we're going to need when implementing the key management CLI (which I think should allow users to generate keys anywhere they want, e.g. arti keymgr generate <key type> --keystore hsm ...) ``` For more details, see the discussion on #903. Closes #903
| * | | | keymgr: Require callers to specify which keystore to insert keys in.Gabriela Moldovan2023-07-203-28/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The caller uses `KeystoreSelector` to specify which keystore to insert the new key into (only `KeystoreSelector::Id` and `KeystoreSelector::Default` are supported for `insert`). The ability to insert keys in a particular keystore will come in handy when we implement the key management CLI (the CLI will have an option for specifying the keystore to access/modify).
| * | | | keymgr: Add a convenience function for boxing keystore errors.Gabriela Moldovan2023-07-203-7/+8
| | | | |
| * | | | keymgr: Add an error type for misuse errors.Gabriela Moldovan2023-07-203-2/+37
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This error will be returned by `KeyMgr` if the caller tries to access a keystore that does not exist, or if the requested `KeystoreSelector` cannot be applied.
| * | | | keymgr: Add type for specifying which keystore to access.Gabriela Moldovan2023-07-202-0/+14
| | | | |
| * | | | keymgr: Add a function for looking keystores up by ID.Gabriela Moldovan2023-07-201-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | This will be used by `KeyMgr::insert` after we add an additional argument to `insert` for specifying the keystore it should be using.