mirrors/arti.git - mirror of https://gitlab.torproject.org/tpo/core/arti

	Commit message (Collapse)	Author	Age	Files	Lines
...
* \| \| \| \|	Merge branch 'keymgr-rm-cond' into 'main'	Ian Jackson	2023-06-21	1	-10/+4
\|\\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	keymgr: Remove unnecessary condition. See merge request tpo/core/arti!1277
\| * \| \| \|	keymgr: Remove unnecessary condition.	Gabriela Moldovan	2023-06-21	1	-10/+4
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	We don't need to special-case `NotFound` errors because `ssh_key::PrivateKey::from_openssh` doesn't read from disk (so it shouldn't be returning `NotFound` errors in the first place). Previously, this condition made sense because we were using `ssh_key::PrivateKey::read_openssh_file` instead of `ssh_key::PrivateKey::from_openssh`, which _does_ read from disk. This condition should have been removed in !1263 (the refactoring where we switched to `from_openssh`). (Also, after #901 is implemented, we probably won't have an `Error::NotFound` error anymore).
* \| \| \| \|	Merge branch 'keymgr-remove-todo' into 'main'	Ian Jackson	2023-06-21	1	-8/+0
\|\ \ \ \ \ \| \|_\|_\|_\|/ \|/\| \| \| \| \| \| \| \| \| \| \| \| \| \|	keymgr: Remove outdated TODO. See merge request tpo/core/arti!1278
\| * \| \| \|	keymgr: Remove outdated TODO.	Gabriela Moldovan	2023-06-21	1	-8/+0
\| \| \|_\|/ \| \|/\| \| \| \| \| \| \| \| \| \| \| \| \| \|	This TODO describes something we're not planning to implement, so let's just remove it.
* \| \| \|	Merge branch 'defer-hsservice-todos' into 'main'	Ian Jackson	2023-06-21	5	-26/+26
\|\ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Downgrade every "TODO HS" in tor-hsservice See merge request tpo/core/arti!1265
\| * \| \| \|	Downgrade every "TODO HS" in tor-hsservice	Nick Mathewson	2023-06-20	5	-26/+26
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	These are all service-specific, and not client-specific.
* \| \| \| \|	Merge branch 'hsdesc-accessors' into 'main'	Ian Jackson	2023-06-21	3	-50/+58
\|\ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	netdoc: Use derive amplify::Getters for HsDesc accessors. Closes #909 See merge request tpo/core/arti!1266
\| * \| \| \| \|	netdoc: downgrade two accessor-related TODOs	Nick Mathewson	2023-06-20	1	-4/+1
\| \| \| \| \| \|
\| * \| \| \| \|	netdoc: Use derive amplify::Getters for HsDesc accessors.	Nick Mathewson	2023-06-20	3	-46/+57
\| \|/ / / / \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Closes #909.
* \| \| \| \|	Merge branch 'doc_link_fix' into 'main'	Alexander Færøy	2023-06-21	1	-1/+1
\|\ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Fix a rustdoc link. See merge request tpo/core/arti!1274
\| * \| \| \| \|	Fix a rustdoc link.	Nick Mathewson	2023-06-21	1	-1/+1
\| \| \| \| \| \|
* \| \| \| \| \|	Merge branch 'upgrade_21June2023' into 'main'	gabi-250	2023-06-21	9	-16/+16
\|\ \ \ \ \ \ \| \|_\|_\|/ / / \|/\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Upgrade a couple of dependencies See merge request tpo/core/arti!1276
\| * \| \| \| \|	Upgrade to memmap2 0.7	Nick Mathewson	2023-06-21	2	-3/+3
\| \| \| \| \| \|
\| * \| \| \| \|	Upgrade to strum 0.25.	Nick Mathewson	2023-06-21	9	-13/+13
\| \| \|_\|/ / \| \|/\| \| \|
* \| \| \| \|	Merge branch 'onionsocks' into 'main'	Nick Mathewson	2023-06-21	3	-7/+85
\|\ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	arti: return prop304 extended socks5 reply codes for onion services See merge request tpo/core/arti!1248
\| * \| \| \| \|	Add and use ErrorKinds for remaining onion service errors	Nick Mathewson	2023-06-21	2	-6/+48
\| \| \| \| \| \|
\| * \| \| \| \|	arti: return prop304 extended socks5 reply codes for onion services	Nick Mathewson	2023-06-21	2	-1/+36
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	We don't yet return all of them; this commit adds some todo notes about changes we may need to our ErrorKinds. Part of #736
\| * \| \| \| \|	arti: Abbreviate SocksStatus and ErrorKind imports and refactor.	Nick Mathewson	2023-06-21	1	-7/+8
\| \| \|/ / / \| \|/\| \| \|
* \| \| \| \|	Merge branch 'chanmgr-method' into 'main'	Nick Mathewson	2023-06-21	1	-2/+11
\|\ \ \ \ \ \| \|_\|/ / / \|/\| \| \| \| \| \| \| \| \| \| \| \| \| \|	Create chanmgr() method in TorClient See merge request tpo/core/arti!1275
\| * \| \| \|	Remove extra 'this' in some methods	Saksham Mittal	2023-06-21	1	-3/+3
\| \| \| \| \|
\| * \| \| \|	Create chanmgr() method in TorClient	Saksham Mittal	2023-06-21	1	-0/+9
\|/ / / /
* \| \| \|	Merge branch 'todos' into 'main'	Nick Mathewson	2023-06-21	6	-62/+31
\|\ \ \ \ \| \|/ / / \|/\| \| \| \| \| \| \| \| \| \| \|	tor-hsclient: Dispose of easy todos and remove many allows See merge request tpo/core/arti!1272
\| * \| \|	tor-hsclient: Apply deferred clippy churn needed by fmt churn	Ian Jackson	2023-06-21	1	-1/+1
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	rustfmt introduced this clippy warning.
\| * \| \|	tor-hsclient: Apply deferred rustfmt churn	Ian Jackson	2023-06-21	2	-11/+6
\| \| \| \|
\| * \| \|	tor-hsclient: Drop most allows that are marked for removal	Ian Jackson	2023-06-21	3	-9/+0
\| \| \| \|
\| * \| \|	tor-hsclient: Drop a large number of unneeded imports	Ian Jackson	2023-06-21	4	-19/+9
\| \| \| \|
\| * \| \|	tor-hsclient: Add HSID to some log messages	Ian Jackson	2023-06-21	1	-6/+7
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	For the debug!, we can use the unredacted form. For error!, we use Sensitive.
\| * \| \|	tor-hsclient: Do Debug the descriptor as part of Data	Ian Jackson	2023-06-21	1	-1/+0
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Empirically, this does not cause the descriptor to be spat out in normal operation. And it seems right.
\| * \| \|	tor-hsclient: Drop some temporary trace calls	Ian Jackson	2023-06-21	2	-8/+2
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	These were added as part of a debugging #885, and are no longer needed.
\| * \| \|	tor-hsclient: Drop two eprintlns in production code	Ian Jackson	2023-06-21	1	-2/+0
\| \| \| \|
\| * \| \|	tor-hsclinet: Promote dead code allows to cover all tests	Ian Jackson	2023-06-21	1	-1/+3
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	We want to remove the crate-level dead code allows. The tests are incomplete and there are multiple todos for that.
\| * \| \|	tor-hsclient: Use a formulaic TODO mark for incompleteness of tests	Ian Jackson	2023-06-21	1	-5/+5
\| \| \| \|
\| * \| \|	tor-hsclinet: Add a narrow allow, pending answer to open question	Ian Jackson	2023-06-21	1	-0/+1
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	I need to talk to HS expert(s) about when this circuit can be torn down.
\| * \| \|	tor-hsclient: Remove unused Context.hs_blind_id_key	Ian Jackson	2023-06-21	1	-3/+0
\| \| \| \|
\| * \| \|	tor-hsclient: Add an allow for a deliberately-unused variable	Ian Jackson	2023-06-21	1	-0/+1
\| \| \| \|
\| * \| \|	tor-hsclient: Omit some unussed struct fields in patterns	Ian Jackson	2023-06-21	1	-2/+2
\| \| \|/ \| \|/\| \| \| \| \| \| \| \| \| \|	For the arms that have a fixed retry time, or a fixed ErrorKind, dont't bind the unused inner error.
* \| \|	Merge branch 'chanmgr-doc-fix' into 'main'	Nick Mathewson	2023-06-21	1	-1/+0
\|\ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Remove message 'For now, only direct channels are supported' in tor-chanmgr docs See merge request tpo/core/arti!1273
\| * \| \|	Remove message 'For now, only direct channels are supported' in tor-chanmgr docs	Saksham Mittal	2023-06-21	1	-1/+0
\| \| \| \|
* \| \| \|	Merge branch 'geoip-nullity-fromstr' into 'main'	Nick Mathewson	2023-06-21	4	-10/+133
\|\ \ \ \ \| \|/ / / \|/\| \| \| \| \| \| \| \| \| \| \|	Followups wrt country-code robustness See merge request tpo/core/arti!1268
\| * \| \|	geoip: Add a few more tests.	Nick Mathewson	2023-06-20	1	-1/+59
\| \| \| \|
\| * \| \|	geoip: Explain in more detail what a CountryCode is to us.	Nick Mathewson	2023-06-20	1	-1/+14
\| \| \| \|
\| * \| \|	geoip: require that ccs actually are printable ascii.	Nick Mathewson	2023-06-20	1	-3/+8
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	(There are plenty of strings that convert into 2 bytes of UTF8 without being two ascii characters, and there are plenty of sequences of two ascii characters that aren't printable.)
\| * \| \|	geoip: Make ?? a little more bullet-proof	Nick Mathewson	2023-06-20	4	-5/+52
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	We want to make sure that ?? is always None, never a CountryCode.
* \| \| \|	Merge branch 'openssl' into 'main'	gabi-250	2023-06-21	1	-4/+4
\|\ \ \ \ \| \| \|/ / \| \|/\| \| \| \| \| \| \| \| \| \|	Bump openssl because RUSTSEC-2023-0044 See merge request tpo/core/arti!1270
\| * \| \|	Bump openssl because RUSTSEC-2023-0044	Ian Jackson	2023-06-21	1	-4/+4
\|/ / /
* \| \|	Merge branch 'keymgr-refactor-fs-ops' into 'main'	gabi-250	2023-06-20	5	-57/+103
\|\ \ \ \| \|/ / \|/\| \| \| \| \| \| \| \|	keymgr: Move FS operations out of KeyType impl See merge request tpo/core/arti!1263
\| * \|	keymgr: Fix clippy lints.	Gabriela Moldovan	2023-06-20	2	-3/+3
\| \| \|
\| * \|	keymgr: Address clippy lints and run cargo fmt.	Gabriela Moldovan	2023-06-20	1	-1/+6
\| \| \|
\| * \|	keymgr: Enforce keystore_dir properties for every key read/written from the ↵	Gabriela Moldovan	2023-06-20	1	-16/+19
\| \| \| \| \| \| \| \| \| \| \| \|	keystore.
\| * \|	keymgr: Update function names and docs to reflect reality.	Gabriela Moldovan	2023-06-20	3	-9/+9
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	The functions that handle OpenSSH-formatted keys now no longer read or write from disk. This commit updates their names and doc strings to stop suggesting they do.