| Commit message (Collapse) | Author | Age | Files | Lines |
| ... | |
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
This is failing in CI. I have no idea what the rules are and AFAICT
no-one is alleging that there is an actual bug in the attributes.
Empirically this suppression causes the script to pass.
|
| | | |
| | |
| | |
| | |
| | | |
I don't know if these are needed because the rules are not documented
afaict. But it seems like probably they ought to be there?
|
| | | |
| | |
| | |
| | | |
These fns are in a feature-gated impls on feature-gated structs.
|
| |\ \ \
| |/ /
|/| |
| | |
| | | |
Gate builder() behind experimental-api feature
See merge request tpo/core/arti!1403
|
| |/ / |
|
| |\ \
| | |
| | |
| | |
| | | |
Expose channel builder in order to create channels more efficiently in external code
See merge request tpo/core/arti!1374
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
CI: Add a job for building arti with additional features.
See merge request tpo/core/arti!1401
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
`onion-service-client` is now a default feature, so we don't need to
explicitly enable it anymore.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This is needed for testing `experimental-api` features (such as the
keymgr) in shadow and chutney.
Prompted by this discussion: https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1399#note_2921294
|
| |\ \ \ \
| |/ / /
|/| | |
| | | |
| | | | |
arti-client: Remove outdated TODO.
See merge request tpo/core/arti!1400
|
| |/ / /
| | |
| | |
| | | |
These errors aren't ignored anymore.
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
Explain the code for the #952 fix.
See merge request tpo/core/arti!1391
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
Let's explain what Trinity did in its fix for #952, so that we know
why this code is here the next time we find it.
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
clippy: Allow some of our existing code patterns
See merge request tpo/core/arti!1396
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This launders the closure so that clippy's
clippy::redundant_closure_call can't see it.
We can't have a local #[allow] because it would be on an expression,
which isn't allowed on stable.
This avoids having to use more clumsy idioms at call sites.
|
| | | | | |
| | | | |
| | | | |
| | | | | |
This fixes a needless_vec lint on nightly.
|
| | | | | | |
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This is a perf issue, only. If tests are too slow, we will notice and
ca speed them up. We should optimise for clarity and convenience,
rather than speed.
Forbidding this can result in churn between vec![] and [] as tests are
updated and changed.
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Rationale: no-one writes these by default without thinkinh. If they
are unnecessary, then either the string must have had " in it
before (in which case it might do again), or it is near other strings
which *do* need it.
And having it does no harm; indeed IMO it can increase clarity.
Alternative to !1388's
Fix new "needless_raw_string_hashes" lint from clippy +nightly
|
| |\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
fix chutney in CI
See merge request tpo/core/arti!1393
|
| | | | | | | |
|
| | | | | | | |
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Forbid use of panicky Rng::gen_range
Closes #920
See merge request tpo/core/arti!1387
|
| | | | | | | | |
|
| | | | | | | | |
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Fixes #920
|
| | | | | | | | |
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
There are a number of places where we generate random Durations
in a range which starts at zero.
These call sites currently (i) have to write out Duration::ZERO
or equivalent, and (ii) would have to use gen_range_checked and expect
the result, even though it can be statically proven to be OK.
To make this slightly smoother, provide `GenRangeInfallible` and
`gen_range_infallible`.
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Ideally we would be allowed to use vanilla gen_range() here, but there
doesn't seem to be a way to allow a specific clippy-forbidden method
using #[allow] and we probably don't want to make a blanket allow.
|
| | | | | | | | |
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
In each of these, it is locally obvious that the range is nonempty.
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
delay_bounds's implementation ensures the postcondition, so the
potential p[anic in next_delay_msec cannot happen.
|
| |/ / / / / /
| | | | | |
| | | | | |
| | | | | | |
We will use this in many places instead of gen_range.
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
keymgr: Use Box<dyn EncodableKey> instead of Box<dyn Any>.
Closes #937
See merge request tpo/core/arti!1398
|
| | | | | | | | |
|
| | | |/ / / /
| |/| | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1337#note_2917701
This will make it harder to accidentally return the wrong value from
`Keystore::get` (the returned value is now at least guaranteed to
implement `EncodableKey`).
Closes #937
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Update s101 stats.
See merge request tpo/core/arti!1397
|
| | | |_|/ / /
| |/| | | | |
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Overhaul send_control_message
See merge request tpo/core/arti!1367
|
| | | | | | | | |
|
| | | | | | | | |
|