summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | | tor-netdir: Minor docs fixesgabi-2502023-03-301-2/+3
| | | | | |
| * | | | | tor-netdir: Provide accessor for params field of HsDirParamsIan Jackson2023-03-301-0/+5
| | | | | |
| * | | | | tor-netdir: Implement hs_dirs accessorIan Jackson2023-03-301-2/+16
| | | | | |
| * | | | | tor-netdir: hs_dirs accessor: change semantics, type, and nameIan Jackson2023-03-301-7/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Don't have it take the TP, so that the caller must call it multiple times. Instead, have it return all the relevant relays.
| * | | | | tor-netdir: Provide hs_all_time_periods instead of ..._secondary_...Ian Jackson2023-03-301-5/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I don't think the server-side support will want to explicitly call current and then secondary. Rather, it will want to iterate over all the relevant ones. And fix the name, and add another comment about whether we need this.
| * | | | | tor-netdir: Rename hs_time_periodIan Jackson2023-03-301-3/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change its name to hs_* like we do with things at this layer. But, it turns out, that at least for hs client connections to fetch the descriptor, I don't seem to need to call it yet ? Maybe it's not needed.
| * | | | | tor-netdir: Sort out HsDirOpIan Jackson2023-03-301-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Change its name to Hs* like we do with things at this layer * Make the Upload variant cfg-conditional
| * | | | | tor-netdir: Reorganise iteration over hsdir ringsIan Jackson2023-03-301-4/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Provide iter_for_op, by changing iter into iter_filter_secondary and having a new entrypoint iter.
| * | | | | tor-netdir: Provide relay_by_rs_idxIan Jackson2023-03-301-0/+16
| | | | | |
* | | | | | Merge branch 'docs-runes' into 'main'Ian Jackson2023-03-311-2/+5
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | | | | | | | | | | | | | CONTRIBUTING.md: Improve wording about docs builds recommendations See merge request tpo/core/arti!1090
| * | | | | CONTRIBUTING.md: Explicitly support --document-private-itemsIan Jackson2023-03-301-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We have many internal doc comments with curated links etc., so we should actually mention that formatting and reading those can be useful.
| * | | | | CONTRIBUTING.md: Recommend --workspace when building docsIan Jackson2023-03-301-2/+3
| | | | | |
* | | | | | Merge branch 'hsdesc-encoder-client-auth' into 'main'gabi-2502023-03-315-157/+310
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Stop requiring the caller to supply `AuthClient`s. See merge request tpo/core/arti!1087
| * | | | | | Generate a new KP_hss_desc_enc keypair for each new descriptor.Gabriela Moldovan2023-03-312-33/+51
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, to build descriptors for hidden services with client auth enabled, in addition to the list of authorized clients, users of `HsDescBuilder` were required to also provide a descriptor encryption keypair and a descriptor cookie. This was potentially dangerous and/or error-prone, because the ephemeral encryption key and the descriptor cookie are expected to be randomly generated and unique for each descriptor. This change makes `ClientAuth` private to the `hsdesc::build` module and updates `HsDescBuilder` to build `ClientAuth`s internally. Users now only need to provide the list of authorized client public keys. Signed-off-by: Gabriela Moldovan <[email protected]>
| * | | | | | Remove unnecessary test constant.Gabriela Moldovan2023-03-312-14/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It's not really needed, it can just be generated at (test) runtime. Signed-off-by: Gabriela Moldovan <[email protected]>
| * | | | | | Add an encode-decode test for descriptors with client auth.Gabriela Moldovan2023-03-311-23/+96
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This adds a test for an `encode -> decode -> encode` flow for a hidden service descriptor with client authorization enabled. Signed-off-by: Gabriela Moldovan <[email protected]>
| * | | | | | Use constants instead of magic numbers.Gabriela Moldovan2023-03-311-6/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Gabriela Moldovan <[email protected]>
| * | | | | | Stop requiring the caller to supply `AuthClient`s.Gabriela Moldovan2023-03-315-102/+166
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `AuthClient`s were originally meant to represent parsed `auth-client` lines. In !1070, this struct was repurposed for representing individual authorized clients in the HS descriptor encoder. However, hidden services will likely use a list of public keys to represent the authorized clients rather than a list of `AuthClient`s, as the information from an `AuthClient` (`client_id`, `iv`, `encrypted_cookie`) likely won't be immediately available to the hidden service. This change updates the HS descriptor encoder to represent authorized clients as a list of `curve25519::PublicKey`s. As such, it is now the responsibility of the encoder to create the `client_id`, `iv`, and `encrypted_cookie` using the available keys, the unencrypted descriptor cookie, and HS subcredential. Signed-off-by: Gabriela Moldovan <[email protected]>
* | | | | | Merge branch 'update_once_more' into 'main'gabi-2502023-03-311-82/+25
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Run cargo-update to move away from yanked versions of "windows" See merge request tpo/core/arti!1103
| * | | | | | Run cargo-update to move away from yanked versions of "windows"Nick Mathewson2023-03-311-82/+25
|/ / / / / / | | | | | | | | | | | | | | | | | | (cargo-audit is complaining about these and breaking CI)
* | | / / / Remove semver.md files.Nick Mathewson2023-03-318-13/+0
| |_|/ / / |/| | | |
* | | | | Remove "publish = false" from tor-hsclient.arti-v1.1.3Nick Mathewson2023-03-311-2/+0
| | | | | | | | | | | | | | | | | | | | It is now a (conditional, experimental) dependency of arti-client.
* | | | | Merge branch 'version_bump' into 'main'gabi-2502023-03-3134-209/+209
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Bump versions for today's release of arti 1.1.3 See merge request tpo/core/arti!1102
| * | | | | Patchlevel bumps for crates whose dependencies just changed.Nick Mathewson2023-03-3119-33/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These crates had no changes until just a moment ago. But since we updated the versions on some of their dependents, they have now changed themselves. Thus they get patchlevel bumps. ``` tor-rtmock tor-protover tor-socksproto tor-consdiff tor-chanmgr tor-dirclient tor-hsservice ```
| * | | | | Bump crate versions that have breaking changesNick Mathewson2023-03-3121-32/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These crates have had breaking changes. They are pre-1.0, so they get a minor bump. ``` tor-basic-utils tor-config ```
| * | | | | Bump patchlevel on crates with non-breaking changesNick Mathewson2023-03-3129-126/+126
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For these crates, the changes are nontrivial, so we _do_ bump the versions on which their dependent crates depend. Fortunately, since they are all pre-1.0, we don't need to distinguish semver-additions from other changes. (Except for arti, which _is_ post-1.0, but gets a patchlevel bump anyway.) These are unstable crates with breaking changes: ``` tor-hscrypto tor-hsclient ``` These have new or extended APIs: ``` safelog tor-bytes tor-cell tor-linkspec tor-llcrypto tor-proto tor-cert arti-client ``` These have new unstable APIs or features: ``` tor-netdoc tor-circmgr (also broke some unstable APIs) arti (is post-1.0) ``` These have bugfixes only: ``` caret tor-dirmgr ```
| * | | | | Bump patchlevel on crates with semver-irrelevant changes.Nick Mathewson2023-03-3110-18/+18
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Their dependents are _not_ updated to a more recent version. These bumped the version of a dependency that they don't expose ``` tor-rtcompat fs-mistrust ``` This one had internal refactoring: ``` tor-netdir ``` These had trivial changes only: ``` tor-checkable tor-ptmgr tor-guardmgr arti-hyper arti-bench arti-testing ```
* | | | | Changelog: Move "Major bugfixes" to the top.Nick Mathewson2023-03-311-5/+5
| | | | |
* | | | | Finish (?) CHANGELOG.md for 1.1.3Nick Mathewson2023-03-311-4/+64
| | | | |
* | | | | Add Gabi to exclude_contributors.Nick Mathewson2023-03-311-0/+3
| | | | | | | | | | | | | | | | | | | | (We don't include Tor employees in our "thanks" section.)
* | | | | Update CHANGELOG for last few commits.Nick Mathewson2023-03-311-2/+4
| | | | |
* | | | | Merge branch 'doc_fixes' into 'main'Nick Mathewson2023-03-301-1/+1
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | tor-hsclient: Fix a doc link. See merge request tpo/core/arti!1101
| * | | | | tor-hsclient: Fix a doc link.Nick Mathewson2023-03-301-1/+1
| | | | | |
* | | | | | Merge branch 'update-20220330' into 'main'Nick Mathewson2023-03-301-212/+249
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | | | | | | | | | | | | Run cargo update in preparation for release tomorrow. See merge request tpo/core/arti!1100
| * | | | | Run cargo update in preparation for release tomorrow.Nick Mathewson2023-03-301-212/+249
| | | | | |
* | | | | | Merge branch 'fix-broken-doc-links' into 'main'Nick Mathewson2023-03-302-5/+5
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | | | | | | | | | | | | Fix broken doc link. See merge request tpo/core/arti!1082
| * | | | | Fix broken doc link.Gabriela Moldovan2023-03-272-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes a broken doc link I introduced in !1070: ``` error: unresolved link to `crate::doc::hsdesc::build::inner::HsDescInnerBuilder` --> crates/tor-netdoc/src/doc/hsdesc/build/middle.rs:34:11 | 34 | /// [`crate::doc::hsdesc::build::inner::HsDescInnerBuilder`] as described in sections | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no item named `HsDescInnerBuilder` in module `inner` | = note: `-D rustdoc::broken-intra-doc-links` implied by `-D warnings` error: could not document `tor-netdoc` ``` Signed-off-by: Gabriela Moldovan <[email protected]>
* | | | | | Merge branch 'plumb' into 'main'Alexander Færøy2023-03-306-49/+69
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | More plumbing for hs connections See merge request tpo/core/arti!1098
| * | | | | | Run rustfmtIan Jackson2023-03-302-21/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Apply this churn, which I deferred for ease of review.
| * | | | | | arti-client: Call HsCircPool::launch_background_tasksIan Jackson2023-03-301-4/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I found that I had the bug where I forgot to call this function, and reached bad_api_usage!("The circuit launcher wasn't initialized") The possibility of such a bug is a hazard of this API pattern.
| * | | | | | tor-hsconn: Rename ConnError (from HsClientConnError)Ian Jackson2023-03-305-21/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The old name was unwieldy and other crates can just as well name it by the crate scope.
| * | | | | | arti-client: When making hs conn, wait for bootstrapIan Jackson2023-03-301-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Not doing this was a bug. The bug was possible because of some code duplication between the exit and hs paths. Add a comment about that.
| * | | | | | tor-client: Pass a netdir for each requestIan Jackson2023-03-304-16/+27
| | |_|/ / / | |/| | | | | | | | | | | | | | | | | | | | | | This will be more convenient inside tor-hsclient. In arti-client, this mirrors the way TorClient::get_or_launch_exit_circ works.
* | | | | | Merge branch 'workflow' into 'main'Ian Jackson2023-03-301-1/+22
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Document some workflow practices See merge request tpo/core/arti!1079
| * | | | | | CONTRIBUTING.md: Add some refs for git autosquashIan Jackson2023-03-301-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | One ref to the official docs, one to a reasonable-looking blog post I found via DDG. Suggested in https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1079#note_2889631
| * | | | | | CONTRIBUTING.md: Discourage contributors from rebasing (typo fix)Ian Jackson2023-03-301-1/+1
| | | | | | |
| * | | | | | CONTRIBUTING.md: Improve wording re not squashingNick Mathewson2023-03-301-1/+1
| | | | | | |
| * | | | | | CONTRIBUTING.md: Document X X X conventionIan Jackson2023-03-301-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The placement in the "Where are some good places to start hacking?" section is rather awkward, but I didn't see where else to put it.
| * | | | | | CONTRIBUTING.md: Add more notes about TODOsIan Jackson2023-03-301-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The placement in the "Where are some good places to start hacking?" section is rather awkward, but I didn't see where else to put it.
| * | | | | | CONTRIBUTING.md: Discourage contributors from rebasingIan Jackson2023-03-301-0/+6
| | |_|/ / / | |/| | | |