summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * | GuardMgr: Explain why we timestamp BridgeSets as we do.Nick Mathewson2022-11-102-10/+12
| | |
| * | GuardMgr: Downgrade a pt-client TODO about an internal APINick Mathewson2022-11-101-2/+4
| | |
| * | GuardMgr Document why a BridgeSet has trivial weight thresholds.Nick Mathewson2022-11-102-3/+4
| | | | | | | | | | | | | | | | | | This is the only way I could find in which parameter interpretation differs between bridge guards and relay guards; with it documented, I can remove a TODO about identifying such ways.
| * | GuardMgr: once more, fix our n_primary_dir_info check.Nick Mathewson2022-11-101-3/+25
| | | | | | | | | | | | | | | Have the check only apply to non-bridge universes, and explain why in a bunch more comments.
| * | GuardMgr: remove redundant call to extend_sample_as_neededNick Mathewson2022-11-102-32/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously we would call extend_sample_as_needed in only two places, one of which called the other unconditionally. That's obviously not necessary. I've selected just one of them (`update_guardset_internal`) since it fits better with the theme if that function. I've added comments explaining what is going on. This commit also introduces a yes/no enum for "were any guards added while extending this set". Formerly we had a boolean, but it got passed around so many times that I think its intent became obscure.
| * | GuardMgr: rename n_primary_without_dir_infoNick Mathewson2022-11-102-7/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | What this function actually does is return the number of primary guards whose presence (by identity) is ambiguous in a current universe. The new name and documentation should help avoid confusion. The method's old name had led me astray when identifying whether it should apply to bridges in one case. This commit also removes the corresponding `TODO pt-client`.
| * | Remove TODO to rename for_circuit_usage in favor of #623Nick Mathewson2022-11-101-1/+0
| | |
| * | GuardMgr: Remove TODO to move `mod bridge` to another crateNick Mathewson2022-11-101-3/+0
| | | | | | | | | | | | The code seems happy enough here for now.
| * | Resolve todo!()s and TODOs around BridgeRelay::HasAddrs.Nick Mathewson2022-11-101-15/+35
| | | | | | | | | | | | | | | | | | | | | Also, add a bunch of reminders around these implementations that `HasAddrs` returns all the address associated with you for GeoIp or family purposes, even if they are _not_ ones that we should actually contact you at.
| * | RouterDesc: Add an or_ports method.Nick Mathewson2022-11-102-0/+11
| | |
| * | GuardMgr: Docs for BridgeDescProviderNick Mathewson2022-11-081-2/+12
| | |
| * | GuardMgr: Remove a TODO pt-client comment.Nick Mathewson2022-11-081-2/+0
| | | | | | | | | | | | | | | The BridgeSet type does not necessarily need further changes... and if it gets them, it won't be because of this comment.
* | | Merge branch 'msrv-1.60' into 'main'Nick Mathewson2022-11-1043-129/+205
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | Increase MSRV to 1.60 Closes #591, #526, #613, and #621 See merge request tpo/core/arti!837
| * | Actually, require rsa 0.7.1.Nick Mathewson2022-11-102-3/+3
| | | | | | | | | | | | rsa 0.7.0 has been yanked.
| * | tor-persist: use map_whileNick Mathewson2022-11-101-4/+1
| | | | | | | | | | | | It was introduced in Rust 1.57.
| * | Remove allow() for a false-positive warn on Rust 1.56.Nick Mathewson2022-11-101-3/+0
| | |
| * | Upgrade rsa to 0.7. Closes #613.Nick Mathewson2022-11-103-28/+24
| | |
| * | Upgrade to serde_with 2, phf 0.11. Closes #526.Nick Mathewson2022-11-103-53/+138
| | |
| * | Upgrade to tinystr 0.7. Closes #591.Nick Mathewson2022-11-102-3/+3
| | |
| * | Use rust 1.60 in minimal-versions.Nick Mathewson2022-11-101-1/+1
| | | | | | | | | | | | Closes #621
| * | bump rust-version to 1.60 in every crate.Nick Mathewson2022-11-1038-37/+38
|/ /
* | Merge branch 'bridge-error' into 'main'Nick Mathewson2022-11-102-5/+5
|\ \ | | | | | | | | | | | | Use ErrorKind::TorAccessFailed for misbehaving bridges See merge request tpo/core/arti!842
| * | Use ErrorKind::TorAccessFailed for misbehaving bridgesIan Jackson2022-11-082-5/+5
| | | | | | | | | | | | (Use semantic linefeed for the doc comment.)
* | | Merge branch 'bdm-process-doc-test' into 'main'Nick Mathewson2022-11-102-2/+100
|\ \ \ | | | | | | | | | | | | | | | | bridge descs: Add tests for process_document See merge request tpo/core/arti!841
| * | | bridge descs: Add tests for process_documentIan Jackson2022-11-082-2/+100
| |/ /
* | | Merge branch 'bdm-params' into 'main'Nick Mathewson2022-11-101-1/+0
|\ \ \ | | | | | | | | | | | | | | | | Remove TODO re BridgeDescDownloadConfig defaults See merge request tpo/core/arti!839
| * | | Remove TODO re BridgeDescDownloadConfig defaultsIan Jackson2022-11-081-1/+0
| |/ /
* | | Merge branch 'check-more-targets' into 'main'Ian Jackson2022-11-1011-9/+143
|\ \ \ | | | | | | | | | | | | | | | | Check more targets See merge request tpo/core/arti!844
| * | | Check more targetstrinity-1686a2022-11-1011-9/+143
|/ / /
* | | Merge branch 'drop-todos' into 'main'Nick Mathewson2022-11-082-4/+2
|\ \ \ | |/ / |/| | | | | | | | bridge desc: Deal with two TODOs See merge request tpo/core/arti!843
| * | bridge desc: Drop a done TODOIan Jackson2022-11-081-1/+0
| | | | | | | | | | | | | | | We have a separate BridgeDescMgr, rather than reusing DirMgr, so we will not be implementing BridgeDescProvider for DirMgr.
| * | bridge desc: todo re config: weaken and reference a new ticketIan Jackson2022-11-081-3/+2
|/ /
* | Merge branch 'clap-v3' into 'main'Ian Jackson2022-11-088-187/+200
|\ \ | |/ |/| | | | | | | | | Upgrade to clap 3 Closes #616 See merge request tpo/core/arti!830
| * Upgrade to clap 3: replace deprecated functionsGabriel de Perthuis2022-11-046-121/+146
| | | | | | | | | | | | | | | | | | | | | | Also replace Arg::takes_value with Arg::action to configure flags that don't take parameters vs options that do. This makes it easy to upgrade to clap 4. Tested deprecations with: cargo check --workspace --all-features --features clap/deprecated
| * Upgrade to clap 3 with minimal changesGabriel de Perthuis2022-11-048-73/+61
| | | | | | | | | | | | | | | | This removes the last cargo audit override (for the unmaintained ansi_term). Don't mark options as required when they have default values: see <https://github.com/clap-rs/clap/pull/3793>.
* | Merge branch 'misc-todo-ptclient' into 'main'Ian Jackson2022-11-083-8/+4
|\ \ | | | | | | | | | | | | Downgrade and/or remove a few misc "TODO pt-client" comments See merge request tpo/core/arti!838
| * | circmgr: downgrade TODO pt-client commentsNick Mathewson2022-11-081-3/+3
| | | | | | | | | | | | These are structure-internal things we can solve later, if ever.
| * | ChanMgr: downgrade and remove a few TODO-ptclient commentsNick Mathewson2022-11-082-5/+1
| | | | | | | | | | | | renamings are now #623. Code movement can happen later.
* | | Merge branch 'store' into 'main'Nick Mathewson2022-11-087-43/+471
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Persistently cache bridge descriptors Closes #619 See merge request tpo/core/arti!831
| * | | bridge descs: Rename BridgeDescMgr from BridgeDescManagerIan Jackson2022-11-083-17/+17
| | | | | | | | | | | | | | | | | | | | | | | | This is more consistent with our naming elsewhere. Suggested-by: Nick Mathewson <[email protected]>
| * | | bridge descs: Apply sensitive() to bridge identity in error log msgIan Jackson2022-11-083-1/+4
| | | |
| * | | sqlite cache: Document reasoning about timestampsIan Jackson2022-11-081-2/+9
| | | | | | | | | | | | | | | | | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/831#note_2851764
| * | | bridge desc tests: Test caching and if-modified-sinceIan Jackson2022-11-041-2/+121
| | | |
| * | | bridge desc tests: Break out queues_are_empty helperIan Jackson2022-11-041-2/+6
| | | |
| * | | bridge desc tests: Provide a sqlite connectionIan Jackson2022-11-041-2/+5
| | | | | | | | | | | | | | | | The current test case doesn't use this.
| * | | bridge desc: Implement storage functions at the DB layerIan Jackson2022-11-041-8/+67
| | | |
| * | | bridge desc: Make Downloaded be DebugIan Jackson2022-11-041-0/+1
| | | |
| * | | bridge desc: Implement cache reuse logic and if-modified-sinceIan Jackson2022-11-045-9/+197
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This introduces the new API functions to Store. But currently they are all no-ops. So all this machinery doesn't actually do anything. Also, it changes the API to the mockable downloader, to allow it to support if-modified-since. So this isn't used either. But it is more convenient to do this all at once in BridgeDescManager, since care needs to be taken about the intraction between if-modified-since and the persistent cache.
| * | | bridge desc: Rename one more variable to textIan Jackson2022-11-041-1/+1
| | | |
| * | | bridge desc: Catch panics in the download functionalityIan Jackson2022-11-041-1/+8
| | | |
generated by cgit v1.2.3 (git 2.46.0) at 2026-08-27 18:49:50 +0000