summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* | | Merge branch 'store3' into 'main'Ian Jackson2022-11-147-165/+76
|\ \ \ | | | | | | | | | | | | | | | | dirmgr: Expopse DirMgrStore See merge request tpo/core/arti!851
| * | | dirmgr Store: Have constructors take DirMgrStoreIan Jackson2022-11-144-10/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Now the Store is constructed by arti_client, solving the problem described here https://gitlab.torproject.org/tpo/core/arti/-/issues/631#note_2853665 but in a different way.
| * | | dirmgr Store: Introduce DirMgrStore and use for BridgeDescMgr (fmt)Ian Jackson2022-11-141-8/+1
| | | | | | | | | | | | | | | | rustfmt only, broken out to ease review.
| * | | dirmgr Store: Introduce DirMgrStore and use for BridgeDescMgrIan Jackson2022-11-142-6/+33
| | | | | | | | | | | | | | | | We are going to change DirMgr's constructors to also take a DirMgrStore.
| * | | dirmgr Store: Abolish redundant trait implIan Jackson2022-11-142-109/+1
| | | |
| * | | dirmgr Store: Use `**` syntax and deref to trait objectsIan Jackson2022-11-142-34/+20
| | | | | | | | | | | | | | | | This will allow us to get rid of a needless trait impl.
| * | | dirmgr Store: Move Send and 'static bounds to Store traitIan Jackson2022-11-141-2/+2
| |/ / | | | | | | | | | | | | | | | | | | | | | This seems tidier to me. (It saved a lot of typing when I was trying to make some complicated pub supertrait with sealed private supertrait, but apparently not now.)
* | | Merge branch 'bdm-dormant' into 'main'Ian Jackson2022-11-142-0/+51
|\| | | | | | | | | | | | | | bridge descriptor dormancy: Define an enum and semantics See merge request tpo/core/arti!845
| * | bridge descriptor dormancy: Accept the dormancy valueIan Jackson2022-11-112-1/+11
| | | | | | | | | | | | But right now, don't do anything with it. That will come in a future MR.
| * | bridge descriptor dormancy: Add a TODO for this enumIan Jackson2022-11-111-0/+2
| | |
| * | bridge descriptor dormancy: Define an enum and semanticsIan Jackson2022-11-101-0/+39
| | | | | | | | | | | | This is part of #630.
* | | Merge branch 'arnabanimesh-main-patch-72156' into 'main'Nick Mathewson2022-11-131-1/+1
|\ \ \ | | | | | | | | | | | | | | | | Fix Windows shortcut target See merge request tpo/core/arti!849
| * | | Fix Windows shortcut targetarnabanimesh2022-11-131-1/+1
|/ / /
* | | Merge branch 'workaround_545' into 'main'eta2022-11-111-0/+5
|\ \ \ | |_|/ |/| | | | | | | | Temporarily disable it_cancels_delayed_firings. See merge request tpo/core/arti!846
| * | Temporarily disable it_cancels_delayed_firings.Nick Mathewson2022-11-101-0/+5
| |/ | | | | | | | | This test is timing-dependent in a way that seems to fail on heavily loaded CI machines. See #545.
* | Merge branch 'guardmgr-todo-misc' into 'main'Nick Mathewson2022-11-108-75/+142
|\ \ | | | | | | | | | | | | Resolve most "TODO pt-client" comments in GuardMgr See merge request tpo/core/arti!840
| * | GuardMgr: Explain why we timestamp BridgeSets as we do.Nick Mathewson2022-11-102-10/+12
| | |
| * | GuardMgr: Downgrade a pt-client TODO about an internal APINick Mathewson2022-11-101-2/+4
| | |
| * | GuardMgr Document why a BridgeSet has trivial weight thresholds.Nick Mathewson2022-11-102-3/+4
| | | | | | | | | | | | | | | | | | This is the only way I could find in which parameter interpretation differs between bridge guards and relay guards; with it documented, I can remove a TODO about identifying such ways.
| * | GuardMgr: once more, fix our n_primary_dir_info check.Nick Mathewson2022-11-101-3/+25
| | | | | | | | | | | | | | | Have the check only apply to non-bridge universes, and explain why in a bunch more comments.
| * | GuardMgr: remove redundant call to extend_sample_as_neededNick Mathewson2022-11-102-32/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously we would call extend_sample_as_needed in only two places, one of which called the other unconditionally. That's obviously not necessary. I've selected just one of them (`update_guardset_internal`) since it fits better with the theme if that function. I've added comments explaining what is going on. This commit also introduces a yes/no enum for "were any guards added while extending this set". Formerly we had a boolean, but it got passed around so many times that I think its intent became obscure.
| * | GuardMgr: rename n_primary_without_dir_infoNick Mathewson2022-11-102-7/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | What this function actually does is return the number of primary guards whose presence (by identity) is ambiguous in a current universe. The new name and documentation should help avoid confusion. The method's old name had led me astray when identifying whether it should apply to bridges in one case. This commit also removes the corresponding `TODO pt-client`.
| * | Remove TODO to rename for_circuit_usage in favor of #623Nick Mathewson2022-11-101-1/+0
| | |
| * | GuardMgr: Remove TODO to move `mod bridge` to another crateNick Mathewson2022-11-101-3/+0
| | | | | | | | | | | | The code seems happy enough here for now.
| * | Resolve todo!()s and TODOs around BridgeRelay::HasAddrs.Nick Mathewson2022-11-101-15/+35
| | | | | | | | | | | | | | | | | | | | | Also, add a bunch of reminders around these implementations that `HasAddrs` returns all the address associated with you for GeoIp or family purposes, even if they are _not_ ones that we should actually contact you at.
| * | RouterDesc: Add an or_ports method.Nick Mathewson2022-11-102-0/+11
| | |
| * | GuardMgr: Docs for BridgeDescProviderNick Mathewson2022-11-081-2/+12
| | |
| * | GuardMgr: Remove a TODO pt-client comment.Nick Mathewson2022-11-081-2/+0
| | | | | | | | | | | | | | | The BridgeSet type does not necessarily need further changes... and if it gets them, it won't be because of this comment.
* | | Merge branch 'msrv-1.60' into 'main'Nick Mathewson2022-11-1043-129/+205
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | Increase MSRV to 1.60 Closes #591, #526, #613, and #621 See merge request tpo/core/arti!837
| * | Actually, require rsa 0.7.1.Nick Mathewson2022-11-102-3/+3
| | | | | | | | | | | | rsa 0.7.0 has been yanked.
| * | tor-persist: use map_whileNick Mathewson2022-11-101-4/+1
| | | | | | | | | | | | It was introduced in Rust 1.57.
| * | Remove allow() for a false-positive warn on Rust 1.56.Nick Mathewson2022-11-101-3/+0
| | |
| * | Upgrade rsa to 0.7. Closes #613.Nick Mathewson2022-11-103-28/+24
| | |
| * | Upgrade to serde_with 2, phf 0.11. Closes #526.Nick Mathewson2022-11-103-53/+138
| | |
| * | Upgrade to tinystr 0.7. Closes #591.Nick Mathewson2022-11-102-3/+3
| | |
| * | Use rust 1.60 in minimal-versions.Nick Mathewson2022-11-101-1/+1
| | | | | | | | | | | | Closes #621
| * | bump rust-version to 1.60 in every crate.Nick Mathewson2022-11-1038-37/+38
|/ /
* | Merge branch 'bridge-error' into 'main'Nick Mathewson2022-11-102-5/+5
|\ \ | | | | | | | | | | | | Use ErrorKind::TorAccessFailed for misbehaving bridges See merge request tpo/core/arti!842
| * | Use ErrorKind::TorAccessFailed for misbehaving bridgesIan Jackson2022-11-082-5/+5
| | | | | | | | | | | | (Use semantic linefeed for the doc comment.)
* | | Merge branch 'bdm-process-doc-test' into 'main'Nick Mathewson2022-11-102-2/+100
|\ \ \ | | | | | | | | | | | | | | | | bridge descs: Add tests for process_document See merge request tpo/core/arti!841
| * | | bridge descs: Add tests for process_documentIan Jackson2022-11-082-2/+100
| |/ /
* | | Merge branch 'bdm-params' into 'main'Nick Mathewson2022-11-101-1/+0
|\ \ \ | | | | | | | | | | | | | | | | Remove TODO re BridgeDescDownloadConfig defaults See merge request tpo/core/arti!839
| * | | Remove TODO re BridgeDescDownloadConfig defaultsIan Jackson2022-11-081-1/+0
| |/ /
* | | Merge branch 'check-more-targets' into 'main'Ian Jackson2022-11-1011-9/+143
|\ \ \ | | | | | | | | | | | | | | | | Check more targets See merge request tpo/core/arti!844
| * | | Check more targetstrinity-1686a2022-11-1011-9/+143
|/ / /
* | | Merge branch 'drop-todos' into 'main'Nick Mathewson2022-11-082-4/+2
|\ \ \ | |/ / |/| | | | | | | | bridge desc: Deal with two TODOs See merge request tpo/core/arti!843
| * | bridge desc: Drop a done TODOIan Jackson2022-11-081-1/+0
| | | | | | | | | | | | | | | We have a separate BridgeDescMgr, rather than reusing DirMgr, so we will not be implementing BridgeDescProvider for DirMgr.
| * | bridge desc: todo re config: weaken and reference a new ticketIan Jackson2022-11-081-3/+2
|/ /
* | Merge branch 'clap-v3' into 'main'Ian Jackson2022-11-088-187/+200
|\ \ | |/ |/| | | | | | | | | Upgrade to clap 3 Closes #616 See merge request tpo/core/arti!830
| * Upgrade to clap 3: replace deprecated functionsGabriel de Perthuis2022-11-046-121/+146
| | | | | | | | | | | | | | | | | | | | | | Also replace Arg::takes_value with Arg::action to configure flags that don't take parameters vs options that do. This makes it easy to upgrade to clap 4. Tested deprecations with: cargo check --workspace --all-features --features clap/deprecated