summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * | KeyPathInfo: Add role fieldIan Jackson2024-01-042-2/+27
| | | | | | | | | | | | This *is* the spec name.
| * | KeySpecifier d-a macro: Populate extra_infoIan Jackson2024-01-042-2/+20
| | | | | | | | | | | | Finishes arti#1151 item 10.
| * | KeySpecifier d-a macro: Use dyn for describingIan Jackson2024-01-042-24/+75
| | | | | | | | | | | | This also passes the information we'll need to populate extra_info.
| * | KeySpecifier d-a macro: Add a test for describingIan Jackson2024-01-041-0/+16
| | |
| * | KeySpecifier d-a macro: Mnaully wrap two long linesIan Jackson2024-01-041-2/+6
| | |
| * | KeySpecifier d-a macro: Use doc-hidden re-exportsIan Jackson2024-01-042-9/+7
| | |
| * | KeySpecifier d-a macro: Name result by whole pathIan Jackson2024-01-041-2/+2
| | | | | | | | | | | | This will make the macro work if call sites rebind Result.
| * | KeySpecifier d-a macro: Use derive-adhoc's pasting featureIan Jackson2024-01-041-6/+4
| | | | | | | | | | | | | | | The KeyInfoExtractor impl is still misindented but we'll change that when we replace it.
| * | KeySpecifier d-a macro: Use dyn for parsingIan Jackson2024-01-041-91/+181
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now the only place that knows how to do all this is the one place in the macro. The indentation is -4 compared to previously, because we're going to remove the wrapping with paste::paste! later. It's convenient to do this reindent now, while we're rewriting it. arti#1151 item 5.
| * | KeyPathError::PatternNotMatched: Remove pattern from errorIan Jackson2024-01-042-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | This can only happen if we tried to parse an ArtiPath as the wrong kind of KeySpecifier, which shouldn't happen very often. If it does, the pattern isn't that interesting. Which is just as well, since we're about to make it a bit harder to obtain it in the place where this error is going to be constructed.
| * | KeySpecifier d-a macro: Do not produce fn new()Ian Jackson2024-01-042-20/+7
| | | | | | | | | | | | | | | | | | Where we wanted this, use derive_more::Constructor isntead. arti#1151 item 6.
| * | KeySpecifier d-a macro: Say what we produce, in the docsIan Jackson2024-01-041-1/+17
| | |
| * | KeySpecifier: Make KeySpecifierPattern a traitIan Jackson2024-01-045-11/+23
| | | | | | | | | | | | | | | | | | So now .arti_pattern() is a trait method. arti#1151 item 3.
| * | KeySpecifier d-a macro: Abolish prefix fnsIan Jackson2024-01-042-55/+0
| | | | | | | | | | | | | | | | | | | | | | | | arti_prefix is no longer used. Abolish prefix too. arti#1151 item 7. Closes #1147.
| * | KeySpecifier d-a macro: Introduce SomeSpecifierPattern and use dynIan Jackson2024-01-044-43/+79
| | | | | | | | | | | | | | | | | | | | | | | | This is a better API. The implementation has less monomorphisation. arti#1151 item 2 and the patterns part of 4. Closes #1126.
| * | KeySpecifier d-a macro: Use dyn for arti_pathIan Jackson2024-01-041-11/+153
| | | | | | | | | | | | | | | | | | | | | | | | | | | This reduces monomorphisation. arti#1151 item 4. The commentary reflects a decision not to do arti#1151 item 9 (using fmt signature for to_component) at this time.
| * | KeySpecifier tests: add a TimePeriod testIan Jackson2024-01-043-2/+38
| | |
| * | KeySpecifierComponent: Add .fmt_pretty() methodIan Jackson2024-01-041-1/+21
| | | | | | | | | | | | | | | | | | | | | Part of arti#1151 item 10. Discussion in https://gitlab.torproject.org/tpo/core/arti/-/issues/1151#note_2977278
| * | tor-hsservice: Drop an unused importIan Jackson2024-01-041-1/+0
| | | | | | | | | | | | | | | I'm not sure why the compiler doesn't complain about this already, but it becomes "more" unused later.
| * | KeySpecifier d-a macro: Move to its own moduleIan Jackson2024-01-043-318/+336
| | | | | | | | | | | | This is going to expand and gain private helper methods.
| * | KeySpecifier d-a macro: insist on structsIan Jackson2024-01-031-1/+1
| | | | | | | | | | | | | | | We don't handle enums and we don't want to try. Put this here as documentation of this intent.
| * | KeySpecifier d-a macro: rename from KeySpecifierDefaultIan Jackson2024-01-033-18/+18
| |/ | | | | | | arti#1151 item 1.
* | Merge branch 'fix-ambitious-certtype' into 'main'Ian Jackson2024-01-081-1/+2
|\ \ | | | | | | | | | | | | tor-cell: Fix ambitious certtype See merge request tpo/core/arti!1846
| * | tor-cell: Fix ambitious certtypeEmil Engler2023-12-281-1/+2
| | | | | | | | | | | | | | | | | | | | | When using the `arti-client` crate in other contexes, the Rust compiler sometimes has difficulties with determining the current type in this particular case, due to a collision with the popular serde json crate, which also provides an implementation for converting u8.
* | | Merge branch 'da-allow' into 'main'gabi-2502024-01-087-14/+39
|\ \ \ | |_|/ |/| | | | | | | | Update to derive-adhoc 0.8 and remove an allow See merge request tpo/core/arti!1850
| * | Remove an unneeded allowIan Jackson2024-01-021-2/+0
| | | | | | | | | | | | Now d-a #27 is fixed, we don't need this.
| * | Update to derive-adhoc 0.8Ian Jackson2024-01-026-12/+39
|/ / | | | | | | | | As recommended in the d-a changelog, I'm not calling this a breaking change to our APIs.
* | Merge branch 'clippy' into 'main'Ian Jackson2024-01-0217-36/+32
|\ \ | |/ |/| | | | | Fix various lints See merge request tpo/core/arti!1849
| * rustdoc: linkify a url properlyIan Jackson2024-01-021-2/+2
| |
| * clippy: consequential rustfmtIan Jackson2024-01-024-17/+5
| |
| * clippy nightly: For now, locally allow implied_bounds_in_implsIan Jackson2024-01-021-0/+2
| | | | | | | | | | | | Filed https://gitlab.torproject.org/tpo/core/arti/-/issues/1177 proposing a final fix.
| * clippy nightly: For now, locally allow blocks_in_conditionsIan Jackson2024-01-023-0/+3
| | | | | | | | | | | | Filed https://gitlab.torproject.org/tpo/core/arti/-/issues/1176 proposing a final fix.
| * clippy nightly: Use Poll.is_pending() in two placesIan Jackson2024-01-021-2/+2
| | | | | | | | clippy correctly identifies that this is nicer than matches!.
| * clippy: An an allow for fallible ed25519 conversionIan Jackson2024-01-021-0/+5
| | | | | | | | | | I'm not sure about this. Leaving it this way seems the most conservative choice for now.
| * clippy: Add an allow to work around a clippy bugIan Jackson2024-01-021-0/+3
| | | | | | | | | | | | | | | | | | | | clippy in current stable thinks |(a, b)| (a, b) is always the identity function, but due to match ergonomics, it might be an implicit copy. This is fixed in nightly by https://github.com/rust-lang/rust-clippy/pull/11792
| * clippy: Use infallible callsIan Jackson2024-01-024-10/+5
| | | | | | | | Resolves clippy complaints about needless fallible conversions.
| * clippy: Replace many calls to .get(0) with .first()Ian Jackson2024-01-026-9/+9
|/ | | | | FTR I don't think agree with clippy on this question, but then I often don't.
* Merge branch 'track-caller' into 'main'Alexander Færøy2023-12-182-0/+4
|\ | | | | | | | | tor-rtcompat: use track-caller for thin wrappers See merge request tpo/core/arti!1843
| * tor-rtcompat: use track-caller for thin wrappersJim Newsome2023-12-182-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | In particular, when the (unstable) tokio tracing feature is enabled, every tracing line includes the name of where the current task was created. Without this change, that ends up being the name of intermediate trait methods like TokioRuntimeHandle::block_on, which is not very helpful. Adding the `track_caller` attribute causes the name of the caller of these methods to be used instead, which is typically more helpful. IIUC this change is not breaking in terms of semver https://rustc-dev-guide.rust-lang.org/backend/implicit-caller-location.html.
* | Merge branch 'zerocopy-bump' into 'main'Alexander Færøy2023-12-181-4/+4
|\ \ | |/ |/| | | | | | | | | Bump zerocopy 0.7.29 -> 0.7.31 Closes #1174 See merge request tpo/core/arti!1844
| * Bump zerocopy 0.7.29 -> 0.7.31Jim Newsome2023-12-181-4/+4
|/ | | | | | | | ``` cargo update -p zerocopy ``` Fixes https://gitlab.torproject.org/tpo/core/arti/-/issues/1174
* Merge branch 'hs-desc-builder' into 'main'Alexander Færøy2023-12-183-17/+23
|\ | | | | | | | | | | | | tor-netdoc: Make HsDescBuilder::auth_clients take an Option. Closes #1019 See merge request tpo/core/arti!1840
| * tor-netdoc: Make HsDescBuilder::auth_clients take an Option.Gabriela Moldovan2023-12-143-17/+23
| | | | | | | | Closes #1019
* | Merge branch 'doctest-deprecated-name' into 'main'Nick Mathewson2023-12-141-2/+2
|\ \ | | | | | | | | | | | | tor-cell: Stop using deprecated name in doctest See merge request tpo/core/arti!1842
| * | tor-cell: Stop using deprecated name in doctestNick Mathewson2023-12-141-2/+2
| | |
* | | Merge branch 'keymgr-proto-domain-name' into 'main'gabi-2502023-12-1411-103/+37
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | tor-keymgr: Use spec.torproject.org for the SSH algo name domain. Closes #1108 See merge request tpo/core/arti!1838
| * | | shadow test: Update the test client auth keys.Gabriela Moldovan2023-12-142-7/+6
| | | | | | | | | | | | | | | | | | | | The algorithm name for x25519 keys has changed, so the test keys need to be updated.
| * | | arti: Fix log message typo.Gabriela Moldovan2023-12-141-1/+1
| | | |
| * | | shadow test: Update hidden service keys.Gabriela Moldovan2023-12-143-8/+8
| | | | | | | | | | | | | | | | | | | | The algorithm name for expanded ed25519 keys has changed, so the test keys need to be updated.
| * | | tor-keymgr: Wrap a long doc comment line.Gabriela Moldovan2023-12-141-3/+3
| | | |